René's URL Explorer Experiment


Title: gh-105035: fix super() calls on unusual types (e.g. meta-types) by carljm · Pull Request #105094 · python/cpython · GitHub

Open Graph Title: gh-105035: fix super() calls on unusual types (e.g. meta-types) by carljm · Pull Request #105094 · python/cpython

X Title: gh-105035: fix super() calls on unusual types (e.g. meta-types) by carljm · Pull Request #105094 · python/cpython

Description: The LOAD_SUPER_ATTR optimization was missing the check (found in _PyObject_GetMethod) to restrict the load-method optimization to lookups only against types that use PyObject_GenericGetAttr for the...

Open Graph Description: The LOAD_SUPER_ATTR optimization was missing the check (found in _PyObject_GetMethod) to restrict the load-method optimization to lookups only against types that use PyObject_GenericGetAttr for the...

X Description: The LOAD_SUPER_ATTR optimization was missing the check (found in _PyObject_GetMethod) to restrict the load-method optimization to lookups only against types that use PyObject_GenericGetAttr for the...

Opengraph URL: https://github.com/python/cpython/pull/105094

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7c5dbb49-ec07-9da9-ae79-0b0297d70121
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB8A:1E0146:F92C3F:14D3EB4:69699173
html-safe-noncefb340af0758ffb9e58e2956185f2a753731be448b0aebd5ef795ff7e5acb94b0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjhBOjFFMDE0NjpGOTJDM0Y6MTREM0VCNDo2OTY5OTE3MyIsInZpc2l0b3JfaWQiOiI0ODI0MTg4NDA5MTU3ODgyMjI3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdfb832502ef9f56ae9357bb3556cb4a5da176533e68fd089d3097ba8300ea246
hovercard-subject-tagpull_request:1370647091
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/105094/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/26e579e78087cda66cf10f222cc3a605e3d59c51a44d4f032ba619026b53dcce/python/cpython/pull/105094
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/26e579e78087cda66cf10f222cc3a605e3d59c51a44d4f032ba619026b53dcce/python/cpython/pull/105094
og:image:altThe LOAD_SUPER_ATTR optimization was missing the check (found in _PyObject_GetMethod) to restrict the load-method optimization to lookups only against types that use PyObject_GenericGetAttr for the...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecarljm
hostnamegithub.com
expected-hostnamegithub.com
None3542e147982176a7ebaa23dfb559c8af16f721c03ec560c68c56b64a0f35e751
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseaf80af7cc9e3de9c336f18b208a600950a3c187c
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105094#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105094
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105094
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105094
Reloadhttps://github.com/python/cpython/pull/105094
Reloadhttps://github.com/python/cpython/pull/105094
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105094
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/105094
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/105094#issue-comment-box
carljmhttps://github.com/carljm
python:mainhttps://github.com/python/cpython/tree/main
carljm:superbadgetattrohttps://github.com/carljm/cpython/tree/superbadgetattro
gh-105035: fix super() calls on unusual types (e.g. meta-types) https://github.com/python/cpython/pull/105094#top
carljmhttps://github.com/carljm
python:mainhttps://github.com/python/cpython/tree/main
carljm:superbadgetattrohttps://github.com/carljm/cpython/tree/superbadgetattro
Conversation 2 https://github.com/python/cpython/pull/105094
Commits 4 https://github.com/python/cpython/pull/105094/commits
Checks 0 https://github.com/python/cpython/pull/105094/checks
Files changed https://github.com/python/cpython/pull/105094/files
Please reload this pagehttps://github.com/python/cpython/pull/105094
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/carljm
carljmhttps://github.com/carljm
May 30, 2023https://github.com/python/cpython/pull/105094#issue-1732467148
Please reload this pagehttps://github.com/python/cpython/pull/105094
3.12.0b1 includes backwards incompatible change to operation of super() #105035https://github.com/python/cpython/issues/105035
Please reload this pagehttps://github.com/python/cpython/pull/105094
https://github.com/carljm
pythongh-105035https://github.com/python/cpython/issues/105035
: fix super() calls on unusual types (e.g. meta-types)https://github.com/python/cpython/pull/105094/commits/4ef2316d072910133143f6aba1d9b42b12e607e9
4ef2316https://github.com/python/cpython/pull/105094/commits/4ef2316d072910133143f6aba1d9b42b12e607e9
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 30, 2023 https://github.com/python/cpython/pull/105094#ref-issue-1729164357
3.12.0b1 includes backwards incompatible change to operation of super() #105035 https://github.com/python/cpython/issues/105035
https://github.com/carljm
add news entryhttps://github.com/python/cpython/pull/105094/commits/289d6a61e786046c5e53e73d94e3fad111e02615
289d6a6https://github.com/python/cpython/pull/105094/commits/289d6a61e786046c5e53e73d94e3fad111e02615
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
May 30, 2023 https://github.com/python/cpython/pull/105094#pullrequestreview-1451229733
View reviewed changes https://github.com/python/cpython/pull/105094/files/289d6a61e786046c5e53e73d94e3fad111e02615
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 30, 2023https://github.com/python/cpython/pull/105094#event-9379883861
https://github.com/carljm
carljmhttps://github.com/carljm
May 30, 2023 16:18https://github.com/python/cpython/pull/105094#event-9380487470
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 30, 2023https://github.com/python/cpython/pull/105094#event-9380487910
https://github.com/carljm
no need to deopthttps://github.com/python/cpython/pull/105094/commits/8fff07262dee66985754bffdbcd3cfa9ecd0598b
8fff072https://github.com/python/cpython/pull/105094/commits/8fff07262dee66985754bffdbcd3cfa9ecd0598b
facebook-github-bothttps://github.com/facebook-github-bot
May 30, 2023 https://github.com/python/cpython/pull/105094#ref-commit-c638629
https://github.com/facebook-github-bot
fix super() calls on unusual types (e.g. meta-types)https://github.com/facebookincubator/cinder/commit/c6386293fec5f6667e70d864bb09bf91067ca711
c638629https://github.com/facebookincubator/cinder/commit/c6386293fec5f6667e70d864bb09bf91067ca711
python/cpython#105094https://github.com/python/cpython/pull/105094
https://github.com/carljm
Merge branch 'main' into superbadgetattrohttps://github.com/python/cpython/pull/105094/commits/24e115917053abaa1540b72a80e962979566e3b2
24e1159https://github.com/python/cpython/pull/105094/commits/24e115917053abaa1540b72a80e962979566e3b2
python#105110https://github.com/python/cpython/pull/105110
pythongh-105071https://github.com/python/cpython/issues/105071
python#105097https://github.com/python/cpython/pull/105097
pythongh-80064https://github.com/python/cpython/issues/80064
python#105099https://github.com/python/cpython/pull/105099
python#104904https://github.com/python/cpython/pull/104904
pythongh-103921https://github.com/python/cpython/issues/103921
python#105093https://github.com/python/cpython/pull/105093
pythongh-105091https://github.com/python/cpython/issues/105091
pythonGH-105092https://github.com/python/cpython/pull/105092
https://github.com/carljm
carljmhttps://github.com/carljm
68c75c3https://github.com/python/cpython/commit/68c75c31536e8c87901934f2d6da81f54f4334f9
May 30, 2023https://github.com/python/cpython/pull/105094#event-9382774207
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 30, 2023https://github.com/python/cpython/pull/105094#event-9382774699
https://github.com/carljm
carljmhttps://github.com/carljm
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
May 30, 2023https://github.com/python/cpython/pull/105094#event-9382775968
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
May 30, 2023https://github.com/python/cpython/pull/105094#issuecomment-1569061241
@carljmhttps://github.com/carljm
Please reload this pagehttps://github.com/python/cpython/pull/105094
miss-islingtonhttps://github.com/miss-islington
May 30, 2023 https://github.com/python/cpython/pull/105094#ref-commit-8eef8d4
https://github.com/carljm
https://github.com/miss-islington
pythongh-105035https://github.com/python/cpython/issues/105035
: fix super() calls on unusual types (e.g. meta-types) (https://github.com/miss-islington/cpython/commit/8eef8d4764ac6205c99a545ae30d5db9cf59e26d
…https://github.com/python/cpython/pull/105094
8eef8d4https://github.com/miss-islington/cpython/commit/8eef8d4764ac6205c99a545ae30d5db9cf59e26d
…pythonGH-105094https://github.com/python/cpython/pull/105094
68c75c3https://github.com/miss-islington/cpython/commit/68c75c31536e8c87901934f2d6da81f54f4334f9
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 30, 2023https://github.com/python/cpython/pull/105094#issuecomment-1569061433
GH-105117https://github.com/python/cpython/pull/105117
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/105094
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
May 30, 2023https://github.com/python/cpython/pull/105094#event-9382777687
carljmhttps://github.com/carljm
May 30, 2023 https://github.com/python/cpython/pull/105094#ref-commit-5fff491
https://github.com/miss-islington
https://github.com/carljm
[3.12]https://github.com/python/cpython/commit/5fff491bd5d6da579a28b521efd3ef15f3f42c01
gh-105035https://github.com/python/cpython/issues/105035
: fix super() calls on unusual types (e.g. meta-types) (https://github.com/python/cpython/commit/5fff491bd5d6da579a28b521efd3ef15f3f42c01
5fff491https://github.com/python/cpython/commit/5fff491bd5d6da579a28b521efd3ef15f3f42c01
GH-105094https://github.com/python/cpython/pull/105094
#105117https://github.com/python/cpython/pull/105117
gh-105035https://github.com/python/cpython/issues/105035
GH-105094https://github.com/python/cpython/pull/105094
68c75c3https://github.com/python/cpython/commit/68c75c31536e8c87901934f2d6da81f54f4334f9
https://github.com/carljm
carljmhttps://github.com/carljm
June 5, 2023 01:19https://github.com/python/cpython/pull/105094#event-9426566914
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 6, 2023 https://github.com/python/cpython/pull/105094#ref-pullrequest-1743530961
3.12 backport gh 105236 #105358 https://github.com/python/cpython/pull/105358
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105094
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/python/cpython/pull/105094/files/289d6a61e786046c5e53e73d94e3fad111e02615
Please reload this pagehttps://github.com/python/cpython/pull/105094
https://github.com/carljm
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/Fidget-Spinner
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.