René's URL Explorer Experiment


Title: gh-90026: support XATTRs on Cygwin by philcerf · Pull Request #105075 · python/cpython · GitHub

Open Graph Title: gh-90026: support XATTRs on Cygwin by philcerf · Pull Request #105075 · python/cpython

X Title: gh-90026: support XATTRs on Cygwin by philcerf · Pull Request #105075 · python/cpython

Description: As described in #90026 (comment) and following comments, CPython’s code for XATTRs seems to already support Cygwin… mostly. Apart from the changes made by this PR (simply compiling the relevant code), there are however also some changes needed on the Cygwin side (I guess): Namely, they don't export XATTR_SIZE_MAX and XATTR_LIST_MAX and so a build of CPython with this commit would fail right now. I've asked at their mailing list to have them included in their cygwin/limits.h (which I think is the proper place - Linux defines them in linux/limits.h): https://cygwin.com/pipermail/cygwin/2023-May/253750.html Right now, he newest Version of CPython in Cygwin is 3.9.9... so unless I can get this change backported, they won't be affected by this (well and even if, ... it would be some more "motivation" to set the missing defines, I guess ;-) ). I could of course also check whether the symbols are defined, as in: #if defined(HAVE_SYS_XATTR_H) # if defined(__linux__) && !defined(__FreeBSD_kernel__) && !defined(__GNU__) # define USE_XATTRS # include // Needed for XATTR_SIZE_MAX on musl libc. # endif # if defined(__CYGWIN__) # include // Needed for XATTR_SIZE_MAX and XATTR_LIST_MAX. # if defined(XATTR_SIZE_MAX) && defined(XATTR_LIST_MAX) # define USE_XATTRS # endif # endif #endif I found that to be a bit ugly and overkill,... but if Python developers like it more... I wouldn’t mind to adapt my commit. Thanks Issue: gh-90026

Open Graph Description: As described in #90026 (comment) and following comments, CPython’s code for XATTRs seems to already support Cygwin… mostly. Apart from the changes made by this PR (simply compiling the relevant cod...

X Description: As described in #90026 (comment) and following comments, CPython’s code for XATTRs seems to already support Cygwin… mostly. Apart from the changes made by this PR (simply compiling the relevant cod...

Opengraph URL: https://github.com/python/cpython/pull/105075

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:55215c9f-9189-57bc-0040-68a53d1381a7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA6F8:3AEA09:9A709B:D362EA:6A4DDCD0
html-safe-noncedf5c50783d458759d09a379386eb3c8f375728e2e229e70f1f787ee47f9fa102
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkY4OjNBRUEwOTo5QTcwOUI6RDM2MkVBOjZBNEREQ0QwIiwidmlzaXRvcl9pZCI6IjgxNDYwODMwODcwNDc4NDMwMjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac83a20aab7c05ea8160b86bbb1f75a5406f60378a8eeef7194177b4a8c021d80e
hovercard-subject-tagpull_request:1369691746
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/105075/files
twitter:imagehttps://avatars.githubusercontent.com/u/41550983?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/41550983?s=400&v=4
og:image:altAs described in #90026 (comment) and following comments, CPython’s code for XATTRs seems to already support Cygwin… mostly. Apart from the changes made by this PR (simply compiling the relevant cod...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/105075/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105075%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F105075%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/105075/files
Reloadhttps://github.com/python/cpython/pull/105075/files
Reloadhttps://github.com/python/cpython/pull/105075/files
Please reload this pagehttps://github.com/python/cpython/pull/105075/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/105075/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
philcerf:xattrs-for-cygwinhttps://github.com/philcerf/cpython/tree/xattrs-for-cygwin
Conversation 20 https://github.com/python/cpython/pull/105075
Commits 2 https://github.com/python/cpython/pull/105075/commits
Checks 0 https://github.com/python/cpython/pull/105075/checks
Files changed https://github.com/python/cpython/pull/105075/files
Please reload this pagehttps://github.com/python/cpython/pull/105075/files
gh-90026: support XATTRs on Cygwin https://github.com/python/cpython/pull/105075/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/105075/files
1b74ef1 gh-90026: support XATTRs on Cygwin (#90026) philcerf May 30, 2023 https://github.com/python/cpython/pull/105075/commits/1b74ef10ecd0252b5834e316b562f7f0efc3ec7a
9ce8c50 📜🤖 Added by blurb_it. blurb-it[bot] May 30, 2023 https://github.com/python/cpython/pull/105075/commits/9ce8c50ab5a585655936060b9c0be28be9b09f7a
Clear filters https://github.com/python/cpython/pull/105075/files
Please reload this pagehttps://github.com/python/cpython/pull/105075/files
Please reload this pagehttps://github.com/python/cpython/pull/105075/files
2023-05-30-02-01-14.gh-issue-90026.FyCXw8.rst https://github.com/python/cpython/pull/105075/files#diff-92db685bf794dc46d13c9371d34f518645a9a4242e7738d5015315dbdd52b1bc
posixmodule.c https://github.com/python/cpython/pull/105075/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
Misc/NEWS.d/next/Library/2023-05-30-02-01-14.gh-issue-90026.FyCXw8.rsthttps://github.com/python/cpython/pull/105075/files#diff-92db685bf794dc46d13c9371d34f518645a9a4242e7738d5015315dbdd52b1bc
View file https://github.com/philcerf/cpython/blob/9ce8c50ab5a585655936060b9c0be28be9b09f7a/Misc/NEWS.d/next/Library/2023-05-30-02-01-14.gh-issue-90026.FyCXw8.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105075/{{ revealButtonHref }}
Modules/posixmodule.chttps://github.com/python/cpython/pull/105075/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
View file https://github.com/philcerf/cpython/blob/9ce8c50ab5a585655936060b9c0be28be9b09f7a/Modules/posixmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/105075/{{ revealButtonHref }}
https://github.com/python/cpython/pull/105075/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com/python/cpython/pull/105075/files#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.