| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a63f19a8-b10a-431c-aa30-8b24d87e3108 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 916C:1F1AF5:921FA8:C6FD90:6969EC3E |
| html-safe-nonce | 39094b7abe815207e18f646d12fa11c4a30c6002fc65dd318828509ced19aa9d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTZDOjFGMUFGNTo5MjFGQTg6QzZGRDkwOjY5NjlFQzNFIiwidmlzaXRvcl9pZCI6IjYwNzEwNzE4MjgxMjczNzg0OTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4fb36ee4c99134229259220a35ef908ccbf60205962f28a10deb5ce42230510c |
| hovercard-subject-tag | pull_request:1365811460 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104965/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d98aacad7f22312c3c628464cf37a25c54ac6e276079968385079c61d987e5c9/python/cpython/pull/104965 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d98aacad7f22312c3c628464cf37a25c54ac6e276079968385079c61d987e5c9/python/cpython/pull/104965 |
| og:image:alt | Thomas, the C code deprecation and the related tests were created in a way that should be easy to review and easy to turned-off if need arises.
Issue: Deprecate pickle support for itertools #1015... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rhettinger |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/104965#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104965 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104965 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/104965 |
| Reload | https://github.com/python/cpython/pull/104965 |
| Reload | https://github.com/python/cpython/pull/104965 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/104965 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/104965 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/104965#issue-comment-box |
| rhettinger | https://github.com/rhettinger |
| python:main | https://github.com/python/cpython/tree/main |
| rhettinger:itertool_pickle_deprecation | https://github.com/rhettinger/cpython/tree/itertool_pickle_deprecation |
|
GH-101588: Deprecate pickle/copy/deepcopy support in itertools
| https://github.com/python/cpython/pull/104965#top |
| rhettinger | https://github.com/rhettinger |
| python:main | https://github.com/python/cpython/tree/main |
| rhettinger:itertool_pickle_deprecation | https://github.com/rhettinger/cpython/tree/itertool_pickle_deprecation |
|
Conversation
4
| https://github.com/python/cpython/pull/104965 |
|
Commits
7
| https://github.com/python/cpython/pull/104965/commits |
|
Checks
0
| https://github.com/python/cpython/pull/104965/checks |
|
Files changed
| https://github.com/python/cpython/pull/104965/files |
| Please reload this page | https://github.com/python/cpython/pull/104965 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/rhettinger |
| rhettinger | https://github.com/rhettinger |
| May 26, 2023 | https://github.com/python/cpython/pull/104965#issue-1727022201 |
| Please reload this page | https://github.com/python/cpython/pull/104965 |
| Deprecate pickle support for itertools #101588 | https://github.com/python/cpython/issues/101588 |
| https://cpython-previews--104965.org.readthedocs.build/ | https://cpython-previews--104965.org.readthedocs.build/ |
| Please reload this page | https://github.com/python/cpython/pull/104965 |
| rhettinger | https://github.com/rhettinger |
| May 25, 2023 21:38 | https://github.com/python/cpython/pull/104965#commits-pushed-6b6aa77 |
|
| https://github.com/rhettinger |
| Add deprecations for itertool pickle support. | https://github.com/python/cpython/pull/104965/commits/6b6aa774a8c6ea5e4c1ec223f8c1d3b5947761cb |
| 6b6aa77 | https://github.com/python/cpython/pull/104965/commits/6b6aa774a8c6ea5e4c1ec223f8c1d3b5947761cb |
|
| https://github.com/rhettinger |
| Limit category to a DeprecationWarnings | https://github.com/python/cpython/pull/104965/commits/c24e2934b28d96fb37b545053f5296622c886c61 |
| c24e293 | https://github.com/python/cpython/pull/104965/commits/c24e2934b28d96fb37b545053f5296622c886c61 |
|
| https://github.com/rhettinger |
| Expand warning message to cover copy and deepcopy as well | https://github.com/python/cpython/pull/104965/commits/168700523b3ce6c8808c273b1fa7aaa7fcb65e05 |
| 1687005 | https://github.com/python/cpython/pull/104965/commits/168700523b3ce6c8808c273b1fa7aaa7fcb65e05 |
|
| https://github.com/rhettinger |
| Add whatsnew entry | https://github.com/python/cpython/pull/104965/commits/ae7f17bc05e67dac170a0977ed3909c64b75e0ec |
| ae7f17b | https://github.com/python/cpython/pull/104965/commits/ae7f17bc05e67dac170a0977ed3909c64b75e0ec |
| https://github.com/rhettinger |
| rhettinger | https://github.com/rhettinger |
|
needs backport to 3.12
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22 |
| May 26, 2023 | https://github.com/python/cpython/pull/104965#event-9347157513 |
| https://github.com/rhettinger |
| rhettinger | https://github.com/rhettinger |
| Yhg1s | https://github.com/Yhg1s |
| May 26, 2023 07:01 | https://github.com/python/cpython/pull/104965#event-9347157524 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| May 26, 2023 | https://github.com/python/cpython/pull/104965#event-9347157875 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
May 26, 2023
| https://github.com/python/cpython/pull/104965#ref-issue-1571582024 |
|
Deprecate pickle support for itertools
#101588
| https://github.com/python/cpython/issues/101588 |
| https://github.com/Yhg1s |
| Yhg1s | https://github.com/Yhg1s |
|
May 26, 2023
| https://github.com/python/cpython/pull/104965#pullrequestreview-1445688550 |
|
View reviewed changes
| https://github.com/python/cpython/pull/104965/files/ae7f17bc05e67dac170a0977ed3909c64b75e0ec |
| Lib/test/test_itertools.py | https://github.com/python/cpython/pull/104965/files/ae7f17bc05e67dac170a0977ed3909c64b75e0ec#diff-9abbaeca99112e9e04b554726bff97b76030eb982f39e591be77be8ef14149e5 |
| Yhg1s | https://github.com/Yhg1s |
| May 26, 2023 | https://github.com/python/cpython/pull/104965#discussion_r1206460683 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/104965 |
| rhettinger | https://github.com/rhettinger |
| May 26, 2023 | https://github.com/python/cpython/pull/104965#discussion_r1207013408 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/104965 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| May 26, 2023 | https://github.com/python/cpython/pull/104965#event-9348312042 |
| rhettinger | https://github.com/rhettinger |
| May 26, 2023 11:11 | https://github.com/python/cpython/pull/104965#commits-pushed-4fefb7e |
|
| https://github.com/rhettinger |
| Return NULL instead of None. Add third pass to check warning-to-error… | https://github.com/python/cpython/pull/104965/commits/4fefb7ee622fc90ffb7c0c12202f44e17d114759 |
| 4fefb7e | https://github.com/python/cpython/pull/104965/commits/4fefb7ee622fc90ffb7c0c12202f44e17d114759 |
|
| https://github.com/rhettinger |
| Minor wording tweak | https://github.com/python/cpython/pull/104965/commits/8943817a61a722524534bb98d43be22d219ab2f8 |
| 8943817 | https://github.com/python/cpython/pull/104965/commits/8943817a61a722524534bb98d43be22d219ab2f8 |
|
| https://github.com/rhettinger |
| Merge branch 'main' into itertool_pickle_deprecation | https://github.com/python/cpython/pull/104965/commits/8b56c335bbbde8b025469b29de245e73db6a5f1f |
| 8b56c33 | https://github.com/python/cpython/pull/104965/commits/8b56c335bbbde8b025469b29de245e73db6a5f1f |
| https://github.com/rhettinger |
| rhettinger | https://github.com/rhettinger |
| 402ee5a | https://github.com/python/cpython/commit/402ee5a68b306b489b782478ab96e8e3b913587a |
| May 26, 2023 | https://github.com/python/cpython/pull/104965#event-9354488427 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| May 26, 2023 | https://github.com/python/cpython/pull/104965#issuecomment-1564915035 |
| @rhettinger | https://github.com/rhettinger |
| Please reload this page | https://github.com/python/cpython/pull/104965 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| May 26, 2023 | https://github.com/python/cpython/pull/104965#event-9354488710 |
| https://github.com/rhettinger |
| rhettinger | https://github.com/rhettinger |
| May 26, 2023 20:33 | https://github.com/python/cpython/pull/104965#event-9354489295 |
| miss-islington | https://github.com/miss-islington |
|
May 26, 2023
| https://github.com/python/cpython/pull/104965#ref-commit-e326b27 |
|
| https://github.com/rhettinger |
|
| https://github.com/miss-islington |
| pythonGH-101588 | https://github.com/python/cpython/issues/101588 |
| : Deprecate pickle/copy/deepcopy support in itertools ( | https://github.com/miss-islington/cpython/commit/e326b2733a9677f28fa940e7959a164ab785b106 |
| p… | https://github.com/python/cpython/pull/104965 |
| e326b27 | https://github.com/miss-islington/cpython/commit/e326b2733a9677f28fa940e7959a164ab785b106 |
| …ythonGH-104965 | https://github.com/python/cpython/pull/104965 |
| 402ee5a | https://github.com/miss-islington/cpython/commit/402ee5a68b306b489b782478ab96e8e3b913587a |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| May 26, 2023 | https://github.com/python/cpython/pull/104965#issuecomment-1564915415 |
| GH-104997 | https://github.com/python/cpython/pull/104997 |
| 3.12 branch | https://github.com/python/cpython/tree/3.12 |
| Please reload this page | https://github.com/python/cpython/pull/104965 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.12
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22 |
| May 26, 2023 | https://github.com/python/cpython/pull/104965#event-9354489980 |
| rhettinger | https://github.com/rhettinger |
|
May 26, 2023
| https://github.com/python/cpython/pull/104965#ref-commit-05189f3 |
|
| https://github.com/miss-islington |
| [3.12] | https://github.com/python/cpython/commit/05189f3054e3a831967a1bb53d14d97c97e31598 |
| GH-101588 | https://github.com/python/cpython/issues/101588 |
| : Deprecate pickle/copy/deepcopy support in itertools ( | https://github.com/python/cpython/commit/05189f3054e3a831967a1bb53d14d97c97e31598 |
| … | https://github.com/python/cpython/pull/104965 |
| 05189f3 | https://github.com/python/cpython/commit/05189f3054e3a831967a1bb53d14d97c97e31598 |
| …GH-104965 | https://github.com/python/cpython/pull/104965 |
| GH-104997 | https://github.com/python/cpython/pull/104997 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
|
Jun 6, 2023
| https://github.com/python/cpython/pull/104965#ref-pullrequest-1743530961 |
|
3.12 backport gh 105236
#105358
| https://github.com/python/cpython/pull/105358 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104965 |
|
| https://github.com/Yhg1s |
|
Yhg1s
| https://github.com/Yhg1s |
|
| https://github.com/python/cpython/pull/104965/files/ae7f17bc05e67dac170a0977ed3909c64b75e0ec |
| Please reload this page | https://github.com/python/cpython/pull/104965 |
|
| https://github.com/rhettinger |
|
| https://github.com/miss-islington |
|
| https://github.com/bedevere-bot |
|
| https://github.com/Yhg1s |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |