René's URL Explorer Experiment


Title: Remove raw asserts in test_typing.py by JelleZijlstra · Pull Request #104951 · python/cpython · GitHub

Open Graph Title: Remove raw asserts in test_typing.py by JelleZijlstra · Pull Request #104951 · python/cpython

X Title: Remove raw asserts in test_typing.py by JelleZijlstra · Pull Request #104951 · python/cpython

Opengraph URL: https://github.com/python/cpython/pull/104951

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b589e968-c011-6c73-6948-05f6a38aecdd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDA0E:1F4CB1:9C2678:CF78CB:696991BE
html-safe-noncef6a6d9de5f39736c7d0c9dae7e46969b2a3aae1f0a731fa4e989571a07d8efed
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTBFOjFGNENCMTo5QzI2Nzg6Q0Y3OENCOjY5Njk5MUJFIiwidmlzaXRvcl9pZCI6Ijc0NjI3MTMxOTg1MDMzNjcxMDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac75301c906aed8994833de473bf5855f073fec35ca6a0ed57ab14c877567d159b
hovercard-subject-tagpull_request:1365630074
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104951/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e77764d2e57214cfefa6154bd69d028e7407161ed3c517bfe75725e6f6e8de92/python/cpython/pull/104951
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e77764d2e57214cfefa6154bd69d028e7407161ed3c517bfe75725e6f6e8de92/python/cpython/pull/104951
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJelleZijlstra
hostnamegithub.com
expected-hostnamegithub.com
None3542e147982176a7ebaa23dfb559c8af16f721c03ec560c68c56b64a0f35e751
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseaf80af7cc9e3de9c336f18b208a600950a3c187c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104951#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104951
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104951
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104951
Reloadhttps://github.com/python/cpython/pull/104951
Reloadhttps://github.com/python/cpython/pull/104951
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104951
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104951
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/104951#issue-comment-box
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
JelleZijlstra:rawasserthttps://github.com/JelleZijlstra/cpython/tree/rawassert
Remove raw asserts in test_typing.py https://github.com/python/cpython/pull/104951#top
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
JelleZijlstra:rawasserthttps://github.com/JelleZijlstra/cpython/tree/rawassert
Conversation 8 https://github.com/python/cpython/pull/104951
Commits 3 https://github.com/python/cpython/pull/104951/commits
Checks 0 https://github.com/python/cpython/pull/104951/checks
Files changed https://github.com/python/cpython/pull/104951/files
Please reload this pagehttps://github.com/python/cpython/pull/104951
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 26, 2023https://github.com/python/cpython/pull/104951#issue-1726815772
Please reload this pagehttps://github.com/python/cpython/pull/104951
https://github.com/JelleZijlstra
Remove raw asserts in test_typing.pyhttps://github.com/python/cpython/pull/104951/commits/33be00cd03d8e7c9aeee97d8421bff88631d5dbd
33be00chttps://github.com/python/cpython/pull/104951/commits/33be00cd03d8e7c9aeee97d8421bff88631d5dbd
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
May 26, 2023https://github.com/python/cpython/pull/104951#event-9346024819
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
AlexWaygoodhttps://github.com/AlexWaygood
Fidget-Spinnerhttps://github.com/Fidget-Spinner
gvanrossumhttps://github.com/gvanrossum
code ownershttps://github.com/python/cpython/blob/705e387dd81b971cb1ee5727da54adfb565f61d0/.github/CODEOWNERS#L146
May 26, 2023 02:55https://github.com/python/cpython/pull/104951#event-9346024850
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
May 26, 2023https://github.com/python/cpython/pull/104951#event-9346025024
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
May 26, 2023 https://github.com/python/cpython/pull/104951#pullrequestreview-1446143268
View reviewed changes https://github.com/python/cpython/pull/104951/files/33be00cd03d8e7c9aeee97d8421bff88631d5dbd
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 26, 2023https://github.com/python/cpython/pull/104951#event-9350377777
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 26, 2023 https://github.com/python/cpython/pull/104951#pullrequestreview-1446106252
View reviewed changes https://github.com/python/cpython/pull/104951/files/33be00cd03d8e7c9aeee97d8421bff88631d5dbd
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/104951/files/33be00cd03d8e7c9aeee97d8421bff88631d5dbd#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
AlexWaygoodhttps://github.com/AlexWaygood
May 26, 2023https://github.com/python/cpython/pull/104951#discussion_r1206697468
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104951
AlexWaygoodhttps://github.com/AlexWaygood
May 26, 2023https://github.com/python/cpython/pull/104951#discussion_r1206720860
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104951
JelleZijlstrahttps://github.com/JelleZijlstra
May 26, 2023https://github.com/python/cpython/pull/104951#discussion_r1206728645
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104951
JelleZijlstrahttps://github.com/JelleZijlstra
May 26, 2023https://github.com/python/cpython/pull/104951#discussion_r1206736395
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104951
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 26, 2023 https://github.com/python/cpython/pull/104951#pullrequestreview-1446146015
View reviewed changes https://github.com/python/cpython/pull/104951/files/33be00cd03d8e7c9aeee97d8421bff88631d5dbd
JelleZijlstrahttps://github.com/JelleZijlstra
May 26, 2023 05:49https://github.com/python/cpython/pull/104951#commits-pushed-f76b460
https://github.com/JelleZijlstra
Add some checks that required/optional keys is really a frozensethttps://github.com/python/cpython/pull/104951/commits/f76b46042e24a121167bbec59d0bc0c6caa8dde4
f76b460https://github.com/python/cpython/pull/104951/commits/f76b46042e24a121167bbec59d0bc0c6caa8dde4
https://github.com/JelleZijlstra
Merge remote-tracking branch 'upstream/main' into rawasserthttps://github.com/python/cpython/pull/104951/commits/c0540214629d72d7329bfcfc920d50c79983958f
c054021https://github.com/python/cpython/pull/104951/commits/c0540214629d72d7329bfcfc920d50c79983958f
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 26, 2023 https://github.com/python/cpython/pull/104951#pullrequestreview-1446202426
View reviewed changes https://github.com/python/cpython/pull/104951/files/c0540214629d72d7329bfcfc920d50c79983958f
AlexWaygoodhttps://github.com/AlexWaygood
https://github.com/python/cpython/pull/104951#pullrequestreview-1446202426
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104951
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
2cb4456https://github.com/python/cpython/commit/2cb445635e99d4401949cabebd373288cfdd0138
May 26, 2023https://github.com/python/cpython/pull/104951#event-9351235276
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
May 26, 2023https://github.com/python/cpython/pull/104951#issuecomment-1564443343
@JelleZijlstrahttps://github.com/JelleZijlstra
@AlexWaygoodhttps://github.com/AlexWaygood
Please reload this pagehttps://github.com/python/cpython/pull/104951
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 26, 2023https://github.com/python/cpython/pull/104951#event-9351235790
miss-islingtonhttps://github.com/miss-islington
May 26, 2023 https://github.com/python/cpython/pull/104951#ref-commit-2715dc4
https://github.com/JelleZijlstra
https://github.com/miss-islington
Remove raw asserts in test_typing.py (https://github.com/miss-islington/cpython/commit/2715dc4063c8ba6008f1f508fcab79f090f382bb
pythonGH-104951https://github.com/python/cpython/pull/104951
)https://github.com/miss-islington/cpython/commit/2715dc4063c8ba6008f1f508fcab79f090f382bb
2715dc4https://github.com/miss-islington/cpython/commit/2715dc4063c8ba6008f1f508fcab79f090f382bb
2cb4456https://github.com/miss-islington/cpython/commit/2cb445635e99d4401949cabebd373288cfdd0138
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 26, 2023https://github.com/python/cpython/pull/104951#issuecomment-1564443581
GH-104978https://github.com/python/cpython/pull/104978
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/104951
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
May 26, 2023https://github.com/python/cpython/pull/104951#event-9351237910
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 26, 2023https://github.com/python/cpython/pull/104951#issuecomment-1564443782
GH-104979https://github.com/python/cpython/pull/104979
3.11 branchhttps://github.com/python/cpython/tree/3.11
Please reload this pagehttps://github.com/python/cpython/pull/104951
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.11 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22
May 26, 2023https://github.com/python/cpython/pull/104951#event-9351240558
miss-islingtonhttps://github.com/miss-islington
May 26, 2023 https://github.com/python/cpython/pull/104951#ref-commit-d37ef60
https://github.com/JelleZijlstra
https://github.com/miss-islington
Remove raw asserts in test_typing.py (https://github.com/miss-islington/cpython/commit/d37ef606bb276c01bd02f4cd54cb673bca828a5f
pythonGH-104951https://github.com/python/cpython/pull/104951
)https://github.com/miss-islington/cpython/commit/d37ef606bb276c01bd02f4cd54cb673bca828a5f
d37ef60https://github.com/miss-islington/cpython/commit/d37ef606bb276c01bd02f4cd54cb673bca828a5f
2cb4456https://github.com/miss-islington/cpython/commit/2cb445635e99d4401949cabebd373288cfdd0138
AlexWaygoodhttps://github.com/AlexWaygood
May 26, 2023 https://github.com/python/cpython/pull/104951#ref-commit-ca55247
https://github.com/miss-islington
https://github.com/JelleZijlstra
[3.11] Remove raw asserts in test_typing.py (https://github.com/python/cpython/commit/ca5524745df32cc8abfec7de3357f3a660594179
GH-104951https://github.com/python/cpython/pull/104951
) (https://github.com/python/cpython/commit/ca5524745df32cc8abfec7de3357f3a660594179
#104979https://github.com/python/cpython/pull/104979
)https://github.com/python/cpython/commit/ca5524745df32cc8abfec7de3357f3a660594179
ca55247https://github.com/python/cpython/commit/ca5524745df32cc8abfec7de3357f3a660594179
GH-104951https://github.com/python/cpython/pull/104951
2cb4456https://github.com/python/cpython/commit/2cb445635e99d4401949cabebd373288cfdd0138
AlexWaygoodhttps://github.com/AlexWaygood
May 26, 2023 https://github.com/python/cpython/pull/104951#ref-commit-01af2b0
https://github.com/miss-islington
https://github.com/JelleZijlstra
[3.12] Remove raw asserts in test_typing.py (https://github.com/python/cpython/commit/01af2b0e516608c831f4c6837087479f45368d21
GH-104951https://github.com/python/cpython/pull/104951
) (https://github.com/python/cpython/commit/01af2b0e516608c831f4c6837087479f45368d21
#104978https://github.com/python/cpython/pull/104978
)https://github.com/python/cpython/commit/01af2b0e516608c831f4c6837087479f45368d21
01af2b0https://github.com/python/cpython/commit/01af2b0e516608c831f4c6837087479f45368d21
GH-104951https://github.com/python/cpython/pull/104951
2cb4456https://github.com/python/cpython/commit/2cb445635e99d4401949cabebd373288cfdd0138
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 6, 2023 https://github.com/python/cpython/pull/104951#ref-pullrequest-1743530961
3.12 backport gh 105236 #105358 https://github.com/python/cpython/pull/105358
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104951
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/python/cpython/pull/104951/files/33be00cd03d8e7c9aeee97d8421bff88631d5dbd
https://github.com/AlexWaygood
AlexWaygood https://github.com/AlexWaygood
https://github.com/python/cpython/pull/104951/files/c0540214629d72d7329bfcfc920d50c79983958f
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/104951
https://github.com/JelleZijlstra
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/Fidget-Spinner
https://github.com/AlexWaygood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.