René's URL Explorer Experiment


Title: bpo-32492: 1.6x speed up in namedtuple attribute access using C fast-path by pablogsal · Pull Request #10495 · python/cpython · GitHub

Open Graph Title: bpo-32492: 1.6x speed up in namedtuple attribute access using C fast-path by pablogsal · Pull Request #10495 · python/cpython

X Title: bpo-32492: 1.6x speed up in namedtuple attribute access using C fast-path by pablogsal · Pull Request #10495 · python/cpython

Description: Timing benchmarks Attribute Access import perf runner = perf.Runner() runner.timeit("a.x", stmt="a.x", setup="import collections;A=collections.namedtuple('A','x')") ./python -m perf compare_to old.json new.json -v Mean +- std dev: [old] 280 ns +- 3 ns -> [new] 111 ns +- 1 ns: 2.52x faster Apparently, there is a regression in the current master. This is the comparison against 3.7: Mean +- std dev: [old] 176 ns +- 2 ns -> [new] 110 ns +- 2 ns: 1.61x faster (-38%) Significant (t=177.69) Creation (Just to check that creation is not slower) import perf runner = perf.Runner() runner.timeit("collections.namedtuple('A','x')", stmt="collections.namedtuple('A','x')", setup="import collections") Mean +- std dev: [old_creation] 209 us +- 3 us -> [new_creation] 207 us +- 4 us: 1.01x faster import perf runner = perf.Runner() runner.timeit("A(2324)", stmt="A(2324)", setup="import collections;A=collections.namedtuple('A','x')") Mean +- std dev: [old_creation_obj] 1.41 us +- 0.03 us -> [new_creation_obj] 1.41 us +- 0.02 us: 1.00x faster (-0%) Cache efficiency Baseline ❯ perf stat -r 200 -B -e cache-references,cache-misses,cycles,instructions,branches,faults,migrations ./python -c " import collections A = collections.namedtuple('A','x');a = A(42) for _ in range(100): some_var = a.x """ Performance counter stats for './python -c import collections A = collections.namedtuple('A','x');a = A(42) for _ in range(100): some_var = a.x ' (200 runs): 1,469,290 cache-references:u ( +- 0.26% ) 20,240 cache-misses:u # 1.378 % of all cache refs ( +- 8.58% ) 146,812,273 cycles:u ( +- 0.24% ) 201,131,089 instructions:u # 1.37 insn per cycle ( +- 0.01% ) 40,257,360 branches:u ( +- 0.01% ) 1,175 faults:u ( +- 0.01% ) 0 migrations:u 0.050526 +- 0.000281 seconds time elapsed ( +- 0.56% ) Patched ❯ perf stat -r 200 -B -e cache-references,cache-misses,cycles,instructions,branches,faults,migrations ./python -c " import collections A = collections.namedtuple('A','x');a = A(42) for _ in range(100): some_var = a.x """ Performance counter stats for './python -c import collections A = collections.namedtuple('A','x');a = A(42) for _ in range(100): some_var = a.x ' (200 runs): 1,471,736 cache-references:u ( +- 0.11% ) 7,196 cache-misses:u # 0.489 % of all cache refs ( +- 6.94% ) 145,004,120 cycles:u ( +- 0.07% ) 201,182,075 instructions:u # 1.39 insn per cycle ( +- 0.01% ) 40,219,107 branches:u ( +- 0.01% ) 1,174 faults:u ( +- 0.01% ) 0 migrations:u 0.048499 +- 0.000222 seconds time elapsed ( +- 0.44% ) https://bugs.python.org/issue32492

Open Graph Description: Timing benchmarks Attribute Access import perf runner = perf.Runner() runner.timeit("a.x", stmt="a.x", setup="import collections;A=collections....

X Description: Timing benchmarks Attribute Access import perf runner = perf.Runner() runner.timeit("a.x", stmt="a.x", setup="import collec...

Opengraph URL: https://github.com/python/cpython/pull/10495

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:af4aeea8-9c71-ed98-a710-b47d37f8361e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB954:1C7149:2FFD13:41B7DA:6A514156
html-safe-nonce79ad48fad2003582b5e1c93a3c3da52616bf440ca8d65cb11bad3eb23e112feb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTU0OjFDNzE0OToyRkZEMTM6NDFCN0RBOjZBNTE0MTU2IiwidmlzaXRvcl9pZCI6IjQ5NDIzODY0ODQ2ODQ2MDM3MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb901248f570f98d7db4e38c8a83fa8b797c9052f89f888d2eb94f8f9a5c3d9d0
hovercard-subject-tagpull_request:230315329
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/10495/files
twitter:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
og:image:altTiming benchmarks Attribute Access import perf runner = perf.Runner() runner.timeit("a.x", stmt="a.x", setup="import collections;A=collections....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee840f405b2718e8f2d55aafa9ff27dbce17e29d0c253011d05ea0fea3c78baff
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee876f00c5723f6080b9d294e4958fd4d506e6faf
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/10495/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10495%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10495%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/10495/files
Reloadhttps://github.com/python/cpython/pull/10495/files
Reloadhttps://github.com/python/cpython/pull/10495/files
Please reload this pagehttps://github.com/python/cpython/pull/10495/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/10495/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
rhettingerhttps://github.com/rhettinger
python:masterhttps://github.com/python/cpython/tree/master
pablogsal:bpo32492https://github.com/pablogsal/cpython/tree/bpo32492
Conversation 44 https://github.com/python/cpython/pull/10495
Commits 14 https://github.com/python/cpython/pull/10495/commits
Checks 0 https://github.com/python/cpython/pull/10495/checks
Files changed https://github.com/python/cpython/pull/10495/files
Please reload this pagehttps://github.com/python/cpython/pull/10495/files
bpo-32492: 1.6x speed up in namedtuple attribute access using C fast-path https://github.com/python/cpython/pull/10495/files#top
Show all changes 14 commits https://github.com/python/cpython/pull/10495/files
97c3ee5 bpo-32492: 2.5x speed up in namedtuple attribute access using C fast … pablogsal Nov 13, 2018 https://github.com/python/cpython/pull/10495/commits/97c3ee547d26599115d438031a2f545fd51dbca8
5dc78ff Add News entry pablogsal Nov 13, 2018 https://github.com/python/cpython/pull/10495/commits/5dc78ffc1f32e9b2a378d7b3fd970e219b92fc70
631ab2c fixup! bpo-32492: 2.5x speed up in namedtuple attribute access using … pablogsal Nov 13, 2018 https://github.com/python/cpython/pull/10495/commits/631ab2cb294e578ef7f505e5bb21514c50c88784
21be735 Check for tuple in the __get__ of the new descriptor and don't cache … pablogsal Nov 13, 2018 https://github.com/python/cpython/pull/10495/commits/21be735c328b1054795af574da559ee90a080a37
1e14509 Don't inherit from property. Implement GC methods to handle __doc__ pablogsal Nov 15, 2018 https://github.com/python/cpython/pull/10495/commits/1e145090919c052a0dddd0cfa3e32a6477dd4b9b
f9ca1e4 Add a test for the docstring substitution in descriptors pablogsal Nov 16, 2018 https://github.com/python/cpython/pull/10495/commits/f9ca1e47dc21f695ae39cfa33a0764683306b3e4
a6187b8 Update NEWS entry to reflect time against 3.7 branch pablogsal Nov 16, 2018 https://github.com/python/cpython/pull/10495/commits/a6187b823ddfe6e776d068d6ae8aa3c4b6c3f91b
7d2dd84 Simplify implementation with argument clinic, better error messages, … pablogsal Nov 16, 2018 https://github.com/python/cpython/pull/10495/commits/7d2dd842c33c4fcf84fe9e11ed9d9a007e047263
e5bca1d Use positional-only parameters for the __new__ pablogsal Nov 27, 2018 https://github.com/python/cpython/pull/10495/commits/e5bca1d348406007bfa219d2033a672a72eb0021
96eae4c Use PyTuple_GET_SIZE and PyTuple_GET_ITEM to tighter the implementati… pablogsal Dec 28, 2018 https://github.com/python/cpython/pull/10495/commits/96eae4c22d9d82e2089138aa2c26b69c5501a055
9838c39 Implement __set__ to make tuplegetter a data descriptor pablogsal Dec 29, 2018 https://github.com/python/cpython/pull/10495/commits/9838c39e36a7ba8e5344388e1fbe9947d4764fe6
2e350ed Use Py_INCREF now that we inline PyTuple_GetItem pablogsal Dec 29, 2018 https://github.com/python/cpython/pull/10495/commits/2e350edc96661572ad9e982cc6abac847b0b8ddb
c9772e8 Apply the valid_index() function, saving one test rhettinger Dec 30, 2018 https://github.com/python/cpython/pull/10495/commits/c9772e866273da66059068a2d4cb9fe600eeaaf3
62cd7fd Move Py_None test out of the critical path. rhettinger Dec 30, 2018 https://github.com/python/cpython/pull/10495/commits/62cd7fd21b746825a5d5dc6605b46964d53584df
Clear filters https://github.com/python/cpython/pull/10495/files
Please reload this pagehttps://github.com/python/cpython/pull/10495/files
Please reload this pagehttps://github.com/python/cpython/pull/10495/files
__init__.py https://github.com/python/cpython/pull/10495/files#diff-c92f871cb9b4aa1583c89f82cd416d58a5d70fff41faf41e45dedf775dbe7713
test_collections.py https://github.com/python/cpython/pull/10495/files#diff-a2a882635e20e8e9439f090d33513502a7af648286efebfa4e4bc37270c44784
2018-11-13-01-03-10.bpo-32492.voIdcp.rst https://github.com/python/cpython/pull/10495/files#diff-d75d3ef83f683c6b419860113896019453326f5a944834ac8244ffa14fb32714
_collectionsmodule.c https://github.com/python/cpython/pull/10495/files#diff-bfedaecb4a5a92b4dc78b96a753ae08600be7f0acab82383abcc6799aa47084c
_collectionsmodule.c.h https://github.com/python/cpython/pull/10495/files#diff-b3663bc8acb4b6949af7bef96b1c56a2b6b5e28937c3932750bff09d7eead4de
Lib/collections/__init__.pyhttps://github.com/python/cpython/pull/10495/files#diff-c92f871cb9b4aa1583c89f82cd416d58a5d70fff41faf41e45dedf775dbe7713
View file https://github.com/pablogsal/cpython/blob/62cd7fd21b746825a5d5dc6605b46964d53584df/Lib/collections/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10495/{{ revealButtonHref }}
https://github.com/python/cpython/pull/10495/files#diff-c92f871cb9b4aa1583c89f82cd416d58a5d70fff41faf41e45dedf775dbe7713
https://github.com/python/cpython/pull/10495/files#diff-c92f871cb9b4aa1583c89f82cd416d58a5d70fff41faf41e45dedf775dbe7713
https://github.com/python/cpython/pull/10495/files#diff-c92f871cb9b4aa1583c89f82cd416d58a5d70fff41faf41e45dedf775dbe7713
serhiy-storchakahttps://github.com/serhiy-storchaka
Nov 15, 2018https://github.com/python/cpython/pull/10495/files#r233754595
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/10495/files
pablogsalhttps://github.com/pablogsal
Nov 16, 2018https://github.com/python/cpython/pull/10495/files#r234053604
Please reload this pagehttps://github.com/python/cpython/pull/10495/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/10495/files
methanehttps://github.com/methane
Nov 15, 2018https://github.com/python/cpython/pull/10495/files#r233779405
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/10495/files
pablogsalhttps://github.com/pablogsal
Nov 16, 2018https://github.com/python/cpython/pull/10495/files#r234052633
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#10495 (comment)https://github.com/python/cpython/pull/10495#discussion_r232916573
Please reload this pagehttps://github.com/python/cpython/pull/10495/files
https://github.com/python/cpython/pull/10495/files#diff-c92f871cb9b4aa1583c89f82cd416d58a5d70fff41faf41e45dedf775dbe7713
Lib/test/test_collections.pyhttps://github.com/python/cpython/pull/10495/files#diff-a2a882635e20e8e9439f090d33513502a7af648286efebfa4e4bc37270c44784
View file https://github.com/pablogsal/cpython/blob/62cd7fd21b746825a5d5dc6605b46964d53584df/Lib/test/test_collections.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10495/{{ revealButtonHref }}
https://github.com/python/cpython/pull/10495/files#diff-a2a882635e20e8e9439f090d33513502a7af648286efebfa4e4bc37270c44784
https://github.com/python/cpython/pull/10495/files#diff-a2a882635e20e8e9439f090d33513502a7af648286efebfa4e4bc37270c44784
Misc/NEWS.d/next/Core and Builtins/2018-11-13-01-03-10.bpo-32492.voIdcp.rsthttps://github.com/python/cpython/pull/10495/files#diff-d75d3ef83f683c6b419860113896019453326f5a944834ac8244ffa14fb32714
View file https://github.com/pablogsal/cpython/blob/62cd7fd21b746825a5d5dc6605b46964d53584df/Misc/NEWS.d/next/Core%20and%20Builtins/2018-11-13-01-03-10.bpo-32492.voIdcp.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10495/{{ revealButtonHref }}
Modules/_collectionsmodule.chttps://github.com/python/cpython/pull/10495/files#diff-bfedaecb4a5a92b4dc78b96a753ae08600be7f0acab82383abcc6799aa47084c
View file https://github.com/pablogsal/cpython/blob/62cd7fd21b746825a5d5dc6605b46964d53584df/Modules/_collectionsmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/10495/{{ revealButtonHref }}
https://github.com/python/cpython/pull/10495/files#diff-bfedaecb4a5a92b4dc78b96a753ae08600be7f0acab82383abcc6799aa47084c
https://github.com/python/cpython/pull/10495/files#diff-bfedaecb4a5a92b4dc78b96a753ae08600be7f0acab82383abcc6799aa47084c
https://github.com/python/cpython/pull/10495/files#diff-bfedaecb4a5a92b4dc78b96a753ae08600be7f0acab82383abcc6799aa47084c
serhiy-storchakahttps://github.com/serhiy-storchaka
Nov 15, 2018https://github.com/python/cpython/pull/10495/files#r233756623
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/10495/files
pablogsalhttps://github.com/pablogsal
Nov 15, 2018https://github.com/python/cpython/pull/10495/files#r234047408
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/10495/files
https://github.com/python/cpython/pull/10495/files#diff-bfedaecb4a5a92b4dc78b96a753ae08600be7f0acab82383abcc6799aa47084c
https://github.com/python/cpython/pull/10495/files#diff-bfedaecb4a5a92b4dc78b96a753ae08600be7f0acab82383abcc6799aa47084c
Modules/clinic/_collectionsmodule.c.hhttps://github.com/python/cpython/pull/10495/files#diff-b3663bc8acb4b6949af7bef96b1c56a2b6b5e28937c3932750bff09d7eead4de
View file https://github.com/pablogsal/cpython/blob/62cd7fd21b746825a5d5dc6605b46964d53584df/Modules/clinic/_collectionsmodule.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/10495/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.