René's URL Explorer Experiment


Title: [3.12] Fix test_importlib.test_side_effect_import() (GH-104840) by miss-islington · Pull Request #104842 · python/cpython · GitHub

Open Graph Title: [3.12] Fix test_importlib.test_side_effect_import() (GH-104840) by miss-islington · Pull Request #104842 · python/cpython

X Title: [3.12] Fix test_importlib.test_side_effect_import() (GH-104840) by miss-islington · Pull Request #104842 · python/cpython

Description: Wait until the thread spawn by the import completes to avoid dangling threads. With this fix, the following command no longer fails: ./python -m test --fail-env-changed test_importlib -m test_side_...

Open Graph Description: Wait until the thread spawn by the import completes to avoid dangling threads. With this fix, the following command no longer fails: ./python -m test --fail-env-changed test_importlib -m test_side_...

X Description: Wait until the thread spawn by the import completes to avoid dangling threads. With this fix, the following command no longer fails: ./python -m test --fail-env-changed test_importlib -m test_side_...

Mail addresses
vstinner@python.org

Opengraph URL: https://github.com/python/cpython/pull/104842

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:30baed7e-0dbd-02c1-1d73-5fd6fa5e83b8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE052:25A3F3:4BAD5:68D55:696A14A2
html-safe-nonceaa01bd39a59712aaf1f155ea841941d4ae075837d83221e1e74b852e82fd6f0f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDUyOjI1QTNGMzo0QkFENTo2OEQ1NTo2OTZBMTRBMiIsInZpc2l0b3JfaWQiOiI3ODQ2MDk2NTM0OTg4NTI2NzU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc7e1a3937e2ceab807c25e218d1b4b1b0f1173803038bb87688ac4e560570a5b
hovercard-subject-tagpull_request:1362634850
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104842/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a0dad621c24947883119bc48812a5fe35cb1d75120db7d9287dd02d9368425a6/python/cpython/pull/104842
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a0dad621c24947883119bc48812a5fe35cb1d75120db7d9287dd02d9368425a6/python/cpython/pull/104842
og:image:altWait until the thread spawn by the import completes to avoid dangling threads. With this fix, the following command no longer fails: ./python -m test --fail-env-changed test_importlib -m test_side_...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
None34a52bd10bd674f68e5c1b6b74413b79bf2ca20c551055ace3f7cdd112803923
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee8bd37502700f365b18a4d39acf7cb7947e11b1a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104842#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104842
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104842
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104842
Reloadhttps://github.com/python/cpython/pull/104842
Reloadhttps://github.com/python/cpython/pull/104842
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104842
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104842
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/104842#issue-comment-box
vstinnerhttps://github.com/vstinner
python:3.12https://github.com/python/cpython/tree/3.12
miss-islington:backport-4269509-3.12https://github.com/miss-islington/cpython/tree/backport-4269509-3.12
[3.12] Fix test_importlib.test_side_effect_import() (GH-104840) https://github.com/python/cpython/pull/104842#top
vstinnerhttps://github.com/vstinner
python:3.12https://github.com/python/cpython/tree/3.12
miss-islington:backport-4269509-3.12https://github.com/miss-islington/cpython/tree/backport-4269509-3.12
Conversation 3 https://github.com/python/cpython/pull/104842
Commits 1 https://github.com/python/cpython/pull/104842/commits
Checks 0 https://github.com/python/cpython/pull/104842/checks
Files changed https://github.com/python/cpython/pull/104842/files
Please reload this pagehttps://github.com/python/cpython/pull/104842
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
May 24, 2023https://github.com/python/cpython/pull/104842#issue-1723453855
4269509https://github.com/python/cpython/commit/426950993f6a39cdf3f6a3333ac8b518833c7e61
Please reload this pagehttps://github.com/python/cpython/pull/104842
https://github.com/vstinner
https://github.com/miss-islington
Fix test_importlib.test_side_effect_import() (https://github.com/python/cpython/pull/104842/commits/85e9c2fb6f8502b8e5d0067f8080bfb7fef29543
pythonGH-104840https://github.com/python/cpython/pull/104840
)https://github.com/python/cpython/pull/104842/commits/85e9c2fb6f8502b8e5d0067f8080bfb7fef29543
85e9c2fhttps://github.com/python/cpython/pull/104842/commits/85e9c2fb6f8502b8e5d0067f8080bfb7fef29543
4269509https://github.com/miss-islington/cpython/commit/426950993f6a39cdf3f6a3333ac8b518833c7e61
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
brettcannonhttps://github.com/brettcannon
encukouhttps://github.com/encukou
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
ncoghlanhttps://github.com/ncoghlan
warsawhttps://github.com/warsaw
code ownershttps://github.com/python/cpython/blob/b719dd8725a820a1af4b76c30ae87c23d8db68c0/.github/CODEOWNERS#L71
May 24, 2023 08:29https://github.com/python/cpython/pull/104842#event-9324661811
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 24, 2023https://github.com/python/cpython/pull/104842#event-9324662206
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 24, 2023 https://github.com/python/cpython/pull/104842#ref-pullrequest-1723408022
Fix test_importlib.test_side_effect_import() #104840 https://github.com/python/cpython/pull/104840
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
May 24, 2023https://github.com/python/cpython/pull/104842#event-9324662775
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 24, 2023 https://github.com/python/cpython/pull/104842#pullrequestreview-1441243498
View reviewed changes https://github.com/python/cpython/pull/104842/files/85e9c2fb6f8502b8e5d0067f8080bfb7fef29543
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/104842#pullrequestreview-1441243498
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104842
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 24, 2023https://github.com/python/cpython/pull/104842#event-9324676664
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
May 24, 2023https://github.com/python/cpython/pull/104842#issuecomment-1561743006
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/104842
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
51eb009https://github.com/python/cpython/commit/51eb009cef155f02c59d05ce1f0d93c50ea9085a
May 25, 2023https://github.com/python/cpython/pull/104842#event-9333978192
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 25, 2023https://github.com/python/cpython/pull/104842#event-9333978430
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
May 25, 2023 00:36https://github.com/python/cpython/pull/104842#event-9333978669
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 25, 2023https://github.com/python/cpython/pull/104842#issuecomment-1562097046
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/104842
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 6, 2023 https://github.com/python/cpython/pull/104842#ref-pullrequest-1743530961
3.12 backport gh 105236 #105358 https://github.com/python/cpython/pull/105358
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104842
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/104842/files/85e9c2fb6f8502b8e5d0067f8080bfb7fef29543
https://github.com/brettcannon
brettcannon https://github.com/brettcannon
https://github.com/encukou
encukou https://github.com/encukou
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
https://github.com/ncoghlan
ncoghlan https://github.com/ncoghlan
https://github.com/warsaw
warsaw https://github.com/warsaw
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/104842
https://github.com/miss-islington
https://github.com/brettcannon
https://github.com/vstinner
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.