| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9912dff8-2e95-1c24-6a33-99ee29a1b5a3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B4C0:861EA:11D7320:180C52B:6969A993 |
| html-safe-nonce | 17387568e4d75603aee11c9d7f0445d04a84a5ae22ce148024b787e95f79521a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEMwOjg2MUVBOjExRDczMjA6MTgwQzUyQjo2OTY5QTk5MyIsInZpc2l0b3JfaWQiOiIzOTAwMzgyNzcyNDc0Nzg0MTQ3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5c8dcd12a2201619166d9115f4dee4696d91aba8ee15158cba3535656c2a0644 |
| hovercard-subject-tag | pull_request:1361937755 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104810/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a22a64f5e05e6ef64dd3a5b4a11f72721175c0f56d284870937d349d10a96c5a/python/cpython/pull/104810 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a22a64f5e05e6ef64dd3a5b4a11f72721175c0f56d284870937d349d10a96c5a/python/cpython/pull/104810 |
| og:image:alt | Move __fspath__(), __bytes__() and as_uri() methods from PurePath to a new _PurePathExt subclass. This new subclass is inherited by PurePosixPath, PureWindowsPath and Path.
Because PurePath isn'... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | barneygale |
| hostname | github.com |
| expected-hostname | github.com |
| None | 24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 124667f43168afb6c9c03b7c02eb5b1d2e1be3d9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/104810#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104810 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104810 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/104810 |
| Reload | https://github.com/python/cpython/pull/104810 |
| Reload | https://github.com/python/cpython/pull/104810 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/104810#issue-comment-box |
| barneygale | https://github.com/barneygale |
| python:main | https://github.com/python/cpython/tree/main |
| barneygale:gh-89812-add-lexicalpath | https://github.com/barneygale/cpython/tree/gh-89812-add-lexicalpath |
|
GH-89812: Add pathlib._PurePathExt
| https://github.com/python/cpython/pull/104810#top |
| barneygale | https://github.com/barneygale |
| python:main | https://github.com/python/cpython/tree/main |
| barneygale:gh-89812-add-lexicalpath | https://github.com/barneygale/cpython/tree/gh-89812-add-lexicalpath |
|
Conversation
32
| https://github.com/python/cpython/pull/104810 |
|
Commits
20
| https://github.com/python/cpython/pull/104810/commits |
|
Checks
0
| https://github.com/python/cpython/pull/104810/checks |
|
Files changed
| https://github.com/python/cpython/pull/104810/files |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| May 23, 2023 | https://github.com/python/cpython/pull/104810#issue-1722664097 |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| https://discuss.python.org/t/make-pathlib-extensible/3428/94 | https://discuss.python.org/t/make-pathlib-extensible/3428/94 |
| Add tarfile.TarPath #89812 | https://github.com/python/cpython/issues/89812 |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
|
| https://github.com/barneygale |
| pythonGH-89812 | https://github.com/python/cpython/issues/89812 |
| : Add | https://github.com/python/cpython/pull/104810/commits/81e301b876a07222283eb87de2128c0bfa5a3f80 |
| pathlib._LexicalPath | https://github.com/python/cpython/pull/104810/commits/81e301b876a07222283eb87de2128c0bfa5a3f80 |
| 81e301b | https://github.com/python/cpython/pull/104810/commits/81e301b876a07222283eb87de2128c0bfa5a3f80 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
topic-pathlib
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-pathlib |
| May 23, 2023 | https://github.com/python/cpython/pull/104810#event-9320026779 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| May 23, 2023 | https://github.com/python/cpython/pull/104810#event-9320027113 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
May 23, 2023
| https://github.com/python/cpython/pull/104810#ref-issue-1199068233 |
|
Add tarfile.TarPath
#89812
| https://github.com/python/cpython/issues/89812 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| CAM-Gerlach | https://github.com/CAM-Gerlach |
| May 23, 2023 19:44 | https://github.com/python/cpython/pull/104810#event-9320112582 |
|
| https://github.com/barneygale |
| Rename _LexicalPath --> _BasePurePath | https://github.com/python/cpython/pull/104810/commits/ace5824a9205f2e81b6aa7780c1fadb4ba7b8fc6 |
| ace5824 | https://github.com/python/cpython/pull/104810/commits/ace5824a9205f2e81b6aa7780c1fadb4ba7b8fc6 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| May 23, 2023 | https://github.com/python/cpython/pull/104810#event-9321348116 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| May 24, 2023 | https://github.com/python/cpython/pull/104810#issuecomment-1561180876 |
| #104829 | https://github.com/python/cpython/pull/104829 |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| https://github.com/merwok |
| merwok | https://github.com/merwok |
|
May 24, 2023
| https://github.com/python/cpython/pull/104810#pullrequestreview-1441923299 |
|
View reviewed changes
| https://github.com/python/cpython/pull/104810/files/ace5824a9205f2e81b6aa7780c1fadb4ba7b8fc6 |
| Lib/pathlib.py | https://github.com/python/cpython/pull/104810/files/ace5824a9205f2e81b6aa7780c1fadb4ba7b8fc6#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| https://github.com/merwok |
| merwok | https://github.com/merwok |
|
May 24, 2023
| https://github.com/python/cpython/pull/104810#pullrequestreview-1441926175 |
|
View reviewed changes
| https://github.com/python/cpython/pull/104810/files/ace5824a9205f2e81b6aa7780c1fadb4ba7b8fc6 |
| Lib/pathlib.py | https://github.com/python/cpython/pull/104810/files/ace5824a9205f2e81b6aa7780c1fadb4ba7b8fc6#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| https://github.com/merwok |
| merwok | https://github.com/merwok |
|
May 24, 2023
| https://github.com/python/cpython/pull/104810#pullrequestreview-1441930338 |
|
View reviewed changes
| https://github.com/python/cpython/pull/104810/files/ace5824a9205f2e81b6aa7780c1fadb4ba7b8fc6 |
| Lib/pathlib.py | https://github.com/python/cpython/pull/104810/files/ace5824a9205f2e81b6aa7780c1fadb4ba7b8fc6#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
|
| https://github.com/barneygale |
| Document __bytes__ in PurePath docstring | https://github.com/python/cpython/pull/104810/commits/d1b23c88334136b70e2c12476ff6839fdbc20ee1 |
| d1b23c8 | https://github.com/python/cpython/pull/104810/commits/d1b23c88334136b70e2c12476ff6839fdbc20ee1 |
| https://github.com/merwok |
| merwok | https://github.com/merwok |
|
May 24, 2023
| https://github.com/python/cpython/pull/104810#pullrequestreview-1442092804 |
|
View reviewed changes
| https://github.com/python/cpython/pull/104810/files/d1b23c88334136b70e2c12476ff6839fdbc20ee1 |
| Lib/pathlib.py | https://github.com/python/cpython/pull/104810/files/d1b23c88334136b70e2c12476ff6839fdbc20ee1#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| Lib/pathlib.py | https://github.com/python/cpython/pull/104810/files/d1b23c88334136b70e2c12476ff6839fdbc20ee1#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| Lib/pathlib.py | https://github.com/python/cpython/pull/104810/files/d1b23c88334136b70e2c12476ff6839fdbc20ee1#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| Lib/pathlib.py | https://github.com/python/cpython/pull/104810/files/ace5824a9205f2e81b6aa7780c1fadb4ba7b8fc6#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| barneygale | https://github.com/barneygale |
| May 24, 2023 16:04 | https://github.com/python/cpython/pull/104810#commits-pushed-115002a |
|
| https://github.com/barneygale |
|
| https://github.com/merwok |
| Apply suggestions from code review | https://github.com/python/cpython/pull/104810/commits/115002aee671ee1221c5c771ec55191a71bd6818 |
| 115002a | https://github.com/python/cpython/pull/104810/commits/115002aee671ee1221c5c771ec55191a71bd6818 |
|
| https://github.com/barneygale |
| Revert "Document __bytes__ in PurePath docstring" | https://github.com/python/cpython/pull/104810/commits/f257e4826e93ed192854e0c57d267c806229db87 |
| f257e48 | https://github.com/python/cpython/pull/104810/commits/f257e4826e93ed192854e0c57d267c806229db87 |
| d1b23c8 | https://github.com/barneygale/cpython/commit/d1b23c88334136b70e2c12476ff6839fdbc20ee1 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
May 24, 2023
| https://github.com/python/cpython/pull/104810#pullrequestreview-1442313736 |
|
View reviewed changes
| https://github.com/python/cpython/pull/104810/files/f257e4826e93ed192854e0c57d267c806229db87 |
| Lib/pathlib.py | https://github.com/python/cpython/pull/104810/files/f257e4826e93ed192854e0c57d267c806229db87#diff-fa525485738fc33d05b06c159172ff1f319c26e88d8c6bb39f7dbaae4dc4105c |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| barneygale | https://github.com/barneygale |
| May 24, 2023 17:36 | https://github.com/python/cpython/pull/104810#commits-pushed-68d2891 |
|
| https://github.com/barneygale |
|
| https://github.com/AlexWaygood |
| Update Lib/pathlib.py | https://github.com/python/cpython/pull/104810/commits/68d28912f47a3c280f3da4a01a1aadfcc318043f |
| 68d2891 | https://github.com/python/cpython/pull/104810/commits/68d28912f47a3c280f3da4a01a1aadfcc318043f |
|
| https://github.com/barneygale |
| Subclass from os.PathLike | https://github.com/python/cpython/pull/104810/commits/458c33d2d7ccbb2e90a6eacfd5fb3a2a776d43dc |
| 458c33d | https://github.com/python/cpython/pull/104810/commits/458c33d2d7ccbb2e90a6eacfd5fb3a2a776d43dc |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
May 24, 2023
| https://github.com/python/cpython/pull/104810#pullrequestreview-1442779327 |
|
View reviewed changes
| https://github.com/python/cpython/pull/104810/files/458c33d2d7ccbb2e90a6eacfd5fb3a2a776d43dc |
| Lib/os.py | https://github.com/python/cpython/pull/104810/files/458c33d2d7ccbb2e90a6eacfd5fb3a2a776d43dc#diff-d2e8ad2f4746ac5fb230fa5a7345fd4332c56818489a2246472d38893aa82431 |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
|
| https://github.com/barneygale |
| Add news blurb | https://github.com/python/cpython/pull/104810/commits/6d9a1a2464e7312f09651b9c045eeb1f82933b8e |
| 6d9a1a2 | https://github.com/python/cpython/pull/104810/commits/6d9a1a2464e7312f09651b9c045eeb1f82933b8e |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| May 24, 2023 | https://github.com/python/cpython/pull/104810#event-9332979017 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
|
May 24, 2023
| https://github.com/python/cpython/pull/104810#ref-issue-1724781135 |
|
os.PathLike is missing __slots__
#104898
| https://github.com/python/cpython/issues/104898 |
| barneygale | https://github.com/barneygale |
| May 24, 2023 22:53 | https://github.com/python/cpython/pull/104810#commits-pushed-bd23782 |
|
| https://github.com/barneygale |
| Revert "Subclass from os.PathLike" | https://github.com/python/cpython/pull/104810/commits/bd237827073c974c1a1e26920a692dfc7a9c2cd6 |
| bd23782 | https://github.com/python/cpython/pull/104810/commits/bd237827073c974c1a1e26920a692dfc7a9c2cd6 |
| 458c33d | https://github.com/barneygale/cpython/commit/458c33d2d7ccbb2e90a6eacfd5fb3a2a776d43dc |
|
| https://github.com/barneygale |
| Revert "Add news blurb" | https://github.com/python/cpython/pull/104810/commits/a69417f2f05bc1d598419eb0f124dde8faf52ee7 |
| a69417f | https://github.com/python/cpython/pull/104810/commits/a69417f2f05bc1d598419eb0f124dde8faf52ee7 |
| 6d9a1a2 | https://github.com/barneygale/cpython/commit/6d9a1a2464e7312f09651b9c045eeb1f82933b8e |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| May 24, 2023 | https://github.com/python/cpython/pull/104810#event-9333077178 |
|
| https://github.com/barneygale |
| Merge branch 'main' into | https://github.com/python/cpython/pull/104810/commits/45f6bd3a2ef0a6000564e5e5bdd476f965e9c260 |
| pythongh-89812 | https://github.com/python/cpython/issues/89812 |
| -add-lexicalpath | https://github.com/python/cpython/pull/104810/commits/45f6bd3a2ef0a6000564e5e5bdd476f965e9c260 |
| 45f6bd3 | https://github.com/python/cpython/pull/104810/commits/45f6bd3a2ef0a6000564e5e5bdd476f965e9c260 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
|
May 25, 2023
| https://github.com/python/cpython/pull/104810#ref-pullrequest-1723036117 |
|
GH-89812: Clean up pathlib tests.
#104829
| https://github.com/python/cpython/pull/104829 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
|
May 29, 2023
| https://github.com/python/cpython/pull/104810#pullrequestreview-1449735988 |
|
View reviewed changes
| https://github.com/python/cpython/pull/104810/files/45f6bd3a2ef0a6000564e5e5bdd476f965e9c260 |
| Lib/test/test_pathlib.py | https://github.com/python/cpython/pull/104810/files/45f6bd3a2ef0a6000564e5e5bdd476f965e9c260#diff-3dd97d2dc8816848d0b0c442e8fdeec9650b3de77935289a93f37ac6396ee17f |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
|
| https://github.com/barneygale |
| Merge branch 'main' into | https://github.com/python/cpython/pull/104810/commits/1e24f80773012e24ff67040e56a25ae34a1171ce |
| pythongh-89812 | https://github.com/python/cpython/issues/89812 |
| -add-lexicalpath | https://github.com/python/cpython/pull/104810/commits/1e24f80773012e24ff67040e56a25ae34a1171ce |
| 1e24f80 | https://github.com/python/cpython/pull/104810/commits/1e24f80773012e24ff67040e56a25ae34a1171ce |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| Jun 7, 2023 | https://github.com/python/cpython/pull/104810#issuecomment-1581461052 |
| #104829 | https://github.com/python/cpython/pull/104829 |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| June 7, 2023 20:26 | https://github.com/python/cpython/pull/104810#event-9463935979 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Jun 7, 2023 | https://github.com/python/cpython/pull/104810#event-9463936391 |
| barneygale | https://github.com/barneygale |
| June 12, 2023 15:53 | https://github.com/python/cpython/pull/104810#commits-pushed-70d81d6 |
|
| https://github.com/barneygale |
| Merge branch 'main' into | https://github.com/python/cpython/pull/104810/commits/70d81d6d6808770e34a4a52664a55408f590ca33 |
| pythongh-89812 | https://github.com/python/cpython/issues/89812 |
| -add-lexicalpath | https://github.com/python/cpython/pull/104810/commits/70d81d6d6808770e34a4a52664a55408f590ca33 |
| 70d81d6 | https://github.com/python/cpython/pull/104810/commits/70d81d6d6808770e34a4a52664a55408f590ca33 |
|
| https://github.com/barneygale |
| Merge branch 'main' into | https://github.com/python/cpython/pull/104810/commits/7e7b5d4670b50ceebacc36c7c4f85f5aaed80859 |
| pythongh-89812 | https://github.com/python/cpython/issues/89812 |
| -add-lexicalpath | https://github.com/python/cpython/pull/104810/commits/7e7b5d4670b50ceebacc36c7c4f85f5aaed80859 |
| 7e7b5d4 | https://github.com/python/cpython/pull/104810/commits/7e7b5d4670b50ceebacc36c7c4f85f5aaed80859 |
|
| https://github.com/barneygale |
| Fix missed isinstance() call. | https://github.com/python/cpython/pull/104810/commits/98e30d4d4d6dc2329e4b0bd1a69b461cb653ea20 |
| 98e30d4 | https://github.com/python/cpython/pull/104810/commits/98e30d4d4d6dc2329e4b0bd1a69b461cb653ea20 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| June 14, 2023 16:12 | https://github.com/python/cpython/pull/104810#event-9530825306 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Jun 14, 2023 | https://github.com/python/cpython/pull/104810#event-9530825917 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| Jun 14, 2023 | https://github.com/python/cpython/pull/104810#issuecomment-1591749057 |
| #104829 | https://github.com/python/cpython/pull/104829 |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| AlexWaygood | https://github.com/AlexWaygood |
| merwok | https://github.com/merwok |
| June 14, 2023 18:02 | https://github.com/python/cpython/pull/104810#event-9531807283 |
| barneygale | https://github.com/barneygale |
| June 15, 2023 02:45 | https://github.com/python/cpython/pull/104810#commits-pushed-8d12e06 |
|
| https://github.com/barneygale |
| Merge branch 'main' into | https://github.com/python/cpython/pull/104810/commits/8d12e064a4d332209642e8be6e5030d7e03948c3 |
| pythongh-89812 | https://github.com/python/cpython/issues/89812 |
| -add-lexicalpath | https://github.com/python/cpython/pull/104810/commits/8d12e064a4d332209642e8be6e5030d7e03948c3 |
| 8d12e06 | https://github.com/python/cpython/pull/104810/commits/8d12e064a4d332209642e8be6e5030d7e03948c3 |
|
| https://github.com/barneygale |
| Drop methods from PurePath itself, as it cannot be instantiated. | https://github.com/python/cpython/pull/104810/commits/e36eb74fc19325f9f500355c21256e5b246c7d70 |
| e36eb74 | https://github.com/python/cpython/pull/104810/commits/e36eb74fc19325f9f500355c21256e5b246c7d70 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| Jun 22, 2023 | https://github.com/python/cpython/pull/104810#event-9611940523 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| Jun 22, 2023 | https://github.com/python/cpython/pull/104810#issuecomment-1603437367 |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| https://private-user-images.githubusercontent.com/960340/248084817-57d72548-a427-460a-8dda-bc057de1b837.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg1MzI2NzEsIm5iZiI6MTc2ODUzMjM3MSwicGF0aCI6Ii85NjAzNDAvMjQ4MDg0ODE3LTU3ZDcyNTQ4LWE0MjctNDYwYS04ZGRhLWJjMDU3ZGUxYjgzNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMTE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDExNlQwMjU5MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zOWEzZWZmYzM5ODVmYTE0YzQyYzEwYzExZDQwYzMzYjZhYjViOTlhYTA0YWU5ZWVkNWVkYWI3YmRhODliYTg0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.IJ_pYUggbGoPHHO6uvq4F-8-p1jP6RTRAt9PwhYW_lE |
| earlier proposed hierarchy | https://discuss.python.org/t/make-pathlib-extensible/3428/109?u=barneygale |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| Jun 22, 2023 | https://github.com/python/cpython/pull/104810#issuecomment-1603449535 |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| https://private-user-images.githubusercontent.com/960340/248101816-aac89f9a-f981-409c-94dc-364224c89466.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg1MzI2NzEsIm5iZiI6MTc2ODUzMjM3MSwicGF0aCI6Ii85NjAzNDAvMjQ4MTAxODE2LWFhYzg5ZjlhLWY5ODEtNDA5Yy05NGRjLTM2NDIyNGM4OTQ2Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwMTE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDExNlQwMjU5MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wNDIwMmY5N2FiODNiMDZhYWE2ZTQ5YWM5YjM4YzBlMmE3ZjkyYjEyYWU5MmRlNGMxOTYyYjkzOWZiNzQ1OTVmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.WhbNf3Vcwy8igoVzNXuc8eYugOzFZwbUqKxwJ-I6UWM |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| https://github.com/merwok |
| merwok | https://github.com/merwok |
| Jun 23, 2023 | https://github.com/python/cpython/pull/104810#issuecomment-1603490926 |
| https://hynek.me/articles/python-subclassing-redux/ | https://hynek.me/articles/python-subclassing-redux/ |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| Jun 23, 2023 | https://github.com/python/cpython/pull/104810#issuecomment-1603493524 |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| June 23, 2023 11:57 | https://github.com/python/cpython/pull/104810#event-9617086339 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Jun 23, 2023 | https://github.com/python/cpython/pull/104810#event-9617086873 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| Jun 23, 2023 | https://github.com/python/cpython/pull/104810#issuecomment-1604181323 |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| barneygale | https://github.com/barneygale |
| June 23, 2023 17:26 | https://github.com/python/cpython/pull/104810#commits-pushed-0ea24cc |
|
| https://github.com/barneygale |
| Move as_uri() back | https://github.com/python/cpython/pull/104810/commits/0ea24cc2e7355627ba97d64aa69bdb6bba56b669 |
| 0ea24cc | https://github.com/python/cpython/pull/104810/commits/0ea24cc2e7355627ba97d64aa69bdb6bba56b669 |
|
| https://github.com/barneygale |
| Adjust docs | https://github.com/python/cpython/pull/104810/commits/342e64b1b53eeb4810c8b01236419723cfa32d05 |
| 342e64b | https://github.com/python/cpython/pull/104810/commits/342e64b1b53eeb4810c8b01236419723cfa32d05 |
|
| https://github.com/barneygale |
| Add tests | https://github.com/python/cpython/pull/104810/commits/90bc6b36f3fabd774bd0e6272bbb46f692094a33 |
| 90bc6b3 | https://github.com/python/cpython/pull/104810/commits/90bc6b36f3fabd774bd0e6272bbb46f692094a33 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| Jun 23, 2023 | https://github.com/python/cpython/pull/104810#issuecomment-1604634963 |
| #104810 | https://github.com/python/cpython/pull/104810 |
| #106043 | https://github.com/python/cpython/pull/106043 |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| https://github.com/barneygale |
| barneygale | https://github.com/barneygale |
| Jun 23, 2023 | https://github.com/python/cpython/pull/104810#event-9620402884 |
| https://github.com/CAM-Gerlach |
| CAM-Gerlach | https://github.com/CAM-Gerlach |
| Jun 23, 2023 | https://github.com/python/cpython/pull/104810#issuecomment-1605017037 |
| @barneygale | https://github.com/barneygale |
| https://private-user-images.githubusercontent.com/17051931/248410837-ebf7f219-ba4c-43bb-9760-42f222dc022c.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg1MzI2NzEsIm5iZiI6MTc2ODUzMjM3MSwicGF0aCI6Ii8xNzA1MTkzMS8yNDg0MTA4MzctZWJmN2YyMTktYmE0Yy00M2JiLTk3NjAtNDJmMjIyZGMwMjJjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAxMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMTE2VDAyNTkzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFiMWUwOWYyZTdkNzI0MmJlYjA3YjJhYTIwNWFkN2VhNjY0YjY0YTM4YTIxYjJjMTNhZmZiM2E2NmRjMjIwYTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Zmr-En7r-RtWu6cDQDgWSkH4Dcy6NMqJhwtu_9oYUlU |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104810 |
|
| https://github.com/brettcannon |
|
brettcannon
| https://github.com/brettcannon |
|
| https://github.com/python/cpython/pull/104810/files/ace5824a9205f2e81b6aa7780c1fadb4ba7b8fc6 |
|
| https://github.com/CAM-Gerlach |
|
CAM-Gerlach
| https://github.com/CAM-Gerlach |
|
| https://github.com/AlexWaygood |
|
AlexWaygood
| https://github.com/AlexWaygood |
|
| https://github.com/merwok |
|
merwok
| https://github.com/merwok |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
topic-pathlib
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-pathlib |
| Please reload this page | https://github.com/python/cpython/pull/104810 |
|
| https://github.com/barneygale |
|
| https://github.com/merwok |
|
| https://github.com/CAM-Gerlach |
|
| https://github.com/brettcannon |
|
| https://github.com/AlexWaygood |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |