René's URL Explorer Experiment


Title: [3.11] gh-104372: Cleanup _posixsubprocess make_inheritable for async signal safety gh-104518 by gpshead · Pull Request #104785 · python/cpython · GitHub

Open Graph Title: [3.11] gh-104372: Cleanup _posixsubprocess make_inheritable for async signal safety gh-104518 by gpshead · Pull Request #104785 · python/cpython

X Title: [3.11] gh-104372: Cleanup _posixsubprocess make_inheritable for async signal safety gh-104518 by gpshead · Pull Request #104785 · python/cpython

Description: Move all of the Python C API calls into the parent process up front instead of doing PyLong_AsLong and PyErr_Occurred and PyTuple_GET from the post-fork/vfork child process. Much of this was long o...

Open Graph Description: Move all of the Python C API calls into the parent process up front instead of doing PyLong_AsLong and PyErr_Occurred and PyTuple_GET from the post-fork/vfork child process. Much of this was long o...

X Description: Move all of the Python C API calls into the parent process up front instead of doing PyLong_AsLong and PyErr_Occurred and PyTuple_GET from the post-fork/vfork child process. Much of this was long o...

Opengraph URL: https://github.com/python/cpython/pull/104785

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:977c34eb-823b-f6b4-f632-a43cb9053047
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1B2:194D77:9E1D9:E0513:696A0223
html-safe-noncec964b797d62d54d97f218ef92514fd66d05e36baa3f1e5a36fdd6f8755463902
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUIyOjE5NEQ3Nzo5RTFEOTpFMDUxMzo2OTZBMDIyMyIsInZpc2l0b3JfaWQiOiI3MTgwNDgyMDM2OTY1NzA0MjI3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac00a2dda773d7fc7b79405a62fe410672a4346791af8eae29546c01970c2bc3fc
hovercard-subject-tagpull_request:1360461418
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104785/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e3f9187fd926be0fc7e36cb18a35c5d54329f5544c7f989965cb5f171f6cbda9/python/cpython/pull/104785
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e3f9187fd926be0fc7e36cb18a35c5d54329f5544c7f989965cb5f171f6cbda9/python/cpython/pull/104785
og:image:altMove all of the Python C API calls into the parent process up front instead of doing PyLong_AsLong and PyErr_Occurred and PyTuple_GET from the post-fork/vfork child process. Much of this was long o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegpshead
hostnamegithub.com
expected-hostnamegithub.com
None578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release671c2f67171dbced24284331f3133a613d08c366
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104785#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104785
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104785
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104785
Reloadhttps://github.com/python/cpython/pull/104785
Reloadhttps://github.com/python/cpython/pull/104785
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104785
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104785
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/104785#issue-comment-box
gpsheadhttps://github.com/gpshead
python:3.11https://github.com/python/cpython/tree/3.11
gpshead:backport-c649df6-3.11https://github.com/gpshead/cpython/tree/backport-c649df6-3.11
[3.11] gh-104372: Cleanup _posixsubprocess make_inheritable for async signal safety gh-104518 https://github.com/python/cpython/pull/104785#top
gpsheadhttps://github.com/gpshead
python:3.11https://github.com/python/cpython/tree/3.11
gpshead:backport-c649df6-3.11https://github.com/gpshead/cpython/tree/backport-c649df6-3.11
Conversation 1 https://github.com/python/cpython/pull/104785
Commits 7 https://github.com/python/cpython/pull/104785/commits
Checks 0 https://github.com/python/cpython/pull/104785/checks
Files changed https://github.com/python/cpython/pull/104785/files
Please reload this pagehttps://github.com/python/cpython/pull/104785
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
May 23, 2023https://github.com/python/cpython/pull/104785#issue-1721012621
Please reload this pagehttps://github.com/python/cpython/pull/104785
c649df6https://github.com/python/cpython/commit/c649df63e0d052044a4660101d5769ff46ae9234
#104518https://github.com/python/cpython/pull/104518
d1732fehttps://github.com/python/cpython/commit/d1732feea0eadd4ccc3516440d0c071be0093dec
#104697https://github.com/python/cpython/pull/104697
subprocess can block all Python threads when using vfork() until the child process exec() succeeds or fails. #104372https://github.com/python/cpython/issues/104372
Please reload this pagehttps://github.com/python/cpython/pull/104785
gpsheadhttps://github.com/gpshead
May 22, 2023 19:01https://github.com/python/cpython/pull/104785#commits-pushed-de47455
https://github.com/gpshead
pythongh-104372https://github.com/python/cpython/issues/104372
: Cleanup _posixsubprocesshttps://github.com/python/cpython/pull/104785/commits/de4745541105bd4866feb9169595997b4fe832ae
make_inheritablehttps://github.com/python/cpython/pull/104785/commits/de4745541105bd4866feb9169595997b4fe832ae
for asyn…https://github.com/python/cpython/pull/104785/commits/de4745541105bd4866feb9169595997b4fe832ae
de47455https://github.com/python/cpython/pull/104785/commits/de4745541105bd4866feb9169595997b4fe832ae
python#104518https://github.com/python/cpython/pull/104518
c649df6https://github.com/gpshead/cpython/commit/c649df63e0d052044a4660101d5769ff46ae9234
https://github.com/gpshead
[3.11]https://github.com/python/cpython/pull/104785/commits/0991dae3be99ead6bcbed002558139c13fcbee66
pythongh-104372https://github.com/python/cpython/issues/104372
: Cleanup _posixsubprocesshttps://github.com/python/cpython/pull/104785/commits/0991dae3be99ead6bcbed002558139c13fcbee66
make_inheritablehttps://github.com/python/cpython/pull/104785/commits/0991dae3be99ead6bcbed002558139c13fcbee66
f…https://github.com/python/cpython/pull/104785/commits/0991dae3be99ead6bcbed002558139c13fcbee66
0991daehttps://github.com/python/cpython/pull/104785/commits/0991dae3be99ead6bcbed002558139c13fcbee66
pythonGH-104518https://github.com/python/cpython/pull/104518
c649df6https://github.com/gpshead/cpython/commit/c649df63e0d052044a4660101d5769ff46ae9234
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
May 23, 2023https://github.com/python/cpython/pull/104785#event-9309894379
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 23, 2023 https://github.com/python/cpython/pull/104785#ref-issue-1704756491
subprocess can block all Python threads when using vfork() until the child process exec() succeeds or fails. #104372 https://github.com/python/cpython/issues/104372
gpsheadhttps://github.com/gpshead
May 22, 2023 19:08https://github.com/python/cpython/pull/104785#commits-pushed-c684290
https://github.com/gpshead
Don't use Raw malloc & free.https://github.com/python/cpython/pull/104785/commits/c6842903927385dc317544d0521b89d81724279b
c684290https://github.com/python/cpython/pull/104785/commits/c6842903927385dc317544d0521b89d81724279b
d1732fehttps://github.com/gpshead/cpython/commit/d1732feea0eadd4ccc3516440d0c071be0093dec
python#104697https://github.com/python/cpython/pull/104697
https://github.com/gpshead
Fix the backport for pre-argument-clinic life.https://github.com/python/cpython/pull/104785/commits/0ecbcba92a0e4efa7b075bf01b0bf898fc42aee0
0ecbcbahttps://github.com/python/cpython/pull/104785/commits/0ecbcba92a0e4efa7b075bf01b0bf898fc42aee0
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
May 23, 2023 02:22https://github.com/python/cpython/pull/104785#event-9310028937
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 23, 2023https://github.com/python/cpython/pull/104785#event-9310029207
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
May 23, 2023 05:59https://github.com/python/cpython/pull/104785#event-9311289391
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 23, 2023https://github.com/python/cpython/pull/104785#event-9311289752
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
May 23, 2023https://github.com/python/cpython/pull/104785#issuecomment-1558689882
Please reload this pagehttps://github.com/python/cpython/pull/104785
Please reload this pagehttps://github.com/python/cpython/pull/104785
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
May 23, 2023 https://github.com/python/cpython/pull/104785#ref-pullrequest-1721442056
[3.11] gh-103726: Set up gcc-10 for ASAN (gh-103728) #104794 https://github.com/python/cpython/pull/104794
gpsheadhttps://github.com/gpshead
May 23, 2023 01:11https://github.com/python/cpython/pull/104785#commits-pushed-b0a7c51
https://github.com/gpshead
Merge branch '3.11' into backport-c649df6-3.11https://github.com/python/cpython/pull/104785/commits/b0a7c51f12e0473a71bae55a77cb31af4f044e94
b0a7c51https://github.com/python/cpython/pull/104785/commits/b0a7c51f12e0473a71bae55a77cb31af4f044e94
https://github.com/gpshead
cleanup to keep the backport more diff concise.https://github.com/python/cpython/pull/104785/commits/c058694ed9ca17201f52c682cbc88b08bf6fe36f
c058694https://github.com/python/cpython/pull/104785/commits/c058694ed9ca17201f52c682cbc88b08bf6fe36f
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
May 23, 2023 19:02https://github.com/python/cpython/pull/104785#event-9319779758
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 23, 2023https://github.com/python/cpython/pull/104785#event-9319780295
https://github.com/gpshead
only check PyErr_Occurred if it returned -1https://github.com/python/cpython/pull/104785/commits/c364eaaff40810cf6440c876bcc495002dfcbefb
c364eaahttps://github.com/python/cpython/pull/104785/commits/c364eaaff40810cf6440c876bcc495002dfcbefb
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
6d00ae3https://github.com/python/cpython/commit/6d00ae3c28b254feeb3c1a81e38db92109180c47
May 24, 2023https://github.com/python/cpython/pull/104785#event-9322664199
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 24, 2023https://github.com/python/cpython/pull/104785#event-9322664367
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
May 24, 2023 03:42https://github.com/python/cpython/pull/104785#event-9322664536
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104785
https://github.com/gpshead
gpshead https://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/104785
https://github.com/gpshead
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.