René's URL Explorer Experiment


Title: gh-104341: Add a Separate "Running" Lock for Each Thread by ericsnowcurrently · Pull Request #104754 · python/cpython · GitHub

Open Graph Title: gh-104341: Add a Separate "Running" Lock for Each Thread by ericsnowcurrently · Pull Request #104754 · python/cpython

X Title: gh-104341: Add a Separate "Running" Lock for Each Thread by ericsnowcurrently · Pull Request #104754 · python/cpython

Description: Having a separate lock means Thread.join() doesn't need to wait for the thread to be cleaned up first. It can wait for the thread's Python target to finish running. This gives us some flexibility in how we clean up threads. (This is a minor cleanup as part of a fix for gh-104341.)

Open Graph Description: Having a separate lock means Thread.join() doesn't need to wait for the thread to be cleaned up first. It can wait for the thread's Python target to finish running. This gives us some fle...

X Description: Having a separate lock means Thread.join() doesn't need to wait for the thread to be cleaned up first. It can wait for the thread's Python target to finish running. This gives us ...

Opengraph URL: https://github.com/python/cpython/pull/104754

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a82f57e3-7117-2a73-c756-53ead1997a0e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC42C:28AE23:27FC70A:36272F5:696ADD7C
html-safe-nonce53304f44b92a46b59f9e99286e37e92046c30135a3aa09f159891c6e82fd87eb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDJDOjI4QUUyMzoyN0ZDNzBBOjM2MjcyRjU6Njk2QUREN0MiLCJ2aXNpdG9yX2lkIjoiODgzNTQ5ODkxMDgzMDc0NzAwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbd6f5a5e6fbcc906758c634aa490a038dee252c382f874208b7dff114f759d76
hovercard-subject-tagpull_request:1359745135
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/104754/files
twitter:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
og:image:altHaving a separate lock means Thread.join() doesn't need to wait for the thread to be cleaned up first. It can wait for the thread's Python target to finish running. This gives us some fle...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release524a93f2c1f36522a3b4be4c110467ee4172245d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104754/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104754%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104754%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104754/files
Reloadhttps://github.com/python/cpython/pull/104754/files
Reloadhttps://github.com/python/cpython/pull/104754/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104754/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104754/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:threading-running-lockhttps://github.com/ericsnowcurrently/cpython/tree/threading-running-lock
Conversation 7 https://github.com/python/cpython/pull/104754
Commits 4 https://github.com/python/cpython/pull/104754/commits
Checks 0 https://github.com/python/cpython/pull/104754/checks
Files changed https://github.com/python/cpython/pull/104754/files
Please reload this pagehttps://github.com/python/cpython/pull/104754/files
gh-104341: Add a Separate "Running" Lock for Each Thread https://github.com/python/cpython/pull/104754/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/104754/files
2d4f12b Add a separate "running" lock for each thread. ericsnowcurrently May 22, 2023 https://github.com/python/cpython/pull/104754/commits/2d4f12b1a57f105b053bb27e037b1041d579a34e
79942af test_tstate_lock -> test_running_lock. ericsnowcurrently May 22, 2023 https://github.com/python/cpython/pull/104754/commits/79942afa6791b0011c65cb62ae61dd798fba983d
a1c2ca1 Merge branch 'main' into threading-running-lock ericsnowcurrently May 22, 2023 https://github.com/python/cpython/pull/104754/commits/a1c2ca13435557ce20b3ba9d9872d58a3efe1c16
55c0a06 Merge branch 'main' into threading-running-lock ericsnowcurrently May 23, 2023 https://github.com/python/cpython/pull/104754/commits/55c0a0629510b5b9c313191e0a1f8a90959bc59f
Clear filters https://github.com/python/cpython/pull/104754/files
Please reload this pagehttps://github.com/python/cpython/pull/104754/files
Please reload this pagehttps://github.com/python/cpython/pull/104754/files
test_threading.py https://github.com/python/cpython/pull/104754/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
threading.py https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
Lib/test/test_threading.pyhttps://github.com/python/cpython/pull/104754/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
View file https://github.com/ericsnowcurrently/cpython/blob/55c0a0629510b5b9c313191e0a1f8a90959bc59f/Lib/test/test_threading.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104754/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104754/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
https://github.com/python/cpython/pull/104754/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
https://github.com/python/cpython/pull/104754/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
Lib/threading.pyhttps://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
View file https://github.com/ericsnowcurrently/cpython/blob/55c0a0629510b5b9c313191e0a1f8a90959bc59f/Lib/threading.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104754/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104754/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.