| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e7a36bd3-59a2-ef86-9867-47d03f934a81 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 82F8:134C26:C1FA8B:106B936:696ABFBA |
| html-safe-nonce | a8a84e472bfe2d702fc78e258fd6142ed1a95d87be805d2a55156ae3aa746a00 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkY4OjEzNEMyNjpDMUZBOEI6MTA2QjkzNjo2OTZBQkZCQSIsInZpc2l0b3JfaWQiOiIzNzI3MzIyOTAyMTQzMDkwNjE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 30aa1f0ed46a56358f57ba63057f8d5e31b6f3d2f77f85f815638b4dc7e21d9d |
| hovercard-subject-tag | pull_request:1359745135 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104754/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/43ff17117a86b2400b9a8e15ff2cc5662619aa4324d962071c2bc84d2725116e/python/cpython/pull/104754 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/43ff17117a86b2400b9a8e15ff2cc5662619aa4324d962071c2bc84d2725116e/python/cpython/pull/104754 |
| og:image:alt | Having a separate lock means Thread.join() doesn't need to wait for the thread to be cleaned up first. It can wait for the thread's Python target to finish running. This gives us some fle... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ericsnowcurrently |
| hostname | github.com |
| expected-hostname | github.com |
| None | 46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 30300f30bb3949de255e84a146706a3bdb5c19c9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/104754#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104754 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104754 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/104754 |
| Reload | https://github.com/python/cpython/pull/104754 |
| Reload | https://github.com/python/cpython/pull/104754 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/104754 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/104754 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/104754#issue-comment-box |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
| python:main | https://github.com/python/cpython/tree/main |
| ericsnowcurrently:threading-running-lock | https://github.com/ericsnowcurrently/cpython/tree/threading-running-lock |
|
gh-104341: Add a Separate "Running" Lock for Each Thread
| https://github.com/python/cpython/pull/104754#top |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
| python:main | https://github.com/python/cpython/tree/main |
| ericsnowcurrently:threading-running-lock | https://github.com/ericsnowcurrently/cpython/tree/threading-running-lock |
|
Conversation
7
| https://github.com/python/cpython/pull/104754 |
|
Commits
4
| https://github.com/python/cpython/pull/104754/commits |
|
Checks
0
| https://github.com/python/cpython/pull/104754/checks |
|
Files changed
| https://github.com/python/cpython/pull/104754/files |
| Please reload this page | https://github.com/python/cpython/pull/104754 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/ericsnowcurrently |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
| May 22, 2023 | https://github.com/python/cpython/pull/104754#issue-1720243704 |
| Please reload this page | https://github.com/python/cpython/pull/104754 |
| gh-104341 | https://github.com/python/cpython/issues/104341 |
| Please reload this page | https://github.com/python/cpython/pull/104754 |
|
| https://github.com/ericsnowcurrently |
| Add a separate "running" lock for each thread. | https://github.com/python/cpython/pull/104754/commits/2d4f12b1a57f105b053bb27e037b1041d579a34e |
| 2d4f12b | https://github.com/python/cpython/pull/104754/commits/2d4f12b1a57f105b053bb27e037b1041d579a34e |
| https://github.com/ericsnowcurrently |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| May 22, 2023 | https://github.com/python/cpython/pull/104754#event-9306107661 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| May 22, 2023 | https://github.com/python/cpython/pull/104754#event-9306108050 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
May 22, 2023
| https://github.com/python/cpython/pull/104754#ref-issue-1702834661 |
|
test__xxsubinterpreters is Occasionally Crashing
#104341
| https://github.com/python/cpython/issues/104341 |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
| May 22, 2023 15:21 | https://github.com/python/cpython/pull/104754#commits-pushed-79942af |
|
| https://github.com/ericsnowcurrently |
| test_tstate_lock -> test_running_lock. | https://github.com/python/cpython/pull/104754/commits/79942afa6791b0011c65cb62ae61dd798fba983d |
| 79942af | https://github.com/python/cpython/pull/104754/commits/79942afa6791b0011c65cb62ae61dd798fba983d |
|
| https://github.com/ericsnowcurrently |
| Merge branch 'main' into threading-running-lock | https://github.com/python/cpython/pull/104754/commits/a1c2ca13435557ce20b3ba9d9872d58a3efe1c16 |
| a1c2ca1 | https://github.com/python/cpython/pull/104754/commits/a1c2ca13435557ce20b3ba9d9872d58a3efe1c16 |
|
| https://github.com/ericsnowcurrently |
| Merge branch 'main' into threading-running-lock | https://github.com/python/cpython/pull/104754/commits/55c0a0629510b5b9c313191e0a1f8a90959bc59f |
| 55c0a06 | https://github.com/python/cpython/pull/104754/commits/55c0a0629510b5b9c313191e0a1f8a90959bc59f |
| https://github.com/ericsnowcurrently |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
|
needs backport to 3.12
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22 |
| May 23, 2023 | https://github.com/python/cpython/pull/104754#event-9320464862 |
| https://github.com/ericsnowcurrently |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
| 097b783 | https://github.com/python/cpython/commit/097b7830cd67f039ff36ba4fa285d82d26e25e84 |
| May 23, 2023 | https://github.com/python/cpython/pull/104754#event-9320467369 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| May 23, 2023 | https://github.com/python/cpython/pull/104754#event-9320467730 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| May 23, 2023 | https://github.com/python/cpython/pull/104754#issuecomment-1560083348 |
| @ericsnowcurrently | https://github.com/ericsnowcurrently |
| Please reload this page | https://github.com/python/cpython/pull/104754 |
| https://github.com/ericsnowcurrently |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
| May 23, 2023 20:29 | https://github.com/python/cpython/pull/104754#event-9320467820 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| May 23, 2023 | https://github.com/python/cpython/pull/104754#issuecomment-1560083758 |
| GH-104817 | https://github.com/python/cpython/pull/104817 |
| 3.12 branch | https://github.com/python/cpython/tree/3.12 |
| Please reload this page | https://github.com/python/cpython/pull/104754 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.12
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22 |
| May 23, 2023 | https://github.com/python/cpython/pull/104754#event-9320471093 |
| https://github.com/terryjreedy |
| terryjreedy | https://github.com/terryjreedy |
| May 24, 2023 | https://github.com/python/cpython/pull/104754#issuecomment-1560359912 |
| Please reload this page | https://github.com/python/cpython/pull/104754 |
| https://github.com/ericsnowcurrently |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
| May 24, 2023 04:40 | https://github.com/python/cpython/pull/104754#event-9322885087 |
| https://github.com/ericsnowcurrently |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
| May 24, 2023 | https://github.com/python/cpython/pull/104754#issuecomment-1560448604 |
| Please reload this page | https://github.com/python/cpython/pull/104754 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| May 24, 2023 | https://github.com/python/cpython/pull/104754#issuecomment-1560583594 |
| Please reload this page | https://github.com/python/cpython/pull/104754 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
|
May 24, 2023
| https://github.com/python/cpython/pull/104754#ref-issue-1723356902 |
|
CI blocked: threading causing random tests to alter the execution environment and fail
#104837
| https://github.com/python/cpython/issues/104837 |
| gpshead | https://github.com/gpshead |
|
May 24, 2023
| https://github.com/python/cpython/pull/104754#ref-commit-5ceae3c |
|
| https://github.com/gpshead |
| pythongh-104837 | https://github.com/python/cpython/issues/104837 |
| : Revert " | https://github.com/gpshead/cpython/commit/5ceae3c2607e521dd8f5ec72f0e19eab5276e804 |
| pythongh-104341 | https://github.com/python/cpython/issues/104341 |
| : Add a Separate "Running" Lo… | https://github.com/gpshead/cpython/commit/5ceae3c2607e521dd8f5ec72f0e19eab5276e804 |
| 5ceae3c | https://github.com/gpshead/cpython/commit/5ceae3c2607e521dd8f5ec72f0e19eab5276e804 |
| pythongh-104754 | https://github.com/python/cpython/pull/104754 |
| 097b783 | https://github.com/gpshead/cpython/commit/097b7830cd67f039ff36ba4fa285d82d26e25e84 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
|
May 24, 2023
| https://github.com/python/cpython/pull/104754#ref-pullrequest-1723361513 |
|
gh-104837: Revert "gh-104341: Add a Separate "Running" Lock for Each Thread (gh-104754)
#104838
| https://github.com/python/cpython/pull/104838 |
| gpshead | https://github.com/gpshead |
|
May 24, 2023
| https://github.com/python/cpython/pull/104754#ref-commit-4b56e56 |
|
| https://github.com/gpshead |
| gh-104837 | https://github.com/python/cpython/issues/104837 |
| : Revert " | https://github.com/python/cpython/commit/4b56e56c495de58425ae3db5f4d8183127ee990b |
| gh-104341 | https://github.com/python/cpython/issues/104341 |
| : Add a Separate "Running" Lock for Each … | https://github.com/python/cpython/commit/4b56e56c495de58425ae3db5f4d8183127ee990b |
| 4b56e56 | https://github.com/python/cpython/commit/4b56e56c495de58425ae3db5f4d8183127ee990b |
| gh-104754 | https://github.com/python/cpython/pull/104754 |
| #104838 | https://github.com/python/cpython/pull/104838 |
| gh-104837 | https://github.com/python/cpython/issues/104837 |
| gh-104341 | https://github.com/python/cpython/issues/104341 |
| gh-104754 | https://github.com/python/cpython/pull/104754 |
| 097b783 | https://github.com/python/cpython/commit/097b7830cd67f039ff36ba4fa285d82d26e25e84 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| May 24, 2023 | https://github.com/python/cpython/pull/104754#issuecomment-1560638888 |
| Please reload this page | https://github.com/python/cpython/pull/104754 |
| https://github.com/ericsnowcurrently |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
| May 24, 2023 | https://github.com/python/cpython/pull/104754#issuecomment-1561380059 |
| Please reload this page | https://github.com/python/cpython/pull/104754 |
| https://github.com/ericsnowcurrently |
| ericsnowcurrently | https://github.com/ericsnowcurrently |
|
Jun 5, 2023
| https://github.com/python/cpython/pull/104754#ref-pullrequest-1742475053 |
|
Threading running lock
#105334
| https://github.com/python/cpython/pull/105334 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104754 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/104754 |
|
| https://github.com/ericsnowcurrently |
|
| https://github.com/miss-islington |
|
| https://github.com/bedevere-bot |
|
| https://github.com/terryjreedy |
|
| https://github.com/gpshead |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |