| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c5ab2be6-f7e8-5f22-f095-002402089815 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9924:36C7A:1F41B6:2A7B34:6969676D |
| html-safe-nonce | dbe62d2c21841665dc61a2bfe951514f19d38a334398a5eb4de97bca527e93b3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTI0OjM2QzdBOjFGNDFCNjoyQTdCMzQ6Njk2OTY3NkQiLCJ2aXNpdG9yX2lkIjoiMTEyODE1OTc5NTg0ODI0MzA1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 073d8caaf4ab402c1c0be87b828de410924b4be4d36b8bf3dd492e1a6ad31930 |
| hovercard-subject-tag | pull_request:1358055609 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104705/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7092484c7a5a5f52731481cc9a3f452b17acabcb07b2baa876af5841afcbb2c0/python/cpython/pull/104705 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7092484c7a5a5f52731481cc9a3f452b17acabcb07b2baa876af5841afcbb2c0/python/cpython/pull/104705 |
| og:image:alt | Issue: Add type annotations to clinic.py #104050 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | erlend-aasland |
| hostname | github.com |
| expected-hostname | github.com |
| None | c6f193beb8ff08443adc07685d75302ab8aaf0a135f6e251c3ff3112c8deb881 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ec4d88fbe7ed62446d90b0a6d8e6db4248a8f8b8 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/104705#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104705 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104705 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/104705 |
| Reload | https://github.com/python/cpython/pull/104705 |
| Reload | https://github.com/python/cpython/pull/104705 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/104705 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/104705 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/104705#issue-comment-box |
| erlend-aasland | https://github.com/erlend-aasland |
| python:main | https://github.com/python/cpython/tree/main |
| erlend-aasland:typed-clinic/clinic | https://github.com/erlend-aasland/cpython/tree/typed-clinic/clinic |
|
gh-104050: Add basic type hints to Argument Clinic clinic class
| https://github.com/python/cpython/pull/104705#top |
| erlend-aasland | https://github.com/erlend-aasland |
| python:main | https://github.com/python/cpython/tree/main |
| erlend-aasland:typed-clinic/clinic | https://github.com/erlend-aasland/cpython/tree/typed-clinic/clinic |
|
Conversation
13
| https://github.com/python/cpython/pull/104705 |
|
Commits
4
| https://github.com/python/cpython/pull/104705/commits |
|
Checks
0
| https://github.com/python/cpython/pull/104705/checks |
|
Files changed
| https://github.com/python/cpython/pull/104705/files |
| Please reload this page | https://github.com/python/cpython/pull/104705 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| May 20, 2023 | https://github.com/python/cpython/pull/104705#issue-1718298109 |
| Please reload this page | https://github.com/python/cpython/pull/104705 |
| Add type annotations to clinic.py #104050 | https://github.com/python/cpython/issues/104050 |
| Please reload this page | https://github.com/python/cpython/pull/104705 |
|
| https://github.com/erlend-aasland |
| pythongh-104050 | https://github.com/python/cpython/issues/104050 |
| : Add basic type hints to Argument Clinic clinic class | https://github.com/python/cpython/pull/104705/commits/5377067ff9f141df4403327b4702bd23b6a3410a |
| 5377067 | https://github.com/python/cpython/pull/104705/commits/5377067ff9f141df4403327b4702bd23b6a3410a |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| May 20, 2023 | https://github.com/python/cpython/pull/104705#event-9295019181 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| AlexWaygood | https://github.com/AlexWaygood |
| May 20, 2023 21:34 | https://github.com/python/cpython/pull/104705#event-9295019192 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| May 20, 2023 | https://github.com/python/cpython/pull/104705#event-9295019200 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
May 20, 2023
| https://github.com/python/cpython/pull/104705#ref-issue-1691115674 |
|
Add type annotations to clinic.py
#104050
| https://github.com/python/cpython/issues/104050 |
|
| https://github.com/erlend-aasland |
| Pull in main | https://github.com/python/cpython/pull/104705/commits/3a0207307c7069dfc2e94215fc791659cc8941d7 |
| 3a02073 | https://github.com/python/cpython/pull/104705/commits/3a0207307c7069dfc2e94215fc791659cc8941d7 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
May 21, 2023
| https://github.com/python/cpython/pull/104705#pullrequestreview-1435568410 |
|
View reviewed changes
| https://github.com/python/cpython/pull/104705/files/3a0207307c7069dfc2e94215fc791659cc8941d7 |
| AlexWaygood | https://github.com/AlexWaygood |
| https://github.com/python/cpython/pull/104705#pullrequestreview-1435568410 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/104705 |
| Tools/clinic/clinic.py | https://github.com/python/cpython/pull/104705/files/3a0207307c7069dfc2e94215fc791659cc8941d7#diff-4c6b55ec7d80a3d60f100ce230eb879d9acbe2e558e01d318960e6197d7c47b3 |
| Please reload this page | https://github.com/python/cpython/pull/104705 |
| Tools/clinic/clinic.py | https://github.com/python/cpython/pull/104705/files/3a0207307c7069dfc2e94215fc791659cc8941d7#diff-4c6b55ec7d80a3d60f100ce230eb879d9acbe2e558e01d318960e6197d7c47b3 |
| Please reload this page | https://github.com/python/cpython/pull/104705 |
| Tools/clinic/clinic.py | https://github.com/python/cpython/pull/104705/files/3a0207307c7069dfc2e94215fc791659cc8941d7#diff-4c6b55ec7d80a3d60f100ce230eb879d9acbe2e558e01d318960e6197d7c47b3 |
| Please reload this page | https://github.com/python/cpython/pull/104705 |
| Tools/clinic/clinic.py | https://github.com/python/cpython/pull/104705/files/3a0207307c7069dfc2e94215fc791659cc8941d7#diff-4c6b55ec7d80a3d60f100ce230eb879d9acbe2e558e01d318960e6197d7c47b3 |
| Please reload this page | https://github.com/python/cpython/pull/104705 |
| Tools/clinic/clinic.py | https://github.com/python/cpython/pull/104705/files/3a0207307c7069dfc2e94215fc791659cc8941d7#diff-4c6b55ec7d80a3d60f100ce230eb879d9acbe2e558e01d318960e6197d7c47b3 |
| Please reload this page | https://github.com/python/cpython/pull/104705 |
| Tools/clinic/clinic.py | https://github.com/python/cpython/pull/104705/files/3a0207307c7069dfc2e94215fc791659cc8941d7#diff-4c6b55ec7d80a3d60f100ce230eb879d9acbe2e558e01d318960e6197d7c47b3 |
| Please reload this page | https://github.com/python/cpython/pull/104705 |
| erlend-aasland | https://github.com/erlend-aasland |
| May 21, 2023 22:12 | https://github.com/python/cpython/pull/104705#commits-pushed-ddf973e |
|
| https://github.com/erlend-aasland |
| Address most of the review remarks | https://github.com/python/cpython/pull/104705/commits/ddf973e6c6ef179f412806dc190b0b2f57edd1eb |
| ddf973e | https://github.com/python/cpython/pull/104705/commits/ddf973e6c6ef179f412806dc190b0b2f57edd1eb |
|
| https://github.com/erlend-aasland |
| Clinic only accepts CLanguage | https://github.com/python/cpython/pull/104705/commits/f84c3d312534f62471fec280770cddb63c2cb4d7 |
| f84c3d3 | https://github.com/python/cpython/pull/104705/commits/f84c3d312534f62471fec280770cddb63c2cb4d7 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
May 21, 2023
| https://github.com/python/cpython/pull/104705#pullrequestreview-1435587929 |
|
View reviewed changes
| https://github.com/python/cpython/pull/104705/files/f84c3d312534f62471fec280770cddb63c2cb4d7 |
| AlexWaygood | https://github.com/AlexWaygood |
| https://github.com/python/cpython/pull/104705#pullrequestreview-1435587929 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/104705 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| May 21, 2023 | https://github.com/python/cpython/pull/104705#event-9296547730 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| May 21, 2023 | https://github.com/python/cpython/pull/104705#issuecomment-1556283395 |
| Please reload this page | https://github.com/python/cpython/pull/104705 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| May 21, 2023 20:28 | https://github.com/python/cpython/pull/104705#event-9296550317 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| May 21, 2023 | https://github.com/python/cpython/pull/104705#issuecomment-1556283652 |
| Please reload this page | https://github.com/python/cpython/pull/104705 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| bf6dd8f | https://github.com/python/cpython/commit/bf6dd8f5fd98a1833646eb22269cad076836ebba |
| May 21, 2023 | https://github.com/python/cpython/pull/104705#event-9296578410 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| May 21, 2023 | https://github.com/python/cpython/pull/104705#event-9296578448 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| May 21, 2023 20:59 | https://github.com/python/cpython/pull/104705#event-9296590485 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104705 |
|
| https://github.com/AlexWaygood |
|
AlexWaygood
| https://github.com/AlexWaygood |
|
| https://github.com/python/cpython/pull/104705/files/f84c3d312534f62471fec280770cddb63c2cb4d7 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/104705 |
|
| https://github.com/erlend-aasland |
|
| https://github.com/AlexWaygood |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |