René's URL Explorer Experiment


Title: GH-104668: Don't call `PyOS_*` hooks in subinterpreters by brandtbucher · Pull Request #104674 · python/cpython · GitHub

Open Graph Title: GH-104668: Don't call `PyOS_*` hooks in subinterpreters by brandtbucher · Pull Request #104674 · python/cpython

X Title: GH-104668: Don't call `PyOS_*` hooks in subinterpreters by brandtbucher · Pull Request #104674 · python/cpython

Description: PyOS_InputHook and PyOS_ReadlineFunctionPointer are now only called in the main interpreter. Issue: The PyOS_* hooks interact poorly with subinterpreters #104668 📚 Documentation preview 📚: ht...

Open Graph Description: PyOS_InputHook and PyOS_ReadlineFunctionPointer are now only called in the main interpreter. Issue: The PyOS_* hooks interact poorly with subinterpreters #104668 📚 Documentation preview 📚: ht...

X Description: PyOS_InputHook and PyOS_ReadlineFunctionPointer are now only called in the main interpreter. Issue: The PyOS_* hooks interact poorly with subinterpreters #104668 📚 Documentation preview 📚: ht...

Opengraph URL: https://github.com/python/cpython/pull/104674

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c1dd040b-24c6-5d0f-c5ec-4f627fc866e5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD45C:17997A:8C7395:BC8885:6969BE09
html-safe-noncebbcd7344ab1613a4b589fbd66c1df230eb17ffcc29f880dd5c12574207b3baab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDVDOjE3OTk3QTo4QzczOTU6QkM4ODg1OjY5NjlCRTA5IiwidmlzaXRvcl9pZCI6IjgzNzgxNTgxNDAxNzg5Mzk0MDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacad7a6bfcff662588ff36d52b8182eccee9c061b4a9ce657c31d1a1fe956f364e
hovercard-subject-tagpull_request:1357732514
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104674/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/420177ffcbd8a55bf90c52db4f13caa46076059e051585579a5bf21d210a1575/python/cpython/pull/104674
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/420177ffcbd8a55bf90c52db4f13caa46076059e051585579a5bf21d210a1575/python/cpython/pull/104674
og:image:altPyOS_InputHook and PyOS_ReadlineFunctionPointer are now only called in the main interpreter. Issue: The PyOS_* hooks interact poorly with subinterpreters #104668 📚 Documentation preview 📚: ht...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebrandtbucher
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104674#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104674
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104674
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104674
Reloadhttps://github.com/python/cpython/pull/104674
Reloadhttps://github.com/python/cpython/pull/104674
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104674
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104674
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/104674#issue-comment-box
brandtbucherhttps://github.com/brandtbucher
python:mainhttps://github.com/python/cpython/tree/main
brandtbucher:global-hookshttps://github.com/brandtbucher/cpython/tree/global-hooks
GH-104668: Don't call PyOS_* hooks in subinterpreters https://github.com/python/cpython/pull/104674#top
brandtbucherhttps://github.com/brandtbucher
python:mainhttps://github.com/python/cpython/tree/main
brandtbucher:global-hookshttps://github.com/brandtbucher/cpython/tree/global-hooks
Conversation 7 https://github.com/python/cpython/pull/104674
Commits 6 https://github.com/python/cpython/pull/104674/commits
Checks 0 https://github.com/python/cpython/pull/104674/checks
Files changed https://github.com/python/cpython/pull/104674/files
Please reload this pagehttps://github.com/python/cpython/pull/104674
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
May 19, 2023https://github.com/python/cpython/pull/104674#issue-1717898260
Please reload this pagehttps://github.com/python/cpython/pull/104674
The PyOS_* hooks interact poorly with subinterpreters #104668https://github.com/python/cpython/issues/104668
https://cpython-previews--104674.org.readthedocs.build/https://cpython-previews--104674.org.readthedocs.build/
Please reload this pagehttps://github.com/python/cpython/pull/104674
brandtbucherhttps://github.com/brandtbucher
May 18, 2023 17:23https://github.com/python/cpython/pull/104674#commits-pushed-262ed9f
https://github.com/brandtbucher
Only call PyOS_* hooks from the main interpreterhttps://github.com/python/cpython/pull/104674/commits/262ed9fc8db7f08f359025288e0356f8fc9d9f77
262ed9fhttps://github.com/python/cpython/pull/104674/commits/262ed9fc8db7f08f359025288e0356f8fc9d9f77
https://github.com/brandtbucher
Document the changehttps://github.com/python/cpython/pull/104674/commits/83d92ae9258da6fa3452bfa04de874790d120294
83d92aehttps://github.com/python/cpython/pull/104674/commits/83d92ae9258da6fa3452bfa04de874790d120294
https://github.com/brandtbucher
blurb addhttps://github.com/python/cpython/pull/104674/commits/7fba174fce8560d3ce8b7e7b9df9ea1b83d7bf87
7fba174https://github.com/python/cpython/pull/104674/commits/7fba174fce8560d3ce8b7e7b9df9ea1b83d7bf87
https://github.com/brandtbucher
Add issue numbershttps://github.com/python/cpython/pull/104674/commits/9800546d4362e508a32851bb2b5749a47675e884
9800546https://github.com/python/cpython/pull/104674/commits/9800546d4362e508a32851bb2b5749a47675e884
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
interpreter-core https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Ainterpreter-core
topic-tkinter https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-tkinter
topic-subinterpreters https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-subinterpreters
topic-C-API https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-C-API
May 19, 2023https://github.com/python/cpython/pull/104674#event-9293136548
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 19, 2023 22:19https://github.com/python/cpython/pull/104674#event-9293136566
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
pablogsalhttps://github.com/pablogsal
code ownerhttps://github.com/python/cpython/blob/3bc94e678f2961eafc9d665898d73afc6204d314/.github/CODEOWNERS#L96
May 19, 2023 22:19https://github.com/python/cpython/pull/104674#event-9293136595
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
May 19, 2023https://github.com/python/cpython/pull/104674#event-9293136597
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
lysnikolaouhttps://github.com/lysnikolaou
code ownerhttps://github.com/python/cpython/blob/3bc94e678f2961eafc9d665898d73afc6204d314/.github/CODEOWNERS#L96
May 19, 2023 22:19https://github.com/python/cpython/pull/104674#event-9293136601
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 19, 2023https://github.com/python/cpython/pull/104674#event-9293136710
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 19, 2023 https://github.com/python/cpython/pull/104674#ref-issue-1717646347
The PyOS_* hooks interact poorly with subinterpreters #104668 https://github.com/python/cpython/issues/104668
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
May 20, 2023https://github.com/python/cpython/pull/104674#issuecomment-1555936000
Please reload this pagehttps://github.com/python/cpython/pull/104674
https://github.com/brandtbucher
Catch up with mainhttps://github.com/python/cpython/pull/104674/commits/0157842507f5b292ce112a095bfc3399e2ed85cc
0157842https://github.com/python/cpython/pull/104674/commits/0157842507f5b292ce112a095bfc3399e2ed85cc
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 22, 2023 https://github.com/python/cpython/pull/104674#pullrequestreview-1437143770
View reviewed changes https://github.com/python/cpython/pull/104674/files/9800546d4362e508a32851bb2b5749a47675e884
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
https://github.com/python/cpython/pull/104674#pullrequestreview-1437143770
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104674
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 22, 2023https://github.com/python/cpython/pull/104674#event-9305513442
https://github.com/brandtbucher
What's Newhttps://github.com/python/cpython/pull/104674/commits/b42f86a3a9539d86918b8777ad8a7a6dd02c7dc3
b42f86ahttps://github.com/python/cpython/pull/104674/commits/b42f86a3a9539d86918b8777ad8a7a6dd02c7dc3
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
May 22, 2023 19:25https://github.com/python/cpython/pull/104674#event-9306567667
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
357bed0https://github.com/python/cpython/commit/357bed0bcd3c5d7c4a8caad451754a9a172aca3e
May 22, 2023https://github.com/python/cpython/pull/104674#event-9306633648
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 22, 2023https://github.com/python/cpython/pull/104674#event-9306634263
https://github.com/arhadthedev
arhadthedevhttps://github.com/arhadthedev
May 22, 2023https://github.com/python/cpython/pull/104674#issuecomment-1557834905
Please reload this pagehttps://github.com/python/cpython/pull/104674
Please reload this pagehttps://github.com/python/cpython/pull/104674
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 22, 2023https://github.com/python/cpython/pull/104674#issuecomment-1558045753
@brandtbucherhttps://github.com/brandtbucher
Please reload this pagehttps://github.com/python/cpython/pull/104674
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
May 22, 2023https://github.com/python/cpython/pull/104674#event-9307786956
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
May 22, 2023https://github.com/python/cpython/pull/104674#issuecomment-1558046721
@brandtbucherhttps://github.com/brandtbucher
Please reload this pagehttps://github.com/python/cpython/pull/104674
miss-islingtonhttps://github.com/miss-islington
May 22, 2023 https://github.com/python/cpython/pull/104674#ref-commit-ef66708
https://github.com/brandtbucher
https://github.com/miss-islington
pythonGH-104668https://github.com/python/cpython/issues/104668
: Don't call PyOS_* hooks in subinterpreters (https://github.com/miss-islington/cpython/commit/ef66708a4a7a40fcb755cc1848ff16474819459c
pythonGH…https://github.com/python/cpython/pull/104674
ef66708https://github.com/miss-islington/cpython/commit/ef66708a4a7a40fcb755cc1848ff16474819459c
…-104674https://github.com/python/cpython/pull/104674
357bed0https://github.com/miss-islington/cpython/commit/357bed0bcd3c5d7c4a8caad451754a9a172aca3e
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 22, 2023https://github.com/python/cpython/pull/104674#issuecomment-1558046921
GH-104760https://github.com/python/cpython/pull/104760
3.12 branchhttps://github.com/python/cpython/tree/3.12
Please reload this pagehttps://github.com/python/cpython/pull/104674
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.12%22
May 22, 2023https://github.com/python/cpython/pull/104674#event-9307788464
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
May 22, 2023https://github.com/python/cpython/pull/104674#issuecomment-1558047282
Please reload this pagehttps://github.com/python/cpython/pull/104674
brandtbucherhttps://github.com/brandtbucher
May 23, 2023 https://github.com/python/cpython/pull/104674#ref-commit-905d419
https://github.com/miss-islington
https://github.com/brandtbucher
[3.12]https://github.com/python/cpython/commit/905d419cac0e2617ee07c8a478e132793878a875
GH-104668https://github.com/python/cpython/issues/104668
: Don't call PyOS_* hooks in subinterpreters (https://github.com/python/cpython/commit/905d419cac0e2617ee07c8a478e132793878a875
GH-104760https://github.com/python/cpython/pull/104760
)https://github.com/python/cpython/commit/905d419cac0e2617ee07c8a478e132793878a875
905d419https://github.com/python/cpython/commit/905d419cac0e2617ee07c8a478e132793878a875
GH-104668https://github.com/python/cpython/issues/104668
GH-104674https://github.com/python/cpython/pull/104674
357bed0https://github.com/python/cpython/commit/357bed0bcd3c5d7c4a8caad451754a9a172aca3e
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104674
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
https://github.com/python/cpython/pull/104674/files/9800546d4362e508a32851bb2b5749a47675e884
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
https://github.com/lysnikolaou
lysnikolaou https://github.com/lysnikolaou
https://github.com/brandtbucher
brandtbucher https://github.com/brandtbucher
interpreter-core https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Ainterpreter-core
topic-C-API https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-C-API
topic-subinterpreters https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-subinterpreters
topic-tkinter https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-tkinter
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/104674
https://github.com/brandtbucher
https://github.com/erlend-aasland
https://github.com/arhadthedev
https://github.com/JelleZijlstra
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/ericsnowcurrently
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.