René's URL Explorer Experiment


Title: Improve readability of `typing._ProtocolMeta.__instancecheck__` by AlexWaygood · Pull Request #104649 · python/cpython · GitHub

Open Graph Title: Improve readability of `typing._ProtocolMeta.__instancecheck__` by AlexWaygood · Pull Request #104649 · python/cpython

X Title: Improve readability of `typing._ProtocolMeta.__instancecheck__` by AlexWaygood · Pull Request #104649 · python/cpython

Description: This doesn't change behaviour at all. It might improve performance slightly for isinstance() checks against concrete subclasses of protocols, but the difference wasn't that significant. This is mai...

Open Graph Description: This doesn't change behaviour at all. It might improve performance slightly for isinstance() checks against concrete subclasses of protocols, but the difference wasn't that significant. Thi...

X Description: This doesn't change behaviour at all. It might improve performance slightly for isinstance() checks against concrete subclasses of protocols, but the difference wasn't that signific...

Opengraph URL: https://github.com/python/cpython/pull/104649

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6e3e52db-400c-50ae-3793-62c72857901d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD894:2E599F:4DCD37:6A01CB:6969D8FA
html-safe-nonced58e15428ef27c17b7189d57219ea32a91cda2910ec4d34a1d2564d63ad42b4b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODk0OjJFNTk5Rjo0RENEMzc6NkEwMUNCOjY5NjlEOEZBIiwidmlzaXRvcl9pZCI6IjIwMzk2ODg1MjYyMTM3OTgxMzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac35b55bdef4bec741e5dcf5bafd37b57eb8ede2d3f07e335be93836d627bafdd4
hovercard-subject-tagpull_request:1357087942
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104649/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3462cfdee651ef357aa3f41d5ce9293b37497e9d626c228407fe41bea1112860/python/cpython/pull/104649
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3462cfdee651ef357aa3f41d5ce9293b37497e9d626c228407fe41bea1112860/python/cpython/pull/104649
og:image:altThis doesn't change behaviour at all. It might improve performance slightly for isinstance() checks against concrete subclasses of protocols, but the difference wasn't that significant. Thi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAlexWaygood
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104649#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104649
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104649
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104649
Reloadhttps://github.com/python/cpython/pull/104649
Reloadhttps://github.com/python/cpython/pull/104649
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104649
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104649
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/104649#issue-comment-box
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:protocolmeta-refactorhttps://github.com/AlexWaygood/cpython/tree/protocolmeta-refactor
Improve readability of typing._ProtocolMeta.__instancecheck__ https://github.com/python/cpython/pull/104649#top
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:protocolmeta-refactorhttps://github.com/AlexWaygood/cpython/tree/protocolmeta-refactor
Conversation 0 https://github.com/python/cpython/pull/104649
Commits 1 https://github.com/python/cpython/pull/104649/commits
Checks 0 https://github.com/python/cpython/pull/104649/checks
Files changed https://github.com/python/cpython/pull/104649/files
Please reload this pagehttps://github.com/python/cpython/pull/104649
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 19, 2023https://github.com/python/cpython/pull/104649#issue-1717178796
Please reload this pagehttps://github.com/python/cpython/pull/104649
https://github.com/AlexWaygood
Improve readability of typing._ProtocolMeta.__instancecheck__https://github.com/python/cpython/pull/104649/commits/566191c27e7a79d94048b733bffac09ee01fec89
566191chttps://github.com/python/cpython/pull/104649/commits/566191c27e7a79d94048b733bffac09ee01fec89
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
May 19, 2023https://github.com/python/cpython/pull/104649#event-9288940440
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Fidget-Spinnerhttps://github.com/Fidget-Spinner
JelleZijlstrahttps://github.com/JelleZijlstra
gvanrossumhttps://github.com/gvanrossum
code ownershttps://github.com/python/cpython/blob/c26d03d5d6da94367c7f9cd93185616f2385db30/.github/CODEOWNERS#L144
May 19, 2023 12:33https://github.com/python/cpython/pull/104649#event-9288940512
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 19, 2023https://github.com/python/cpython/pull/104649#event-9288940842
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 19, 2023 https://github.com/python/cpython/pull/104649#pullrequestreview-1434426610
View reviewed changes https://github.com/python/cpython/pull/104649/files/566191c27e7a79d94048b733bffac09ee01fec89
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 19, 2023https://github.com/python/cpython/pull/104649#event-9289393340
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
a412fc5https://github.com/python/cpython/commit/a412fc58ccb8c6739b179137321cbbb1abebcd2f
May 19, 2023https://github.com/python/cpython/pull/104649#event-9289399877
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 19, 2023https://github.com/python/cpython/pull/104649#event-9289400374
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 19, 2023 13:30https://github.com/python/cpython/pull/104649#event-9289400418
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 19, 2023 https://github.com/python/cpython/pull/104649#ref-pullrequest-1717412141
Backport some recent Protocol fixes from 3.12 python/typing_extensions#161 https://github.com/python/typing_extensions/pull/161
carljmhttps://github.com/carljm
May 20, 2023 https://github.com/python/cpython/pull/104649#ref-commit-ea5965a
https://github.com/carljm
Merge branch 'main' into gsallam/mainhttps://github.com/gsallam/cpython_with_perfmap_apii/commit/ea5965a54e6979e3a6f4b47418b5064c4e41733e
ea5965ahttps://github.com/gsallam/cpython_with_perfmap_apii/commit/ea5965a54e6979e3a6f4b47418b5064c4e41733e
pythongh-103987https://github.com/python/cpython/issues/103987
python#103990https://github.com/python/cpython/pull/103990
python#104661https://github.com/python/cpython/pull/104661
pythongh-94906https://github.com/python/cpython/issues/94906
python#103881https://github.com/python/cpython/pull/103881
pythongh-104472https://github.com/python/cpython/issues/104472
python#104667https://github.com/python/cpython/pull/104667
pythongh-103839https://github.com/python/cpython/issues/103839
pythonGH-103842https://github.com/python/cpython/pull/103842
pythongh-85984https://github.com/python/cpython/issues/85984
python#101832https://github.com/python/cpython/pull/101832
pythongh-104659https://github.com/python/cpython/issues/104659
python#104665https://github.com/python/cpython/pull/104665
pythongh-92248https://github.com/python/cpython/issues/92248
python#103678https://github.com/python/cpython/pull/103678
pythongh-104645https://github.com/python/cpython/issues/104645
python#104646https://github.com/python/cpython/pull/104646
pythongh-104600https://github.com/python/cpython/issues/104600
python#104634https://github.com/python/cpython/pull/104634
pythongh-104602https://github.com/python/cpython/issues/104602
python#104639https://github.com/python/cpython/pull/104639
pythongh-104640https://github.com/python/cpython/issues/104640
python#104641https://github.com/python/cpython/pull/104641
pythongh-103921https://github.com/python/cpython/issues/103921
python#104654https://github.com/python/cpython/pull/104654
python#104649https://github.com/python/cpython/pull/104649
pythongh-96522https://github.com/python/cpython/issues/96522
python#96639https://github.com/python/cpython/pull/96639
pythonGH-102818https://github.com/python/cpython/issues/102818
pythonGH-104579https://github.com/python/cpython/pull/104579
pythonGH-103545https://github.com/python/cpython/issues/103545
python#104606https://github.com/python/cpython/pull/104606
pythongh-104623https://github.com/python/cpython/issues/104623
pythonGH-104624https://github.com/python/cpython/pull/104624
pythongh-104619https://github.com/python/cpython/issues/104619
python#104637https://github.com/python/cpython/pull/104637
pythongh-104602https://github.com/python/cpython/issues/104602
python#104603https://github.com/python/cpython/pull/104603
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104649
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/python/cpython/pull/104649/files/566191c27e7a79d94048b733bffac09ee01fec89
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
skip issue https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/104649
https://github.com/AlexWaygood
https://github.com/JelleZijlstra
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.