René's URL Explorer Experiment


Title: gh-104619: never leak comprehension locals to outer locals() by carljm · Pull Request #104637 · python/cpython · GitHub

Open Graph Title: gh-104619: never leak comprehension locals to outer locals() by carljm · Pull Request #104637 · python/cpython

X Title: gh-104619: never leak comprehension locals to outer locals() by carljm · Pull Request #104637 · python/cpython

Description: The initial implementation of PEP 709 didn't bother to clear comprehension locals after an inlined comprehension, if the name was a global outside the comprehension. This was purely an optimization...

Open Graph Description: The initial implementation of PEP 709 didn't bother to clear comprehension locals after an inlined comprehension, if the name was a global outside the comprehension. This was purely an optimiza...

X Description: The initial implementation of PEP 709 didn't bother to clear comprehension locals after an inlined comprehension, if the name was a global outside the comprehension. This was purely an opti...

Opengraph URL: https://github.com/python/cpython/pull/104637

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b1f070e8-1c0d-b358-05d8-01c04a70dc0d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9F94:19BAB9:48C0EB:605ED1:696B417D
html-safe-nonce4404f11c347d49a34f198cc7177280b5b95a1ebfe0561901a2a234dccf3eec3b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Rjk0OjE5QkFCOTo0OEMwRUI6NjA1RUQxOjY5NkI0MTdEIiwidmlzaXRvcl9pZCI6Ijc0NTQ1NTIyMTk0NzUxOTgzMzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac21874f4520095e9e8539dccfdde59528f91b211fa7baa973add45c0348980fca
hovercard-subject-tagpull_request:1356465222
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104637/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7187b8582b923fe275c6c4ebf7977e7ac14e7fe7166953ff74c6131ab2124e8a/python/cpython/pull/104637
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7187b8582b923fe275c6c4ebf7977e7ac14e7fe7166953ff74c6131ab2124e8a/python/cpython/pull/104637
og:image:altThe initial implementation of PEP 709 didn't bother to clear comprehension locals after an inlined comprehension, if the name was a global outside the comprehension. This was purely an optimiza...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecarljm
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104637#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104637
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104637
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104637
Reloadhttps://github.com/python/cpython/pull/104637
Reloadhttps://github.com/python/cpython/pull/104637
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104637
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104637
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/104637#issue-comment-box
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
carljm:709localshttps://github.com/carljm/cpython/tree/709locals
gh-104619: never leak comprehension locals to outer locals() https://github.com/python/cpython/pull/104637#top
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
carljm:709localshttps://github.com/carljm/cpython/tree/709locals
Conversation 0 https://github.com/python/cpython/pull/104637
Commits 1 https://github.com/python/cpython/pull/104637/commits
Checks 0 https://github.com/python/cpython/pull/104637/checks
Files changed https://github.com/python/cpython/pull/104637/files
Please reload this pagehttps://github.com/python/cpython/pull/104637
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/carljm
carljmhttps://github.com/carljm
May 19, 2023https://github.com/python/cpython/pull/104637#issue-1716474832
Please reload this pagehttps://github.com/python/cpython/pull/104637
PEP 709: Comprehension iteration variable leaks into outer locals() #104619https://github.com/python/cpython/issues/104619
Please reload this pagehttps://github.com/python/cpython/pull/104637
https://github.com/carljm
pythongh-104619https://github.com/python/cpython/issues/104619
: never leak comprehension locals to outer locals()https://github.com/python/cpython/pull/104637/commits/58b7d963b46f1d705d37175643aeb943e25bede5
58b7d96https://github.com/python/cpython/pull/104637/commits/58b7d963b46f1d705d37175643aeb943e25bede5
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 19, 2023 https://github.com/python/cpython/pull/104637#ref-issue-1715988007
PEP 709: Comprehension iteration variable leaks into outer locals() #104619 https://github.com/python/cpython/issues/104619
https://github.com/carljm
carljmhttps://github.com/carljm
JelleZijlstrahttps://github.com/JelleZijlstra
May 19, 2023 01:23https://github.com/python/cpython/pull/104637#event-9284933053
https://github.com/carljm
carljmhttps://github.com/carljm
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
May 19, 2023https://github.com/python/cpython/pull/104637#event-9284933968
https://github.com/carljm
carljmhttps://github.com/carljm
May 19, 2023 01:25https://github.com/python/cpython/pull/104637#event-9284940471
https://github.com/carljm
carljmhttps://github.com/carljm
iritkatrielhttps://github.com/iritkatriel
markshannonhttps://github.com/markshannon
code ownershttps://github.com/python/cpython/blob/86e6f16ccb97f66f2b9a31191ce347dca499d48c/.github/CODEOWNERS#L31
May 19, 2023 01:25https://github.com/python/cpython/pull/104637#event-9284940517
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 19, 2023https://github.com/python/cpython/pull/104637#event-9284940652
https://github.com/carljm
carljmhttps://github.com/carljm
May 19, 2023https://github.com/python/cpython/pull/104637#event-9284947702
PEP 709: Comprehension iteration variable leaks into outer locals() #104619 https://github.com/python/cpython/issues/104619
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 19, 2023 https://github.com/python/cpython/pull/104637#pullrequestreview-1433671411
View reviewed changes https://github.com/python/cpython/pull/104637/files/58b7d963b46f1d705d37175643aeb943e25bede5
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 19, 2023https://github.com/python/cpython/pull/104637#event-9285034323
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
70c7796https://github.com/python/cpython/commit/70c77964778817907fbcc2a047a2abad4eb6e127
May 19, 2023https://github.com/python/cpython/pull/104637#event-9285035408
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 19, 2023https://github.com/python/cpython/pull/104637#event-9285035542
carljmhttps://github.com/carljm
May 20, 2023 https://github.com/python/cpython/pull/104637#ref-commit-ea5965a
https://github.com/carljm
Merge branch 'main' into gsallam/mainhttps://github.com/gsallam/cpython_with_perfmap_apii/commit/ea5965a54e6979e3a6f4b47418b5064c4e41733e
ea5965ahttps://github.com/gsallam/cpython_with_perfmap_apii/commit/ea5965a54e6979e3a6f4b47418b5064c4e41733e
pythongh-103987https://github.com/python/cpython/issues/103987
python#103990https://github.com/python/cpython/pull/103990
python#104661https://github.com/python/cpython/pull/104661
pythongh-94906https://github.com/python/cpython/issues/94906
python#103881https://github.com/python/cpython/pull/103881
pythongh-104472https://github.com/python/cpython/issues/104472
python#104667https://github.com/python/cpython/pull/104667
pythongh-103839https://github.com/python/cpython/issues/103839
pythonGH-103842https://github.com/python/cpython/pull/103842
pythongh-85984https://github.com/python/cpython/issues/85984
python#101832https://github.com/python/cpython/pull/101832
pythongh-104659https://github.com/python/cpython/issues/104659
python#104665https://github.com/python/cpython/pull/104665
pythongh-92248https://github.com/python/cpython/issues/92248
python#103678https://github.com/python/cpython/pull/103678
pythongh-104645https://github.com/python/cpython/issues/104645
python#104646https://github.com/python/cpython/pull/104646
pythongh-104600https://github.com/python/cpython/issues/104600
python#104634https://github.com/python/cpython/pull/104634
pythongh-104602https://github.com/python/cpython/issues/104602
python#104639https://github.com/python/cpython/pull/104639
pythongh-104640https://github.com/python/cpython/issues/104640
python#104641https://github.com/python/cpython/pull/104641
pythongh-103921https://github.com/python/cpython/issues/103921
python#104654https://github.com/python/cpython/pull/104654
python#104649https://github.com/python/cpython/pull/104649
pythongh-96522https://github.com/python/cpython/issues/96522
python#96639https://github.com/python/cpython/pull/96639
pythonGH-102818https://github.com/python/cpython/issues/102818
pythonGH-104579https://github.com/python/cpython/pull/104579
pythonGH-103545https://github.com/python/cpython/issues/103545
python#104606https://github.com/python/cpython/pull/104606
pythongh-104623https://github.com/python/cpython/issues/104623
pythonGH-104624https://github.com/python/cpython/pull/104624
pythongh-104619https://github.com/python/cpython/issues/104619
python#104637https://github.com/python/cpython/pull/104637
pythongh-104602https://github.com/python/cpython/issues/104602
python#104603https://github.com/python/cpython/pull/104603
https://github.com/carljm
carljmhttps://github.com/carljm
June 16, 2023 17:39https://github.com/python/cpython/pull/104637#event-9554156371
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104637
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/python/cpython/pull/104637/files/58b7d963b46f1d705d37175643aeb943e25bede5
https://github.com/markshannon
markshannon https://github.com/markshannon
https://github.com/iritkatriel
iritkatriel https://github.com/iritkatriel
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
PEP 709: Comprehension iteration variable leaks into outer locals() https://github.com/python/cpython/issues/104619
Please reload this pagehttps://github.com/python/cpython/pull/104637
https://github.com/carljm
https://github.com/JelleZijlstra
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.