René's URL Explorer Experiment


Title: gh-74690: Don't set special protocol attributes on non-protocol subclasses of protocols by AlexWaygood · Pull Request #104622 · python/cpython · GitHub

Open Graph Title: gh-74690: Don't set special protocol attributes on non-protocol subclasses of protocols by AlexWaygood · Pull Request #104622 · python/cpython

X Title: gh-74690: Don't set special protocol attributes on non-protocol subclasses of protocols by AlexWaygood · Pull Request #104622 · python/cpython

Description: This was a small oversight in #103160. It's not a huge issue by any means, but there's no reason to set the special __protocol_attrs__ and __callable_proto_members_only__ attributes for concrete su...

Open Graph Description: This was a small oversight in #103160. It's not a huge issue by any means, but there's no reason to set the special __protocol_attrs__ and __callable_proto_members_only__ attributes for con...

X Description: This was a small oversight in #103160. It's not a huge issue by any means, but there's no reason to set the special __protocol_attrs__ and __callable_proto_members_only__ attributes...

Opengraph URL: https://github.com/python/cpython/pull/104622

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c9fd870b-dd0a-afe7-ad9c-d0ce546846db
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC904:7C3CC:89C3FF:BA03A6:69697D10
html-safe-noncea3c198b94e3feb8bdf6c86cc8ad03ae4d6385c21f183c18c4d13240de47e8712
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTA0OjdDM0NDOjg5QzNGRjpCQTAzQTY6Njk2OTdEMTAiLCJ2aXNpdG9yX2lkIjoiMjAxMTI4NzYyMTE3NzI3NzcxMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac12fb49546b26793f5c9b86ad65a265114b0c762a15f5d69b70035c926e373431
hovercard-subject-tagpull_request:1356222983
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104622/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/edebb95454e2e63b4a3f45a549b0271723bc8857eecb9ed058566237cc39127c/python/cpython/pull/104622
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/edebb95454e2e63b4a3f45a549b0271723bc8857eecb9ed058566237cc39127c/python/cpython/pull/104622
og:image:altThis was a small oversight in #103160. It's not a huge issue by any means, but there's no reason to set the special __protocol_attrs__ and __callable_proto_members_only__ attributes for con...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAlexWaygood
hostnamegithub.com
expected-hostnamegithub.com
Nonef33e4b94c8824ab2b434d82a94139432fb5ebee9df4b75304140ad22508c4a77
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release48f380098b30acbb700b04f1724481ca10d574fc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104622#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104622
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104622
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104622
Reloadhttps://github.com/python/cpython/pull/104622
Reloadhttps://github.com/python/cpython/pull/104622
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104622
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104622
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/104622#issue-comment-box
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:concrete-proto-subclasseshttps://github.com/AlexWaygood/cpython/tree/concrete-proto-subclasses
gh-74690: Don't set special protocol attributes on non-protocol subclasses of protocols https://github.com/python/cpython/pull/104622#top
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:concrete-proto-subclasseshttps://github.com/AlexWaygood/cpython/tree/concrete-proto-subclasses
Conversation 0 https://github.com/python/cpython/pull/104622
Commits 1 https://github.com/python/cpython/pull/104622/commits
Checks 0 https://github.com/python/cpython/pull/104622/checks
Files changed https://github.com/python/cpython/pull/104622/files
Please reload this pagehttps://github.com/python/cpython/pull/104622
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 18, 2023https://github.com/python/cpython/pull/104622#issue-1716201399
Please reload this pagehttps://github.com/python/cpython/pull/104622
#103160https://github.com/python/cpython/pull/103160
Performance of typing._ProtocolMeta._get_protocol_attrs and isinstance #74690https://github.com/python/cpython/issues/74690
Please reload this pagehttps://github.com/python/cpython/pull/104622
https://github.com/AlexWaygood
Don't set special protocol attributes on non-protocol subclasses of p…https://github.com/python/cpython/pull/104622/commits/5a8cdc5dbb5ceda9930f6db67d4f32af2b743371
5a8cdc5https://github.com/python/cpython/pull/104622/commits/5a8cdc5dbb5ceda9930f6db67d4f32af2b743371
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
May 18, 2023https://github.com/python/cpython/pull/104622#event-9283416963
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Fidget-Spinnerhttps://github.com/Fidget-Spinner
JelleZijlstrahttps://github.com/JelleZijlstra
gvanrossumhttps://github.com/gvanrossum
code ownershttps://github.com/python/cpython/blob/dcdc90d384723920e8dea0ee04eae8c219333634/.github/CODEOWNERS#L144
May 18, 2023 20:10https://github.com/python/cpython/pull/104622#event-9283417051
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 18, 2023https://github.com/python/cpython/pull/104622#event-9283417378
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 18, 2023 https://github.com/python/cpython/pull/104622#ref-issue-1198974045
Performance of typing._ProtocolMeta._get_protocol_attrs and isinstance #74690 https://github.com/python/cpython/issues/74690
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
May 18, 2023https://github.com/python/cpython/pull/104622#event-9283418217
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
carljmhttps://github.com/carljm
May 18, 2023 20:33https://github.com/python/cpython/pull/104622#event-9283573805
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 18, 2023 https://github.com/python/cpython/pull/104622#pullrequestreview-1433582817
View reviewed changes https://github.com/python/cpython/pull/104622/files/5a8cdc5dbb5ceda9930f6db67d4f32af2b743371
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 18, 2023https://github.com/python/cpython/pull/104622#event-9284524682
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
f7835fchttps://github.com/python/cpython/commit/f7835fc7e9617cefd87e72002916e258f589c857
May 18, 2023https://github.com/python/cpython/pull/104622#event-9284527422
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 18, 2023https://github.com/python/cpython/pull/104622#event-9284527579
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 18, 2023 23:34https://github.com/python/cpython/pull/104622#event-9284527635
carljmhttps://github.com/carljm
May 18, 2023 https://github.com/python/cpython/pull/104622#ref-commit-54095f0
https://github.com/carljm
Merge branch 'main' into nestedcompshttps://github.com/carljm/cpython/commit/54095f0737e7d24f2daeade09466bba714de484c
54095f0https://github.com/carljm/cpython/commit/54095f0737e7d24f2daeade09466bba714de484c
pythongh-74690https://github.com/python/cpython/issues/74690
python#104622https://github.com/python/cpython/pull/104622
pythongh-104623https://github.com/python/cpython/issues/104623
python#104625https://github.com/python/cpython/pull/104625
pythongh-104050https://github.com/python/cpython/issues/104050
python#104628https://github.com/python/cpython/pull/104628
pythongh-104629https://github.com/python/cpython/issues/104629
python#104630https://github.com/python/cpython/pull/104630
pythongh-104549https://github.com/python/cpython/issues/104549
python#104550https://github.com/python/cpython/pull/104550
pythongh-104050https://github.com/python/cpython/issues/104050
python#104626https://github.com/python/cpython/pull/104626
pythongh-104146https://github.com/python/cpython/issues/104146
python#104627https://github.com/python/cpython/pull/104627
pythongh-104615https://github.com/python/cpython/issues/104615
python#104620https://github.com/python/cpython/pull/104620
pythonGH-104484https://github.com/python/cpython/issues/104484
pythonGH-104565https://github.com/python/cpython/pull/104565
pythonGH-96803https://github.com/python/cpython/issues/96803
pythonGH-104211https://github.com/python/cpython/pull/104211
pythonGH-104580https://github.com/python/cpython/issues/104580
pythonGH-104581https://github.com/python/cpython/pull/104581
Backport some recent Protocol fixes from 3.12 python/typing_extensions#161 https://github.com/python/typing_extensions/pull/161
gh-74690: Make a typing test more resilient #104691 https://github.com/python/cpython/pull/104691
[Bug] typing_extensions.Protocol unsupported under typing_extensions ≥ 4.6.0 beartype/beartype#241 https://github.com/beartype/beartype/issues/241
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104622
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/python/cpython/pull/104622/files/5a8cdc5dbb5ceda9930f6db67d4f32af2b743371
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/carljm
carljm https://github.com/carljm
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
Please reload this pagehttps://github.com/python/cpython/pull/104622
https://github.com/AlexWaygood
https://github.com/JelleZijlstra
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.