René's URL Explorer Experiment


Title: gh-104341: Fix threading Module Shutdown by ericsnowcurrently · Pull Request #104560 · python/cpython · GitHub

Open Graph Title: gh-104341: Fix threading Module Shutdown by ericsnowcurrently · Pull Request #104560 · python/cpython

X Title: gh-104341: Fix threading Module Shutdown by ericsnowcurrently · Pull Request #104560 · python/cpython

Description: This should fix the frequent crashes in test_threading and test__xxsubinterpreters. There is some duplication with the threading module which could be removed after this lands. We can also eliminate PyThreadState.on_delete and PyInterpreterState.threads.count, both of which are cases where the state of the threading module leaked out into the runtime. (Also see gh-63008 and gh-18296.) Issue: gh-104341

Open Graph Description: This should fix the frequent crashes in test_threading and test__xxsubinterpreters. There is some duplication with the threading module which could be removed after this lands. We can also elimina...

X Description: This should fix the frequent crashes in test_threading and test__xxsubinterpreters. There is some duplication with the threading module which could be removed after this lands. We can also elimina...

Opengraph URL: https://github.com/python/cpython/pull/104560

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ba5a485d-303e-3151-9f94-dad6f1d324df
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB0EE:13A77B:2A4224:39079F:6969D20B
html-safe-noncede993e56a83d431b89599cb7ec946bf4e2fbf5a1914041bda90ae84da9943923
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEVFOjEzQTc3QjoyQTQyMjQ6MzkwNzlGOjY5NjlEMjBCIiwidmlzaXRvcl9pZCI6IjU1MDcyMjc5MTE2MjMxMzU3NTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4af5fa32e1775bca82c65a85b9bcbddd621ae037ccb1d4c7dd4a95e6f82d3d92
hovercard-subject-tagpull_request:1353038373
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/104560/files
twitter:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
og:image:altThis should fix the frequent crashes in test_threading and test__xxsubinterpreters. There is some duplication with the threading module which could be removed after this lands. We can also elimina...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104560/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104560%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104560%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104560/files
Reloadhttps://github.com/python/cpython/pull/104560/files
Reloadhttps://github.com/python/cpython/pull/104560/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104560/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104560/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:fix-threading-module-shutdownhttps://github.com/ericsnowcurrently/cpython/tree/fix-threading-module-shutdown
Conversation 9 https://github.com/python/cpython/pull/104560
Commits 12 https://github.com/python/cpython/pull/104560/commits
Checks 0 https://github.com/python/cpython/pull/104560/checks
Files changed https://github.com/python/cpython/pull/104560/files
Please reload this pagehttps://github.com/python/cpython/pull/104560/files
gh-104341: Fix threading Module Shutdown https://github.com/python/cpython/pull/104560/files#top
Show all changes 12 commits https://github.com/python/cpython/pull/104560/files
e5804c1 Add module-owned threads to module state. ericsnowcurrently May 15, 2023 https://github.com/python/cpython/pull/104560/commits/e5804c1a0b85eefe4087c133405ec6a357723235
62df3e6 Re-initialize the module threads lock upon fork. ericsnowcurrently May 15, 2023 https://github.com/python/cpython/pull/104560/commits/62df3e6eef1a1243ed763feadbdb6038ecfb5474
1bf707f Add module_thread.daemonic. ericsnowcurrently May 16, 2023 https://github.com/python/cpython/pull/104560/commits/1bf707f29582e2590454e9dd0e165fe7a7618849
da78235 Add module_thread.lifetime_mutex. ericsnowcurrently May 16, 2023 https://github.com/python/cpython/pull/104560/commits/da78235d48060b5846e4d3172b44df397bdac910
ad9bbce Add _thread._wait_for_threads_fini(). ericsnowcurrently May 16, 2023 https://github.com/python/cpython/pull/104560/commits/ad9bbcec3cac3a9509fa9491921fee19a6d79b0f
54dc3b5 Wait for all the threads to finalize. ericsnowcurrently May 16, 2023 https://github.com/python/cpython/pull/104560/commits/54dc3b5f299208d886edb2dfaff23aaea449203f
b15fa9d Fix Windows. ericsnowcurrently May 16, 2023 https://github.com/python/cpython/pull/104560/commits/b15fa9dddedc014e9070b379fbdb6e087c60af3d
c7a832b Fix Windows. ericsnowcurrently May 16, 2023 https://github.com/python/cpython/pull/104560/commits/c7a832bb5b24ba4203647cdb436268754553bc2d
51d960e Fix Windows. ericsnowcurrently May 16, 2023 https://github.com/python/cpython/pull/104560/commits/51d960e2ca553f8a8be985e12ed3c2b67ab600d7
bddfc46 Wait for all threads that aren't killed daemon threads to finalize. ericsnowcurrently May 16, 2023 https://github.com/python/cpython/pull/104560/commits/bddfc4634cd092b389ce35f70fb94517ef23417a
188d141 Fix a typo. ericsnowcurrently May 16, 2023 https://github.com/python/cpython/pull/104560/commits/188d1413c9acabdd8887890026bf91ae2ab94dc8
bd3accd Silence some warnings. ericsnowcurrently May 16, 2023 https://github.com/python/cpython/pull/104560/commits/bd3accd4a3f1d3f4586afcbd9c23fb48c5d27df3
Clear filters https://github.com/python/cpython/pull/104560/files
Please reload this pagehttps://github.com/python/cpython/pull/104560/files
Please reload this pagehttps://github.com/python/cpython/pull/104560/files
test_threading.py https://github.com/python/cpython/pull/104560/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
threading.py https://github.com/python/cpython/pull/104560/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
_threadmodule.c https://github.com/python/cpython/pull/104560/files#diff-23071700ee893f365a4c117210b9129d4ac6afe5cc6e52bb5cd4cabbc6816e07
Lib/test/test_threading.pyhttps://github.com/python/cpython/pull/104560/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
View file https://github.com/python/cpython/blob/bd3accd4a3f1d3f4586afcbd9c23fb48c5d27df3/Lib/test/test_threading.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104560/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104560/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
https://github.com/python/cpython/pull/104560/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
Lib/threading.pyhttps://github.com/python/cpython/pull/104560/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
View file https://github.com/python/cpython/blob/bd3accd4a3f1d3f4586afcbd9c23fb48c5d27df3/Lib/threading.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104560/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104560/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104560/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104560/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104560/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104560/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104560/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104560/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104560/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
Please reload this pagehttps://github.com/python/cpython/pull/104560/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.