René's URL Explorer Experiment


Title: gh-104555: Runtime-checkable protocols: Don't let previous calls to `isinstance()` influence whether `issubclass()` raises an exception by AlexWaygood · Pull Request #104559 · python/cpython · GitHub

Open Graph Title: gh-104555: Runtime-checkable protocols: Don't let previous calls to `isinstance()` influence whether `issubclass()` raises an exception by AlexWaygood · Pull Request #104559 · python/cpython

X Title: gh-104555: Runtime-checkable protocols: Don't let previous calls to `isinstance()` influence whether `issubclass()` raises an exception by AlexWaygood · Pull Request #104559 · python/cpython

Description: ABCMeta.__instancecheck__ caches isinstance() calls against classes that have ABCMeta as their metaclass. It uses these cache entries not only to inform how future isinstance() calls behave, but al...

Open Graph Description: ABCMeta.__instancecheck__ caches isinstance() calls against classes that have ABCMeta as their metaclass. It uses these cache entries not only to inform how future isinstance() calls behave, but al...

X Description: ABCMeta.__instancecheck__ caches isinstance() calls against classes that have ABCMeta as their metaclass. It uses these cache entries not only to inform how future isinstance() calls behave, but al...

Opengraph URL: https://github.com/python/cpython/pull/104559

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:47a7aa5e-7d8b-adcc-b303-5aa644a443ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD60E:14FC13:C09FBF:104789F:696AC0D8
html-safe-nonce1f65f5a50afd0019c3f7d866829170bf0f75a2d6d6dafcd52e03c4383b7a99f6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjBFOjE0RkMxMzpDMDlGQkY6MTA0Nzg5Rjo2OTZBQzBEOCIsInZpc2l0b3JfaWQiOiI2MzQ3ODcwMzA3MDA3MjUwNjQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac76271e90fe190988209860bd67d8c57735a2aa2436d1d944000c30a0707fe677
hovercard-subject-tagpull_request:1352936438
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104559/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e77340ce79c578d9382c3ac9510d11a6069308b94368633869b7ebf8a2a1b421/python/cpython/pull/104559
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e77340ce79c578d9382c3ac9510d11a6069308b94368633869b7ebf8a2a1b421/python/cpython/pull/104559
og:image:altABCMeta.__instancecheck__ caches isinstance() calls against classes that have ABCMeta as their metaclass. It uses these cache entries not only to inform how future isinstance() calls behave, but al...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAlexWaygood
hostnamegithub.com
expected-hostnamegithub.com
None986b6a1d774985095564e64d6963d11f094da3d0e2bfda2ab1a27d63662eb033
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release89ad2112b9c4e11df6a0c13c8c1f8eedd36b0977
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104559#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104559
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104559
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104559
Reloadhttps://github.com/python/cpython/pull/104559
Reloadhttps://github.com/python/cpython/pull/104559
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104559
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104559
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/104559#issue-comment-box
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:fix-runtime-protocolshttps://github.com/AlexWaygood/cpython/tree/fix-runtime-protocols
gh-104555: Runtime-checkable protocols: Don't let previous calls to isinstance() influence whether issubclass() raises an exception https://github.com/python/cpython/pull/104559#top
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:fix-runtime-protocolshttps://github.com/AlexWaygood/cpython/tree/fix-runtime-protocols
Conversation 19 https://github.com/python/cpython/pull/104559
Commits 12 https://github.com/python/cpython/pull/104559/commits
Checks 0 https://github.com/python/cpython/pull/104559/checks
Files changed https://github.com/python/cpython/pull/104559/files
Please reload this pagehttps://github.com/python/cpython/pull/104559
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 16, 2023https://github.com/python/cpython/pull/104559#issue-1712507022
Please reload this pagehttps://github.com/python/cpython/pull/104559
47753echttps://github.com/python/cpython/commit/47753ecde21b79b5c5f11d883946fda2a340e427
#104555https://github.com/python/cpython/issues/104555
Typing: runtime-checkable protocols are broken on main #104555https://github.com/python/cpython/issues/104555
Please reload this pagehttps://github.com/python/cpython/pull/104559
https://github.com/AlexWaygood
pythongh-104555https://github.com/python/cpython/issues/104555
: Sidestep the ABCMeta.__instancecheck__ cache in typi…https://github.com/python/cpython/pull/104559/commits/2601138e6379e5e4305a07181a80a266488d9968
2601138https://github.com/python/cpython/pull/104559/commits/2601138e6379e5e4305a07181a80a266488d9968
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
May 16, 2023https://github.com/python/cpython/pull/104559#event-9261132097
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
carljmhttps://github.com/carljm
May 16, 2023 18:14https://github.com/python/cpython/pull/104559#event-9261132137
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Fidget-Spinnerhttps://github.com/Fidget-Spinner
JelleZijlstrahttps://github.com/JelleZijlstra
gvanrossumhttps://github.com/gvanrossum
code ownershttps://github.com/python/cpython/blob/5e9f471e7db30893fb3f42681f17fdcdb70069ee/.github/CODEOWNERS#L144
May 16, 2023 18:14https://github.com/python/cpython/pull/104559#event-9261132221
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 16, 2023https://github.com/python/cpython/pull/104559#event-9261132552
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 16, 2023 https://github.com/python/cpython/pull/104559#ref-issue-1712247778
Typing: runtime-checkable protocols are broken on main #104555 https://github.com/python/cpython/issues/104555
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 16, 2023 https://github.com/python/cpython/pull/104559#pullrequestreview-1429152761
View reviewed changes https://github.com/python/cpython/pull/104559/files/2601138e6379e5e4305a07181a80a266488d9968
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/104559/files/2601138e6379e5e4305a07181a80a266488d9968#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/104559
https://github.com/AlexWaygood
Simplify testhttps://github.com/python/cpython/pull/104559/commits/f3a4551bbfcbb7cdfb9207af76fc739ea9c19611
f3a4551https://github.com/python/cpython/pull/104559/commits/f3a4551bbfcbb7cdfb9207af76fc739ea9c19611
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 16, 2023 https://github.com/python/cpython/pull/104559#pullrequestreview-1429164797
View reviewed changes https://github.com/python/cpython/pull/104559/files/f3a4551bbfcbb7cdfb9207af76fc739ea9c19611
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 16, 2023https://github.com/python/cpython/pull/104559#event-9261220367
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 16, 2023https://github.com/python/cpython/pull/104559#issuecomment-1550168437
Please reload this pagehttps://github.com/python/cpython/pull/104559
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 16, 2023 18:39https://github.com/python/cpython/pull/104559#event-9261372822
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 16, 2023https://github.com/python/cpython/pull/104559#event-9261373214
https://github.com/AlexWaygood
Optimisehttps://github.com/python/cpython/pull/104559/commits/714badc0f3ecef0cfc070a6d2dab37847aaeb344
714badchttps://github.com/python/cpython/pull/104559/commits/714badc0f3ecef0cfc070a6d2dab37847aaeb344
https://github.com/sunmy2019
sunmy2019https://github.com/sunmy2019
May 16, 2023 https://github.com/python/cpython/pull/104559#pullrequestreview-1429213214
View reviewed changes https://github.com/python/cpython/pull/104559/files/f3a4551bbfcbb7cdfb9207af76fc739ea9c19611
sunmy2019https://github.com/sunmy2019
https://github.com/python/cpython/pull/104559#pullrequestreview-1429213214
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#104555 (comment)https://github.com/python/cpython/issues/104555#issuecomment-1550178426
Please reload this pagehttps://github.com/python/cpython/pull/104559
https://github.com/carljm
carljmhttps://github.com/carljm
May 16, 2023 https://github.com/python/cpython/pull/104559#pullrequestreview-1429164957
View reviewed changes https://github.com/python/cpython/pull/104559/files/f3a4551bbfcbb7cdfb9207af76fc739ea9c19611
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/104559/files/f3a4551bbfcbb7cdfb9207af76fc739ea9c19611#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/104559
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/104559/files/f3a4551bbfcbb7cdfb9207af76fc739ea9c19611#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/104559
AlexWaygoodhttps://github.com/AlexWaygood
May 16, 2023 20:11https://github.com/python/cpython/pull/104559#commits-pushed-04ed974
https://github.com/AlexWaygood
https://github.com/carljm
who needs codespell when we have carlhttps://github.com/python/cpython/pull/104559/commits/04ed9747351f16b86aea6177661d56103cf4aa71
04ed974https://github.com/python/cpython/pull/104559/commits/04ed9747351f16b86aea6177661d56103cf4aa71
https://github.com/AlexWaygood
Merge branch 'fix-runtime-protocols' ofhttps://github.com/python/cpython/pull/104559/commits/9c5c75f205336e7b45884d63abcf1b43f8065866
https://github.com/AlexWaygoo…https://github.com/AlexWaygood/cpython
9c5c75fhttps://github.com/python/cpython/pull/104559/commits/9c5c75f205336e7b45884d63abcf1b43f8065866
…d/cpythonhttps://github.com/AlexWaygood/cpython
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 16, 2023 https://github.com/python/cpython/pull/104559#pullrequestreview-1429254393
View reviewed changes https://github.com/python/cpython/pull/104559/files/9c5c75f205336e7b45884d63abcf1b43f8065866
Lib/typing.pyhttps://github.com/python/cpython/pull/104559/files/9c5c75f205336e7b45884d63abcf1b43f8065866#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
AlexWaygoodhttps://github.com/AlexWaygood
May 16, 2023https://github.com/python/cpython/pull/104559#discussion_r1195597382
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104559
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 16, 2023 19:19https://github.com/python/cpython/pull/104559#event-9261721047
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 16, 2023https://github.com/python/cpython/pull/104559#event-9261721510
AlexWaygoodhttps://github.com/AlexWaygood
May 16, 2023 20:24https://github.com/python/cpython/pull/104559#commits-pushed-49373a9
https://github.com/AlexWaygood
be more carefulhttps://github.com/python/cpython/pull/104559/commits/49373a9b123e19c90365ed7add2358e2ef69b889
49373a9https://github.com/python/cpython/pull/104559/commits/49373a9b123e19c90365ed7add2358e2ef69b889
https://github.com/AlexWaygood
Add commenthttps://github.com/python/cpython/pull/104559/commits/e114fe95049ef27f36774fbc9d17436b4a9343fd
e114fe9https://github.com/python/cpython/pull/104559/commits/e114fe95049ef27f36774fbc9d17436b4a9343fd
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
carljmhttps://github.com/carljm
May 16, 2023 19:30https://github.com/python/cpython/pull/104559#event-9261811076
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 16, 2023 https://github.com/python/cpython/pull/104559#ref-issue-1712689073
Incorrect bedevere transition (the sequel) python/bedevere#559 https://github.com/python/bedevere/issues/559
https://github.com/sunmy2019
sunmy2019https://github.com/sunmy2019
May 17, 2023https://github.com/python/cpython/pull/104559#issuecomment-1550603903
Please reload this pagehttps://github.com/python/cpython/pull/104559
Please reload this pagehttps://github.com/python/cpython/pull/104559
https://github.com/AlexWaygood
Add more failing tests (thanks sunmy2019!)https://github.com/python/cpython/pull/104559/commits/b5cc9cd59072c950f8c399c6e54b25c0333cf1ac
b5cc9cdhttps://github.com/python/cpython/pull/104559/commits/b5cc9cd59072c950f8c399c6e54b25c0333cf1ac
https://github.com/sunmy2019
sunmy2019https://github.com/sunmy2019
May 17, 2023https://github.com/python/cpython/pull/104559#issuecomment-1551270634
Please reload this pagehttps://github.com/python/cpython/pull/104559
Please reload this pagehttps://github.com/python/cpython/pull/104559
https://github.com/AlexWaygood
Better fixhttps://github.com/python/cpython/pull/104559/commits/5f72b820e68c63c44c51f6c7f7f068e6cfab57c2
5f72b82https://github.com/python/cpython/pull/104559/commits/5f72b820e68c63c44c51f6c7f7f068e6cfab57c2
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
May 17, 2023https://github.com/python/cpython/pull/104559#event-9268632705
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 17, 2023https://github.com/python/cpython/pull/104559#issuecomment-1551289354
@sunmy2019https://github.com/sunmy2019
5f72b82https://github.com/python/cpython/commit/5f72b820e68c63c44c51f6c7f7f068e6cfab57c2
Please reload this pagehttps://github.com/python/cpython/pull/104559
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
JelleZijlstrahttps://github.com/JelleZijlstra
sunmy2019https://github.com/sunmy2019
May 17, 2023 12:18https://github.com/python/cpython/pull/104559#event-9268645912
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 17, 2023 https://github.com/python/cpython/pull/104559#pullrequestreview-1430542453
View reviewed changes https://github.com/python/cpython/pull/104559/files/5f72b820e68c63c44c51f6c7f7f068e6cfab57c2
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/104559/files/5f72b820e68c63c44c51f6c7f7f068e6cfab57c2#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
AlexWaygoodhttps://github.com/AlexWaygood
May 17, 2023https://github.com/python/cpython/pull/104559#discussion_r1196422531
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104559
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 17, 2023https://github.com/python/cpython/pull/104559#event-9268739909
https://github.com/AlexWaygood
Improve commentshttps://github.com/python/cpython/pull/104559/commits/bb56e1318a56a41ea21e21aec179e751cad0197f
bb56e13https://github.com/python/cpython/pull/104559/commits/bb56e1318a56a41ea21e21aec179e751cad0197f
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 17, 2023https://github.com/python/cpython/pull/104559#issuecomment-1551578789
Please reload this pagehttps://github.com/python/cpython/pull/104559
Please reload this pagehttps://github.com/python/cpython/pull/104559
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 17, 2023 15:57https://github.com/python/cpython/pull/104559#event-9271290948
https://github.com/apps/blurb-it
📜🤖 Added by blurb_it.https://github.com/python/cpython/pull/104559/commits/430cacd7795ea6603c16f759483e4fbaa44067d3
430cacdhttps://github.com/python/cpython/pull/104559/commits/430cacd7795ea6603c16f759483e4fbaa44067d3
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A3.12
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
May 17, 2023https://github.com/python/cpython/pull/104559#event-9271838833
https://github.com/sunmy2019
sunmy2019https://github.com/sunmy2019
May 17, 2023https://github.com/python/cpython/pull/104559#issuecomment-1552175276
Please reload this pagehttps://github.com/python/cpython/pull/104559
https://github.com/carljm
carljmhttps://github.com/carljm
May 17, 2023 https://github.com/python/cpython/pull/104559#pullrequestreview-1431785834
View reviewed changes https://github.com/python/cpython/pull/104559/files/430cacd7795ea6603c16f759483e4fbaa44067d3
carljmhttps://github.com/carljm
https://github.com/python/cpython/pull/104559#pullrequestreview-1431785834
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104559
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/104559/files/430cacd7795ea6603c16f759483e4fbaa44067d3#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/104559
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/104559/files/430cacd7795ea6603c16f759483e4fbaa44067d3#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/104559
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 17, 2023https://github.com/python/cpython/pull/104559#event-9274360900
https://github.com/AlexWaygood
https://github.com/carljm
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/104559/commits/f9273fc978d52d3c870c8d4d14d3cafce36c5286
f9273fchttps://github.com/python/cpython/pull/104559/commits/f9273fc978d52d3c870c8d4d14d3cafce36c5286
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 17, 2023 23:23https://github.com/python/cpython/pull/104559#event-9274379848
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 17, 2023https://github.com/python/cpython/pull/104559#issuecomment-1552208503
@JelleZijlstrahttps://github.com/JelleZijlstra
@sunmy2019https://github.com/sunmy2019
Please reload this pagehttps://github.com/python/cpython/pull/104559
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
b27fe67https://github.com/python/cpython/commit/b27fe67f3c643e174c3619b669228ef34b6d87ee
May 17, 2023https://github.com/python/cpython/pull/104559#event-9274459169
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 17, 2023https://github.com/python/cpython/pull/104559#event-9274459269
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 18, 2023https://github.com/python/cpython/pull/104559#issuecomment-1552250957
b27fe67https://github.com/python/cpython/commit/b27fe67f3c643e174c3619b669228ef34b6d87ee
the buildbot page in the devguidehttps://devguide.python.org/buildbots/
https://buildbot.python.org/all/#builders/1079/builds/1325https://buildbot.python.org/all/#builders/1079/builds/1325
b27fe67https://github.com/python/cpython/commit/b27fe67f3c643e174c3619b669228ef34b6d87ee
https://buildbot.python.org/all/#builders/1079/builds/1325https://buildbot.python.org/all/#builders/1079/builds/1325
Please reload this pagehttps://github.com/python/cpython/pull/104559
JelleZijlstrahttps://github.com/JelleZijlstra
May 18, 2023 https://github.com/python/cpython/pull/104559#ref-commit-42b48ce
https://github.com/AlexWaygood
https://github.com/carljm
https://github.com/JelleZijlstra
pythongh-104555https://github.com/python/cpython/issues/104555
: Runtime-checkable protocols: Don't let previous call…https://github.com/JelleZijlstra/cpython/commit/42b48ceeb57da28db347eb11e7a3e61e78526485
42b48cehttps://github.com/JelleZijlstra/cpython/commit/42b48ceeb57da28db347eb11e7a3e61e78526485
python#104559https://github.com/python/cpython/pull/104559
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 18, 2023 05:34https://github.com/python/cpython/pull/104559#event-9275809495
Backport some recent Protocol fixes from 3.12 python/typing_extensions#161 https://github.com/python/typing_extensions/pull/161
[Bug] typing_extensions.Protocol unsupported under typing_extensions ≥ 4.6.0 beartype/beartype#241 https://github.com/beartype/beartype/issues/241
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104559
https://github.com/carljm
carljm https://github.com/carljm
https://github.com/python/cpython/pull/104559/files/430cacd7795ea6603c16f759483e4fbaa44067d3
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/sunmy2019
sunmy2019 https://github.com/sunmy2019
3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A3.12
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Typing: runtime-checkable protocols are broken on main https://github.com/python/cpython/issues/104555
Please reload this pagehttps://github.com/python/cpython/pull/104559
https://github.com/AlexWaygood
https://github.com/sunmy2019
https://github.com/bedevere-bot
https://github.com/carljm
https://github.com/JelleZijlstra
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.