René's URL Explorer Experiment


Title: gh-104341: Clean Up threading Module by ericsnowcurrently · Pull Request #104552 · python/cpython · GitHub

Open Graph Title: gh-104341: Clean Up threading Module by ericsnowcurrently · Pull Request #104552 · python/cpython

X Title: gh-104341: Clean Up threading Module by ericsnowcurrently · Pull Request #104552 · python/cpython

Description: To fix gh-104341, we need to change the threading module to utilize two locks for each thread: one for if it running (for join()) and one for its overall lifetime, on which Py_EndInterpreter() will wait. This PR cleans things up to make it easier to make that change. As part of that, we move all the module's state out of PyThreadState and PyInterpreterState.

Open Graph Description: To fix gh-104341, we need to change the threading module to utilize two locks for each thread: one for if it running (for join()) and one for its overall lifetime, on which Py_EndInterpreter() will...

X Description: To fix gh-104341, we need to change the threading module to utilize two locks for each thread: one for if it running (for join()) and one for its overall lifetime, on which Py_EndInterpreter() will...

Opengraph URL: https://github.com/python/cpython/pull/104552

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3896a83f-ba6b-5749-f92d-ff4a7915cd68
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE5AE:13A77B:1AE654:24442A:6969CF24
html-safe-nonce8df7499e90c6c30caca6eb04a6dbf90a4f8f32981115f1b1cadceee54bb96680
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUFFOjEzQTc3QjoxQUU2NTQ6MjQ0NDJBOjY5NjlDRjI0IiwidmlzaXRvcl9pZCI6IjY0MDA1NjIwOTEwNzU5NDgzMjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca3ca68b81fd0a7452b235aa2b5da8d8488a06242bc08b61d40e87a37ccaa1064
hovercard-subject-tagpull_request:1352612642
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/104552/files
twitter:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
og:image:altTo fix gh-104341, we need to change the threading module to utilize two locks for each thread: one for if it running (for join()) and one for its overall lifetime, on which Py_EndInterpreter() will...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104552/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104552%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104552%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104552/files
Reloadhttps://github.com/python/cpython/pull/104552/files
Reloadhttps://github.com/python/cpython/pull/104552/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104552/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104552/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:clean-up-threading-modulehttps://github.com/ericsnowcurrently/cpython/tree/clean-up-threading-module
Conversation 2 https://github.com/python/cpython/pull/104552
Commits 12 https://github.com/python/cpython/pull/104552/commits
Checks 0 https://github.com/python/cpython/pull/104552/checks
Files changed https://github.com/python/cpython/pull/104552/files
Please reload this pagehttps://github.com/python/cpython/pull/104552/files
gh-104341: Clean Up threading Module https://github.com/python/cpython/pull/104552/files#top
Show all changes 12 commits https://github.com/python/cpython/pull/104552/files
b3474f3 Drop bootstate.interp and bootstate.runtime. ericsnowcurrently May 15, 2023 https://github.com/python/cpython/pull/104552/commits/b3474f3d65b9e7078ebbf6ca71abad8ee01d5fdd
ec9f53b Add module-owned threads to module state. ericsnowcurrently May 15, 2023 https://github.com/python/cpython/pull/104552/commits/ec9f53b15429d8183444144aaa580949c4abc328
05aa205 Call on_delete() in remove_module_thread(). ericsnowcurrently May 15, 2023 https://github.com/python/cpython/pull/104552/commits/05aa205de5d944edfee1116bb8b7a6447c19a73b
da85eed Drop interp.threads.count. ericsnowcurrently May 15, 2023 https://github.com/python/cpython/pull/104552/commits/da85eeda70a3c051d3203b36bd9627eee66e4ebe
004589b Pass module_state to newlockobject(). ericsnowcurrently May 15, 2023 https://github.com/python/cpython/pull/104552/commits/004589be6d8489c2b75cac5c908e5fdd96cf09ef
aa4d3bb Create the thread lock in threading.py. ericsnowcurrently May 15, 2023 https://github.com/python/cpython/pull/104552/commits/aa4d3bb0cef8a1cc7b9e6e9fac9fe3eae669c854
82ff2ba Re-initialize the module threads lock upon fork. ericsnowcurrently May 15, 2023 https://github.com/python/cpython/pull/104552/commits/82ff2ba965113b5417c8fcd3af1a07e0e6f4eae1
a19c684 Add module_thread.running_lock. ericsnowcurrently May 15, 2023 https://github.com/python/cpython/pull/104552/commits/a19c68400c24bbe92a3e1bba5cb9fd3ab774512a
de530b1 Be more specific in _wait_for_tstate_lock(). ericsnowcurrently May 16, 2023 https://github.com/python/cpython/pull/104552/commits/de530b173522da45ecc6e0520915581d01eabe54
e2c7058 Fix _set_sentinel(). ericsnowcurrently May 16, 2023 https://github.com/python/cpython/pull/104552/commits/e2c7058abee4cd85c8d9e2773ec336edfe799267
0d30811 Track the "main" thread too. ericsnowcurrently May 16, 2023 https://github.com/python/cpython/pull/104552/commits/0d30811396885f89deb94d8083bb4be980c19a6a
86e5d82 Drop tstate->on_delete. ericsnowcurrently May 16, 2023 https://github.com/python/cpython/pull/104552/commits/86e5d821b0911019b25b284d28e19efeeb19debe
Clear filters https://github.com/python/cpython/pull/104552/files
Please reload this pagehttps://github.com/python/cpython/pull/104552/files
Please reload this pagehttps://github.com/python/cpython/pull/104552/files
pystate.h https://github.com/python/cpython/pull/104552/files#diff-fefbbf791abe2a1b6d9cab39778d388ebb9135eeefbd734e463aac75d1979e7f
pycore_interp.h https://github.com/python/cpython/pull/104552/files#diff-cb06b7ba43789a1d6ae5bef46baa8a255b72dbcd2b44bfec7f146ea4e94dbfa0
threading.py https://github.com/python/cpython/pull/104552/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
_threadmodule.c https://github.com/python/cpython/pull/104552/files#diff-23071700ee893f365a4c117210b9129d4ac6afe5cc6e52bb5cd4cabbc6816e07
pystate.c https://github.com/python/cpython/pull/104552/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L311
Include/cpython/pystate.hhttps://github.com/python/cpython/pull/104552/files#diff-fefbbf791abe2a1b6d9cab39778d388ebb9135eeefbd734e463aac75d1979e7f
View file https://github.com/ericsnowcurrently/cpython/blob/86e5d821b0911019b25b284d28e19efeeb19debe/Include/cpython/pystate.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104552/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104552/files#diff-fefbbf791abe2a1b6d9cab39778d388ebb9135eeefbd734e463aac75d1979e7f
https://github.com/python/cpython/pull/104552/files#diff-fefbbf791abe2a1b6d9cab39778d388ebb9135eeefbd734e463aac75d1979e7f
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L317
Include/internal/pycore_interp.hhttps://github.com/python/cpython/pull/104552/files#diff-cb06b7ba43789a1d6ae5bef46baa8a255b72dbcd2b44bfec7f146ea4e94dbfa0
View file https://github.com/ericsnowcurrently/cpython/blob/86e5d821b0911019b25b284d28e19efeeb19debe/Include/internal/pycore_interp.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104552/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104552/files#diff-cb06b7ba43789a1d6ae5bef46baa8a255b72dbcd2b44bfec7f146ea4e94dbfa0
https://github.com/python/cpython/pull/104552/files#diff-cb06b7ba43789a1d6ae5bef46baa8a255b72dbcd2b44bfec7f146ea4e94dbfa0
Lib/threading.pyhttps://github.com/python/cpython/pull/104552/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
View file https://github.com/ericsnowcurrently/cpython/blob/86e5d821b0911019b25b284d28e19efeeb19debe/Lib/threading.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104552/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104552/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104552/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104552/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104552/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104552/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/104552/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
Please reload this pagehttps://github.com/python/cpython/pull/104552/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.