René's URL Explorer Experiment


Title: gh-104341: Clean Up threading Module by ericsnowcurrently · Pull Request #104552 · python/cpython · GitHub

Open Graph Title: gh-104341: Clean Up threading Module by ericsnowcurrently · Pull Request #104552 · python/cpython

X Title: gh-104341: Clean Up threading Module by ericsnowcurrently · Pull Request #104552 · python/cpython

Description: To fix gh-104341, we need to change the threading module to utilize two locks for each thread: one for if it running (for join()) and one for its overall lifetime, on which Py_EndInterpreter() will...

Open Graph Description: To fix gh-104341, we need to change the threading module to utilize two locks for each thread: one for if it running (for join()) and one for its overall lifetime, on which Py_EndInterpreter() will...

X Description: To fix gh-104341, we need to change the threading module to utilize two locks for each thread: one for if it running (for join()) and one for its overall lifetime, on which Py_EndInterpreter() will...

Opengraph URL: https://github.com/python/cpython/pull/104552

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ba669851-30fb-7107-79a2-bc8d6132951c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8C2:23762:3D8A10:529F2D:69697D4C
html-safe-nonce9afb68da6be41172e09ddc4926dca676d5642f9fc27cc972c854c05a50d096da
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEMyOjIzNzYyOjNEOEExMDo1MjlGMkQ6Njk2OTdENEMiLCJ2aXNpdG9yX2lkIjoiNjU3MzU4MjI2NzMxOTk0MjQ3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac611f0373ec588aa35748fda0ee32a6fe5a79759bf4692388594048a4bd84fbb8
hovercard-subject-tagpull_request:1352612642
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104552/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/919b6a7524415fd4e190ec6c52405468e2e9e8c7e9144dfd12942c6ab4dd1a7e/python/cpython/pull/104552
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/919b6a7524415fd4e190ec6c52405468e2e9e8c7e9144dfd12942c6ab4dd1a7e/python/cpython/pull/104552
og:image:altTo fix gh-104341, we need to change the threading module to utilize two locks for each thread: one for if it running (for join()) and one for its overall lifetime, on which Py_EndInterpreter() will...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericsnowcurrently
hostnamegithub.com
expected-hostnamegithub.com
Nonef33e4b94c8824ab2b434d82a94139432fb5ebee9df4b75304140ad22508c4a77
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release48f380098b30acbb700b04f1724481ca10d574fc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104552#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104552
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104552
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104552
Reloadhttps://github.com/python/cpython/pull/104552
Reloadhttps://github.com/python/cpython/pull/104552
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104552
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104552
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/104552#issue-comment-box
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:clean-up-threading-modulehttps://github.com/ericsnowcurrently/cpython/tree/clean-up-threading-module
gh-104341: Clean Up threading Module https://github.com/python/cpython/pull/104552#top
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:clean-up-threading-modulehttps://github.com/ericsnowcurrently/cpython/tree/clean-up-threading-module
Conversation 2 https://github.com/python/cpython/pull/104552
Commits 12 https://github.com/python/cpython/pull/104552/commits
Checks 0 https://github.com/python/cpython/pull/104552/checks
Files changed https://github.com/python/cpython/pull/104552/files
Please reload this pagehttps://github.com/python/cpython/pull/104552
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 16, 2023https://github.com/python/cpython/pull/104552#issue-1712139706
gh-104341https://github.com/python/cpython/issues/104341
Please reload this pagehttps://github.com/python/cpython/pull/104552
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 15, 2023 14:23https://github.com/python/cpython/pull/104552#commits-pushed-b3474f3
https://github.com/ericsnowcurrently
Drop bootstate.interp and bootstate.runtime.https://github.com/python/cpython/pull/104552/commits/b3474f3d65b9e7078ebbf6ca71abad8ee01d5fdd
b3474f3https://github.com/python/cpython/pull/104552/commits/b3474f3d65b9e7078ebbf6ca71abad8ee01d5fdd
https://github.com/ericsnowcurrently
Add module-owned threads to module state.https://github.com/python/cpython/pull/104552/commits/ec9f53b15429d8183444144aaa580949c4abc328
ec9f53bhttps://github.com/python/cpython/pull/104552/commits/ec9f53b15429d8183444144aaa580949c4abc328
https://github.com/ericsnowcurrently
Call on_delete() in remove_module_thread().https://github.com/python/cpython/pull/104552/commits/05aa205de5d944edfee1116bb8b7a6447c19a73b
05aa205https://github.com/python/cpython/pull/104552/commits/05aa205de5d944edfee1116bb8b7a6447c19a73b
https://github.com/ericsnowcurrently
Drop interp.threads.count.https://github.com/python/cpython/pull/104552/commits/da85eeda70a3c051d3203b36bd9627eee66e4ebe
da85eedhttps://github.com/python/cpython/pull/104552/commits/da85eeda70a3c051d3203b36bd9627eee66e4ebe
https://github.com/ericsnowcurrently
Pass module_state to newlockobject().https://github.com/python/cpython/pull/104552/commits/004589be6d8489c2b75cac5c908e5fdd96cf09ef
004589bhttps://github.com/python/cpython/pull/104552/commits/004589be6d8489c2b75cac5c908e5fdd96cf09ef
https://github.com/ericsnowcurrently
Create the thread lock in threading.py.https://github.com/python/cpython/pull/104552/commits/aa4d3bb0cef8a1cc7b9e6e9fac9fe3eae669c854
aa4d3bbhttps://github.com/python/cpython/pull/104552/commits/aa4d3bb0cef8a1cc7b9e6e9fac9fe3eae669c854
https://github.com/ericsnowcurrently
Re-initialize the module threads lock upon fork.https://github.com/python/cpython/pull/104552/commits/82ff2ba965113b5417c8fcd3af1a07e0e6f4eae1
82ff2bahttps://github.com/python/cpython/pull/104552/commits/82ff2ba965113b5417c8fcd3af1a07e0e6f4eae1
https://github.com/ericsnowcurrently
Add module_thread.running_lock.https://github.com/python/cpython/pull/104552/commits/a19c68400c24bbe92a3e1bba5cb9fd3ab774512a
a19c684https://github.com/python/cpython/pull/104552/commits/a19c68400c24bbe92a3e1bba5cb9fd3ab774512a
https://github.com/ericsnowcurrently
Be more specific in _wait_for_tstate_lock().https://github.com/python/cpython/pull/104552/commits/de530b173522da45ecc6e0520915581d01eabe54
de530b1https://github.com/python/cpython/pull/104552/commits/de530b173522da45ecc6e0520915581d01eabe54
https://github.com/ericsnowcurrently
Fix _set_sentinel().https://github.com/python/cpython/pull/104552/commits/e2c7058abee4cd85c8d9e2773ec336edfe799267
e2c7058https://github.com/python/cpython/pull/104552/commits/e2c7058abee4cd85c8d9e2773ec336edfe799267
https://github.com/ericsnowcurrently
Track the "main" thread too.https://github.com/python/cpython/pull/104552/commits/0d30811396885f89deb94d8083bb4be980c19a6a
0d30811https://github.com/python/cpython/pull/104552/commits/0d30811396885f89deb94d8083bb4be980c19a6a
https://github.com/ericsnowcurrently
Drop tstate->on_delete.https://github.com/python/cpython/pull/104552/commits/86e5d821b0911019b25b284d28e19efeeb19debe
86e5d82https://github.com/python/cpython/pull/104552/commits/86e5d821b0911019b25b284d28e19efeeb19debe
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
May 16, 2023https://github.com/python/cpython/pull/104552#event-9258849507
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 16, 2023https://github.com/python/cpython/pull/104552#event-9258850230
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 16, 2023 https://github.com/python/cpython/pull/104552#ref-issue-1702834661
test__xxsubinterpreters is Occasionally Crashing #104341 https://github.com/python/cpython/issues/104341
https://github.com/Eclips4
Eclips4https://github.com/Eclips4
May 16, 2023 https://github.com/python/cpython/pull/104552#pullrequestreview-1428756533
View reviewed changes https://github.com/python/cpython/pull/104552/files/86e5d821b0911019b25b284d28e19efeeb19debe
Modules/_threadmodule.chttps://github.com/python/cpython/pull/104552/files/86e5d821b0911019b25b284d28e19efeeb19debe#diff-23071700ee893f365a4c117210b9129d4ac6afe5cc6e52bb5cd4cabbc6816e07
Eclips4https://github.com/Eclips4
May 16, 2023https://github.com/python/cpython/pull/104552#discussion_r1195276613
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104552
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 16, 2023https://github.com/python/cpython/pull/104552#issuecomment-1549907262
Please reload this pagehttps://github.com/python/cpython/pull/104552
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 16, 2023https://github.com/python/cpython/pull/104552#event-9259669898
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104552
https://github.com/Eclips4
Eclips4 https://github.com/Eclips4
https://github.com/python/cpython/pull/104552/files/86e5d821b0911019b25b284d28e19efeeb19debe
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
test__xxsubinterpreters is Occasionally Crashing https://github.com/python/cpython/issues/104341
Please reload this pagehttps://github.com/python/cpython/pull/104552
https://github.com/ericsnowcurrently
https://github.com/Eclips4
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.