| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d31e6d8b-e2bf-5742-e941-e13f70a89788 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DF8C:383777:819EB8E:B5AF6C1:6A504B7C |
| html-safe-nonce | b949a0bd9bde50784409392eb63f972a21789a045ca96425607f3c35f20d91b2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjhDOjM4Mzc3Nzo4MTlFQjhFOkI1QUY2QzE6NkE1MDRCN0MiLCJ2aXNpdG9yX2lkIjoiNTgzNTcyNDY4ODUyMTcxMDQ2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d026498d7672bca0a513ddb4ac4546256b97f4c4e13f32fe4285c93ec74f978e |
| hovercard-subject-tag | pull_request:229915112 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/10454/files |
| twitter:image | https://avatars.githubusercontent.com/u/532281?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/532281?s=400&v=4 |
| og:image:alt | This also cleans up and improves the testing of count_lines(), which has been significantly changed as part of this optimization.
https://bugs.python.org/issue35196 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5741a45fe07e5f377d0d4c524a92e3056acc51bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/10454/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10454%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F10454%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/10454/files |
| Reload | https://github.com/python/cpython/pull/10454/files |
| Reload | https://github.com/python/cpython/pull/10454/files |
| Please reload this page | https://github.com/python/cpython/pull/10454/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/10454/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| taleinat | https://github.com/taleinat |
| python:master | https://github.com/python/cpython/tree/master |
| taleinat:bpo-35196/optimize_squeezer_write | https://github.com/taleinat/cpython/tree/bpo-35196/optimize_squeezer_write |
|
Conversation
50
| https://github.com/python/cpython/pull/10454 |
|
Commits
26
| https://github.com/python/cpython/pull/10454/commits |
|
Checks
0
| https://github.com/python/cpython/pull/10454/checks |
|
Files changed
| https://github.com/python/cpython/pull/10454/files |
| Please reload this page | https://github.com/python/cpython/pull/10454/files |
|
bpo-35196: optimize Squeezer's write() interception
| https://github.com/python/cpython/pull/10454/files#top |
|
Show all changes
26 commits
| https://github.com/python/cpython/pull/10454/files |
|
2525992
bpo-35196: optimize Squeezer's write() interception
taleinat Nov 10, 2018
| https://github.com/python/cpython/pull/10454/commits/25259921eab001ec8620a7ba46aaf47917ac9965 |
|
6b60df6
remove dead, old test code from test_squeezer.py
taleinat Nov 10, 2018
| https://github.com/python/cpython/pull/10454/commits/6b60df6e2625a69d5daeb02aee65b15d6633e7fb |
|
0e30a72
bpo-35196: fix test_reload() failing
taleinat Nov 11, 2018
| https://github.com/python/cpython/pull/10454/commits/0e30a72e1a59df0ff193ad3b12a526cd41b55523 |
|
76e8ea2
remove unnecessary additional check which doesn't improve performance
taleinat Dec 24, 2018
| https://github.com/python/cpython/pull/10454/commits/76e8ea271adf34e5a05672b9d407851fa033d856 |
|
65ee056
instantiate Squeezer only on PyShell windows
taleinat Dec 24, 2018
| https://github.com/python/cpython/pull/10454/commits/65ee0565f4b0b05c5cf3bdc9e6eaa5e35cd00798 |
|
485d954
hard-code tab width to 8 (always true for IDLE's shell)
taleinat Dec 24, 2018
| https://github.com/python/cpython/pull/10454/commits/485d954a3bb2d2e23fed6dcb9beaf13b464ce131 |
|
22f1c4f
Merge remote-tracking branch 'origin/master' into pr_10454
terryjreedy Dec 27, 2018
| https://github.com/python/cpython/pull/10454/commits/22f1c4fd03d5eb234598a548af49e0c57cd72839 |
|
5f0e69f
Add blurb and idlelib news.
terryjreedy Dec 27, 2018
| https://github.com/python/cpython/pull/10454/commits/5f0e69fda6dc73a70e0408ce5398eff2d3dec3a2 |
|
23af040
Condense character width comment and update to 8.6.
terryjreedy Dec 27, 2018
| https://github.com/python/cpython/pull/10454/commits/23af0403709fe67e1205c65225556b3a1dd8f7a0 |
|
8a4ca02
In test, change deprecated assertEquals to assertEqual.
terryjreedy Dec 27, 2018
| https://github.com/python/cpython/pull/10454/commits/8a4ca02160b4ef8f77b5c48aed555ccdc8323ae5 |
|
1f56ee8
Add coverage information. Details in comment.
terryjreedy Dec 28, 2018
| https://github.com/python/cpython/pull/10454/commits/1f56ee8000414ec2d76b11deba9ed04c0a087388 |
|
390d089
Add X windows comment.
terryjreedy Dec 28, 2018
| https://github.com/python/cpython/pull/10454/commits/390d0899a13442eaa2e54f8a02000770df339a85 |
|
8e12a81
Move PyShell only code to pyshell.PyShell.
terryjreedy Dec 28, 2018
| https://github.com/python/cpython/pull/10454/commits/8e12a8169d9b16336a07b2b723e2d99769860269 |
|
ee25bac
Use existing local reference.
terryjreedy Dec 28, 2018
| https://github.com/python/cpython/pull/10454/commits/ee25bac1684e766a32901c0c8e6ae63686d2be4e |
|
9ac5156
Fix comments (# Cap ... length ... end.) in squeezer.py.
terryjreedy Dec 28, 2018
| https://github.com/python/cpython/pull/10454/commits/9ac5156ea72636a94ee173e66b4584e083bf282f |
|
6e1556d
Fix comments in test_squeezer to PEP standards. Uncomment test
terryjreedy Dec 28, 2018
| https://github.com/python/cpython/pull/10454/commits/6e1556dc7bc3d96633eb3bc94b7b7ad2fb43b79e |
|
2f0e0a5
fix bug in setting Squeezer._instance_weakref and improve test coverage
taleinat Jan 3, 2019
| https://github.com/python/cpython/pull/10454/commits/2f0e0a5b53b33676c45f1d13c1e60f51cff08717 |
|
37daa8a
add a do-nothing test case for Squeezer.reload(), and fix test cleanup
taleinat Jan 3, 2019
| https://github.com/python/cpython/pull/10454/commits/37daa8a517eb287a810fc47895a187948742e8f5 |
|
62ca6d3
re-format inline comments
taleinat Jan 3, 2019
| https://github.com/python/cpython/pull/10454/commits/62ca6d38a06b2462fb4eaf895aa3506607ed8595 |
|
3f77905
Update test_squeezer, trigger retest
terryjreedy Jan 11, 2019
| https://github.com/python/cpython/pull/10454/commits/3f7790564f0cd71d6081d516ceaf5edb7523847f |
|
17bc8d9
Reverse asssertions to test 2nd
terryjreedy Jan 11, 2019
| https://github.com/python/cpython/pull/10454/commits/17bc8d99caf33bc3f5e17e4b74684e99273f57b2 |
|
69eaa4f
Change taked to taken
terryjreedy Jan 12, 2019
| https://github.com/python/cpython/pull/10454/commits/69eaa4fd39f9eb1f61150d609eddb8c35052a137 |
|
3c3fb9d
fix test_reload() check that zero_with_char has increased
taleinat Jan 12, 2019
| https://github.com/python/cpython/pull/10454/commits/3c3fb9de29442944e4e47f72e5d4820ac634e50e |
|
05543b0
Change 'name' to 'font' in load_font Font().
terryjreedy Jan 12, 2019
| https://github.com/python/cpython/pull/10454/commits/05543b0791aa44945e25c7dba7898e5082766c59 |
|
66c01e5
Reset font size by resetting font option.
terryjreedy Jan 12, 2019
| https://github.com/python/cpython/pull/10454/commits/66c01e5c94414adb3c7796b61cc7e0f4d65aa7a2 |
|
ae8a483
minor code cleanup in Squeezer's mywrite()
taleinat Jan 13, 2019
| https://github.com/python/cpython/pull/10454/commits/ae8a483615ed254084255ca4c67c95c0b890f092 |
|
Clear filters
| https://github.com/python/cpython/pull/10454/files |
| Please reload this page | https://github.com/python/cpython/pull/10454/files |
| Please reload this page | https://github.com/python/cpython/pull/10454/files |
|
NEWS.txt
| https://github.com/python/cpython/pull/10454/files#diff-58ad78c6c9bd40472cf2060280dadce5e6b2fa117eabbc42f053390dfaaf3d12 |
|
editor.py
| https://github.com/python/cpython/pull/10454/files#diff-0ebe4cdabcc123ccaae0e7cb5fcc54423a11b82957a8f972db70e98a1e847ae4 |
|
test_squeezer.py
| https://github.com/python/cpython/pull/10454/files#diff-afb0b76aac5e2c839ebbb7a74a6564b967b342c06254754b1da18ab0d44de58a |
|
pyshell.py
| https://github.com/python/cpython/pull/10454/files#diff-f6ced3d8ba872fb8904aa7cf07512890be864c5b00ae0ccf3d0c3edff0a03567 |
|
squeezer.py
| https://github.com/python/cpython/pull/10454/files#diff-486b6b07195bce1d36671cf788223d59dfacb9ded857a267295baf09cae1a29f |
|
2018-12-27-17-46-42.bpo-35196.9E-xUh.rst
| https://github.com/python/cpython/pull/10454/files#diff-0a5f7cc3dbce577da9eecd6718bacf4b94f33b426aee1dd282439aa8f9d35fcb |
| Lib/idlelib/NEWS.txt | https://github.com/python/cpython/pull/10454/files#diff-58ad78c6c9bd40472cf2060280dadce5e6b2fa117eabbc42f053390dfaaf3d12 |
|
View file
| https://github.com/taleinat/cpython/blob/ae8a483615ed254084255ca4c67c95c0b890f092/Lib/idlelib/NEWS.txt |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/10454/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/10454/files#diff-58ad78c6c9bd40472cf2060280dadce5e6b2fa117eabbc42f053390dfaaf3d12 |
|
| https://github.com/python/cpython/pull/10454/files#diff-58ad78c6c9bd40472cf2060280dadce5e6b2fa117eabbc42f053390dfaaf3d12 |
| Lib/idlelib/editor.py | https://github.com/python/cpython/pull/10454/files#diff-0ebe4cdabcc123ccaae0e7cb5fcc54423a11b82957a8f972db70e98a1e847ae4 |
|
View file
| https://github.com/taleinat/cpython/blob/ae8a483615ed254084255ca4c67c95c0b890f092/Lib/idlelib/editor.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/10454/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/10454/files#diff-0ebe4cdabcc123ccaae0e7cb5fcc54423a11b82957a8f972db70e98a1e847ae4 |
|
| https://github.com/python/cpython/pull/10454/files#diff-0ebe4cdabcc123ccaae0e7cb5fcc54423a11b82957a8f972db70e98a1e847ae4 |
| Please reload this page | https://github.com/python/cpython/pull/10454/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |