René's URL Explorer Experiment


Title: gh-64595: Fix write file logic in Argument Clinic by erlend-aasland · Pull Request #104507 · python/cpython · GitHub

Open Graph Title: gh-64595: Fix write file logic in Argument Clinic by erlend-aasland · Pull Request #104507 · python/cpython

X Title: gh-64595: Fix write file logic in Argument Clinic by erlend-aasland · Pull Request #104507 · python/cpython

Description: Check if any clinic output actually changes any of the output files before deciding if we should touch the source file. This needs to be done before we eventually update the source file. Issue: A...

Open Graph Description: Check if any clinic output actually changes any of the output files before deciding if we should touch the source file. This needs to be done before we eventually update the source file. Issue: A...

X Description: Check if any clinic output actually changes any of the output files before deciding if we should touch the source file. This needs to be done before we eventually update the source file. Issue: A...

Opengraph URL: https://github.com/python/cpython/pull/104507

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b9ec4d41-3c4d-5133-af32-390e2d518165
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8208:6FE17:1F818B5:2BE5F0A:69693634
html-safe-noncecc0e9b074b051b059e7c931b01508ee2b71f31031f9379dfb104384b401e587d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjA4OjZGRTE3OjFGODE4QjU6MkJFNUYwQTo2OTY5MzYzNCIsInZpc2l0b3JfaWQiOiIzMDQwMDM2MzgxMzk2NjQ1NDI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3993bb59cb40244a28d2e5deb60653e78b2ceef12a46fbe1a2755828f1b43508
hovercard-subject-tagpull_request:1350766064
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104507/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/831297eaa52a4d84912743db69c4b0c8874e44f3a050303af68f12557307d253/python/cpython/pull/104507
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/831297eaa52a4d84912743db69c4b0c8874e44f3a050303af68f12557307d253/python/cpython/pull/104507
og:image:altCheck if any clinic output actually changes any of the output files before deciding if we should touch the source file. This needs to be done before we eventually update the source file. Issue: A...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerlend-aasland
hostnamegithub.com
expected-hostnamegithub.com
None54182691a21263b584d2e600b758e081b0ff1d10ffc0d2eefa51cf754b43b51d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released69ac0477df0f87da03b8b06cebd187012d7a930
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104507#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104507
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104507
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104507
Reloadhttps://github.com/python/cpython/pull/104507
Reloadhttps://github.com/python/cpython/pull/104507
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104507
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104507
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/104507#issue-comment-box
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:clinic-dont-touch-everythinghttps://github.com/erlend-aasland/cpython/tree/clinic-dont-touch-everything
gh-64595: Fix write file logic in Argument Clinic https://github.com/python/cpython/pull/104507#top
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:clinic-dont-touch-everythinghttps://github.com/erlend-aasland/cpython/tree/clinic-dont-touch-everything
Conversation 2 https://github.com/python/cpython/pull/104507
Commits 2 https://github.com/python/cpython/pull/104507/commits
Checks 0 https://github.com/python/cpython/pull/104507/checks
Files changed https://github.com/python/cpython/pull/104507/files
Please reload this pagehttps://github.com/python/cpython/pull/104507
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
May 15, 2023https://github.com/python/cpython/pull/104507#issue-1710056958
Please reload this pagehttps://github.com/python/cpython/pull/104507
Argument Clinic: Touch source file if any output file changed #64595https://github.com/python/cpython/issues/64595
Please reload this pagehttps://github.com/python/cpython/pull/104507
https://github.com/erlend-aasland
pythongh-64595https://github.com/python/cpython/issues/64595
: Fix write file logic in Argument Clinichttps://github.com/python/cpython/pull/104507/commits/15bf463f6722646a34a730a2de99ecbadb88503b
15bf463https://github.com/python/cpython/pull/104507/commits/15bf463f6722646a34a730a2de99ecbadb88503b
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
May 15, 2023https://github.com/python/cpython/pull/104507#event-9246421852
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 15, 2023https://github.com/python/cpython/pull/104507#event-9246422676
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 15, 2023 https://github.com/python/cpython/pull/104507#ref-issue-1198913487
Argument Clinic: Touch source file if any output file changed #64595 https://github.com/python/cpython/issues/64595
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
hauntsaninjahttps://github.com/hauntsaninja
May 15, 2023 13:03https://github.com/python/cpython/pull/104507#event-9246426733
https://github.com/erlend-aasland
Alternative implementationhttps://github.com/python/cpython/pull/104507/commits/2a20f908c6b26969a9e76135604a35a7b84d4ccc
2a20f90https://github.com/python/cpython/pull/104507/commits/2a20f908c6b26969a9e76135604a35a7b84d4ccc
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
May 15, 2023https://github.com/python/cpython/pull/104507#issuecomment-1547836111
2a20f90https://github.com/python/cpython/commit/2a20f908c6b26969a9e76135604a35a7b84d4ccc
Please reload this pagehttps://github.com/python/cpython/pull/104507
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
cca90b6https://github.com/python/cpython/commit/cca90b690679ed62a689b7867e83776b15c8a5e8
May 16, 2023https://github.com/python/cpython/pull/104507#event-9256320758
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 16, 2023https://github.com/python/cpython/pull/104507#event-9256321323
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
May 16, 2023 10:25https://github.com/python/cpython/pull/104507#event-9256321453
carljmhttps://github.com/carljm
May 16, 2023 https://github.com/python/cpython/pull/104507#ref-commit-a6dd626
https://github.com/carljm
Merge branch 'main' into supermonhttps://github.com/carljm/cpython/commit/a6dd62626507a149e20e7c28f46bfe8bf03b56d9
a6dd626https://github.com/carljm/cpython/commit/a6dd62626507a149e20e7c28f46bfe8bf03b56d9
pythonGH-104510https://github.com/python/cpython/issues/104510
python#104516https://github.com/python/cpython/pull/104516
pythongh-104539https://github.com/python/cpython/issues/104539
python#104545https://github.com/python/cpython/pull/104545
pythongh-104050https://github.com/python/cpython/issues/104050
python#104543https://github.com/python/cpython/pull/104543
pythongh-104050https://github.com/python/cpython/issues/104050
python#104538https://github.com/python/cpython/pull/104538
pythongh-64595https://github.com/python/cpython/issues/64595
python#104507https://github.com/python/cpython/pull/104507
pythongh-104523https://github.com/python/cpython/issues/104523
python#104524https://github.com/python/cpython/pull/104524
pythongh-103861https://github.com/python/cpython/issues/103861
python#103863https://github.com/python/cpython/pull/103863
pythongh-69152https://github.com/python/cpython/issues/69152
python#104248https://github.com/python/cpython/pull/104248
pythongh-103763https://github.com/python/cpython/issues/103763
python#103764https://github.com/python/cpython/pull/103764
pythongh-104461https://github.com/python/cpython/issues/104461
pythonGH-104462https://github.com/python/cpython/pull/104462
pythongh-104469https://github.com/python/cpython/issues/104469
python#104503https://github.com/python/cpython/pull/104503
pythongh-104482https://github.com/python/cpython/issues/104482
python#104483https://github.com/python/cpython/pull/104483
pythongh-104341https://github.com/python/cpython/issues/104341
pythongh-104437https://github.com/python/cpython/pull/104437
pythonGH-102613https://github.com/python/cpython/issues/102613
pythonGH-104373https://github.com/python/cpython/pull/104373
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 5, 2023 https://github.com/python/cpython/pull/104507#ref-pullrequest-1789173725
gh-64595: Fix regression in file write logic in Argument Clinic #106449 https://github.com/python/cpython/pull/106449
erlend-aaslandhttps://github.com/erlend-aasland
Jul 5, 2023 https://github.com/python/cpython/pull/104507#ref-commit-6f5936a
https://github.com/erlend-aasland
pythongh-64595https://github.com/python/cpython/issues/64595
: Fix regression in file write logic in Argument Clinichttps://github.com/erlend-aasland/cpython/commit/6f5936a2919e61c4f4445a8c5b716682baf4efd3
6f5936ahttps://github.com/erlend-aasland/cpython/commit/6f5936a2919e61c4f4445a8c5b716682baf4efd3
pythongh-104152https://github.com/python/cpython/pull/104152
pythongh-104507https://github.com/python/cpython/pull/104507
ambvhttps://github.com/ambv
Jul 5, 2023 https://github.com/python/cpython/pull/104507#ref-commit-9d1d4f9
https://github.com/erlend-aasland
gh-64595https://github.com/python/cpython/issues/64595
: Fix regression in file write logic in Argument Clinic (https://github.com/python/cpython/commit/9d1d4f9c73a71192b22ab52a2eb9278737f98ddb
#106449https://github.com/python/cpython/pull/106449
9d1d4f9https://github.com/python/cpython/commit/9d1d4f9c73a71192b22ab52a2eb9278737f98ddb
https://github.com/python/cpython/pull/106449
gh-104152https://github.com/python/cpython/pull/104152
gh-104507https://github.com/python/cpython/pull/104507
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jul 5, 2023 https://github.com/python/cpython/pull/104507#ref-pullrequest-1789480009
[3.12] gh-64595: Fix regression in file write logic in Argument Clinic (#106449) #106452 https://github.com/python/cpython/pull/106452
erlend-aaslandhttps://github.com/erlend-aasland
Jul 5, 2023 https://github.com/python/cpython/pull/104507#ref-commit-b02430a
https://github.com/erlend-aasland
[3.12]https://github.com/erlend-aasland/cpython/commit/b02430adf923f7dda46fff34bf1e8f168fc74e99
pythongh-64595https://github.com/python/cpython/issues/64595
: Fix regression in file write logic in Argument…https://github.com/erlend-aasland/cpython/commit/b02430adf923f7dda46fff34bf1e8f168fc74e99
b02430ahttps://github.com/erlend-aasland/cpython/commit/b02430adf923f7dda46fff34bf1e8f168fc74e99
python#106449https://github.com/python/cpython/pull/106449
pythongh-104152https://github.com/python/cpython/pull/104152
pythongh-104507https://github.com/python/cpython/pull/104507
9d1d4f9https://github.com/erlend-aasland/cpython/commit/9d1d4f9c73a71192b22ab52a2eb9278737f98ddb
erlend-aaslandhttps://github.com/erlend-aasland
Jul 5, 2023 https://github.com/python/cpython/pull/104507#ref-commit-b72601e
https://github.com/erlend-aasland
[3.12]https://github.com/python/cpython/commit/b72601e7e5a8e3286b1345ac14fa21ac2d3056dc
gh-64595https://github.com/python/cpython/issues/64595
: Fix regression in file write logic in Argument Clinic (https://github.com/python/cpython/commit/b72601e7e5a8e3286b1345ac14fa21ac2d3056dc
b72601ehttps://github.com/python/cpython/commit/b72601e7e5a8e3286b1345ac14fa21ac2d3056dc
#106449https://github.com/python/cpython/pull/106449
#106452https://github.com/python/cpython/pull/106452
gh-104152https://github.com/python/cpython/pull/104152
gh-104507https://github.com/python/cpython/pull/104507
9d1d4f9https://github.com/python/cpython/commit/9d1d4f9c73a71192b22ab52a2eb9278737f98ddb
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jan 12, 2024https://github.com/python/cpython/pull/104507#issuecomment-1889387763
#113317https://github.com/python/cpython/issues/113317
Please reload this pagehttps://github.com/python/cpython/pull/104507
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104507
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/104507
https://github.com/erlend-aasland
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.