René's URL Explorer Experiment


Title: gh-104377: fix cell in comprehension that is free in outer scope by carljm · Pull Request #104394 · python/cpython · GitHub

Open Graph Title: gh-104377: fix cell in comprehension that is free in outer scope by carljm · Pull Request #104394 · python/cpython

X Title: gh-104377: fix cell in comprehension that is free in outer scope by carljm · Pull Request #104394 · python/cpython

Description: Fix the case where a comprehension wraps its iteration variable in a cell inside the comprehension (i.e. it's used in a lambda's closure), but that same variable name is free in the outer scope. Also added a few tests for explicit globals (none of these cases required fixes) and verified that now every possible combination of inner and outer scope is tested. Also fixed accidental namespace reuse in listcomps test harness, which revealed that two existing tests should not have been passing (and should not pass) when run in class scope; run these tests only in module and function scope. Fixes #104377. Issue: gh-104377

Open Graph Description: Fix the case where a comprehension wraps its iteration variable in a cell inside the comprehension (i.e. it's used in a lambda's closure), but that same variable name is free in the outer s...

X Description: Fix the case where a comprehension wraps its iteration variable in a cell inside the comprehension (i.e. it's used in a lambda's closure), but that same variable name is free in the...

Opengraph URL: https://github.com/python/cpython/pull/104394

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ebb80dee-42e4-4ec4-7aba-573b4ddcb034
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E18:1FC3E6:A84716:ECADCE:696A1C80
html-safe-nonce833cfe44d866f7e7555461096c9e480c849297bbbeb99bde2b36948c193f8251
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTE4OjFGQzNFNjpBODQ3MTY6RUNBRENFOjY5NkExQzgwIiwidmlzaXRvcl9pZCI6IjMxMTg4MTI4NDE4ODM4NjgyODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacab8ec23b13f0f3921aee3699259affa54a63c4f628248da0a85db8da176f225d
hovercard-subject-tagpull_request:1347324011
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/104394/files
twitter:imagehttps://avatars.githubusercontent.com/u/61586?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/61586?s=400&v=4
og:image:altFix the case where a comprehension wraps its iteration variable in a cell inside the comprehension (i.e. it's used in a lambda's closure), but that same variable name is free in the outer s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released515f6f09fa57a93bf90355cb894eb84ca4f458f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104394/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104394%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104394%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104394/files
Reloadhttps://github.com/python/cpython/pull/104394/files
Reloadhttps://github.com/python/cpython/pull/104394/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104394/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104394/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
carljm:segfaulthttps://github.com/carljm/cpython/tree/segfault
Conversation 1 https://github.com/python/cpython/pull/104394
Commits 1 https://github.com/python/cpython/pull/104394/commits
Checks 0 https://github.com/python/cpython/pull/104394/checks
Files changed https://github.com/python/cpython/pull/104394/files
Please reload this pagehttps://github.com/python/cpython/pull/104394/files
gh-104377: fix cell in comprehension that is free in outer scope https://github.com/python/cpython/pull/104394/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/104394/files
cb8a531 gh-104377: fix cell in comprehension that is free outside carljm May 11, 2023 https://github.com/python/cpython/pull/104394/commits/cb8a531d4c67f2502e380cb27f890b9a7b0ebd36
Clear filters https://github.com/python/cpython/pull/104394/files
Please reload this pagehttps://github.com/python/cpython/pull/104394/files
Please reload this pagehttps://github.com/python/cpython/pull/104394/files
test_listcomps.py https://github.com/python/cpython/pull/104394/files#diff-6f30ce607962fa738e784af87142b4bb73d48160a1f354eea2cbf31a5bcb310a
compile.c https://github.com/python/cpython/pull/104394/files#diff-ebc983d9f91e5bcf73500e377ac65e85863c4f77fd5b6b6caf4fcdf7c0f0b057
Lib/test/test_listcomps.pyhttps://github.com/python/cpython/pull/104394/files#diff-6f30ce607962fa738e784af87142b4bb73d48160a1f354eea2cbf31a5bcb310a
View file https://github.com/carljm/cpython/blob/cb8a531d4c67f2502e380cb27f890b9a7b0ebd36/Lib/test/test_listcomps.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104394/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104394/files#diff-6f30ce607962fa738e784af87142b4bb73d48160a1f354eea2cbf31a5bcb310a
https://github.com/python/cpython/pull/104394/files#diff-6f30ce607962fa738e784af87142b4bb73d48160a1f354eea2cbf31a5bcb310a
https://github.com/python/cpython/pull/104394/files#diff-6f30ce607962fa738e784af87142b4bb73d48160a1f354eea2cbf31a5bcb310a
https://github.com/python/cpython/pull/104394/files#diff-6f30ce607962fa738e784af87142b4bb73d48160a1f354eea2cbf31a5bcb310a
JelleZijlstrahttps://github.com/JelleZijlstra
May 11, 2023https://github.com/python/cpython/pull/104394/files#r1191782454
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104394/files
https://github.com/python/cpython/pull/104394/files#diff-6f30ce607962fa738e784af87142b4bb73d48160a1f354eea2cbf31a5bcb310a
https://github.com/python/cpython/pull/104394/files#diff-6f30ce607962fa738e784af87142b4bb73d48160a1f354eea2cbf31a5bcb310a
https://github.com/python/cpython/pull/104394/files#diff-6f30ce607962fa738e784af87142b4bb73d48160a1f354eea2cbf31a5bcb310a
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L228
Python/compile.chttps://github.com/python/cpython/pull/104394/files#diff-ebc983d9f91e5bcf73500e377ac65e85863c4f77fd5b6b6caf4fcdf7c0f0b057
View file https://github.com/carljm/cpython/blob/cb8a531d4c67f2502e380cb27f890b9a7b0ebd36/Python/compile.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104394/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104394/files#diff-ebc983d9f91e5bcf73500e377ac65e85863c4f77fd5b6b6caf4fcdf7c0f0b057
https://github.com/python/cpython/pull/104394/files#diff-ebc983d9f91e5bcf73500e377ac65e85863c4f77fd5b6b6caf4fcdf7c0f0b057
https://github.com/python/cpython/pull/104394/files#diff-ebc983d9f91e5bcf73500e377ac65e85863c4f77fd5b6b6caf4fcdf7c0f0b057
https://github.com/python/cpython/pull/104394/files#diff-ebc983d9f91e5bcf73500e377ac65e85863c4f77fd5b6b6caf4fcdf7c0f0b057
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.