René's URL Explorer Experiment


Title: gh-104357: fix inlined comprehensions that close over iteration var by carljm · Pull Request #104368 · python/cpython · GitHub

Open Graph Title: gh-104357: fix inlined comprehensions that close over iteration var by carljm · Pull Request #104368 · python/cpython

X Title: gh-104357: fix inlined comprehensions that close over iteration var by carljm · Pull Request #104368 · python/cpython

Description: This fixes the case where an inlined comprehension has an internal cellvar (i.e. it creates lambdas that close over the comprehension iteration variable), but the same name is also used a fast-loca...

Open Graph Description: This fixes the case where an inlined comprehension has an internal cellvar (i.e. it creates lambdas that close over the comprehension iteration variable), but the same name is also used a fast-loca...

X Description: This fixes the case where an inlined comprehension has an internal cellvar (i.e. it creates lambdas that close over the comprehension iteration variable), but the same name is also used a fast-loca...

Opengraph URL: https://github.com/python/cpython/pull/104368

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4bb9302d-2680-f907-eac8-5f14d756e311
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8AC:37CCD2:BA70C0:FDE4E4:696AC03E
html-safe-nonce595696b3a59f29f5c2654b066de3f09adbed526741d15250ee986478c53070e0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEFDOjM3Q0NEMjpCQTcwQzA6RkRFNEU0OjY5NkFDMDNFIiwidmlzaXRvcl9pZCI6IjM0NDY0NTQ4ODU5MTU3MzgxNzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5cb96aead99fe83e2e0dad8fd1e738fdd3982d1af01c9115be395e2f968e27a2
hovercard-subject-tagpull_request:1346006114
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104368/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c24c80e595b1094c9a337c1e00f462ea30075d79efe78e4527182ffb07f634ee/python/cpython/pull/104368
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c24c80e595b1094c9a337c1e00f462ea30075d79efe78e4527182ffb07f634ee/python/cpython/pull/104368
og:image:altThis fixes the case where an inlined comprehension has an internal cellvar (i.e. it creates lambdas that close over the comprehension iteration variable), but the same name is also used a fast-loca...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecarljm
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104368#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104368
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104368
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104368
Reloadhttps://github.com/python/cpython/pull/104368
Reloadhttps://github.com/python/cpython/pull/104368
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104368
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104368
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/104368#issue-comment-box
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
carljm:argcellhttps://github.com/carljm/cpython/tree/argcell
gh-104357: fix inlined comprehensions that close over iteration var https://github.com/python/cpython/pull/104368#top
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
carljm:argcellhttps://github.com/carljm/cpython/tree/argcell
Conversation 6 https://github.com/python/cpython/pull/104368
Commits 2 https://github.com/python/cpython/pull/104368/commits
Checks 0 https://github.com/python/cpython/pull/104368/checks
Files changed https://github.com/python/cpython/pull/104368/files
Please reload this pagehttps://github.com/python/cpython/pull/104368
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/carljm
carljmhttps://github.com/carljm
May 10, 2023https://github.com/python/cpython/pull/104368#issue-1704588570
Please reload this pagehttps://github.com/python/cpython/pull/104368
#104357https://github.com/python/cpython/issues/104357
Comprehension inlining: Bug if comprehension contains a lambda #104357https://github.com/python/cpython/issues/104357
Please reload this pagehttps://github.com/python/cpython/pull/104368
https://github.com/carljm
pythongh-104357https://github.com/python/cpython/issues/104357
: fix inlined comprehensions with cellshttps://github.com/python/cpython/pull/104368/commits/a9c5a4f137e98bba14a9100c81da1e1a2e041fd1
a9c5a4fhttps://github.com/python/cpython/pull/104368/commits/a9c5a4f137e98bba14a9100c81da1e1a2e041fd1
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 10, 2023https://github.com/python/cpython/pull/104368#event-9215315298
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 10, 2023 https://github.com/python/cpython/pull/104368#ref-issue-1703912143
Comprehension inlining: Bug if comprehension contains a lambda #104357 https://github.com/python/cpython/issues/104357
https://github.com/carljm
carljmhttps://github.com/carljm
May 10, 2023https://github.com/python/cpython/pull/104368#event-9215317247
https://github.com/carljm
carljmhttps://github.com/carljm
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
May 10, 2023https://github.com/python/cpython/pull/104368#event-9215321990
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 10, 2023 https://github.com/python/cpython/pull/104368#pullrequestreview-1421404885
View reviewed changes https://github.com/python/cpython/pull/104368/files/a9c5a4f137e98bba14a9100c81da1e1a2e041fd1
Lib/test/test_listcomps.pyhttps://github.com/python/cpython/pull/104368/files/a9c5a4f137e98bba14a9100c81da1e1a2e041fd1#diff-6f30ce607962fa738e784af87142b4bb73d48160a1f354eea2cbf31a5bcb310a
Please reload this pagehttps://github.com/python/cpython/pull/104368
https://github.com/carljm
update test to also verify isolationhttps://github.com/python/cpython/pull/104368/commits/b5c8c800364752b9796238252d28e368b6c0eb9d
b5c8c80https://github.com/python/cpython/pull/104368/commits/b5c8c800364752b9796238252d28e368b6c0eb9d
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 11, 2023 https://github.com/python/cpython/pull/104368#pullrequestreview-1421569773
View reviewed changes https://github.com/python/cpython/pull/104368/files/b5c8c800364752b9796238252d28e368b6c0eb9d
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 11, 2023https://github.com/python/cpython/pull/104368#event-9216651710
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
fcd5fb4https://github.com/python/cpython/commit/fcd5fb49b1d71165f3c503c3d2e74a082ddb2f21
May 11, 2023https://github.com/python/cpython/pull/104368#event-9216655296
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 11, 2023https://github.com/python/cpython/pull/104368#event-9216655727
carljmhttps://github.com/carljm
May 11, 2023 https://github.com/python/cpython/pull/104368#ref-commit-19b3d9e
https://github.com/carljm
Merge branch 'main' into supermonhttps://github.com/carljm/cpython/commit/19b3d9ef01efa4c931b0224849bb8eaccd3c9fa6
19b3d9ehttps://github.com/carljm/cpython/commit/19b3d9ef01efa4c931b0224849bb8eaccd3c9fa6
pythongh-87849https://github.com/python/cpython/issues/87849
pythonGH-104268https://github.com/python/cpython/pull/104268
pythongh-101819https://github.com/python/cpython/issues/101819
python#104384https://github.com/python/cpython/pull/104384
pythongh-101819https://github.com/python/cpython/issues/101819
python#104367https://github.com/python/cpython/pull/104367
pythongh-101819https://github.com/python/cpython/issues/101819
python#104369https://github.com/python/cpython/pull/104369
pythongh-101819https://github.com/python/cpython/issues/101819
python#104383https://github.com/python/cpython/pull/104383
pythongh-101117https://github.com/python/cpython/issues/101117
python#104287https://github.com/python/cpython/pull/104287
pythonGH-92184https://github.com/python/cpython/issues/92184
python#92185https://github.com/python/cpython/pull/92185
pythongh-104357https://github.com/python/cpython/issues/104357
python#104368https://github.com/python/cpython/pull/104368
pythonGH-90208https://github.com/python/cpython/issues/90208
pythonGH-104141https://github.com/python/cpython/pull/104141
pythonGH-102181https://github.com/python/cpython/issues/102181
pythonGH-102182https://github.com/python/cpython/pull/102182
pythongh-103000https://github.com/python/cpython/issues/103000
python#104364https://github.com/python/cpython/pull/104364
pythongh-103538https://github.com/python/cpython/issues/103538
pythonGH-103539https://github.com/python/cpython/pull/103539
pythonGH-87695https://github.com/python/cpython/issues/87695
pythonGH-104292https://github.com/python/cpython/pull/104292
pythongh-104263https://github.com/python/cpython/issues/104263
pythonGH-104202https://github.com/python/cpython/pull/104202
pythongh-104010https://github.com/python/cpython/issues/104010
python#104013https://github.com/python/cpython/pull/104013
pythongh-101819https://github.com/python/cpython/issues/101819
python#104355https://github.com/python/cpython/pull/104355
pythongh-103960https://github.com/python/cpython/issues/103960
python#103983https://github.com/python/cpython/pull/103983
pythongh-104252https://github.com/python/cpython/issues/104252
pythongh-104253https://github.com/python/cpython/pull/104253
pythongh-101819https://github.com/python/cpython/issues/101819
pythongh-104197https://github.com/python/cpython/pull/104197
python#104354https://github.com/python/cpython/pull/104354
pythongh-101819https://github.com/python/cpython/issues/101819
python#104352https://github.com/python/cpython/pull/104352
carljmhttps://github.com/carljm
May 11, 2023 https://github.com/python/cpython/pull/104368#ref-commit-4456dd6
https://github.com/carljm
Merge branch 'main' into fixloadsuperspechttps://github.com/carljm/cpython/commit/4456dd6059df588e2542dc29e217aab19ceffc32
4456dd6https://github.com/carljm/cpython/commit/4456dd6059df588e2542dc29e217aab19ceffc32
pythongh-87849https://github.com/python/cpython/issues/87849
pythonGH-104268https://github.com/python/cpython/pull/104268
pythongh-101819https://github.com/python/cpython/issues/101819
python#104384https://github.com/python/cpython/pull/104384
pythongh-101819https://github.com/python/cpython/issues/101819
python#104367https://github.com/python/cpython/pull/104367
pythongh-101819https://github.com/python/cpython/issues/101819
python#104369https://github.com/python/cpython/pull/104369
pythongh-101819https://github.com/python/cpython/issues/101819
python#104383https://github.com/python/cpython/pull/104383
pythongh-101117https://github.com/python/cpython/issues/101117
python#104287https://github.com/python/cpython/pull/104287
pythonGH-92184https://github.com/python/cpython/issues/92184
python#92185https://github.com/python/cpython/pull/92185
pythongh-104357https://github.com/python/cpython/issues/104357
python#104368https://github.com/python/cpython/pull/104368
pythonGH-90208https://github.com/python/cpython/issues/90208
pythonGH-104141https://github.com/python/cpython/pull/104141
https://github.com/carljm
carljmhttps://github.com/carljm
May 12, 2023 https://github.com/python/cpython/pull/104368#ref-pullrequest-1708302115
gh-104404: fix crasher with nested comprehensions plus lambdas #104442 https://github.com/python/cpython/pull/104442
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 22, 2023 https://github.com/python/cpython/pull/104368#ref-issue-1718900863
PPC64LE Fedora Stable Clang 3.x fails test_gdb #104736 https://github.com/python/cpython/issues/104736
https://github.com/carljm
carljmhttps://github.com/carljm
June 16, 2023 17:41https://github.com/python/cpython/pull/104368#event-9554168661
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104368
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/python/cpython/pull/104368/files/b5c8c800364752b9796238252d28e368b6c0eb9d
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Comprehension inlining: Bug if comprehension contains a lambda https://github.com/python/cpython/issues/104357
Please reload this pagehttps://github.com/python/cpython/pull/104368
https://github.com/carljm
https://github.com/JelleZijlstra
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.