| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:fd63e856-ccd2-a248-c5a1-4a0ad8ce6c94 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E926:B07CA:47A9FE:651B76:696A0C7D |
| html-safe-nonce | ed96070256c4f03a58b8b47da7817bd37b7a50e74beaee2360f58b946810b370 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTI2OkIwN0NBOjQ3QTlGRTo2NTFCNzY6Njk2QTBDN0QiLCJ2aXNpdG9yX2lkIjoiNDUzNjkzNzc1MzcwMTEyNTI0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 18167dcb1f5bfed5851009c484722b494f3aff22434e3e9c9c14ce2dc5d62756 |
| hovercard-subject-tag | pull_request:1345205404 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/104355/files |
| twitter:image | https://avatars.githubusercontent.com/u/13780613?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/13780613?s=400&v=4 |
| og:image:alt | Make sure the defining class is passed to all methods,
so we can easily fetch module state from them in the future.
Issue: gh-101819 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7266b2d935baa1c6474b16dd9feaa5ca30607261 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/104355/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104355%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104355%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/104355/files |
| Reload | https://github.com/python/cpython/pull/104355/files |
| Reload | https://github.com/python/cpython/pull/104355/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/104355/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/104355/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| erlend-aasland | https://github.com/erlend-aasland |
| python:main | https://github.com/python/cpython/tree/main |
| erlend-aasland:isolate-io/clinic | https://github.com/erlend-aasland/cpython/tree/isolate-io/clinic |
|
Conversation
14
| https://github.com/python/cpython/pull/104355 |
|
Commits
6
| https://github.com/python/cpython/pull/104355/commits |
|
Checks
0
| https://github.com/python/cpython/pull/104355/checks |
|
Files changed
| https://github.com/python/cpython/pull/104355/files |
| Please reload this page | https://github.com/python/cpython/pull/104355/files |
|
gh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic
| https://github.com/python/cpython/pull/104355/files#top |
|
Show all changes
6 commits
| https://github.com/python/cpython/pull/104355/files |
|
98dd91b
gh-101819: Adapt _io._BufferedIOBase_Type methods to Argument Clinic
erlend-aasland May 10, 2023
| https://github.com/python/cpython/pull/104355/commits/98dd91bf8e2a7122faedbeedd1f842dd1a30b019 |
|
fc14019
Wrap docstrings
erlend-aasland May 10, 2023
| https://github.com/python/cpython/pull/104355/commits/fc1401963d8d0afb99501bf4396bcc1dc89b1f6f |
|
34c3e99
Add missing *args
erlend-aasland May 10, 2023
| https://github.com/python/cpython/pull/104355/commits/34c3e990247b1311a617109735b2670cb139c24b |
|
7c785b3
..but not detach()
erlend-aasland May 10, 2023
| https://github.com/python/cpython/pull/104355/commits/7c785b34a66ef4600970dedbdf0b00798b142069 |
|
28fc57e
Use consistent mood, since we're touching this anyways
erlend-aasland May 10, 2023
| https://github.com/python/cpython/pull/104355/commits/28fc57ea0999822a8d251c8acafdef1fb42abffa |
|
940db40
Address docstring review
erlend-aasland May 10, 2023
| https://github.com/python/cpython/pull/104355/commits/940db40899e984a67c8abb05d83aaaee684a0b13 |
|
Clear filters
| https://github.com/python/cpython/pull/104355/files |
| Please reload this page | https://github.com/python/cpython/pull/104355/files |
| Please reload this page | https://github.com/python/cpython/pull/104355/files |
|
bufferedio.c
| https://github.com/python/cpython/pull/104355/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
bufferedio.c.h
| https://github.com/python/cpython/pull/104355/files#diff-9b822806a1ab112f6eb4d2f83e35fbbfe20779015bfc9a55aa51c748635ce5a2 |
| Modules/_io/bufferedio.c | https://github.com/python/cpython/pull/104355/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
View file
| https://github.com/erlend-aasland/cpython/blob/940db40899e984a67c8abb05d83aaaee684a0b13/Modules/_io/bufferedio.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/104355/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/104355/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
| Please reload this page | https://github.com/python/cpython/pull/104355/files |
| vstinner | https://github.com/vstinner |
| May 11, 2023 | https://github.com/python/cpython/pull/104355/files#r1191067707 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/104355/files |
| erlend-aasland | https://github.com/erlend-aasland |
| May 11, 2023 | https://github.com/python/cpython/pull/104355/files#r1191079740 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/104355/files |
| vstinner | https://github.com/vstinner |
| May 11, 2023 | https://github.com/python/cpython/pull/104355/files#r1191071368 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://docs.python.org/dev/library/io.html#io.BufferedIOBase.read | https://docs.python.org/dev/library/io.html#io.BufferedIOBase.read |
| Please reload this page | https://github.com/python/cpython/pull/104355/files |
| erlend-aasland | https://github.com/erlend-aasland |
| May 11, 2023 | https://github.com/python/cpython/pull/104355/files#r1191076706 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/104355/files |
| Please reload this page | https://github.com/python/cpython/pull/104355/files |
| Please reload this page | https://github.com/python/cpython/pull/104355/files |
|
| https://github.com/python/cpython/pull/104355/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/104355/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
|
| https://github.com/python/cpython/pull/104355/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a |
| Modules/_io/clinic/bufferedio.c.h | https://github.com/python/cpython/pull/104355/files#diff-9b822806a1ab112f6eb4d2f83e35fbbfe20779015bfc9a55aa51c748635ce5a2 |
|
View file
| https://github.com/erlend-aasland/cpython/blob/940db40899e984a67c8abb05d83aaaee684a0b13/Modules/_io/clinic/bufferedio.c.h |
|
Open in desktop
| https://desktop.github.com |
| how customized files appear on GitHub | https://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github |
| Please reload this page | https://github.com/python/cpython/pull/104355/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |