René's URL Explorer Experiment


Title: gh-101819: Harden _io init by erlend-aasland · Pull Request #104352 · python/cpython · GitHub

Open Graph Title: gh-101819: Harden _io init by erlend-aasland · Pull Request #104352 · python/cpython

X Title: gh-101819: Harden _io init by erlend-aasland · Pull Request #104352 · python/cpython

Description: Fix potential refleak if PyModule_AddObject() fails Issue: Isolate the _io extension module #101819

Open Graph Description: Fix potential refleak if PyModule_AddObject() fails Issue: Isolate the _io extension module #101819

X Description: Fix potential refleak if PyModule_AddObject() fails Issue: Isolate the _io extension module #101819

Opengraph URL: https://github.com/python/cpython/pull/104352

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d7cf8eba-018b-1e00-4648-ada14d6b4566
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC592:1D5ACA:16E1E48:1E92A62:6969BD62
html-safe-nonce862071a4d51527f43b0b6002a0f56a24c5b85677c295c5620937b8075d46859a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTkyOjFENUFDQToxNkUxRTQ4OjFFOTJBNjI6Njk2OUJENjIiLCJ2aXNpdG9yX2lkIjoiNjIzODI0MTMzMTIwMTI5MzY2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6d041326da2517439e7865bb408b33e97dd5d610a9c055c1aa5b65dc6cdfee16
hovercard-subject-tagpull_request:1345131802
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104352/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8eec6819a9dfb10d077b5153208798e1676be54cc231dbfa9ddaf18aeb67d4e5/python/cpython/pull/104352
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8eec6819a9dfb10d077b5153208798e1676be54cc231dbfa9ddaf18aeb67d4e5/python/cpython/pull/104352
og:image:altFix potential refleak if PyModule_AddObject() fails Issue: Isolate the _io extension module #101819
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerlend-aasland
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104352#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104352
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104352
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104352
Reloadhttps://github.com/python/cpython/pull/104352
Reloadhttps://github.com/python/cpython/pull/104352
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104352
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104352
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/104352#issue-comment-box
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:isolate-io/harden-inithttps://github.com/erlend-aasland/cpython/tree/isolate-io/harden-init
gh-101819: Harden _io init https://github.com/python/cpython/pull/104352#top
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:isolate-io/harden-inithttps://github.com/erlend-aasland/cpython/tree/isolate-io/harden-init
Conversation 2 https://github.com/python/cpython/pull/104352
Commits 1 https://github.com/python/cpython/pull/104352/commits
Checks 0 https://github.com/python/cpython/pull/104352/checks
Files changed https://github.com/python/cpython/pull/104352/files
Please reload this pagehttps://github.com/python/cpython/pull/104352
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
May 10, 2023https://github.com/python/cpython/pull/104352#issue-1703601290
Please reload this pagehttps://github.com/python/cpython/pull/104352
Isolate the _io extension module #101819https://github.com/python/cpython/issues/101819
Please reload this pagehttps://github.com/python/cpython/pull/104352
https://github.com/erlend-aasland
pythongh-101819https://github.com/python/cpython/issues/101819
: Harden _io inithttps://github.com/python/cpython/pull/104352/commits/e54f3a52f50d3112096c43732cea658b13a2214d
e54f3a5https://github.com/python/cpython/pull/104352/commits/e54f3a52f50d3112096c43732cea658b13a2214d
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
May 10, 2023https://github.com/python/cpython/pull/104352#event-9209989119
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
kumaraditya303https://github.com/kumaraditya303
vstinnerhttps://github.com/vstinner
May 10, 2023 10:26https://github.com/python/cpython/pull/104352#event-9209989252
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 10, 2023 https://github.com/python/cpython/pull/104352#ref-issue-1580724680
Isolate the _io extension module #101819 https://github.com/python/cpython/issues/101819
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 10, 2023https://github.com/python/cpython/pull/104352#event-9209989817
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
May 10, 2023 https://github.com/python/cpython/pull/104352#pullrequestreview-1420345101
View reviewed changes https://github.com/python/cpython/pull/104352/files/e54f3a52f50d3112096c43732cea658b13a2214d
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 10, 2023https://github.com/python/cpython/pull/104352#event-9210155279
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
68a8ca6https://github.com/python/cpython/commit/68a8ca6dc10bdceb4efaac569081b78ec01c3a99
May 10, 2023https://github.com/python/cpython/pull/104352#event-9210287564
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 10, 2023https://github.com/python/cpython/pull/104352#event-9210288061
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
May 10, 2023 10:59https://github.com/python/cpython/pull/104352#event-9210288206
carljmhttps://github.com/carljm
May 10, 2023 https://github.com/python/cpython/pull/104352#ref-commit-5976df9
https://github.com/carljm
Merge branch 'main' into fixloadsuperspechttps://github.com/carljm/cpython/commit/5976df922bb352f2de093dc18e8e90e9f9529746
5976df9https://github.com/carljm/cpython/commit/5976df922bb352f2de093dc18e8e90e9f9529746
pythonGH-102181https://github.com/python/cpython/issues/102181
pythonGH-102182https://github.com/python/cpython/pull/102182
pythongh-103000https://github.com/python/cpython/issues/103000
python#104364https://github.com/python/cpython/pull/104364
pythongh-103538https://github.com/python/cpython/issues/103538
pythonGH-103539https://github.com/python/cpython/pull/103539
pythonGH-87695https://github.com/python/cpython/issues/87695
pythonGH-104292https://github.com/python/cpython/pull/104292
pythongh-104263https://github.com/python/cpython/issues/104263
pythonGH-104202https://github.com/python/cpython/pull/104202
pythongh-104010https://github.com/python/cpython/issues/104010
python#104013https://github.com/python/cpython/pull/104013
pythongh-101819https://github.com/python/cpython/issues/101819
python#104355https://github.com/python/cpython/pull/104355
pythongh-103960https://github.com/python/cpython/issues/103960
python#103983https://github.com/python/cpython/pull/103983
pythongh-104252https://github.com/python/cpython/issues/104252
pythongh-104253https://github.com/python/cpython/pull/104253
pythongh-101819https://github.com/python/cpython/issues/101819
pythongh-104197https://github.com/python/cpython/pull/104197
python#104354https://github.com/python/cpython/pull/104354
pythongh-101819https://github.com/python/cpython/issues/101819
python#104352https://github.com/python/cpython/pull/104352
pythongh-103247https://github.com/python/cpython/issues/103247
pythonGH-104226https://github.com/python/cpython/pull/104226
pythongh-103848https://github.com/python/cpython/issues/103848
python#103849https://github.com/python/cpython/pull/103849
pythongh-74895https://github.com/python/cpython/issues/74895
python#104326https://github.com/python/cpython/pull/104326
pythongh-101819https://github.com/python/cpython/issues/101819
python#104334https://github.com/python/cpython/pull/104334
pythongh-90953https://github.com/python/cpython/issues/90953
python#104322https://github.com/python/cpython/pull/104322
pythongh-102327https://github.com/python/cpython/issues/102327
pythongh-104328https://github.com/python/cpython/issues/104328
python#104335https://github.com/python/cpython/pull/104335
carljmhttps://github.com/carljm
May 11, 2023 https://github.com/python/cpython/pull/104352#ref-commit-19b3d9e
https://github.com/carljm
Merge branch 'main' into supermonhttps://github.com/carljm/cpython/commit/19b3d9ef01efa4c931b0224849bb8eaccd3c9fa6
19b3d9ehttps://github.com/carljm/cpython/commit/19b3d9ef01efa4c931b0224849bb8eaccd3c9fa6
pythongh-87849https://github.com/python/cpython/issues/87849
pythonGH-104268https://github.com/python/cpython/pull/104268
pythongh-101819https://github.com/python/cpython/issues/101819
python#104384https://github.com/python/cpython/pull/104384
pythongh-101819https://github.com/python/cpython/issues/101819
python#104367https://github.com/python/cpython/pull/104367
pythongh-101819https://github.com/python/cpython/issues/101819
python#104369https://github.com/python/cpython/pull/104369
pythongh-101819https://github.com/python/cpython/issues/101819
python#104383https://github.com/python/cpython/pull/104383
pythongh-101117https://github.com/python/cpython/issues/101117
python#104287https://github.com/python/cpython/pull/104287
pythonGH-92184https://github.com/python/cpython/issues/92184
python#92185https://github.com/python/cpython/pull/92185
pythongh-104357https://github.com/python/cpython/issues/104357
python#104368https://github.com/python/cpython/pull/104368
pythonGH-90208https://github.com/python/cpython/issues/90208
pythonGH-104141https://github.com/python/cpython/pull/104141
pythonGH-102181https://github.com/python/cpython/issues/102181
pythonGH-102182https://github.com/python/cpython/pull/102182
pythongh-103000https://github.com/python/cpython/issues/103000
python#104364https://github.com/python/cpython/pull/104364
pythongh-103538https://github.com/python/cpython/issues/103538
pythonGH-103539https://github.com/python/cpython/pull/103539
pythonGH-87695https://github.com/python/cpython/issues/87695
pythonGH-104292https://github.com/python/cpython/pull/104292
pythongh-104263https://github.com/python/cpython/issues/104263
pythonGH-104202https://github.com/python/cpython/pull/104202
pythongh-104010https://github.com/python/cpython/issues/104010
python#104013https://github.com/python/cpython/pull/104013
pythongh-101819https://github.com/python/cpython/issues/101819
python#104355https://github.com/python/cpython/pull/104355
pythongh-103960https://github.com/python/cpython/issues/103960
python#103983https://github.com/python/cpython/pull/103983
pythongh-104252https://github.com/python/cpython/issues/104252
pythongh-104253https://github.com/python/cpython/pull/104253
pythongh-101819https://github.com/python/cpython/issues/101819
pythongh-104197https://github.com/python/cpython/pull/104197
python#104354https://github.com/python/cpython/pull/104354
pythongh-101819https://github.com/python/cpython/issues/101819
python#104352https://github.com/python/cpython/pull/104352
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 11, 2023 https://github.com/python/cpython/pull/104352#pullrequestreview-1422535542
View reviewed changes https://github.com/python/cpython/pull/104352/files/e54f3a52f50d3112096c43732cea658b13a2214d
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/104352#pullrequestreview-1422535542
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104352
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
May 11, 2023 https://github.com/python/cpython/pull/104352#pullrequestreview-1422536080
View reviewed changes https://github.com/python/cpython/pull/104352/files/e54f3a52f50d3112096c43732cea658b13a2214d
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/104352#pullrequestreview-1422536080
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104352
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104352
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/104352/files/e54f3a52f50d3112096c43732cea658b13a2214d
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/104352/files/e54f3a52f50d3112096c43732cea658b13a2214d
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/104352
https://github.com/erlend-aasland
https://github.com/vstinner
https://github.com/kumaraditya303
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.