| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:40eae222-63de-cc92-6c20-78a145e65785 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 987E:30006B:27F5BB:35A43F:6969A938 |
| html-safe-nonce | 9cdb37403a0790123085d114155653119d7fe2c3bc8ad733252ea6a3c6405445 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODdFOjMwMDA2QjoyN0Y1QkI6MzVBNDNGOjY5NjlBOTM4IiwidmlzaXRvcl9pZCI6IjkxMjE2NDIxMzkwMzQ5NTQwNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2d3d63d5e0cd56e4816629258ac0037af16289914822bd31d40a8e322a1829e0 |
| hovercard-subject-tag | pull_request:1344063076 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104334/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e7c4c25409ec638c83362c4ef43c38222306158a35e406938ca8efa66353dc4d/python/cpython/pull/104334 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e7c4c25409ec638c83362c4ef43c38222306158a35e406938ca8efa66353dc4d/python/cpython/pull/104334 |
| og:image:alt | Issue: Isolate the _io extension module #101819 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | erlend-aasland |
| hostname | github.com |
| expected-hostname | github.com |
| None | 24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 124667f43168afb6c9c03b7c02eb5b1d2e1be3d9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/104334#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104334 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104334 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/104334 |
| Reload | https://github.com/python/cpython/pull/104334 |
| Reload | https://github.com/python/cpython/pull/104334 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/104334 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/104334 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/104334#issue-comment-box |
| erlend-aasland | https://github.com/erlend-aasland |
| python:main | https://github.com/python/cpython/tree/main |
| erlend-aasland:isolate-io/refactorings | https://github.com/erlend-aasland/cpython/tree/isolate-io/refactorings |
|
gh-101819: Refactor _io in preparation for module isolation
| https://github.com/python/cpython/pull/104334#top |
| erlend-aasland | https://github.com/erlend-aasland |
| python:main | https://github.com/python/cpython/tree/main |
| erlend-aasland:isolate-io/refactorings | https://github.com/erlend-aasland/cpython/tree/isolate-io/refactorings |
|
Conversation
6
| https://github.com/python/cpython/pull/104334 |
|
Commits
12
| https://github.com/python/cpython/pull/104334/commits |
|
Checks
0
| https://github.com/python/cpython/pull/104334/checks |
|
Files changed
| https://github.com/python/cpython/pull/104334/files |
| Please reload this page | https://github.com/python/cpython/pull/104334 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| May 9, 2023 | https://github.com/python/cpython/pull/104334#issue-1702383526 |
| Please reload this page | https://github.com/python/cpython/pull/104334 |
| Isolate the _io extension module #101819 | https://github.com/python/cpython/issues/101819 |
| Please reload this page | https://github.com/python/cpython/pull/104334 |
| erlend-aasland | https://github.com/erlend-aasland |
| May 9, 2023 18:04 | https://github.com/python/cpython/pull/104334#commits-pushed-14f923e |
|
| https://github.com/erlend-aasland |
| Refactor: replace query with parameter | https://github.com/python/cpython/pull/104334/commits/14f923e938d89053653d3722770d81f8a5c814db |
| 14f923e | https://github.com/python/cpython/pull/104334/commits/14f923e938d89053653d3722770d81f8a5c814db |
|
| https://github.com/erlend-aasland |
| Refactor: replace query with parameter | https://github.com/python/cpython/pull/104334/commits/482f13404ff6a7d1e1b3c4f158de641939bf0b7c |
| 482f134 | https://github.com/python/cpython/pull/104334/commits/482f13404ff6a7d1e1b3c4f158de641939bf0b7c |
|
| https://github.com/erlend-aasland |
| Refactor: hide delegate | https://github.com/python/cpython/pull/104334/commits/8adc0cd0e7eb3b295f7455eeedb6fc31b2c9d391 |
| 8adc0cd | https://github.com/python/cpython/pull/104334/commits/8adc0cd0e7eb3b295f7455eeedb6fc31b2c9d391 |
|
| https://github.com/erlend-aasland |
| Refactor: hide delegate | https://github.com/python/cpython/pull/104334/commits/703440a7e1717d518ac5b848e6fe72dc002d8bf1 |
| 703440a | https://github.com/python/cpython/pull/104334/commits/703440a7e1717d518ac5b848e6fe72dc002d8bf1 |
|
| https://github.com/erlend-aasland |
| Refactor: hide delegate | https://github.com/python/cpython/pull/104334/commits/ea9c0989813665aae0cf757f56dc8b985aa9bdef |
| ea9c098 | https://github.com/python/cpython/pull/104334/commits/ea9c0989813665aae0cf757f56dc8b985aa9bdef |
|
| https://github.com/erlend-aasland |
| Add io state struct forward declaration. | https://github.com/python/cpython/pull/104334/commits/e940ed3631cc57df552bb2b8454ae2817b3c114b |
| e940ed3 | https://github.com/python/cpython/pull/104334/commits/e940ed3631cc57df552bb2b8454ae2817b3c114b |
|
| https://github.com/erlend-aasland |
| Refactor: replace query with parameter | https://github.com/python/cpython/pull/104334/commits/c68d657173994b1b3d7be543ae6bd789838f313f |
| c68d657 | https://github.com/python/cpython/pull/104334/commits/c68d657173994b1b3d7be543ae6bd789838f313f |
|
| https://github.com/erlend-aasland |
| Refactor: replace query with parameter | https://github.com/python/cpython/pull/104334/commits/0084715e00725c660a796c15cc7f8710ab8061db |
| 0084715 | https://github.com/python/cpython/pull/104334/commits/0084715e00725c660a796c15cc7f8710ab8061db |
|
| https://github.com/erlend-aasland |
| Refactor: replace query with parameter | https://github.com/python/cpython/pull/104334/commits/20777e7d45ebb906653217b4ffd423bfbec2130d |
| 20777e7 | https://github.com/python/cpython/pull/104334/commits/20777e7d45ebb906653217b4ffd423bfbec2130d |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| May 9, 2023 | https://github.com/python/cpython/pull/104334#event-9202890332 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| kumaraditya303 | https://github.com/kumaraditya303 |
| May 9, 2023 16:43 | https://github.com/python/cpython/pull/104334#event-9202890475 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
May 9, 2023
| https://github.com/python/cpython/pull/104334#ref-issue-1580724680 |
|
Isolate the _io extension module
#101819
| https://github.com/python/cpython/issues/101819 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| May 9, 2023 | https://github.com/python/cpython/pull/104334#event-9202891041 |
|
| https://github.com/erlend-aasland |
| Fetch state by module def in _io__Buffered_seek_impl() | https://github.com/python/cpython/pull/104334/commits/b22b41d7858ae234fd25ec7e86cee827688cfa7e |
| b22b41d | https://github.com/python/cpython/pull/104334/commits/b22b41d7858ae234fd25ec7e86cee827688cfa7e |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
May 9, 2023
| https://github.com/python/cpython/pull/104334#pullrequestreview-1419530383 |
|
View reviewed changes
| https://github.com/python/cpython/pull/104334/files/b22b41d7858ae234fd25ec7e86cee827688cfa7e |
| vstinner | https://github.com/vstinner |
| https://github.com/python/cpython/pull/104334#pullrequestreview-1419530383 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/104334 |
| Modules/_io/_iomodule.h | https://github.com/python/cpython/pull/104334/files/b22b41d7858ae234fd25ec7e86cee827688cfa7e#diff-5316ec91b4e6cbcf680b208755cf8e7efce11e2a6682efb569ade29d6465a55b |
| Please reload this page | https://github.com/python/cpython/pull/104334 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| May 9, 2023 | https://github.com/python/cpython/pull/104334#event-9205481633 |
|
| https://github.com/erlend-aasland |
| Address review: improve forward decl. of _PyIO_State | https://github.com/python/cpython/pull/104334/commits/0044293b1a93f0e4adeb77f48dda0efa3c42c314 |
| 0044293 | https://github.com/python/cpython/pull/104334/commits/0044293b1a93f0e4adeb77f48dda0efa3c42c314 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| May 9, 2023 22:32 | https://github.com/python/cpython/pull/104334#event-9205521248 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
May 9, 2023
| https://github.com/python/cpython/pull/104334#pullrequestreview-1419540111 |
|
View reviewed changes
| https://github.com/python/cpython/pull/104334/files/0044293b1a93f0e4adeb77f48dda0efa3c42c314 |
| Modules/_io/_iomodule.h | https://github.com/python/cpython/pull/104334/files/0044293b1a93f0e4adeb77f48dda0efa3c42c314#diff-5316ec91b4e6cbcf680b208755cf8e7efce11e2a6682efb569ade29d6465a55b |
| Please reload this page | https://github.com/python/cpython/pull/104334 |
|
| https://github.com/erlend-aasland |
| Address review: remove second typedef | https://github.com/python/cpython/pull/104334/commits/7aa8da76a45c237f80e86a4bd2d0542e8426e395 |
| 7aa8da7 | https://github.com/python/cpython/pull/104334/commits/7aa8da76a45c237f80e86a4bd2d0542e8426e395 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
May 9, 2023
| https://github.com/python/cpython/pull/104334#pullrequestreview-1419545376 |
|
View reviewed changes
| https://github.com/python/cpython/pull/104334/files/7aa8da76a45c237f80e86a4bd2d0542e8426e395 |
| vstinner | https://github.com/vstinner |
| https://github.com/python/cpython/pull/104334#pullrequestreview-1419545376 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/104334 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| 235b827 | https://github.com/python/cpython/commit/235b82721dbbe2bc5bf1f45a74e22b7185e5783e |
| May 9, 2023 | https://github.com/python/cpython/pull/104334#event-9205679004 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| May 9, 2023 | https://github.com/python/cpython/pull/104334#event-9205679223 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| May 10, 2023 04:41 | https://github.com/python/cpython/pull/104334#event-9207043116 |
| carljm | https://github.com/carljm |
|
May 10, 2023
| https://github.com/python/cpython/pull/104334#ref-commit-5976df9 |
|
| https://github.com/carljm |
| Merge branch 'main' into fixloadsuperspec | https://github.com/carljm/cpython/commit/5976df922bb352f2de093dc18e8e90e9f9529746 |
| 5976df9 | https://github.com/carljm/cpython/commit/5976df922bb352f2de093dc18e8e90e9f9529746 |
| pythonGH-102181 | https://github.com/python/cpython/issues/102181 |
| pythonGH-102182 | https://github.com/python/cpython/pull/102182 |
| pythongh-103000 | https://github.com/python/cpython/issues/103000 |
| python#104364 | https://github.com/python/cpython/pull/104364 |
| pythongh-103538 | https://github.com/python/cpython/issues/103538 |
| pythonGH-103539 | https://github.com/python/cpython/pull/103539 |
| pythonGH-87695 | https://github.com/python/cpython/issues/87695 |
| pythonGH-104292 | https://github.com/python/cpython/pull/104292 |
| pythongh-104263 | https://github.com/python/cpython/issues/104263 |
| pythonGH-104202 | https://github.com/python/cpython/pull/104202 |
| pythongh-104010 | https://github.com/python/cpython/issues/104010 |
| python#104013 | https://github.com/python/cpython/pull/104013 |
| pythongh-101819 | https://github.com/python/cpython/issues/101819 |
| python#104355 | https://github.com/python/cpython/pull/104355 |
| pythongh-103960 | https://github.com/python/cpython/issues/103960 |
| python#103983 | https://github.com/python/cpython/pull/103983 |
| pythongh-104252 | https://github.com/python/cpython/issues/104252 |
| pythongh-104253 | https://github.com/python/cpython/pull/104253 |
| pythongh-101819 | https://github.com/python/cpython/issues/101819 |
| pythongh-104197 | https://github.com/python/cpython/pull/104197 |
| python#104354 | https://github.com/python/cpython/pull/104354 |
| pythongh-101819 | https://github.com/python/cpython/issues/101819 |
| python#104352 | https://github.com/python/cpython/pull/104352 |
| pythongh-103247 | https://github.com/python/cpython/issues/103247 |
| pythonGH-104226 | https://github.com/python/cpython/pull/104226 |
| pythongh-103848 | https://github.com/python/cpython/issues/103848 |
| python#103849 | https://github.com/python/cpython/pull/103849 |
| pythongh-74895 | https://github.com/python/cpython/issues/74895 |
| python#104326 | https://github.com/python/cpython/pull/104326 |
| pythongh-101819 | https://github.com/python/cpython/issues/101819 |
| python#104334 | https://github.com/python/cpython/pull/104334 |
| pythongh-90953 | https://github.com/python/cpython/issues/90953 |
| python#104322 | https://github.com/python/cpython/pull/104322 |
| pythongh-102327 | https://github.com/python/cpython/issues/102327 |
| pythongh-104328 | https://github.com/python/cpython/issues/104328 |
| python#104335 | https://github.com/python/cpython/pull/104335 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104334 |
|
| https://github.com/vstinner |
|
vstinner
| https://github.com/vstinner |
|
| https://github.com/python/cpython/pull/104334/files/7aa8da76a45c237f80e86a4bd2d0542e8426e395 |
|
| https://github.com/kumaraditya303 |
|
kumaraditya303
| https://github.com/kumaraditya303 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/104334 |
|
| https://github.com/erlend-aasland |
|
| https://github.com/vstinner |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |