René's URL Explorer Experiment


Title: gh-91896: Improve visibility of `ByteString` deprecation warnings by AlexWaygood · Pull Request #104294 · python/cpython · GitHub

Open Graph Title: gh-91896: Improve visibility of `ByteString` deprecation warnings by AlexWaygood · Pull Request #104294 · python/cpython

X Title: gh-91896: Improve visibility of `ByteString` deprecation warnings by AlexWaygood · Pull Request #104294 · python/cpython

Description: #102096 added deprecation warnings for collections.abc.ByteString, but these warnings are currently only emitted on subclassing ByteString or calling isinstance() against it. Importing ByteString or accessing it via import collections.abc; collections.abc.ByteString does not currently trigger any warnings, meaning somebody who's just using the class for type annotations might not get any warning that the class will be removed in 3.14. Moreover, the isinstance() deprecation warnings are only emitted on isinstance() checks against collections.abc.ByteString, not on isinstance() checks against typing.ByteString. The docs update that we just made in 1f56795 says that typing.ByteString will also be removed in Python 3.14, so we should emit the same deprecation warnings for typing.ByteString. This PR adds deprecation warnings for: from collections.abc import ByteString import collections.abc; collections.abc.ByteString from typing import ByteString import typing; typing.ByteString isinstance(b"", typing.ByteString) Issue: gh-91896

Open Graph Description: #102096 added deprecation warnings for collections.abc.ByteString, but these warnings are currently only emitted on subclassing ByteString or calling isinstance() against it. Importing ByteString o...

X Description: #102096 added deprecation warnings for collections.abc.ByteString, but these warnings are currently only emitted on subclassing ByteString or calling isinstance() against it. Importing ByteString o...

Opengraph URL: https://github.com/python/cpython/pull/104294

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7227b8d8-2c83-5e08-58e6-07bccbde34aa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEE04:2E3F95:148C2AB:1C66D27:696A96F5
html-safe-noncef7e8d483915606c15c2a4ec8f060e66487cfe5eb6bb3e3c9afbe361c16ed3926
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRTA0OjJFM0Y5NToxNDhDMkFCOjFDNjZEMjc6Njk2QTk2RjUiLCJ2aXNpdG9yX2lkIjoiMzM0OTMxOTA4OTUwNTYwNTM2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2e2644bf60666453015263c86eceb1711f8bef3a637e322cc7930e4878d68ac2
hovercard-subject-tagpull_request:1342389061
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/104294/files
twitter:imagehttps://avatars.githubusercontent.com/u/66076021?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/66076021?s=400&v=4
og:image:alt#102096 added deprecation warnings for collections.abc.ByteString, but these warnings are currently only emitted on subclassing ByteString or calling isinstance() against it. Importing ByteString o...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec0d8175e41e0e55b9e984c935b24b808cabab919dd3174aa45dac3ef503ed1af
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release99aab454e5ddc8df30805fb76c114c3008a15842
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104294/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104294%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104294%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104294/files
Reloadhttps://github.com/python/cpython/pull/104294/files
Reloadhttps://github.com/python/cpython/pull/104294/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104294/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104294/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
hauntsaninjahttps://github.com/hauntsaninja
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:more-bytestring-warningshttps://github.com/AlexWaygood/cpython/tree/more-bytestring-warnings
Conversation 6 https://github.com/python/cpython/pull/104294
Commits 3 https://github.com/python/cpython/pull/104294/commits
Checks 0 https://github.com/python/cpython/pull/104294/checks
Files changed https://github.com/python/cpython/pull/104294/files
Please reload this pagehttps://github.com/python/cpython/pull/104294/files
gh-91896: Improve visibility of ByteString deprecation warnings https://github.com/python/cpython/pull/104294/files#top
Show all changes 3 commits https://github.com/python/cpython/pull/104294/files
424486a gh-91896: Improve visibility of `ByteString` deprecation warnings AlexWaygood May 8, 2023 https://github.com/python/cpython/pull/104294/commits/424486ad0880620fb01a9a95ee3f0f2b01a899d2
8015ba3 Fix `test_regrtest` (hopefully) AlexWaygood May 8, 2023 https://github.com/python/cpython/pull/104294/commits/8015ba3614f98237fe78fa48c6429e2df0025fa6
67973d1 Multiple inheritance with typing.ByteString also emits a warning AlexWaygood May 8, 2023 https://github.com/python/cpython/pull/104294/commits/67973d171e188b33cd7b06cedea740b348c098f1
Clear filters https://github.com/python/cpython/pull/104294/files
Please reload this pagehttps://github.com/python/cpython/pull/104294/files
Please reload this pagehttps://github.com/python/cpython/pull/104294/files
abc.py https://github.com/python/cpython/pull/104294/files#diff-8f5b4b1ece612d08455a0a88823f7816e4f0c56a90104721478ff07045f57a9d
refleak.py https://github.com/python/cpython/pull/104294/files#diff-a9ae74da20089d7e315cc884eec16e9105c45fefd9b3da12e3382fb43c4310c9
test_collections.py https://github.com/python/cpython/pull/104294/files#diff-a2a882635e20e8e9439f090d33513502a7af648286efebfa4e4bc37270c44784
test_typing.py https://github.com/python/cpython/pull/104294/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
typing.py https://github.com/python/cpython/pull/104294/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L401
Lib/collections/abc.pyhttps://github.com/python/cpython/pull/104294/files#diff-8f5b4b1ece612d08455a0a88823f7816e4f0c56a90104721478ff07045f57a9d
View file https://github.com/AlexWaygood/cpython/blob/67973d171e188b33cd7b06cedea740b348c098f1/Lib/collections/abc.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104294/{{ revealButtonHref }}
Lib/test/libregrtest/refleak.pyhttps://github.com/python/cpython/pull/104294/files#diff-a9ae74da20089d7e315cc884eec16e9105c45fefd9b3da12e3382fb43c4310c9
View file https://github.com/AlexWaygood/cpython/blob/67973d171e188b33cd7b06cedea740b348c098f1/Lib/test/libregrtest/refleak.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104294/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104294/files#diff-a9ae74da20089d7e315cc884eec16e9105c45fefd9b3da12e3382fb43c4310c9
https://github.com/python/cpython/pull/104294/files#diff-a9ae74da20089d7e315cc884eec16e9105c45fefd9b3da12e3382fb43c4310c9
https://github.com/python/cpython/pull/104294/files#diff-a9ae74da20089d7e315cc884eec16e9105c45fefd9b3da12e3382fb43c4310c9
https://github.com/python/cpython/pull/104294/files#diff-a9ae74da20089d7e315cc884eec16e9105c45fefd9b3da12e3382fb43c4310c9
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L402
Lib/test/test_collections.pyhttps://github.com/python/cpython/pull/104294/files#diff-a2a882635e20e8e9439f090d33513502a7af648286efebfa4e4bc37270c44784
View file https://github.com/AlexWaygood/cpython/blob/67973d171e188b33cd7b06cedea740b348c098f1/Lib/test/test_collections.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104294/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104294/files#diff-a2a882635e20e8e9439f090d33513502a7af648286efebfa4e4bc37270c44784
https://github.com/python/cpython/pull/104294/files#diff-a2a882635e20e8e9439f090d33513502a7af648286efebfa4e4bc37270c44784
https://github.com/python/cpython/pull/104294/files#diff-a2a882635e20e8e9439f090d33513502a7af648286efebfa4e4bc37270c44784
https://github.com/python/cpython/pull/104294/files#diff-a2a882635e20e8e9439f090d33513502a7af648286efebfa4e4bc37270c44784
https://github.com/python/cpython/pull/104294/files#diff-a2a882635e20e8e9439f090d33513502a7af648286efebfa4e4bc37270c44784
https://github.com/python/cpython/pull/104294/files#diff-a2a882635e20e8e9439f090d33513502a7af648286efebfa4e4bc37270c44784
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L599
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/104294/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
View file https://github.com/AlexWaygood/cpython/blob/67973d171e188b33cd7b06cedea740b348c098f1/Lib/test/test_typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104294/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104294/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/104294/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/104294/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/104294/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/104294/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/104294/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/104294/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/104294/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/104294/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/104294/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/pull/104294/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L601
Lib/typing.pyhttps://github.com/python/cpython/pull/104294/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
View file https://github.com/AlexWaygood/cpython/blob/67973d171e188b33cd7b06cedea740b348c098f1/Lib/typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104294/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104294/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/104294/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/104294/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/104294/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com/python/cpython/pull/104294/files#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.