René's URL Explorer Experiment


Title: gh-91896: Improve visibility of `ByteString` deprecation warnings by AlexWaygood · Pull Request #104294 · python/cpython · GitHub

Open Graph Title: gh-91896: Improve visibility of `ByteString` deprecation warnings by AlexWaygood · Pull Request #104294 · python/cpython

X Title: gh-91896: Improve visibility of `ByteString` deprecation warnings by AlexWaygood · Pull Request #104294 · python/cpython

Description: #102096 added deprecation warnings for collections.abc.ByteString, but these warnings are currently only emitted on subclassing ByteString or calling isinstance() against it. Importing ByteString o...

Open Graph Description: #102096 added deprecation warnings for collections.abc.ByteString, but these warnings are currently only emitted on subclassing ByteString or calling isinstance() against it. Importing ByteString o...

X Description: #102096 added deprecation warnings for collections.abc.ByteString, but these warnings are currently only emitted on subclassing ByteString or calling isinstance() against it. Importing ByteString o...

Opengraph URL: https://github.com/python/cpython/pull/104294

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1e720747-6737-e152-d421-64332ec209ba
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD4A:8A288:7E43AB:AAB485:6969BACC
html-safe-nonce0acbf058c20af41241cf2ea00a59554890cc3c8a3227cd4d466a00e368fc45c8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDRBOjhBMjg4OjdFNDNBQjpBQUI0ODU6Njk2OUJBQ0MiLCJ2aXNpdG9yX2lkIjoiNTA2ODYwMDAxMjgzMjM1NzA2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccbb5e70a2fca286e6119c9cb8638294d2ac93bfeb9ead52b385824c885a26fdb
hovercard-subject-tagpull_request:1342389061
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104294/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c842a64a49f0594b6ba6bdee5d9e65b1cbc31d05b98acd8315437ac7b5a5eea2/python/cpython/pull/104294
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c842a64a49f0594b6ba6bdee5d9e65b1cbc31d05b98acd8315437ac7b5a5eea2/python/cpython/pull/104294
og:image:alt#102096 added deprecation warnings for collections.abc.ByteString, but these warnings are currently only emitted on subclassing ByteString or calling isinstance() against it. Importing ByteString o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAlexWaygood
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104294#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104294
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104294
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104294
Reloadhttps://github.com/python/cpython/pull/104294
Reloadhttps://github.com/python/cpython/pull/104294
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104294
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104294
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/104294#issue-comment-box
hauntsaninjahttps://github.com/hauntsaninja
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:more-bytestring-warningshttps://github.com/AlexWaygood/cpython/tree/more-bytestring-warnings
gh-91896: Improve visibility of ByteString deprecation warnings https://github.com/python/cpython/pull/104294#top
hauntsaninjahttps://github.com/hauntsaninja
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:more-bytestring-warningshttps://github.com/AlexWaygood/cpython/tree/more-bytestring-warnings
Conversation 6 https://github.com/python/cpython/pull/104294
Commits 3 https://github.com/python/cpython/pull/104294/commits
Checks 0 https://github.com/python/cpython/pull/104294/checks
Files changed https://github.com/python/cpython/pull/104294/files
Please reload this pagehttps://github.com/python/cpython/pull/104294
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 8, 2023https://github.com/python/cpython/pull/104294#issue-1700484624
Please reload this pagehttps://github.com/python/cpython/pull/104294
#102096https://github.com/python/cpython/pull/102096
1f56795https://github.com/python/cpython/commit/1f5679540ca4aa5c0eae06d3a2d5eda34b47e041
Deprecate and schedule removal of collections.abc.ByteString and typing.ByteString #91896https://github.com/python/cpython/issues/91896
Please reload this pagehttps://github.com/python/cpython/pull/104294
https://github.com/AlexWaygood
pythongh-91896https://github.com/python/cpython/issues/91896
: Improve visibility ofhttps://github.com/python/cpython/pull/104294/commits/424486ad0880620fb01a9a95ee3f0f2b01a899d2
ByteStringhttps://github.com/python/cpython/pull/104294/commits/424486ad0880620fb01a9a95ee3f0f2b01a899d2
deprecation warningshttps://github.com/python/cpython/pull/104294/commits/424486ad0880620fb01a9a95ee3f0f2b01a899d2
424486ahttps://github.com/python/cpython/pull/104294/commits/424486ad0880620fb01a9a95ee3f0f2b01a899d2
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
May 8, 2023https://github.com/python/cpython/pull/104294#event-9191771588
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
hauntsaninjahttps://github.com/hauntsaninja
May 8, 2023 15:36https://github.com/python/cpython/pull/104294#event-9191771621
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Fidget-Spinnerhttps://github.com/Fidget-Spinner
JelleZijlstrahttps://github.com/JelleZijlstra
gvanrossumhttps://github.com/gvanrossum
rhettingerhttps://github.com/rhettinger
code ownershttps://github.com/python/cpython/blob/921185ed050efbca2f0adeab79f676b7f8cc3660/.github/CODEOWNERS#L142
May 8, 2023 15:36https://github.com/python/cpython/pull/104294#event-9191771733
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 8, 2023 https://github.com/python/cpython/pull/104294#ref-issue-1213932492
Deprecate and schedule removal of collections.abc.ByteString and typing.ByteString #91896 https://github.com/python/cpython/issues/91896
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 8, 2023https://github.com/python/cpython/pull/104294#event-9191772586
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 8, 2023https://github.com/python/cpython/pull/104294#issuecomment-1538601332
#102096https://github.com/python/cpython/pull/102096
Please reload this pagehttps://github.com/python/cpython/pull/104294
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 8, 2023 15:57https://github.com/python/cpython/pull/104294#event-9191936186
https://github.com/AlexWaygood
Fix test_regrtest (hopefully)https://github.com/python/cpython/pull/104294/commits/8015ba3614f98237fe78fa48c6429e2df0025fa6
8015ba3https://github.com/python/cpython/pull/104294/commits/8015ba3614f98237fe78fa48c6429e2df0025fa6
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
force-pushedhttps://github.com/python/cpython/compare/8c469cf9d46f71d3f8522ef58ad0681041d3f42a..8015ba3614f98237fe78fa48c6429e2df0025fa6
8c469cfhttps://github.com/python/cpython/commit/8c469cf9d46f71d3f8522ef58ad0681041d3f42a
8015ba3https://github.com/python/cpython/commit/8015ba3614f98237fe78fa48c6429e2df0025fa6
Compare https://github.com/python/cpython/compare/8c469cf9d46f71d3f8522ef58ad0681041d3f42a..8015ba3614f98237fe78fa48c6429e2df0025fa6
May 8, 2023 16:38https://github.com/python/cpython/pull/104294#event-9192318190
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 8, 2023 16:55https://github.com/python/cpython/pull/104294#event-9192441272
https://github.com/Eclips4
Eclips4https://github.com/Eclips4
May 8, 2023 https://github.com/python/cpython/pull/104294#pullrequestreview-1417165841
View reviewed changes https://github.com/python/cpython/pull/104294/files/8015ba3614f98237fe78fa48c6429e2df0025fa6
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/104294/files/8015ba3614f98237fe78fa48c6429e2df0025fa6#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/104294
https://github.com/AlexWaygood
Multiple inheritance with typing.ByteString also emits a warninghttps://github.com/python/cpython/pull/104294/commits/67973d171e188b33cd7b06cedea740b348c098f1
67973d1https://github.com/python/cpython/pull/104294/commits/67973d171e188b33cd7b06cedea740b348c098f1
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
May 9, 2023https://github.com/python/cpython/pull/104294#issuecomment-1539300243
Please reload this pagehttps://github.com/python/cpython/pull/104294
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 9, 2023https://github.com/python/cpython/pull/104294#issuecomment-1539573706
Please reload this pagehttps://github.com/python/cpython/pull/104294
Please reload this pagehttps://github.com/python/cpython/pull/104294
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
May 9, 2023 https://github.com/python/cpython/pull/104294#pullrequestreview-1418290504
View reviewed changes https://github.com/python/cpython/pull/104294/files/67973d171e188b33cd7b06cedea740b348c098f1
hauntsaninjahttps://github.com/hauntsaninja
https://github.com/python/cpython/pull/104294#pullrequestreview-1418290504
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104294
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
May 12, 2023 https://github.com/python/cpython/pull/104294#pullrequestreview-1423821556
View reviewed changes https://github.com/python/cpython/pull/104294/files/67973d171e188b33cd7b06cedea740b348c098f1
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 12, 2023https://github.com/python/cpython/pull/104294#event-9229244534
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
f0f5bb3https://github.com/python/cpython/commit/f0f5bb32043e1223d8c413e763cd93061d4f9fac
May 12, 2023https://github.com/python/cpython/pull/104294#event-9229251212
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 12, 2023https://github.com/python/cpython/pull/104294#event-9229251595
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 12, 2023 07:30https://github.com/python/cpython/pull/104294#event-9229966334
gh-91896: Fixup some docs issues following ByteString deprecation #104422 https://github.com/python/cpython/pull/104422
gh-91896: Revert some very noisy DeprecationWarnings for ByteString #104424 https://github.com/python/cpython/pull/104424
carljmhttps://github.com/carljm
May 12, 2023 https://github.com/python/cpython/pull/104294#ref-commit-8efd7c6
https://github.com/carljm
Merge branch 'main' into supermonhttps://github.com/carljm/cpython/commit/8efd7c6f17e0faeca8fe6337a9eeca472d74b0ba
8efd7c6https://github.com/carljm/cpython/commit/8efd7c6f17e0faeca8fe6337a9eeca472d74b0ba
pythongh-91896https://github.com/python/cpython/issues/91896
python#104422https://github.com/python/cpython/pull/104422
pythonGH-104371https://github.com/python/cpython/issues/104371
python#104417https://github.com/python/cpython/pull/104417
pythongh-104415https://github.com/python/cpython/issues/104415
python#104416https://github.com/python/cpython/pull/104416
pythonGH-86275https://github.com/python/cpython/issues/86275
python#22863https://github.com/python/cpython/pull/22863
pythonGH-103082https://github.com/python/cpython/issues/103082
pythonGH-104387https://github.com/python/cpython/pull/104387
pythongh-93649https://github.com/python/cpython/issues/93649
pythonGH-104403https://github.com/python/cpython/pull/104403
pythongh-104389https://github.com/python/cpython/issues/104389
python#104390https://github.com/python/cpython/pull/104390
pythongh-101819https://github.com/python/cpython/issues/101819
python#104386https://github.com/python/cpython/pull/104386
pythongh-104413https://github.com/python/cpython/issues/104413
python#104414https://github.com/python/cpython/pull/104414
python#104408https://github.com/python/cpython/pull/104408
pythongh-87526https://github.com/python/cpython/issues/87526
python#24700https://github.com/python/cpython/pull/24700
pythongh-91896https://github.com/python/cpython/issues/91896
python#104294https://github.com/python/cpython/pull/104294
pythongh-104371https://github.com/python/cpython/issues/104371
python#104378https://github.com/python/cpython/pull/104378
pythongh-104377https://github.com/python/cpython/issues/104377
python#104394https://github.com/python/cpython/pull/104394
pythongh-104392https://github.com/python/cpython/issues/104392
python#104393https://github.com/python/cpython/pull/104393
pythongh-104396https://github.com/python/cpython/issues/104396
pythongh-104397https://github.com/python/cpython/pull/104397
pythongh-99108https://github.com/python/cpython/issues/99108
python#104401https://github.com/python/cpython/pull/104401
pythongh-104301https://github.com/python/cpython/issues/104301
python#104342https://github.com/python/cpython/pull/104342
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104294
https://github.com/Eclips4
Eclips4 https://github.com/Eclips4
https://github.com/python/cpython/pull/104294/files/8015ba3614f98237fe78fa48c6429e2df0025fa6
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/cpython/pull/104294/files/67973d171e188b33cd7b06cedea740b348c098f1
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
https://github.com/rhettinger
rhettinger https://github.com/rhettinger
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
Please reload this pagehttps://github.com/python/cpython/pull/104294
https://github.com/AlexWaygood
https://github.com/rhettinger
https://github.com/hauntsaninja
https://github.com/Eclips4
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.