René's URL Explorer Experiment


Title: gh-103193: Improve `getattr_static` test coverage by AlexWaygood · Pull Request #104286 · python/cpython · GitHub

Open Graph Title: gh-103193: Improve `getattr_static` test coverage by AlexWaygood · Pull Request #104286 · python/cpython

X Title: gh-103193: Improve `getattr_static` test coverage by AlexWaygood · Pull Request #104286 · python/cpython

Description: Currently, no tests would fail if we were to apply this optimisation to getattr_static, which makes things a fair bit faster: --- a/Lib/inspect.py +++ b/Lib/inspect.py @@ -1780,13 +1780,9 @@ def trace(context=1): def _check_instance(obj, attr): - instance_dict = {} - try: - instance_dict = object.__getattribute__(obj, "__dict__") - except AttributeError: - pass - return dict.get(instance_dict, attr, _sentinel) - + if hasattr(obj, "__dict__"): + return dict.get(obj.__dict__, attr, _sentinel) + return _sentinel However, the optimisation would lead to incorrect behaviour. test_custom___getattribute__, added in this PR, would correctly fail if the incorrect optimisation were applied. Issue: gh-103193

Open Graph Description: Currently, no tests would fail if we were to apply this optimisation to getattr_static, which makes things a fair bit faster: --- a/Lib/inspect.py +++ b/Lib/inspect.py @@ -1780,13 +1780,9 @@ def tr...

X Description: Currently, no tests would fail if we were to apply this optimisation to getattr_static, which makes things a fair bit faster: --- a/Lib/inspect.py +++ b/Lib/inspect.py @@ -1780,13 +1780,9 @@ def tr...

Opengraph URL: https://github.com/python/cpython/pull/104286

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a9802710-d960-e9ea-cd9f-b8bcbf7b5192
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9FD8:15A631:AAA38:E6BAF:6969CBB8
html-safe-nonce89463062e6f496588fb4a0148be9d9a5555ec157adccd02c39b6dc6146b5894a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkQ4OjE1QTYzMTpBQUEzODpFNkJBRjo2OTY5Q0JCOCIsInZpc2l0b3JfaWQiOiIxNTQ4NjQ1NjM2ODE2NjIwNDcyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac84a10ee036e2278fbc24f09f0d18a8f56b4ed264f499c2e0a6932913839a6825
hovercard-subject-tagpull_request:1341797589
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/104286/files
twitter:imagehttps://avatars.githubusercontent.com/u/66076021?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/66076021?s=400&v=4
og:image:altCurrently, no tests would fail if we were to apply this optimisation to getattr_static, which makes things a fair bit faster: --- a/Lib/inspect.py +++ b/Lib/inspect.py @@ -1780,13 +1780,9 @@ def tr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104286/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104286%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104286%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104286/files
Reloadhttps://github.com/python/cpython/pull/104286/files
Reloadhttps://github.com/python/cpython/pull/104286/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104286/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104286/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:attr_static-coveragehttps://github.com/AlexWaygood/cpython/tree/attr_static-coverage
Conversation 4 https://github.com/python/cpython/pull/104286
Commits 1 https://github.com/python/cpython/pull/104286/commits
Checks 0 https://github.com/python/cpython/pull/104286/checks
Files changed https://github.com/python/cpython/pull/104286/files
Please reload this pagehttps://github.com/python/cpython/pull/104286/files
gh-103193: Improve getattr_static test coverage https://github.com/python/cpython/pull/104286/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/104286/files
080871a gh-103193: Improve `getattr_static` test coverage AlexWaygood May 8, 2023 https://github.com/python/cpython/pull/104286/commits/080871af0ffcef9fdc01d180d1c4266be48c0afb
Clear filters https://github.com/python/cpython/pull/104286/files
Please reload this pagehttps://github.com/python/cpython/pull/104286/files
Please reload this pagehttps://github.com/python/cpython/pull/104286/files
Lib/test/test_inspect.pyhttps://github.com/python/cpython/pull/104286/files#diff-cd0b5ed704ccdad2d507d4f756ac2a9b391e0c9bbb5554baf851dbebd8b5e618
View file https://github.com/AlexWaygood/cpython/blob/080871af0ffcef9fdc01d180d1c4266be48c0afb/Lib/test/test_inspect.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104286/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104286/files#diff-cd0b5ed704ccdad2d507d4f756ac2a9b391e0c9bbb5554baf851dbebd8b5e618
https://github.com/python/cpython/pull/104286/files#diff-cd0b5ed704ccdad2d507d4f756ac2a9b391e0c9bbb5554baf851dbebd8b5e618
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.