René's URL Explorer Experiment


Title: gh-87849: fix SEND specialization family definition by carljm · Pull Request #104268 · python/cpython · GitHub

Open Graph Title: gh-87849: fix SEND specialization family definition by carljm · Pull Request #104268 · python/cpython

X Title: gh-87849: fix SEND specialization family definition by carljm · Pull Request #104268 · python/cpython

Description: The family definition for SEND/SEND_GEN appears to have been copy-pasted from for_iter and not updated. Fixing this also triggered an error in the cases generator due to the mismatch in stack effec...

Open Graph Description: The family definition for SEND/SEND_GEN appears to have been copy-pasted from for_iter and not updated. Fixing this also triggered an error in the cases generator due to the mismatch in stack effec...

X Description: The family definition for SEND/SEND_GEN appears to have been copy-pasted from for_iter and not updated. Fixing this also triggered an error in the cases generator due to the mismatch in stack effec...

Opengraph URL: https://github.com/python/cpython/pull/104268

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5ea47c13-a72b-8ca4-c66a-ba1b6f5a0c60
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCAC0:62AE6:198F6C:23FD36:696A3B20
html-safe-noncec630f09d862e8d9b6fdd235d0568b331bb39e45b3d7ccc269089550bdd30af7c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQUMwOjYyQUU2OjE5OEY2QzoyM0ZEMzY6Njk2QTNCMjAiLCJ2aXNpdG9yX2lkIjoiMjY4NzY3OTU1Nzk0NTQwODI4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6b0fd63348cea07748420b3b039dc4dd118845faab237252fe57e92613230553
hovercard-subject-tagpull_request:1341184608
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104268/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/324bf4a716c4959b49a15df6539903050bb19cd36c6ac3c2ea8bfe92e7450155/python/cpython/pull/104268
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/324bf4a716c4959b49a15df6539903050bb19cd36c6ac3c2ea8bfe92e7450155/python/cpython/pull/104268
og:image:altThe family definition for SEND/SEND_GEN appears to have been copy-pasted from for_iter and not updated. Fixing this also triggered an error in the cases generator due to the mismatch in stack effec...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecarljm
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release13581a31d51edf4a3aca179e10890a4d4f9b6d76
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104268#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104268
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104268
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104268
Reloadhttps://github.com/python/cpython/pull/104268
Reloadhttps://github.com/python/cpython/pull/104268
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104268
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104268
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/104268#issue-comment-box
markshannonhttps://github.com/markshannon
python:mainhttps://github.com/python/cpython/tree/main
carljm:fixsendfamilyhttps://github.com/carljm/cpython/tree/fixsendfamily
gh-87849: fix SEND specialization family definition https://github.com/python/cpython/pull/104268#top
markshannonhttps://github.com/markshannon
python:mainhttps://github.com/python/cpython/tree/main
carljm:fixsendfamilyhttps://github.com/carljm/cpython/tree/fixsendfamily
Conversation 3 https://github.com/python/cpython/pull/104268
Commits 4 https://github.com/python/cpython/pull/104268/commits
Checks 0 https://github.com/python/cpython/pull/104268/checks
Files changed https://github.com/python/cpython/pull/104268/files
Please reload this pagehttps://github.com/python/cpython/pull/104268
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/carljm
carljmhttps://github.com/carljm
May 7, 2023https://github.com/python/cpython/pull/104268#issue-1699124065
Please reload this pagehttps://github.com/python/cpython/pull/104268
Handle generator (and coroutine) state in the bytecode. #87849https://github.com/python/cpython/issues/87849
Please reload this pagehttps://github.com/python/cpython/pull/104268
https://github.com/carljm
pythongh-87849https://github.com/python/cpython/issues/87849
: fix SEND specialization family definitionhttps://github.com/python/cpython/pull/104268/commits/6b0d9460cb795ebc81a79659085e9ee3416f8c72
6b0d946https://github.com/python/cpython/pull/104268/commits/6b0d9460cb795ebc81a79659085e9ee3416f8c72
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 7, 2023 https://github.com/python/cpython/pull/104268#ref-issue-1199055668
Handle generator (and coroutine) state in the bytecode. #87849 https://github.com/python/cpython/issues/87849
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 7, 2023https://github.com/python/cpython/pull/104268#event-9184532285
https://github.com/carljm
carljmhttps://github.com/carljm
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
May 7, 2023https://github.com/python/cpython/pull/104268#event-9184532625
https://github.com/carljm
carljmhttps://github.com/carljm
markshannonhttps://github.com/markshannon
May 7, 2023 15:57https://github.com/python/cpython/pull/104268#event-9184533687
https://github.com/markshannon
markshannonhttps://github.com/markshannon
May 9, 2023 https://github.com/python/cpython/pull/104268#pullrequestreview-1419016766
View reviewed changes https://github.com/python/cpython/pull/104268/files/6b0d9460cb795ebc81a79659085e9ee3416f8c72
Python/bytecodes.chttps://github.com/python/cpython/pull/104268/files/6b0d9460cb795ebc81a79659085e9ee3416f8c72#diff-729a985b0cb8b431cb291f1edb561bbbfea22e3f8c262451cd83328a0936a342
Please reload this pagehttps://github.com/python/cpython/pull/104268
carljmhttps://github.com/carljm
May 9, 2023 09:43https://github.com/python/cpython/pull/104268#commits-pushed-a614216
https://github.com/carljm
Merge branch 'main' into fixsendfamilyhttps://github.com/python/cpython/pull/104268/commits/a614216ab9fd31856ff8a7c2189606bf76030467
a614216https://github.com/python/cpython/pull/104268/commits/a614216ab9fd31856ff8a7c2189606bf76030467
pythongh-104276https://github.com/python/cpython/issues/104276
python#104277https://github.com/python/cpython/pull/104277
pythongh-97696https://github.com/python/cpython/issues/97696
python#104298https://github.com/python/cpython/pull/104298
pythongh-103193https://github.com/python/cpython/issues/103193
python#104320https://github.com/python/cpython/pull/104320
python#104309https://github.com/python/cpython/pull/104309
pythongh-90656https://github.com/python/cpython/issues/90656
python#30939https://github.com/python/cpython/pull/30939
pythongh-104180https://github.com/python/cpython/issues/104180
python#104181https://github.com/python/cpython/pull/104181
pythongh-97696https://github.com/python/cpython/issues/97696
python#104188https://github.com/python/cpython/pull/104188
pythonGH-104308https://github.com/python/cpython/issues/104308
python#104307https://github.com/python/cpython/pull/104307
pythongh-104310https://github.com/python/cpython/issues/104310
pythongh-104311https://github.com/python/cpython/pull/104311
pythongh-99113https://github.com/python/cpython/issues/99113
pythongh-104210https://github.com/python/cpython/pull/104210
pythonGH-104284https://github.com/python/cpython/issues/104284
python#104296https://github.com/python/cpython/pull/104296
pythongh-89550https://github.com/python/cpython/issues/89550
python#101251https://github.com/python/cpython/pull/101251
pythongh-104223https://github.com/python/cpython/issues/104223
python#104227https://github.com/python/cpython/pull/104227
pythongh-99108https://github.com/python/cpython/issues/99108
python#104293https://github.com/python/cpython/pull/104293
pythonGH-104145https://github.com/python/cpython/issues/104145
python#104172https://github.com/python/cpython/pull/104172
pythongh-103193https://github.com/python/cpython/issues/103193
python#104286https://github.com/python/cpython/pull/104286
python#104275https://github.com/python/cpython/pull/104275
pythongh-102500https://github.com/python/cpython/issues/102500
python#104281https://github.com/python/cpython/pull/104281
pythongh-97696https://github.com/python/cpython/issues/97696
python#104256https://github.com/python/cpython/pull/104256
pythongh-99108https://github.com/python/cpython/issues/99108
python#103597https://github.com/python/cpython/pull/103597
https://github.com/carljm
mark unused variable as suchhttps://github.com/python/cpython/pull/104268/commits/f44e763ece3949f998265357523a89645dc60384
f44e763https://github.com/python/cpython/pull/104268/commits/f44e763ece3949f998265357523a89645dc60384
https://github.com/carljm
Merge branch 'main' into fixsendfamilyhttps://github.com/python/cpython/pull/104268/commits/e40071d385661a07b89429554f93474a097f193f
e40071dhttps://github.com/python/cpython/pull/104268/commits/e40071d385661a07b89429554f93474a097f193f
pythongh-97696https://github.com/python/cpython/issues/97696
python#104304https://github.com/python/cpython/pull/104304
pythongh-97933https://github.com/python/cpython/issues/97933
python#101441https://github.com/python/cpython/pull/101441
pythongh-99889https://github.com/python/cpython/issues/99889
python#104096https://github.com/python/cpython/pull/104096
pythongh-104184https://github.com/python/cpython/issues/104184
python#104217https://github.com/python/cpython/pull/104217
pythongh-104139https://github.com/python/cpython/issues/104139
python#104312https://github.com/python/cpython/pull/104312
pythongh-104240https://github.com/python/cpython/issues/104240
python#104300https://github.com/python/cpython/pull/104300
https://github.com/markshannon
markshannonhttps://github.com/markshannon
May 11, 2023 11:51https://github.com/python/cpython/pull/104268#event-9221501320
https://github.com/markshannon
markshannonhttps://github.com/markshannon
May 11, 2023 https://github.com/python/cpython/pull/104268#pullrequestreview-1422428101
View reviewed changes https://github.com/python/cpython/pull/104268/files/e40071d385661a07b89429554f93474a097f193f
markshannonhttps://github.com/markshannon
https://github.com/python/cpython/pull/104268#pullrequestreview-1422428101
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104268
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 11, 2023https://github.com/python/cpython/pull/104268#event-9221503926
https://github.com/markshannon
markshannonhttps://github.com/markshannon
1670729https://github.com/python/cpython/commit/167072938342981b96d06d739cd97185207b64dd
May 11, 2023https://github.com/python/cpython/pull/104268#event-9221510647
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 11, 2023https://github.com/python/cpython/pull/104268#event-9221511117
carljmhttps://github.com/carljm
May 11, 2023 https://github.com/python/cpython/pull/104268#ref-commit-19b3d9e
https://github.com/carljm
Merge branch 'main' into supermonhttps://github.com/carljm/cpython/commit/19b3d9ef01efa4c931b0224849bb8eaccd3c9fa6
19b3d9ehttps://github.com/carljm/cpython/commit/19b3d9ef01efa4c931b0224849bb8eaccd3c9fa6
pythongh-87849https://github.com/python/cpython/issues/87849
pythonGH-104268https://github.com/python/cpython/pull/104268
pythongh-101819https://github.com/python/cpython/issues/101819
python#104384https://github.com/python/cpython/pull/104384
pythongh-101819https://github.com/python/cpython/issues/101819
python#104367https://github.com/python/cpython/pull/104367
pythongh-101819https://github.com/python/cpython/issues/101819
python#104369https://github.com/python/cpython/pull/104369
pythongh-101819https://github.com/python/cpython/issues/101819
python#104383https://github.com/python/cpython/pull/104383
pythongh-101117https://github.com/python/cpython/issues/101117
python#104287https://github.com/python/cpython/pull/104287
pythonGH-92184https://github.com/python/cpython/issues/92184
python#92185https://github.com/python/cpython/pull/92185
pythongh-104357https://github.com/python/cpython/issues/104357
python#104368https://github.com/python/cpython/pull/104368
pythonGH-90208https://github.com/python/cpython/issues/90208
pythonGH-104141https://github.com/python/cpython/pull/104141
pythonGH-102181https://github.com/python/cpython/issues/102181
pythonGH-102182https://github.com/python/cpython/pull/102182
pythongh-103000https://github.com/python/cpython/issues/103000
python#104364https://github.com/python/cpython/pull/104364
pythongh-103538https://github.com/python/cpython/issues/103538
pythonGH-103539https://github.com/python/cpython/pull/103539
pythonGH-87695https://github.com/python/cpython/issues/87695
pythonGH-104292https://github.com/python/cpython/pull/104292
pythongh-104263https://github.com/python/cpython/issues/104263
pythonGH-104202https://github.com/python/cpython/pull/104202
pythongh-104010https://github.com/python/cpython/issues/104010
python#104013https://github.com/python/cpython/pull/104013
pythongh-101819https://github.com/python/cpython/issues/101819
python#104355https://github.com/python/cpython/pull/104355
pythongh-103960https://github.com/python/cpython/issues/103960
python#103983https://github.com/python/cpython/pull/103983
pythongh-104252https://github.com/python/cpython/issues/104252
pythongh-104253https://github.com/python/cpython/pull/104253
pythongh-101819https://github.com/python/cpython/issues/101819
pythongh-104197https://github.com/python/cpython/pull/104197
python#104354https://github.com/python/cpython/pull/104354
pythongh-101819https://github.com/python/cpython/issues/101819
python#104352https://github.com/python/cpython/pull/104352
carljmhttps://github.com/carljm
May 11, 2023 https://github.com/python/cpython/pull/104268#ref-commit-4456dd6
https://github.com/carljm
Merge branch 'main' into fixloadsuperspechttps://github.com/carljm/cpython/commit/4456dd6059df588e2542dc29e217aab19ceffc32
4456dd6https://github.com/carljm/cpython/commit/4456dd6059df588e2542dc29e217aab19ceffc32
pythongh-87849https://github.com/python/cpython/issues/87849
pythonGH-104268https://github.com/python/cpython/pull/104268
pythongh-101819https://github.com/python/cpython/issues/101819
python#104384https://github.com/python/cpython/pull/104384
pythongh-101819https://github.com/python/cpython/issues/101819
python#104367https://github.com/python/cpython/pull/104367
pythongh-101819https://github.com/python/cpython/issues/101819
python#104369https://github.com/python/cpython/pull/104369
pythongh-101819https://github.com/python/cpython/issues/101819
python#104383https://github.com/python/cpython/pull/104383
pythongh-101117https://github.com/python/cpython/issues/101117
python#104287https://github.com/python/cpython/pull/104287
pythonGH-92184https://github.com/python/cpython/issues/92184
python#92185https://github.com/python/cpython/pull/92185
pythongh-104357https://github.com/python/cpython/issues/104357
python#104368https://github.com/python/cpython/pull/104368
pythonGH-90208https://github.com/python/cpython/issues/90208
pythonGH-104141https://github.com/python/cpython/pull/104141
https://github.com/carljm
carljmhttps://github.com/carljm
May 11, 2023 12:18https://github.com/python/cpython/pull/104268#event-9221773017
bytecodes.c has inconsistent family definition for SEND/SEND_GEN #103296 https://github.com/python/cpython/issues/103296
Streamline family syntax in Tools/cases_generator #106706 https://github.com/python/cpython/issues/106706
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104268
https://github.com/markshannon
markshannon https://github.com/markshannon
https://github.com/python/cpython/pull/104268/files/e40071d385661a07b89429554f93474a097f193f
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/104268
https://github.com/carljm
https://github.com/markshannon
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.