René's URL Explorer Experiment


Title: gh-104265 Disallow instantiation of `_csv.Reader` and `_csv.Writer` by chgnrdv · Pull Request #104266 · python/cpython · GitHub

Open Graph Title: gh-104265 Disallow instantiation of `_csv.Reader` and `_csv.Writer` by chgnrdv · Pull Request #104266 · python/cpython

X Title: gh-104265 Disallow instantiation of `_csv.Reader` and `_csv.Writer` by chgnrdv · Pull Request #104266 · python/cpython

Description: Fixes #104265 Set Py_TPFLAGS_DISALLOW_INSTANTIATION and unset Py_TPFLAGS_BASETYPE flags on Reader and Writer types to prevent their instantiation and subtyping Issue: gh-104265

Open Graph Description: Fixes #104265 Set Py_TPFLAGS_DISALLOW_INSTANTIATION and unset Py_TPFLAGS_BASETYPE flags on Reader and Writer types to prevent their instantiation and subtyping Issue: gh-104265

X Description: Fixes #104265 Set Py_TPFLAGS_DISALLOW_INSTANTIATION and unset Py_TPFLAGS_BASETYPE flags on Reader and Writer types to prevent their instantiation and subtyping Issue: gh-104265

Opengraph URL: https://github.com/python/cpython/pull/104266

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f4bc1a03-45b6-1c03-9bb5-10d5b571fe49
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id92A2:2AC946:529DB7:6FB16D:6969B1B3
html-safe-nonceaff5a911af2f44ec1de99997b691e259461c9f1b052f46db1ce517b345bfbf19
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkEyOjJBQzk0Njo1MjlEQjc6NkZCMTZEOjY5NjlCMUIzIiwidmlzaXRvcl9pZCI6IjE1MDc4NTY1MTcwOTAwOTU1MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0dfc19bec6fbd106d24da5dc17299874c2694ff8cb84e901b54d9a8dc4319523
hovercard-subject-tagpull_request:1341118850
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/104266/files
twitter:imagehttps://avatars.githubusercontent.com/u/52372310?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/52372310?s=400&v=4
og:image:altFixes #104265 Set Py_TPFLAGS_DISALLOW_INSTANTIATION and unset Py_TPFLAGS_BASETYPE flags on Reader and Writer types to prevent their instantiation and subtyping Issue: gh-104265
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb23b8fcc855cd29bb04d6c94aafa62d336bf44eefa8229444eecc968cad03aee
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0672399d88424758731ec07fe24509e23bb17fb5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104266/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104266%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104266%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104266/files
Reloadhttps://github.com/python/cpython/pull/104266/files
Reloadhttps://github.com/python/cpython/pull/104266/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104266/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104266/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
Conversation 18 https://github.com/python/cpython/pull/104266
Commits 13 https://github.com/python/cpython/pull/104266/commits
Checks 0 https://github.com/python/cpython/pull/104266/checks
Files changed https://github.com/python/cpython/pull/104266/files
Please reload this pagehttps://github.com/python/cpython/pull/104266/files
gh-104265 Disallow instantiation of _csv.Reader and _csv.Writer https://github.com/python/cpython/pull/104266/files#top
Show all changes 13 commits https://github.com/python/cpython/pull/104266/files
ae69f9b Disallow instantiation and subtyping of `_csv.Reader` and `_csv.Write… chgnrdv May 7, 2023 https://github.com/python/cpython/pull/104266/commits/ae69f9b8e4a8987ff814006f9b3731e0185d320b
7d1fcd8 added test chgnrdv May 7, 2023 https://github.com/python/cpython/pull/104266/commits/7d1fcd809040aeb0ff3bd8efd52a52feb8678cb1
aa34fae changed tests to use check_disallow_instantiation, separated tests chgnrdv May 7, 2023 https://github.com/python/cpython/pull/104266/commits/aa34fae64b55982bb0abb8a306f4075fe17292c1
6c45ff8 reverted Py_TPFLAGS_BASETYPE flag deletion, removed corresponding tests chgnrdv May 7, 2023 https://github.com/python/cpython/pull/104266/commits/6c45ff87210c6e26633e24f9a45b11adf0b4bd71
7d9ec2a 📜🤖 Added by blurb_it. blurb-it[bot] May 7, 2023 https://github.com/python/cpython/pull/104266/commits/7d9ec2a140c846dcaa2e13b16106047fab4d3a93
19bddd0 Update 2023-05-07-16-13-07.gh-issue-104265.fU60bZ.rst chgnrdv May 7, 2023 https://github.com/python/cpython/pull/104266/commits/19bddd06eb3eec41561c0356c97ce38797b92af9
b3f4a65 Update 2023-05-07-16-13-07.gh-issue-104265.fU60bZ.rst chgnrdv May 7, 2023 https://github.com/python/cpython/pull/104266/commits/b3f4a65c5d6b49ce6a59b6abd84bedfabc2f3460
a022e91 Update 2023-05-07-16-13-07.gh-issue-104265.fU60bZ.rst chgnrdv May 7, 2023 https://github.com/python/cpython/pull/104266/commits/a022e91600542a25e011649873a2c7af7adb080f
52aacfd 📜🤖 Added by blurb_it. blurb-it[bot] May 7, 2023 https://github.com/python/cpython/pull/104266/commits/52aacfd58f25b44b112ce8e437c0bb895a982d1b
d31d214 Delete 2023-05-07-16-13-07.gh-issue-104265.fU60bZ.rst chgnrdv May 7, 2023 https://github.com/python/cpython/pull/104266/commits/d31d2140b1356cc89b0e4b5a5df47f84de290bb9
2804744 Update Misc/NEWS.d/next/Library/2023-05-07-19-56-45.gh-issue-104265.f… erlend-aasland May 7, 2023 https://github.com/python/cpython/pull/104266/commits/28047448a58d9e4525b710e417a91a3ad60f7a7d
8255467 applied suggestion by erlend-aasland chgnrdv May 7, 2023 https://github.com/python/cpython/pull/104266/commits/8255467fac91c691367f1b38a1a89a28f68dd5bc
73609a8 Merge branch '_csv-make-Reader-Writer-types-non-instantiable' of gith… chgnrdv May 7, 2023 https://github.com/python/cpython/pull/104266/commits/73609a830637406fe9984d2863edb81fb04045fa
Clear filters https://github.com/python/cpython/pull/104266/files
Please reload this pagehttps://github.com/python/cpython/pull/104266/files
Please reload this pagehttps://github.com/python/cpython/pull/104266/files
test_csv.py https://github.com/python/cpython/pull/104266/files#diff-dd5e5efc1566b1c1dc988769a04cc403d2416c8af5bf4785bec235d02a780813
2023-05-07-19-56-45.gh-issue-104265.fVblry.rst https://github.com/python/cpython/pull/104266/files#diff-9a7416be5160dc546efa5c00c171596475e3583145f268988a96fae9571fcafd
_csv.c https://github.com/python/cpython/pull/104266/files#diff-38fcce6bb475616052f5c9a0973eefd49489a4dff719f30e407534258e2a3ec3
Lib/test/test_csv.pyhttps://github.com/python/cpython/pull/104266/files#diff-dd5e5efc1566b1c1dc988769a04cc403d2416c8af5bf4785bec235d02a780813
View file https://github.com/python/cpython/blob/73609a830637406fe9984d2863edb81fb04045fa/Lib/test/test_csv.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104266/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104266/files#diff-dd5e5efc1566b1c1dc988769a04cc403d2416c8af5bf4785bec235d02a780813
https://github.com/python/cpython/pull/104266/files#diff-dd5e5efc1566b1c1dc988769a04cc403d2416c8af5bf4785bec235d02a780813
https://github.com/python/cpython/pull/104266/files#diff-dd5e5efc1566b1c1dc988769a04cc403d2416c8af5bf4785bec235d02a780813
Misc/NEWS.d/next/Library/2023-05-07-19-56-45.gh-issue-104265.fVblry.rsthttps://github.com/python/cpython/pull/104266/files#diff-9a7416be5160dc546efa5c00c171596475e3583145f268988a96fae9571fcafd
View file https://github.com/python/cpython/blob/73609a830637406fe9984d2863edb81fb04045fa/Misc/NEWS.d/next/Library/2023-05-07-19-56-45.gh-issue-104265.fVblry.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104266/{{ revealButtonHref }}
Modules/_csv.chttps://github.com/python/cpython/pull/104266/files#diff-38fcce6bb475616052f5c9a0973eefd49489a4dff719f30e407534258e2a3ec3
View file https://github.com/python/cpython/blob/73609a830637406fe9984d2863edb81fb04045fa/Modules/_csv.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104266/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104266/files#diff-38fcce6bb475616052f5c9a0973eefd49489a4dff719f30e407534258e2a3ec3
https://github.com/python/cpython/pull/104266/files#diff-38fcce6bb475616052f5c9a0973eefd49489a4dff719f30e407534258e2a3ec3
https://github.com/python/cpython/pull/104266/files#diff-38fcce6bb475616052f5c9a0973eefd49489a4dff719f30e407534258e2a3ec3
https://github.com/python/cpython/pull/104266/files#diff-38fcce6bb475616052f5c9a0973eefd49489a4dff719f30e407534258e2a3ec3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.