René's URL Explorer Experiment


Title: gh-104252: Immortalize Py_EMPTY_KEYS by ericsnowcurrently · Pull Request #104253 · python/cpython · GitHub

Open Graph Title: gh-104252: Immortalize Py_EMPTY_KEYS by ericsnowcurrently · Pull Request #104253 · python/cpython

X Title: gh-104252: Immortalize Py_EMPTY_KEYS by ericsnowcurrently · Pull Request #104253 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This was missed in gh-19474. It matters for with a per-interpreter GIL since PyDictKeysObject.dk_refcnt breaks isolation and leads to races. cc @eduardo-elizondo Issue: Immortalize Py_EMPTY_KEYS...

X Description: This was missed in gh-19474. It matters for with a per-interpreter GIL since PyDictKeysObject.dk_refcnt breaks isolation and leads to races. cc @eduardo-elizondo Issue: Immortalize Py_EMPTY_KEYS...

Opengraph URL: https://github.com/python/cpython/pull/104253

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:8a66217b-6faf-096d-69fc-ce287f75f1e5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8972:363784:166C1:1ECA8:6969F8AB
html-safe-nonce965b06754c09c46dea771c764ea9a4edb5d0963f3bca476d00694450ccba98d6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTcyOjM2Mzc4NDoxNjZDMToxRUNBODo2OTY5RjhBQiIsInZpc2l0b3JfaWQiOiIxMzY5ODQ4MzYwMTkyMzA5NDE5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1a9c5b540863950f63e8ee97f06a34345fac9cd1380f708cb0ca2f2d57061271
hovercard-subject-tagpull_request:1340931462
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/104253/commits
twitter:imagehttps://opengraph.githubassets.com/ee311d0446d2be637223d1aa5a645a4678137e5f55bcd984b110ab0e31bdff1e/python/cpython/pull/104253
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ee311d0446d2be637223d1aa5a645a4678137e5f55bcd984b110ab0e31bdff1e/python/cpython/pull/104253
og:image:altThis was missed in gh-19474. It matters for with a per-interpreter GIL since PyDictKeysObject.dk_refcnt breaks isolation and leads to races. cc @eduardo-elizondo Issue: Immortalize Py_EMPTY_KEYS...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericsnowcurrently
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104253/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104253%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104253%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104253/commits
Reloadhttps://github.com/python/cpython/pull/104253/commits
Reloadhttps://github.com/python/cpython/pull/104253/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104253/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104253/commits
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:immortalize-empty-keyshttps://github.com/ericsnowcurrently/cpython/tree/immortalize-empty-keys
Conversationhttps://github.com/python/cpython/pull/104253
Commits10 (10)https://github.com/python/cpython/pull/104253/commits
Checkshttps://github.com/python/cpython/pull/104253/checks
Files changedhttps://github.com/python/cpython/pull/104253/files
gh-104252: Immortalize Py_EMPTY_KEYShttps://github.com/python/cpython/pull/104253/commits#top
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:immortalize-empty-keyshttps://github.com/ericsnowcurrently/cpython/tree/immortalize-empty-keys
Factor out _dict_state_INIT.https://github.com/python/cpython/pull/104253/commits/5bc2469e313d47e8e0daa7ffd3333e5638cfcbf2
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/python/cpython/commits?author=ericsnowcurrently
5bc2469https://github.com/python/cpython/pull/104253/commits/5bc2469e313d47e8e0daa7ffd3333e5638cfcbf2
https://github.com/python/cpython/tree/5bc2469e313d47e8e0daa7ffd3333e5638cfcbf2
Immortalize Py_EMPTY_KEYS.https://github.com/python/cpython/pull/104253/commits/e472d944abd7bdccdeaae96623b46580072f53c9
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/python/cpython/commits?author=ericsnowcurrently
e472d94https://github.com/python/cpython/pull/104253/commits/e472d944abd7bdccdeaae96623b46580072f53c9
https://github.com/python/cpython/tree/e472d944abd7bdccdeaae96623b46580072f53c9
Handle other uses of dk_refcnt.https://github.com/python/cpython/pull/104253/commits/87351e0159fd9b758e715f2033e57cec9165cb5b
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/python/cpython/commits?author=ericsnowcurrently
87351e0https://github.com/python/cpython/pull/104253/commits/87351e0159fd9b758e715f2033e57cec9165cb5b
https://github.com/python/cpython/tree/87351e0159fd9b758e715f2033e57cec9165cb5b
Add a note.https://github.com/python/cpython/pull/104253/commits/f5da08808d8cc957989a9552ccdbf13897af9acc
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/python/cpython/commits?author=ericsnowcurrently
f5da088https://github.com/python/cpython/pull/104253/commits/f5da08808d8cc957989a9552ccdbf13897af9acc
https://github.com/python/cpython/tree/f5da08808d8cc957989a9552ccdbf13897af9acc
Drop an old line.https://github.com/python/cpython/pull/104253/commits/db8612fbb0a1c75c7a1c1f605fc7d5ac733ffe16
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/python/cpython/commits?author=ericsnowcurrently
db8612fhttps://github.com/python/cpython/pull/104253/commits/db8612fbb0a1c75c7a1c1f605fc7d5ac733ffe16
https://github.com/python/cpython/tree/db8612fbb0a1c75c7a1c1f605fc7d5ac733ffe16
Drop an unnecessary condition.https://github.com/python/cpython/pull/104253/commits/58585a9a983002c2d76c9524d60750d32c7d69ef
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/python/cpython/commits?author=ericsnowcurrently
58585a9https://github.com/python/cpython/pull/104253/commits/58585a9a983002c2d76c9524d60750d32c7d69ef
https://github.com/python/cpython/tree/58585a9a983002c2d76c9524d60750d32c7d69ef
Drop an unnecessary assert.https://github.com/python/cpython/pull/104253/commits/6b5c952eddb429c7cddb513884e9613dfd8c76d9
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/python/cpython/commits?author=ericsnowcurrently
6b5c952https://github.com/python/cpython/pull/104253/commits/6b5c952eddb429c7cddb513884e9613dfd8c76d9
https://github.com/python/cpython/tree/6b5c952eddb429c7cddb513884e9613dfd8c76d9
Do not bother inc/dec-refing Py_EMPTY_KEYS.https://github.com/python/cpython/pull/104253/commits/bdbce5f693ffdb40e5887e600a1422a98b89ce69
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/python/cpython/commits?author=ericsnowcurrently
bdbce5fhttps://github.com/python/cpython/pull/104253/commits/bdbce5f693ffdb40e5887e600a1422a98b89ce69
https://github.com/python/cpython/tree/bdbce5f693ffdb40e5887e600a1422a98b89ce69
Do not update Py_Reftotal for Py_EMPTY_KEYS.https://github.com/python/cpython/pull/104253/commits/aab493ae2e76368af63581617591caec1be874e9
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/python/cpython/commits?author=ericsnowcurrently
aab493ahttps://github.com/python/cpython/pull/104253/commits/aab493ae2e76368af63581617591caec1be874e9
https://github.com/python/cpython/tree/aab493ae2e76368af63581617591caec1be874e9
Clarify the comment about dictkeys_incref() and dictkeys_decref().https://github.com/python/cpython/pull/104253/commits/5aabfd77b1bba5de8b5ff1a5fbac9a6e32e82dd6
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/python/cpython/commits?author=ericsnowcurrently
5aabfd7https://github.com/python/cpython/pull/104253/commits/5aabfd77b1bba5de8b5ff1a5fbac9a6e32e82dd6
https://github.com/python/cpython/tree/5aabfd77b1bba5de8b5ff1a5fbac9a6e32e82dd6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.