René's URL Explorer Experiment


Title: gh-99113: Make Sure the GIL is Acquired at the Right Places by ericsnowcurrently · Pull Request #104208 · python/cpython · GitHub

Open Graph Title: gh-99113: Make Sure the GIL is Acquired at the Right Places by ericsnowcurrently · Pull Request #104208 · python/cpython

X Title: gh-99113: Make Sure the GIL is Acquired at the Right Places by ericsnowcurrently · Pull Request #104208 · python/cpython

Description: This is a pre-requisite for a per-interpreter GIL. Without it this change isn't strictly necessary. However, there is no downside otherwise. (This change is broken out from gh-99114.) Issue: gh-99113

Open Graph Description: This is a pre-requisite for a per-interpreter GIL. Without it this change isn't strictly necessary. However, there is no downside otherwise. (This change is broken out from gh-99114.) Issue...

X Description: This is a pre-requisite for a per-interpreter GIL. Without it this change isn't strictly necessary. However, there is no downside otherwise. (This change is broken out from gh-99114.) I...

Opengraph URL: https://github.com/python/cpython/pull/104208

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bbc73ae8-874a-82d8-f9f1-4cdbc4838d01
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id88F4:1D70BE:C47894:106AEEB:69699870
html-safe-nonce3ffb6f0dca61fd5d7c141875bd249563e38230f66b8ce6563690d24142d166a2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OEY0OjFENzBCRTpDNDc4OTQ6MTA2QUVFQjo2OTY5OTg3MCIsInZpc2l0b3JfaWQiOiI2MDcxNjUyMDkxMDkzOTQ4NTI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacebfedbe99b2ec91356d2ca92879a09e01a912b86434f42aaf94315dd5b3d58c7
hovercard-subject-tagpull_request:1340194533
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/104208/files
twitter:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
og:image:altThis is a pre-requisite for a per-interpreter GIL. Without it this change isn't strictly necessary. However, there is no downside otherwise. (This change is broken out from gh-99114.) Issue...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3542e147982176a7ebaa23dfb559c8af16f721c03ec560c68c56b64a0f35e751
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseaf80af7cc9e3de9c336f18b208a600950a3c187c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104208/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104208%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104208%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104208/files
Reloadhttps://github.com/python/cpython/pull/104208/files
Reloadhttps://github.com/python/cpython/pull/104208/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104208/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104208/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:fix-acquiring-gilhttps://github.com/ericsnowcurrently/cpython/tree/fix-acquiring-gil
Conversation 15 https://github.com/python/cpython/pull/104208
Commits 7 https://github.com/python/cpython/pull/104208/commits
Checks 0 https://github.com/python/cpython/pull/104208/checks
Files changed https://github.com/python/cpython/pull/104208/files
Please reload this pagehttps://github.com/python/cpython/pull/104208/files
gh-99113: Make Sure the GIL is Acquired at the Right Places https://github.com/python/cpython/pull/104208/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/104208/files
ca1f78e Add _PyEval_AcquireLock(). ericsnowcurrently Apr 10, 2023 https://github.com/python/cpython/pull/104208/commits/ca1f78e8a17759157df576b410d3a61e807aa307
c5d3b2c Add _PyThreadState_SwapNoGIL(). ericsnowcurrently Apr 10, 2023 https://github.com/python/cpython/pull/104208/commits/c5d3b2cc5843e66c652bff50c6f3373c15ea98e6
2404310 Acquire the GIL when not owned. ericsnowcurrently Apr 10, 2023 https://github.com/python/cpython/pull/104208/commits/2404310dea7c14a59fba9a7ffae4f203005bbf4f
85702ae Fix a typo. ericsnowcurrently May 6, 2023 https://github.com/python/cpython/pull/104208/commits/85702ae366068db7923dca2190f665e970f6ab60
3cc9dc3 Do not release the GIL when not necessary. ericsnowcurrently May 6, 2023 https://github.com/python/cpython/pull/104208/commits/3cc9dc3d8382aa4d84017b6f2adfa9e23e9cdf01
3104796 Make sure the GIL is held by the current thread in _PyEval_InitGIL(). ericsnowcurrently May 6, 2023 https://github.com/python/cpython/pull/104208/commits/3104796f16f3a6e25340fa9247e532d8863ff283
56064c7 Release the GIL after swapping thread states. ericsnowcurrently May 6, 2023 https://github.com/python/cpython/pull/104208/commits/56064c7973aad97e9c5fe745796e62d46ed6442c
Clear filters https://github.com/python/cpython/pull/104208/files
Please reload this pagehttps://github.com/python/cpython/pull/104208/files
Please reload this pagehttps://github.com/python/cpython/pull/104208/files
pycore_ceval.h https://github.com/python/cpython/pull/104208/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
ceval_gil.c https://github.com/python/cpython/pull/104208/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
pylifecycle.c https://github.com/python/cpython/pull/104208/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
pystate.c https://github.com/python/cpython/pull/104208/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
Include/internal/pycore_ceval.hhttps://github.com/python/cpython/pull/104208/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
View file https://github.com/ericsnowcurrently/cpython/blob/56064c7973aad97e9c5fe745796e62d46ed6442c/Include/internal/pycore_ceval.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104208/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104208/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
https://github.com/python/cpython/pull/104208/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L309
Python/ceval_gil.chttps://github.com/python/cpython/pull/104208/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
View file https://github.com/ericsnowcurrently/cpython/blob/56064c7973aad97e9c5fe745796e62d46ed6442c/Python/ceval_gil.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104208/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104208/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
Please reload this pagehttps://github.com/python/cpython/pull/104208/files
https://github.com/python/cpython/pull/104208/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
https://github.com/python/cpython/pull/104208/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
https://github.com/python/cpython/pull/104208/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
https://github.com/python/cpython/pull/104208/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
https://github.com/python/cpython/pull/104208/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
https://github.com/python/cpython/pull/104208/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
https://github.com/python/cpython/pull/104208/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
https://github.com/python/cpython/pull/104208/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
https://github.com/python/cpython/pull/104208/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
https://github.com/python/cpython/pull/104208/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
https://github.com/python/cpython/pull/104208/files#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L310
Python/pylifecycle.chttps://github.com/python/cpython/pull/104208/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
View file https://github.com/ericsnowcurrently/cpython/blob/56064c7973aad97e9c5fe745796e62d46ed6442c/Python/pylifecycle.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104208/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104208/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
https://github.com/python/cpython/pull/104208/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
https://github.com/python/cpython/pull/104208/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
https://github.com/python/cpython/pull/104208/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
https://github.com/python/cpython/pull/104208/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
https://github.com/python/cpython/pull/104208/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
https://github.com/python/cpython/pull/104208/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
https://github.com/python/cpython/pull/104208/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
https://github.com/python/cpython/pull/104208/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L311
Python/pystate.chttps://github.com/python/cpython/pull/104208/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
View file https://github.com/ericsnowcurrently/cpython/blob/56064c7973aad97e9c5fe745796e62d46ed6442c/Python/pystate.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/104208/{{ revealButtonHref }}
https://github.com/python/cpython/pull/104208/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/104208/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com/python/cpython/pull/104208/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.