René's URL Explorer Experiment


Title: gh-99113: Make Sure the GIL is Acquired at the Right Places by ericsnowcurrently · Pull Request #104208 · python/cpython · GitHub

Open Graph Title: gh-99113: Make Sure the GIL is Acquired at the Right Places by ericsnowcurrently · Pull Request #104208 · python/cpython

X Title: gh-99113: Make Sure the GIL is Acquired at the Right Places by ericsnowcurrently · Pull Request #104208 · python/cpython

Description: This is a pre-requisite for a per-interpreter GIL. Without it this change isn't strictly necessary. However, there is no downside otherwise. (This change is broken out from gh-99114.) Issue: Im...

Open Graph Description: This is a pre-requisite for a per-interpreter GIL. Without it this change isn't strictly necessary. However, there is no downside otherwise. (This change is broken out from gh-99114.) Issue...

X Description: This is a pre-requisite for a per-interpreter GIL. Without it this change isn't strictly necessary. However, there is no downside otherwise. (This change is broken out from gh-99114.) I...

Opengraph URL: https://github.com/python/cpython/pull/104208

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b59a0230-746a-f0eb-75a9-17fc4afd9cc1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BCE:23CDC6:985E35:CC9579:69697CE2
html-safe-nonce6a40c3fc6a09c8c002029567fa8ce40e01dd638715cdc4d5c8c532d8af3a8746
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkNFOjIzQ0RDNjo5ODVFMzU6Q0M5NTc5OjY5Njk3Q0UyIiwidmlzaXRvcl9pZCI6IjQwNzkyNDc1NjU5ODQ5ODgzODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac11caab8c55fc9472d0a9684679f6a9de6e60e7bc4c3bb0340b318e859d88c16d
hovercard-subject-tagpull_request:1340194533
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104208/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a80076c9890c67ba3ccbf5bbf935f192e7b0aeb1769322e8b7751b231d194b05/python/cpython/pull/104208
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a80076c9890c67ba3ccbf5bbf935f192e7b0aeb1769322e8b7751b231d194b05/python/cpython/pull/104208
og:image:altThis is a pre-requisite for a per-interpreter GIL. Without it this change isn't strictly necessary. However, there is no downside otherwise. (This change is broken out from gh-99114.) Issue...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericsnowcurrently
hostnamegithub.com
expected-hostnamegithub.com
Nonef33e4b94c8824ab2b434d82a94139432fb5ebee9df4b75304140ad22508c4a77
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release48f380098b30acbb700b04f1724481ca10d574fc
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104208#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104208
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104208
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104208
Reloadhttps://github.com/python/cpython/pull/104208
Reloadhttps://github.com/python/cpython/pull/104208
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104208
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104208
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/104208#issue-comment-box
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:fix-acquiring-gilhttps://github.com/ericsnowcurrently/cpython/tree/fix-acquiring-gil
gh-99113: Make Sure the GIL is Acquired at the Right Places https://github.com/python/cpython/pull/104208#top
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:fix-acquiring-gilhttps://github.com/ericsnowcurrently/cpython/tree/fix-acquiring-gil
Conversation 15 https://github.com/python/cpython/pull/104208
Commits 7 https://github.com/python/cpython/pull/104208/commits
Checks 0 https://github.com/python/cpython/pull/104208/checks
Files changed https://github.com/python/cpython/pull/104208/files
Please reload this pagehttps://github.com/python/cpython/pull/104208
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 5, 2023https://github.com/python/cpython/pull/104208#issue-1697965554
Please reload this pagehttps://github.com/python/cpython/pull/104208
gh-99114https://github.com/python/cpython/pull/99114
Implement PEP 684: A Per-Interpreter GIL #99113https://github.com/python/cpython/issues/99113
Please reload this pagehttps://github.com/python/cpython/pull/104208
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
May 5, 2023https://github.com/python/cpython/pull/104208#event-9179093673
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 5, 2023 https://github.com/python/cpython/pull/104208#ref-issue-1436754839
Implement PEP 684: A Per-Interpreter GIL #99113 https://github.com/python/cpython/issues/99113
gh-99113: A Per-Interpreter GIL! #104210 https://github.com/python/cpython/pull/104210
gh-99113: A Per-Interpreter GIL! #99114 https://github.com/python/cpython/pull/99114
https://github.com/Eclips4
Eclips4https://github.com/Eclips4
May 5, 2023https://github.com/python/cpython/pull/104208#issuecomment-1536657917
Please reload this pagehttps://github.com/python/cpython/pull/104208
Please reload this pagehttps://github.com/python/cpython/pull/104208
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 5, 2023https://github.com/python/cpython/pull/104208#issuecomment-1536816088
@Eclips4https://github.com/Eclips4
#99114https://github.com/python/cpython/pull/99114
Please reload this pagehttps://github.com/python/cpython/pull/104208
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
force-pushedhttps://github.com/python/cpython/compare/ad1e40b332c336ba7b367aeb5aa5654093622bc3..d6c15f9e9a5219099cc9927f7407aa9e6c324de5
ad1e40bhttps://github.com/python/cpython/commit/ad1e40b332c336ba7b367aeb5aa5654093622bc3
d6c15f9https://github.com/python/cpython/commit/d6c15f9e9a5219099cc9927f7407aa9e6c324de5
Compare https://github.com/python/cpython/compare/ad1e40b332c336ba7b367aeb5aa5654093622bc3..d6c15f9e9a5219099cc9927f7407aa9e6c324de5
May 5, 2023 21:46https://github.com/python/cpython/pull/104208#event-9180659145
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 5, 2023https://github.com/python/cpython/pull/104208#issuecomment-1536818509
@Eclips4https://github.com/Eclips4
Please reload this pagehttps://github.com/python/cpython/pull/104208
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 5, 2023 16:01https://github.com/python/cpython/pull/104208#commits-pushed-ca1f78e
https://github.com/ericsnowcurrently
Add _PyEval_AcquireLock().https://github.com/python/cpython/pull/104208/commits/ca1f78e8a17759157df576b410d3a61e807aa307
ca1f78ehttps://github.com/python/cpython/pull/104208/commits/ca1f78e8a17759157df576b410d3a61e807aa307
https://github.com/ericsnowcurrently
Add _PyThreadState_SwapNoGIL().https://github.com/python/cpython/pull/104208/commits/c5d3b2cc5843e66c652bff50c6f3373c15ea98e6
c5d3b2chttps://github.com/python/cpython/pull/104208/commits/c5d3b2cc5843e66c652bff50c6f3373c15ea98e6
https://github.com/ericsnowcurrently
Acquire the GIL when not owned.https://github.com/python/cpython/pull/104208/commits/2404310dea7c14a59fba9a7ffae4f203005bbf4f
2404310https://github.com/python/cpython/pull/104208/commits/2404310dea7c14a59fba9a7ffae4f203005bbf4f
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
force-pushedhttps://github.com/python/cpython/compare/d6c15f9e9a5219099cc9927f7407aa9e6c324de5..2404310dea7c14a59fba9a7ffae4f203005bbf4f
d6c15f9https://github.com/python/cpython/commit/d6c15f9e9a5219099cc9927f7407aa9e6c324de5
2404310https://github.com/python/cpython/commit/2404310dea7c14a59fba9a7ffae4f203005bbf4f
Compare https://github.com/python/cpython/compare/d6c15f9e9a5219099cc9927f7407aa9e6c324de5..2404310dea7c14a59fba9a7ffae4f203005bbf4f
May 5, 2023 22:03https://github.com/python/cpython/pull/104208#event-9180732204
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 5, 2023 22:03https://github.com/python/cpython/pull/104208#event-9180734644
https://github.com/Eclips4
Eclips4https://github.com/Eclips4
May 6, 2023https://github.com/python/cpython/pull/104208#issuecomment-1537075084
Please reload this pagehttps://github.com/python/cpython/pull/104208
Please reload this pagehttps://github.com/python/cpython/pull/104208
https://github.com/Eclips4
Eclips4https://github.com/Eclips4
May 6, 2023https://github.com/python/cpython/pull/104208#issuecomment-1537075286
Please reload this pagehttps://github.com/python/cpython/pull/104208
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 6, 2023 10:34https://github.com/python/cpython/pull/104208#commits-pushed-85702ae
https://github.com/ericsnowcurrently
Fix a typo.https://github.com/python/cpython/pull/104208/commits/85702ae366068db7923dca2190f665e970f6ab60
85702aehttps://github.com/python/cpython/pull/104208/commits/85702ae366068db7923dca2190f665e970f6ab60
https://github.com/ericsnowcurrently
Do not release the GIL when not necessary.https://github.com/python/cpython/pull/104208/commits/3cc9dc3d8382aa4d84017b6f2adfa9e23e9cdf01
3cc9dc3https://github.com/python/cpython/pull/104208/commits/3cc9dc3d8382aa4d84017b6f2adfa9e23e9cdf01
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 6, 2023https://github.com/python/cpython/pull/104208#issuecomment-1537179705
Please reload this pagehttps://github.com/python/cpython/pull/104208
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 6, 2023https://github.com/python/cpython/pull/104208#issuecomment-1537182557
Please reload this pagehttps://github.com/python/cpython/pull/104208
https://github.com/Eclips4
Eclips4https://github.com/Eclips4
May 6, 2023https://github.com/python/cpython/pull/104208#issuecomment-1537182771
Please reload this pagehttps://github.com/python/cpython/pull/104208
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 6, 2023https://github.com/python/cpython/pull/104208#issuecomment-1537213229
Please reload this pagehttps://github.com/python/cpython/pull/104208
the failurehttps://github.com/python/cpython/pull/104208#issuecomment-1536657917
Please reload this pagehttps://github.com/python/cpython/pull/104208
https://github.com/ericsnowcurrently
Make sure the GIL is held by the current thread in _PyEval_InitGIL().https://github.com/python/cpython/pull/104208/commits/3104796f16f3a6e25340fa9247e532d8863ff283
3104796https://github.com/python/cpython/pull/104208/commits/3104796f16f3a6e25340fa9247e532d8863ff283
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
May 6, 2023 https://github.com/python/cpython/pull/104208#pullrequestreview-1415817066
View reviewed changes https://github.com/python/cpython/pull/104208/files/3104796f16f3a6e25340fa9247e532d8863ff283
Python/ceval_gil.chttps://github.com/python/cpython/pull/104208/files/3104796f16f3a6e25340fa9247e532d8863ff283#diff-b7d806d282eab9f532468633d9090ed0a7f3215d8c6bcae04f4f8547baa39da1
Please reload this pagehttps://github.com/python/cpython/pull/104208
https://github.com/ericsnowcurrently
Release the GIL after swapping thread states.https://github.com/python/cpython/pull/104208/commits/56064c7973aad97e9c5fe745796e62d46ed6442c
56064c7https://github.com/python/cpython/pull/104208/commits/56064c7973aad97e9c5fe745796e62d46ed6442c
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
92d8bffhttps://github.com/python/cpython/commit/92d8bfffbf377e91d8b92666525cb8700bb1d5e8
May 6, 2023https://github.com/python/cpython/pull/104208#event-9183254600
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 6, 2023 21:59https://github.com/python/cpython/pull/104208#event-9183254647
jbower-fbhttps://github.com/jbower-fb
May 8, 2023 https://github.com/python/cpython/pull/104208#ref-commit-74d38ea
https://github.com/ericsnowcurrently
https://github.com/jbower-fb
pythongh-99113https://github.com/python/cpython/issues/99113
: Make Sure the GIL is Acquired at the Right Places (https://github.com/jbower-fb/cpython/commit/74d38eaae640eb1b3bc9cc2154bd7aed1c3fce6e
py…https://github.com/python/cpython/pull/104208
74d38eahttps://github.com/jbower-fb/cpython/commit/74d38eaae640eb1b3bc9cc2154bd7aed1c3fce6e
…thongh-104208https://github.com/python/cpython/pull/104208
https://github.com/Eclips4
Eclips4https://github.com/Eclips4
May 9, 2023 https://github.com/python/cpython/pull/104208#ref-pullrequest-1700915220
GH-104308: socket.getnameinfo should release the GIL #104307 https://github.com/python/cpython/pull/104307
https://github.com/asottile
asottilehttps://github.com/asottile
Aug 16, 2024https://github.com/python/cpython/pull/104208#issuecomment-2293938973
@ericsnowcurrentlyhttps://github.com/ericsnowcurrently
unbit/uwsgi#2659https://github.com/unbit/uwsgi/issues/2659
Please reload this pagehttps://github.com/python/cpython/pull/104208
https://github.com/asottile
asottilehttps://github.com/asottile
Aug 16, 2024https://github.com/python/cpython/pull/104208#issuecomment-2293991393
Please reload this pagehttps://github.com/python/cpython/pull/104208
https://github.com/asottile
asottilehttps://github.com/asottile
Aug 16, 2024 https://github.com/python/cpython/pull/104208#ref-pullrequest-2470789947
[3.12] gh-99113: restore behaviour of PyThreadState_Swap #123079 https://github.com/python/cpython/pull/123079
asottilehttps://github.com/asottile
Aug 16, 2024 https://github.com/python/cpython/pull/104208#ref-commit-01f131e
https://github.com/asottile
restore behaviour of PyThreadState_Swaphttps://github.com/asottile/cpython/commit/01f131e7b8deb0035ca812486f007bf3fca36412
01f131ehttps://github.com/asottile/cpython/commit/01f131e7b8deb0035ca812486f007bf3fca36412
python#104208https://github.com/python/cpython/pull/104208
https://github.com/asottile
asottilehttps://github.com/asottile
Aug 16, 2024https://github.com/python/cpython/pull/104208#issuecomment-2293999133
#123079https://github.com/python/cpython/pull/123079
Please reload this pagehttps://github.com/python/cpython/pull/104208
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104208
https://github.com/erlend-aasland
erlend-aasland https://github.com/erlend-aasland
https://github.com/python/cpython/pull/104208/files/3104796f16f3a6e25340fa9247e532d8863ff283
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/104208
https://github.com/ericsnowcurrently
https://github.com/Eclips4
https://github.com/asottile
https://github.com/erlend-aasland
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.