Title: gh-103963: fix 'make regen-opcode' in out-of-tree builds by carljm · Pull Request #104177 · python/cpython · GitHub
Open Graph Title: gh-103963: fix 'make regen-opcode' in out-of-tree builds by carljm · Pull Request #104177 · python/cpython
X Title: gh-103963: fix 'make regen-opcode' in out-of-tree builds by carljm · Pull Request #104177 · python/cpython
Description: #104029 added a new file generated by make regen-opcode, but unlike the existing path arguments to generate_opcode_h.py, the new intrinsicoutfile argument was not wired in as an explicitly-provided argument from the Makefile. The result is that the default relative path is always used, which only works for in-tree builds. (The Makefile always uses a path relative to $srcdir which is set correctly in out-of-tree builds to find the source tree.) This PR handles intrinsicoutfile in the same way that outfile and internaloutfile were already handled, which allows make regen-opcode to work again in out-of-tree builds. This also makes the update of the file use Tools/build/update_file.py, which avoids replacing the file if the contents haven't changed. This can avoid needless rebuilds. Issue: gh-103963
Open Graph Description: #104029 added a new file generated by make regen-opcode, but unlike the existing path arguments to generate_opcode_h.py, the new intrinsicoutfile argument was not wired in as an explicitly-provided...
X Description: #104029 added a new file generated by make regen-opcode, but unlike the existing path arguments to generate_opcode_h.py, the new intrinsicoutfile argument was not wired in as an explicitly-provided...
Opengraph URL: https://github.com/python/cpython/pull/104177
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:689c9abf-0a50-869e-4aa2-3eead36ad0f1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 940E:12EEDE:64BF26:891217:6969B4E7 |
| html-safe-nonce | 2557a3deb7416a771185e01f9cb1c5901e6450e24336b8002727ab70e962c67e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDBFOjEyRUVERTo2NEJGMjY6ODkxMjE3OjY5NjlCNEU3IiwidmlzaXRvcl9pZCI6IjM2NTM5ODEwNTcwNDkwMTU1MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 65adb26e6b56e5f3b6b1e84d4be319a4ea94fd5262b5818017157eaec75c594a |
| hovercard-subject-tag | pull_request:1338788119 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/104177/files |
| twitter:image | https://avatars.githubusercontent.com/u/61586?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/61586?s=400&v=4 |
| og:image:alt | #104029 added a new file generated by make regen-opcode, but unlike the existing path arguments to generate_opcode_h.py, the new intrinsicoutfile argument was not wired in as an explicitly-provided... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b23b8fcc855cd29bb04d6c94aafa62d336bf44eefa8229444eecc968cad03aee |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0672399d88424758731ec07fe24509e23bb17fb5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width