Title: GH-90208: Suppress OSError exceptions from `pathlib.Path.glob()` by barneygale · Pull Request #104141 · python/cpython · GitHub
Open Graph Title: GH-90208: Suppress OSError exceptions from `pathlib.Path.glob()` by barneygale · Pull Request #104141 · python/cpython
X Title: GH-90208: Suppress OSError exceptions from `pathlib.Path.glob()` by barneygale · Pull Request #104141 · python/cpython
Description: pathlib.Path.glob() now suppresses all OSError exceptions, except those raised from calling is_dir() on the top-level path. Previously, glob() suppressed ENOENT, ENOTDIR, EBADF and ELOOP errors and their Windows equivalents. PermissionError was also suppressed unless it occurred when calling is_dir() on the top-level path. However, the selector would abort prematurely if a PermissionError was raised, and so glob() could return incomplete results. Rationale Globbing is a shell feature, per the glob module docs: The glob module finds all the pathnames matching a specified pattern according to the rules used by the Unix shell When implemented by shells, globbing matches as much as possible without aborting. In fact, other Python functions that walk a directory tree usually suppress errors, e.g.: glob.glob() os.walk() and os.fwalk() (configurable) pathlib.Path.walk() (configurable) The rationale is the same: an error from one file/directory isn't fatal for the walk, and we can continue walking elsewhere. Finally, as noted above, pathlib.Path.glob() already ignores the most common kinds of OSError. This shows some recognition of the above rationale, though incomplete. Issue: gh-90208
Open Graph Description: pathlib.Path.glob() now suppresses all OSError exceptions, except those raised from calling is_dir() on the top-level path. Previously, glob() suppressed ENOENT, ENOTDIR, EBADF and ELOOP errors and...
X Description: pathlib.Path.glob() now suppresses all OSError exceptions, except those raised from calling is_dir() on the top-level path. Previously, glob() suppressed ENOENT, ENOTDIR, EBADF and ELOOP errors and...
Opengraph URL: https://github.com/python/cpython/pull/104141
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:4b708ee1-4a00-b636-bf49-32d9f7d7519f |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | D086:A457C:153086E:1C5CF37:6969B4FC |
| html-safe-nonce | 4e8b8489a390a2e1fd9b81b99fd5c3ca26a6a911201dccb153d54aacaa48f140 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDg2OkE0NTdDOjE1MzA4NkU6MUM1Q0YzNzo2OTY5QjRGQyIsInZpc2l0b3JfaWQiOiIxNTc5NjI3ODU1ODUyNzEzMjEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ca22ef01d131cba2a62a091b57881d8b24d9a8f1f9a0a070b2ed461a80e68cca |
| hovercard-subject-tag | pull_request:1337160120 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/104141/checks |
| twitter:image | https://avatars.githubusercontent.com/u/960340?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/960340?s=400&v=4 |
| og:image:alt | pathlib.Path.glob() now suppresses all OSError exceptions, except those raised from calling is_dir() on the top-level path. Previously, glob() suppressed ENOENT, ENOTDIR, EBADF and ELOOP errors and... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b23b8fcc855cd29bb04d6c94aafa62d336bf44eefa8229444eecc968cad03aee |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0672399d88424758731ec07fe24509e23bb17fb5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width