René's URL Explorer Experiment


Title: gh-104144: Skip scheduling a done callback if a TaskGroup task completes eagerly by itamaro · Pull Request #104140 · python/cpython · GitHub

Open Graph Title: gh-104144: Skip scheduling a done callback if a TaskGroup task completes eagerly by itamaro · Pull Request #104140 · python/cpython

X Title: gh-104144: Skip scheduling a done callback if a TaskGroup task completes eagerly by itamaro · Pull Request #104140 · python/cpython

Description: gh-97696 introduced eager tasks factory, which speeds up some async-heavy workloads by up to 50% when opted in. installing the eager tasks factory applies out-of-the-box when creating tasks as part...

Open Graph Description: gh-97696 introduced eager tasks factory, which speeds up some async-heavy workloads by up to 50% when opted in. installing the eager tasks factory applies out-of-the-box when creating tasks as part...

X Description: gh-97696 introduced eager tasks factory, which speeds up some async-heavy workloads by up to 50% when opted in. installing the eager tasks factory applies out-of-the-box when creating tasks as part...

Opengraph URL: https://github.com/python/cpython/pull/104140

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b526d8ca-2dc4-dbf3-97a3-29b8ce9b035c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE12C:2EFAA1:972DBE:CB003B:6969BEDA
html-safe-noncecb3ba62a699108e4c3f0a1570779c646c350e512504a637709771afebc4453b3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTJDOjJFRkFBMTo5NzJEQkU6Q0IwMDNCOjY5NjlCRURBIiwidmlzaXRvcl9pZCI6IjIxODYzODUyMzAxNTI3MTE4OTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6921ae4971a3b0d818041273947f7d4385f553948d2897f9a2c08f21200efc3b
hovercard-subject-tagpull_request:1337141007
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/104140/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5e055f7b640787d5614facf6ea211e1231272d446758723bc297174358ef2f84/python/cpython/pull/104140
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5e055f7b640787d5614facf6ea211e1231272d446758723bc297174358ef2f84/python/cpython/pull/104140
og:image:altgh-97696 introduced eager tasks factory, which speeds up some async-heavy workloads by up to 50% when opted in. installing the eager tasks factory applies out-of-the-box when creating tasks as part...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameitamaro
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/104140#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104140
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104140
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/104140
Reloadhttps://github.com/python/cpython/pull/104140
Reloadhttps://github.com/python/cpython/pull/104140
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/104140
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/104140
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/104140#issue-comment-box
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
itamaro:taskgroups-skip-done-callbackhttps://github.com/itamaro/cpython/tree/taskgroups-skip-done-callback
gh-104144: Skip scheduling a done callback if a TaskGroup task completes eagerly https://github.com/python/cpython/pull/104140#top
gvanrossumhttps://github.com/gvanrossum
python:mainhttps://github.com/python/cpython/tree/main
itamaro:taskgroups-skip-done-callbackhttps://github.com/itamaro/cpython/tree/taskgroups-skip-done-callback
Conversation 7 https://github.com/python/cpython/pull/104140
Commits 6 https://github.com/python/cpython/pull/104140/commits
Checks 0 https://github.com/python/cpython/pull/104140/checks
Files changed https://github.com/python/cpython/pull/104140/files
Please reload this pagehttps://github.com/python/cpython/pull/104140
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/itamaro
itamarohttps://github.com/itamaro
May 3, 2023https://github.com/python/cpython/pull/104140#issue-1694562053
Please reload this pagehttps://github.com/python/cpython/pull/104140
gh-97696https://github.com/python/cpython/issues/97696
patch to pyperformancehttps://github.com/python/pyperformance/compare/main...itamaro:pyperformance:use-task-groups
Leverage eager tasks to optimize asyncio gather & TaskGroups further #104144https://github.com/python/cpython/issues/104144
Please reload this pagehttps://github.com/python/cpython/pull/104140
https://github.com/itamaro
gh-NNNN: Skip scheduling a done callback if a TaskGroup task complete…https://github.com/python/cpython/pull/104140/commits/5397cd9f62db0e695d94c59bafc119613110b672
5397cd9https://github.com/python/cpython/pull/104140/commits/5397cd9f62db0e695d94c59bafc119613110b672
https://github.com/itamaro
itamarohttps://github.com/itamaro
May 3, 2023https://github.com/python/cpython/pull/104140#event-9160833645
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 3, 2023 https://github.com/python/cpython/pull/104140#ref-issue-1694945693
Leverage eager tasks to optimize asyncio gather & TaskGroups further #104144 https://github.com/python/cpython/issues/104144
https://github.com/itamaro
Add NEWS entryhttps://github.com/python/cpython/pull/104140/commits/8d6a77e8c312bb1cbdaaca2f316897412fce4da3
8d6a77ehttps://github.com/python/cpython/pull/104140/commits/8d6a77e8c312bb1cbdaaca2f316897412fce4da3
https://github.com/itamaro
itamarohttps://github.com/itamaro
May 3, 2023 23:52https://github.com/python/cpython/pull/104140#event-9161196506
https://github.com/itamaro
itamarohttps://github.com/itamaro
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
gvanrossumhttps://github.com/gvanrossum
kumaraditya303https://github.com/kumaraditya303
willingchttps://github.com/willingc
code ownershttps://github.com/python/cpython/blob/e95dd40aff35775efce4c03bec7d82f03711310b/.github/CODEOWNERS#L14
May 3, 2023 23:52https://github.com/python/cpython/pull/104140#event-9161196535
https://github.com/carljm
carljmhttps://github.com/carljm
May 4, 2023 https://github.com/python/cpython/pull/104140#pullrequestreview-1412070113
View reviewed changes https://github.com/python/cpython/pull/104140/files/8d6a77e8c312bb1cbdaaca2f316897412fce4da3
Misc/NEWS.d/next/Library/2023-05-03-16-51-53.gh-issue-104144.653Q0P.rsthttps://github.com/python/cpython/pull/104140/files/8d6a77e8c312bb1cbdaaca2f316897412fce4da3#diff-8cd098b0f3d62773c0bc494355244d69c09472bdbdb2df4c729d9c5aa22090ef
Please reload this pagehttps://github.com/python/cpython/pull/104140
https://github.com/itamaro
https://github.com/carljm
Apply review feedback to NEWS entryhttps://github.com/python/cpython/pull/104140/commits/a125c1fc495782429baca2f892b7a798ec9bdf4c
a125c1fhttps://github.com/python/cpython/pull/104140/commits/a125c1fc495782429baca2f892b7a798ec9bdf4c
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
May 4, 2023https://github.com/python/cpython/pull/104140#event-9171447636
https://github.com/itamaro
Merge branch 'main' into taskgroups-skip-done-callbackhttps://github.com/python/cpython/pull/104140/commits/dae3e063e7d9c7d523ca114291116e23f7fb9ba2
dae3e06https://github.com/python/cpython/pull/104140/commits/dae3e063e7d9c7d523ca114291116e23f7fb9ba2
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 5, 2023 https://github.com/python/cpython/pull/104140#pullrequestreview-1415324751
View reviewed changes https://github.com/python/cpython/pull/104140/files/dae3e063e7d9c7d523ca114291116e23f7fb9ba2
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/cpython/pull/104140#pullrequestreview-1415324751
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104140
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 5, 2023https://github.com/python/cpython/pull/104140#event-9179765644
https://github.com/itamaro
itamarohttps://github.com/itamaro
May 5, 2023https://github.com/python/cpython/pull/104140#issuecomment-1536750634
Please reload this pagehttps://github.com/python/cpython/pull/104140
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 5, 2023https://github.com/python/cpython/pull/104140#issuecomment-1536761579
gh-103767https://github.com/python/cpython/pull/103767
Please reload this pagehttps://github.com/python/cpython/pull/104140
https://github.com/itamaro
itamarohttps://github.com/itamaro
May 5, 2023https://github.com/python/cpython/pull/104140#issuecomment-1536776848
Please reload this pagehttps://github.com/python/cpython/pull/104140
itamarohttps://github.com/itamaro
May 5, 2023 14:06https://github.com/python/cpython/pull/104140#commits-pushed-161d0f8
https://github.com/itamaro
revert skipping _set_task_name if name is None; fix typo in commenthttps://github.com/python/cpython/pull/104140/commits/161d0f8c6f0241bb20f887522659b1bc8700452d
161d0f8https://github.com/python/cpython/pull/104140/commits/161d0f8c6f0241bb20f887522659b1bc8700452d
https://github.com/itamaro
Merge branch 'main' into taskgroups-skip-done-callbackhttps://github.com/python/cpython/pull/104140/commits/2b98bd99b9b545620bafdc2ca96d90d1e0b898a5
2b98bd9https://github.com/python/cpython/pull/104140/commits/2b98bd99b9b545620bafdc2ca96d90d1e0b898a5
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 5, 2023 https://github.com/python/cpython/pull/104140#pullrequestreview-1415471411
View reviewed changes https://github.com/python/cpython/pull/104140/files/2b98bd99b9b545620bafdc2ca96d90d1e0b898a5
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
52d8f36https://github.com/python/cpython/commit/52d8f36e8c9f6048367d7bdfede3698e3f5f70d0
May 5, 2023https://github.com/python/cpython/pull/104140#event-9181075544
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 5, 2023https://github.com/python/cpython/pull/104140#event-9181075633
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
May 6, 2023 https://github.com/python/cpython/pull/104140#pullrequestreview-1415791535
View reviewed changes https://github.com/python/cpython/pull/104140/files/2b98bd99b9b545620bafdc2ca96d90d1e0b898a5
Misc/NEWS.d/next/Library/2023-05-03-16-51-53.gh-issue-104144.653Q0P.rsthttps://github.com/python/cpython/pull/104140/files/2b98bd99b9b545620bafdc2ca96d90d1e0b898a5#diff-8cd098b0f3d62773c0bc494355244d69c09472bdbdb2df4c729d9c5aa22090ef
kumaraditya303https://github.com/kumaraditya303
May 6, 2023https://github.com/python/cpython/pull/104140#discussion_r1186714354
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/104140
itamarohttps://github.com/itamaro
May 7, 2023https://github.com/python/cpython/pull/104140#discussion_r1186762338
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
itamaro@ac1ee82https://github.com/itamaro/cpython/commit/ac1ee82a311b86d78f422364bf8ada660df21ecb
gh-104251https://github.com/python/cpython/pull/104251
Please reload this pagehttps://github.com/python/cpython/pull/104140
https://github.com/itamaro
itamarohttps://github.com/itamaro
May 7, 2023 22:16https://github.com/python/cpython/pull/104140#event-9185040419
jbower-fbhttps://github.com/jbower-fb
May 8, 2023 https://github.com/python/cpython/pull/104140#ref-commit-0b9d0b2
https://github.com/itamaro
https://github.com/carljm
https://github.com/jbower-fb
pythongh-104144https://github.com/python/cpython/issues/104144
: Skip scheduling a done callback if a TaskGroup task …https://github.com/jbower-fb/cpython/commit/0b9d0b2ba01cf7fbfd5f0625035b19bd44de0159
0b9d0b2https://github.com/jbower-fb/cpython/commit/0b9d0b2ba01cf7fbfd5f0625035b19bd44de0159
python#104140https://github.com/python/cpython/pull/104140
https://github.com/itamaro
itamarohttps://github.com/itamaro
Feb 2, 2025 https://github.com/python/cpython/pull/104140#ref-pullrequest-2799219819
gh-128588: gh-128550: remove eager tasks optimization that missed and introduced incorrect cancellations #129063 https://github.com/python/cpython/pull/129063
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F104140
https://github.com/carljm
carljm https://github.com/carljm
https://github.com/python/cpython/pull/104140/files/8d6a77e8c312bb1cbdaaca2f316897412fce4da3
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/104140/files/2b98bd99b9b545620bafdc2ca96d90d1e0b898a5
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/cpython/pull/104140/files/2b98bd99b9b545620bafdc2ca96d90d1e0b898a5
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/willingc
willingc https://github.com/willingc
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
Please reload this pagehttps://github.com/python/cpython/pull/104140
https://github.com/itamaro
https://github.com/gvanrossum
https://github.com/carljm
https://github.com/kumaraditya303
https://github.com/bedevere-bot
https://github.com/AlexWaygood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.