René's URL Explorer Experiment


Title: gh-103968: Deprecate creating heap types whose metaclass has custom tp_new. by encukou · Pull Request #103972 · python/cpython · GitHub

Open Graph Title: gh-103968: Deprecate creating heap types whose metaclass has custom tp_new. by encukou · Pull Request #103972 · python/cpython

X Title: gh-103968: Deprecate creating heap types whose metaclass has custom tp_new. by encukou · Pull Request #103972 · python/cpython

Description: (That's a mouthful of an edge case!) Issue: PyType_FromSpec refuses to create classes with tp_new #103968

Open Graph Description: (That's a mouthful of an edge case!) Issue: PyType_FromSpec refuses to create classes with tp_new #103968

X Description: (That's a mouthful of an edge case!) Issue: PyType_FromSpec refuses to create classes with tp_new #103968

Opengraph URL: https://github.com/python/cpython/pull/103972

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:15f84da7-11b7-e4ef-9fa5-334dc9358dad
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C66:155BED:77117E:A4B796:696A7CA1
html-safe-nonce0ad84e21442b0acbe699aa8705d21505602dd76675adee578230aba4fface9ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzY2OjE1NUJFRDo3NzExN0U6QTRCNzk2OjY5NkE3Q0ExIiwidmlzaXRvcl9pZCI6Ijg1MTA0NTU0NTA4NjE5OTMxMjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac07b364c710f1794b3fe9a2748b1121ce300e0af6383f0c0ee07dc12ad0281269
hovercard-subject-tagpull_request:1332115684
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/103972/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/81b2c493294c180b4119ce4507256a55ba2147b5d565d647563c62aa64540467/python/cpython/pull/103972
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/81b2c493294c180b4119ce4507256a55ba2147b5d565d647563c62aa64540467/python/cpython/pull/103972
og:image:alt(That's a mouthful of an edge case!) Issue: PyType_FromSpec refuses to create classes with tp_new #103968
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
None5b774e44f85c14a75886edd04ddda4e5a25ddebbb241bcbb590b08a3048730e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecc5f4eee261b3601c1e98e217ceaf28508b9567e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/103972#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103972
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103972
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/103972
Reloadhttps://github.com/python/cpython/pull/103972
Reloadhttps://github.com/python/cpython/pull/103972
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/103972
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/103972
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/103972#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:fromspec-metaclass-deprecationhttps://github.com/encukou/cpython/tree/fromspec-metaclass-deprecation
gh-103968: Deprecate creating heap types whose metaclass has custom tp_new. https://github.com/python/cpython/pull/103972#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:fromspec-metaclass-deprecationhttps://github.com/encukou/cpython/tree/fromspec-metaclass-deprecation
Conversation 9 https://github.com/python/cpython/pull/103972
Commits 4 https://github.com/python/cpython/pull/103972/commits
Checks 0 https://github.com/python/cpython/pull/103972/checks
Files changed https://github.com/python/cpython/pull/103972/files
Please reload this pagehttps://github.com/python/cpython/pull/103972
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/encukou
encukouhttps://github.com/encukou
Apr 28, 2023https://github.com/python/cpython/pull/103972#issue-1688817029
Please reload this pagehttps://github.com/python/cpython/pull/103972
PyType_FromSpec refuses to create classes with tp_new #103968https://github.com/python/cpython/issues/103968
Please reload this pagehttps://github.com/python/cpython/pull/103972
https://github.com/encukou
pythongh-103968https://github.com/python/cpython/issues/103968
: Deprecate creating heap types whose metaclass has cu…https://github.com/python/cpython/pull/103972/commits/2ca04bb1b3d99a67e29aed52b05717f90171b1eb
2ca04bbhttps://github.com/python/cpython/pull/103972/commits/2ca04bb1b3d99a67e29aed52b05717f90171b1eb
https://github.com/encukou
encukouhttps://github.com/encukou
April 28, 2023 16:16https://github.com/python/cpython/pull/103972#event-9126489687
https://github.com/encukou
encukouhttps://github.com/encukou
markshannonhttps://github.com/markshannon
code ownerhttps://github.com/python/cpython/blob/81387fe36e76438447ff2bddc36f4f5ff2c820a2/.github/CODEOWNERS#L22
April 28, 2023 16:16https://github.com/python/cpython/pull/103972#event-9126489732
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Apr 28, 2023 https://github.com/python/cpython/pull/103972#ref-issue-1688642474
PyType_FromSpec refuses to create classes with tp_new #103968 https://github.com/python/cpython/issues/103968
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 28, 2023https://github.com/python/cpython/pull/103972#event-9126489926
https://github.com/barneygale
barneygalehttps://github.com/barneygale
Apr 29, 2023 https://github.com/python/cpython/pull/103972#pullrequestreview-1407020851
View reviewed changes https://github.com/python/cpython/pull/103972/files/2ca04bb1b3d99a67e29aed52b05717f90171b1eb
Doc/whatsnew/3.12.rsthttps://github.com/python/cpython/pull/103972/files/2ca04bb1b3d99a67e29aed52b05717f90171b1eb#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b
Please reload this pagehttps://github.com/python/cpython/pull/103972
Doc/whatsnew/3.12.rsthttps://github.com/python/cpython/pull/103972/files/2ca04bb1b3d99a67e29aed52b05717f90171b1eb#diff-0f2c1763c64530268325a0ee2dfaa4f5d555c4ac27deb78bd77102c8ce1b886b
Please reload this pagehttps://github.com/python/cpython/pull/103972
Doc/c-api/type.rsthttps://github.com/python/cpython/pull/103972/files/2ca04bb1b3d99a67e29aed52b05717f90171b1eb#diff-04d16413dd014ab960bcc7e5f56e3e087da668393f6525d10d099e5a86020016
barneygalehttps://github.com/barneygale
Apr 29, 2023https://github.com/python/cpython/pull/103972#discussion_r1181121856
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/103972
encukouhttps://github.com/encukou
May 2, 2023https://github.com/python/cpython/pull/103972#discussion_r1182710715
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/103972
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Apr 29, 2023 https://github.com/python/cpython/pull/103972#pullrequestreview-1407022292
View reviewed changes https://github.com/python/cpython/pull/103972/files/2ca04bb1b3d99a67e29aed52b05717f90171b1eb
Objects/typeobject.chttps://github.com/python/cpython/pull/103972/files/2ca04bb1b3d99a67e29aed52b05717f90171b1eb#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Please reload this pagehttps://github.com/python/cpython/pull/103972
Objects/typeobject.chttps://github.com/python/cpython/pull/103972/files/2ca04bb1b3d99a67e29aed52b05717f90171b1eb#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Please reload this pagehttps://github.com/python/cpython/pull/103972
encukouhttps://github.com/encukou
May 2, 2023 17:28https://github.com/python/cpython/pull/103972#commits-pushed-4921987
https://github.com/encukou
https://github.com/barneygale
Apply suggestions from code reviewhttps://github.com/python/cpython/pull/103972/commits/492198728a79737babd8e29be943fe4e658ea2fc
4921987https://github.com/python/cpython/pull/103972/commits/492198728a79737babd8e29be943fe4e658ea2fc
https://github.com/encukou
Merge in the main branchhttps://github.com/python/cpython/pull/103972/commits/4e03abdd3443bfdbf53a52266038dd9c1a536c10
4e03abdhttps://github.com/python/cpython/pull/103972/commits/4e03abdd3443bfdbf53a52266038dd9c1a536c10
https://github.com/encukou
Add static to _PyType_FromMetaclass_implhttps://github.com/python/cpython/pull/103972/commits/ecaf7d9e4f6f746df0bc717a818cb1cd819cf5ca
ecaf7d9https://github.com/python/cpython/pull/103972/commits/ecaf7d9e4f6f746df0bc717a818cb1cd819cf5ca
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
May 3, 2023 https://github.com/python/cpython/pull/103972#pullrequestreview-1410380195
View reviewed changes https://github.com/python/cpython/pull/103972/files/ecaf7d9e4f6f746df0bc717a818cb1cd819cf5ca
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 3, 2023https://github.com/python/cpython/pull/103972#event-9152686671
https://github.com/encukou
encukouhttps://github.com/encukou
May 3, 2023https://github.com/python/cpython/pull/103972#issuecomment-1533015480
Please reload this pagehttps://github.com/python/cpython/pull/103972
https://github.com/encukou
encukouhttps://github.com/encukou
524a7f7https://github.com/python/cpython/commit/524a7f77fd8244835e382f076dd4a76404580bb3
May 3, 2023https://github.com/python/cpython/pull/103972#event-9155453040
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 3, 2023https://github.com/python/cpython/pull/103972#event-9155453577
https://github.com/encukou
encukouhttps://github.com/encukou
May 3, 2023 13:17https://github.com/python/cpython/pull/103972#event-9155453678
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
May 3, 2023 https://github.com/python/cpython/pull/103972#ref-pullrequest-1694988858
gh-104146: Remove unused 'second_pass_replacements' from clinic.py #104147 https://github.com/python/cpython/pull/104147
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Jun 2, 2023 https://github.com/python/cpython/pull/103972#ref-issue-1617410055
Compiled Python extension does not work with Python 3.12 protocolbuffers/protobuf#12186 https://github.com/protocolbuffers/protobuf/issues/12186
https://github.com/ofek
ofekhttps://github.com/ofek
Nov 14, 2025 https://github.com/python/cpython/pull/103972#ref-pullrequest-3623975373
Support mixing with ABCMeta jcrist/msgspec#928 https://github.com/jcrist/msgspec/pull/928
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103972
https://github.com/barneygale
barneygale https://github.com/barneygale
https://github.com/python/cpython/pull/103972/files/2ca04bb1b3d99a67e29aed52b05717f90171b1eb
https://github.com/erlend-aasland
erlend-aasland https://github.com/erlend-aasland
https://github.com/python/cpython/pull/103972/files/ecaf7d9e4f6f746df0bc717a818cb1cd819cf5ca
https://github.com/markshannon
markshannon https://github.com/markshannon
Please reload this pagehttps://github.com/python/cpython/pull/103972
https://github.com/encukou
https://github.com/barneygale
https://github.com/erlend-aasland
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.