René's URL Explorer Experiment


Title: gh-103895: Improve how invalid `Exception.__notes__` are displayed by pR0Ps · Pull Request #103897 · python/cpython · GitHub

Open Graph Title: gh-103895: Improve how invalid `Exception.__notes__` are displayed by pR0Ps · Pull Request #103897 · python/cpython

X Title: gh-103895: Improve how invalid `Exception.__notes__` are displayed by pR0Ps · Pull Request #103897 · python/cpython

Description: Ensure that when displayed a note fails, the failure message includes a trailing newline. Improve isinstance(__notes__, Sequence) check to exclude strings and bytes to avoid exploding them into ind...

Open Graph Description: Ensure that when displayed a note fails, the failure message includes a trailing newline. Improve isinstance(__notes__, Sequence) check to exclude strings and bytes to avoid exploding them into ind...

X Description: Ensure that when displayed a note fails, the failure message includes a trailing newline. Improve isinstance(__notes__, Sequence) check to exclude strings and bytes to avoid exploding them into ind...

Opengraph URL: https://github.com/python/cpython/pull/103897

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:023de656-c9c8-ea77-5336-fbc557a47a7e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA25E:2B0240:C00F3C:1086447:6969EC6E
html-safe-nonce6e123eb34d465401914811fe819b9dda130935a704c43ae9bf499448f88d5f28
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjVFOjJCMDI0MDpDMDBGM0M6MTA4NjQ0Nzo2OTY5RUM2RSIsInZpc2l0b3JfaWQiOiIyOTA1NzkwNzAxNzQ5NTI5NzEwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac528ca8a5dcf37baf040833fc5e6e1df0b65d739e4d352aebd321c19c625e1651
hovercard-subject-tagpull_request:1329457962
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/103897/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/003494cce41d7031d493b895f74555a43c4bf955759cf399f10fad869ac3863d/python/cpython/pull/103897
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/003494cce41d7031d493b895f74555a43c4bf955759cf399f10fad869ac3863d/python/cpython/pull/103897
og:image:altEnsure that when displayed a note fails, the failure message includes a trailing newline. Improve isinstance(__notes__, Sequence) check to exclude strings and bytes to avoid exploding them into ind...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepR0Ps
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/103897#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103897
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103897
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/103897
Reloadhttps://github.com/python/cpython/pull/103897
Reloadhttps://github.com/python/cpython/pull/103897
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/103897
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/103897
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/103897#issue-comment-box
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
pR0Ps:bugfix/traceback-notes-displayhttps://github.com/pR0Ps/cpython/tree/bugfix/traceback-notes-display
gh-103895: Improve how invalid Exception.__notes__ are displayed https://github.com/python/cpython/pull/103897#top
iritkatrielhttps://github.com/iritkatriel
python:mainhttps://github.com/python/cpython/tree/main
pR0Ps:bugfix/traceback-notes-displayhttps://github.com/pR0Ps/cpython/tree/bugfix/traceback-notes-display
Conversation 3 https://github.com/python/cpython/pull/103897
Commits 2 https://github.com/python/cpython/pull/103897/commits
Checks 0 https://github.com/python/cpython/pull/103897/checks
Files changed https://github.com/python/cpython/pull/103897/files
Please reload this pagehttps://github.com/python/cpython/pull/103897
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/pR0Ps
pR0Pshttps://github.com/pR0Ps
Apr 26, 2023https://github.com/python/cpython/pull/103897#issue-1685803986
Please reload this pagehttps://github.com/python/cpython/pull/103897
experts indexhttps://devguide.python.org/core-developers/experts/
d4c4a76https://github.com/python/cpython/commit/d4c4a76ed1427c947fcbbe692625b3f644cf3aaf
@iritkatrielhttps://github.com/iritkatriel
Issues when showing broken Exception.__notes__ #103895https://github.com/python/cpython/issues/103895
Please reload this pagehttps://github.com/python/cpython/pull/103897
https://github.com/pR0Ps
Improve how invalid Exception.__notes__ are displayedhttps://github.com/python/cpython/pull/103897/commits/6c7ffad1a3711454f9dbcc80ac3c685b0b8c918e
6c7ffadhttps://github.com/python/cpython/pull/103897/commits/6c7ffad1a3711454f9dbcc80ac3c685b0b8c918e
https://github.com/pR0Ps
pR0Pshttps://github.com/pR0Ps
iritkatrielhttps://github.com/iritkatriel
code ownerhttps://github.com/python/cpython/blob/a3a5b4bb232ba29875147baa3b56a5524eece353/.github/CODEOWNERS#L33
April 26, 2023 22:03https://github.com/python/cpython/pull/103897#event-9108328092
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Apr 26, 2023 https://github.com/python/cpython/pull/103897#ref-issue-1685766667
Issues when showing broken Exception.__notes__ #103895 https://github.com/python/cpython/issues/103895
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 26, 2023https://github.com/python/cpython/pull/103897#event-9108328672
https://github.com/EtiennePelletier
EtiennePelletierhttps://github.com/EtiennePelletier
Apr 26, 2023 https://github.com/python/cpython/pull/103897#ref-pullrequest-1685874987
Display exception notes in tracebacks ipython/ipython#14039 https://github.com/ipython/ipython/pull/14039
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Apr 27, 2023 https://github.com/python/cpython/pull/103897#pullrequestreview-1404144552
View reviewed changes https://github.com/python/cpython/pull/103897/files/6c7ffad1a3711454f9dbcc80ac3c685b0b8c918e
Lib/test/test_traceback.pyhttps://github.com/python/cpython/pull/103897/files/6c7ffad1a3711454f9dbcc80ac3c685b0b8c918e#diff-8a52124ffceebd98f91bf96caa0f341ae109f79e190cd5acc1c56c8968d75252
Please reload this pagehttps://github.com/python/cpython/pull/103897
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Apr 27, 2023 https://github.com/python/cpython/pull/103897#pullrequestreview-1404362612
View reviewed changes https://github.com/python/cpython/pull/103897/files/c1dd2de00e4c9e2b869e0344893be5734d9d1748
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 27, 2023https://github.com/python/cpython/pull/103897#event-9116064177
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
interpreter-core https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Ainterpreter-core
Apr 27, 2023https://github.com/python/cpython/pull/103897#event-9116075275
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
Apr 27, 2023https://github.com/python/cpython/pull/103897#issuecomment-1525920758
@ambvhttps://github.com/ambv
Please reload this pagehttps://github.com/python/cpython/pull/103897
https://github.com/iritkatriel
Merge branch 'main' into bugfix/traceback-notes-displayhttps://github.com/python/cpython/pull/103897/commits/c1dd2de00e4c9e2b869e0344893be5734d9d1748
c1dd2dehttps://github.com/python/cpython/pull/103897/commits/c1dd2de00e4c9e2b869e0344893be5734d9d1748
https://github.com/iritkatriel
iritkatrielhttps://github.com/iritkatriel
487f55dhttps://github.com/python/cpython/commit/487f55d5801a9ae7d79d37e259e8c377c9acd39b
May 1, 2023https://github.com/python/cpython/pull/103897#event-9135052626
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 1, 2023https://github.com/python/cpython/pull/103897#event-9135052804
carljmhttps://github.com/carljm
May 1, 2023 https://github.com/python/cpython/pull/103897#ref-commit-159b2aa
https://github.com/carljm
Merge branch 'main' into supermonhttps://github.com/carljm/cpython/commit/159b2aa551ad8c9f71da1a5835b658a70f93bfd5
159b2aahttps://github.com/carljm/cpython/commit/159b2aa551ad8c9f71da1a5835b658a70f93bfd5
pythongh-104028https://github.com/python/cpython/issues/104028
pythongh-104030https://github.com/python/cpython/pull/104030
pythongh-104036https://github.com/python/cpython/issues/104036
python#104037https://github.com/python/cpython/pull/104037
pythongh-102213https://github.com/python/cpython/issues/102213
pythonGH-103761https://github.com/python/cpython/pull/103761
pythongh-103895https://github.com/python/cpython/issues/103895
python#103897https://github.com/python/cpython/pull/103897
pythonGH-104021https://github.com/python/cpython/pull/104021
pythongh-88496https://github.com/python/cpython/issues/88496
python#104025https://github.com/python/cpython/pull/104025
python#104024https://github.com/python/cpython/pull/104024
pythongh-88773https://github.com/python/cpython/issues/88773
python#103974https://github.com/python/cpython/pull/103974
pythongh-104015https://github.com/python/cpython/issues/104015
python#104017https://github.com/python/cpython/pull/104017
pythongh-104012https://github.com/python/cpython/issues/104012
python#104014https://github.com/python/cpython/pull/104014
pythongh-103977https://github.com/python/cpython/issues/103977
python#103981https://github.com/python/cpython/pull/103981
pythongh-98003https://github.com/python/cpython/issues/98003
pythonGH-98004https://github.com/python/cpython/pull/98004
python#103843https://github.com/python/cpython/pull/103843
python#103696https://github.com/python/cpython/pull/103696
pythongh-82054https://github.com/python/cpython/issues/82054
python#103927https://github.com/python/cpython/pull/103927
python#103991https://github.com/python/cpython/pull/103991
pythongh-103793https://github.com/python/cpython/issues/103793
python#103767https://github.com/python/cpython/pull/103767
pythongh-87092https://github.com/python/cpython/issues/87092
python#103933https://github.com/python/cpython/pull/103933
pythongh-103636https://github.com/python/cpython/issues/103636
python#103833https://github.com/python/cpython/pull/103833
python#103923https://github.com/python/cpython/pull/103923
carljmhttps://github.com/carljm
May 1, 2023 https://github.com/python/cpython/pull/103897#ref-commit-1274e2b
https://github.com/carljm
Merge branch 'main' into inlinecomp2https://github.com/carljm/cpython/commit/1274e2bf55565619f80c9b9ceee35c258b413eb6
1274e2bhttps://github.com/carljm/cpython/commit/1274e2bf55565619f80c9b9ceee35c258b413eb6
pythongh-104057https://github.com/python/cpython/issues/104057
python#104064https://github.com/python/cpython/pull/104064
pythongh-87092https://github.com/python/cpython/issues/87092
python#103988https://github.com/python/cpython/pull/103988
pythongh-97696https://github.com/python/cpython/issues/97696
python#102853https://github.com/python/cpython/pull/102853
pythongh-84436https://github.com/python/cpython/issues/84436
pythongh-104054https://github.com/python/cpython/pull/104054
pythongh-104057https://github.com/python/cpython/issues/104057
pythonGH-104059https://github.com/python/cpython/pull/104059
pythongh-100458https://github.com/python/cpython/issues/100458
pythonGH-100387https://github.com/python/cpython/pull/100387
pythongh-104018https://github.com/python/cpython/issues/104018
pythonGH-104033https://github.com/python/cpython/pull/104033
pythongh-104016https://github.com/python/cpython/issues/104016
python#104047https://github.com/python/cpython/pull/104047
pythonGH-103629https://github.com/python/cpython/issues/103629
python#104048https://github.com/python/cpython/pull/104048
pythongh-102799https://github.com/python/cpython/issues/102799
python#104032https://github.com/python/cpython/pull/104032
python#104034https://github.com/python/cpython/pull/104034
pythongh-103824https://github.com/python/cpython/issues/103824
python#103993https://github.com/python/cpython/pull/103993
pythongh-104035https://github.com/python/cpython/issues/104035
python#104041https://github.com/python/cpython/pull/104041
pythongh-104028https://github.com/python/cpython/issues/104028
pythongh-104030https://github.com/python/cpython/pull/104030
pythongh-104036https://github.com/python/cpython/issues/104036
python#104037https://github.com/python/cpython/pull/104037
pythongh-102213https://github.com/python/cpython/issues/102213
pythonGH-103761https://github.com/python/cpython/pull/103761
pythongh-103895https://github.com/python/cpython/issues/103895
python#103897https://github.com/python/cpython/pull/103897
pythonGH-104021https://github.com/python/cpython/pull/104021
pythongh-88496https://github.com/python/cpython/issues/88496
python#104025https://github.com/python/cpython/pull/104025
python#104024https://github.com/python/cpython/pull/104024
Carreauhttps://github.com/Carreau
Jun 2, 2023 https://github.com/python/cpython/pull/103897#ref-commit-1d4e184
https://github.com/Carreau
Display exception notes in tracebacks (https://github.com/ipython/ipython/commit/1d4e18474ed5734c4cfddd912f38c9170fffba4e
#14039https://github.com/ipython/ipython/pull/14039
)https://github.com/ipython/ipython/commit/1d4e18474ed5734c4cfddd912f38c9170fffba4e
1d4e184https://github.com/ipython/ipython/commit/1d4e18474ed5734c4cfddd912f38c9170fffba4e
https://peps.python.org/pep-0678/https://peps.python.org/pep-0678/
https://docs.python.org/3/library/exceptions.html#BaseException.add_notehttps://docs.python.org/3/library/exceptions.html#BaseException.add_note
https://github.com/python/cpython/blob/main/Lib/traceback.pyhttps://github.com/python/cpython/blob/main/Lib/traceback.py
python/cpython#103897https://github.com/python/cpython/pull/103897
https://docs.python.org/3/tutorial/errors.html#enriching-exceptions-with-noteshttps://docs.python.org/3/tutorial/errors.html#enriching-exceptions-with-notes
https://user-images.githubusercontent.com/16963011/234723689-6bbfe0ff-94d4-4a90-9da6-acfe1c8e5edf.pnghttps://user-images.githubusercontent.com/16963011/234723689-6bbfe0ff-94d4-4a90-9da6-acfe1c8e5edf.png
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103897
https://github.com/iritkatriel
iritkatriel https://github.com/iritkatriel
https://github.com/python/cpython/pull/103897/files/6c7ffad1a3711454f9dbcc80ac3c685b0b8c918e
interpreter-core https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Ainterpreter-core
Please reload this pagehttps://github.com/python/cpython/pull/103897
https://github.com/pR0Ps
https://github.com/iritkatriel
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.