René's URL Explorer Experiment


Title: gh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending by alisaifee · Pull Request #103463 · python/cpython · GitHub

Open Graph Title: gh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending by alisaifee · Pull Request #103463 · python/cpython

X Title: gh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending by alisaifee · Pull Request #103463 · python/cpython

Description: Description When the payload used with SelectorSocketTransport.writelines is too large to write in one call to either socket.send or socket.sendmsg the remaining buffer needs to be handled by regis...

Open Graph Description: Description When the payload used with SelectorSocketTransport.writelines is too large to write in one call to either socket.send or socket.sendmsg the remaining buffer needs to be handled by regis...

X Description: Description When the payload used with SelectorSocketTransport.writelines is too large to write in one call to either socket.send or socket.sendmsg the remaining buffer needs to be handled by regis...

Opengraph URL: https://github.com/python/cpython/pull/103463

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:57fbd6c8-713f-991a-92bc-88c8f7c492d2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD660:2BBD61:C51A6B:10AE858:696AC0DA
html-safe-nonce88024ca39c036da93f12277e6fd262a69969be120125c9be17963cba65d67a85
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjYwOjJCQkQ2MTpDNTFBNkI6MTBBRTg1ODo2OTZBQzBEQSIsInZpc2l0b3JfaWQiOiIyMTEzMzU3MTc1MzY5NDE2OTIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4dc9c09c635a9c35679c25d17b2487bd574da7a9c1b4a38a5ba246287abd2936
hovercard-subject-tagpull_request:1309977269
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/103463/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d188769d972ff95f81a9a9354151791638c7d2ba24b3fdf2f7d8b80c340135a6/python/cpython/pull/103463
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d188769d972ff95f81a9a9354151791638c7d2ba24b3fdf2f7d8b80c340135a6/python/cpython/pull/103463
og:image:altDescription When the payload used with SelectorSocketTransport.writelines is too large to write in one call to either socket.send or socket.sendmsg the remaining buffer needs to be handled by regis...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealisaifee
hostnamegithub.com
expected-hostnamegithub.com
None986b6a1d774985095564e64d6963d11f094da3d0e2bfda2ab1a27d63662eb033
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release89ad2112b9c4e11df6a0c13c8c1f8eedd36b0977
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/103463#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103463
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103463
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/103463
Reloadhttps://github.com/python/cpython/pull/103463
Reloadhttps://github.com/python/cpython/pull/103463
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/103463
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/103463
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/103463#issue-comment-box
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
alisaifee:fix-incomplete-writelinehttps://github.com/alisaifee/cpython/tree/fix-incomplete-writeline
gh-103462: Ensure SelectorSocketTransport.writelines registers a writer when data is still pending https://github.com/python/cpython/pull/103463#top
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
alisaifee:fix-incomplete-writelinehttps://github.com/alisaifee/cpython/tree/fix-incomplete-writeline
Conversation 8 https://github.com/python/cpython/pull/103463
Commits 7 https://github.com/python/cpython/pull/103463/commits
Checks 0 https://github.com/python/cpython/pull/103463/checks
Files changed https://github.com/python/cpython/pull/103463/files
Please reload this pagehttps://github.com/python/cpython/pull/103463
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/alisaifee
alisaifeehttps://github.com/alisaifee
Apr 12, 2023https://github.com/python/cpython/pull/103463#issue-1663558086
Please reload this pagehttps://github.com/python/cpython/pull/103463
Implement zero copy writes in SelectorSocketTransport in asyncio #91166https://github.com/python/cpython/issues/91166
Calling SelectorSocketTransport.writelines with a very large payload doesn't get completely written to the socket #103462https://github.com/python/cpython/issues/103462
Please reload this pagehttps://github.com/python/cpython/pull/103463
alisaifeehttps://github.com/alisaifee
April 11, 2023 19:05https://github.com/python/cpython/pull/103463#commits-pushed-273e1e7
https://github.com/alisaifee
Add explicit tests for writelineshttps://github.com/python/cpython/pull/103463/commits/273e1e74a9656b3e45cbc67b284457e730b38ea2
273e1e7https://github.com/python/cpython/pull/103463/commits/273e1e74a9656b3e45cbc67b284457e730b38ea2
https://github.com/alisaifee
Schedule writer for remaining buffer in writelineshttps://github.com/python/cpython/pull/103463/commits/ce03f17a778d91f83684466d471714a51f9b0bde
ce03f17https://github.com/python/cpython/pull/103463/commits/ce03f17a778d91f83684466d471714a51f9b0bde
https://github.com/alisaifee
alisaifeehttps://github.com/alisaifee
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
gvanrossumhttps://github.com/gvanrossum
kumaraditya303https://github.com/kumaraditya303
code ownershttps://github.com/python/cpython/blob/2f41a009b7311a4b44bae5b3583cde3d6d10d8d1/.github/CODEOWNERS#L14
April 12, 2023 02:12https://github.com/python/cpython/pull/103463#event-8979927776
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Apr 12, 2023https://github.com/python/cpython/pull/103463#issuecomment-1504438214
require a NEWS entryhttps://devguide.python.org/committing/#updating-news-and-what-s-new-in-python
blurb_ithttps://blurb-it.herokuapp.com
blurbhttps://pypi.org/project/blurb/
Please reload this pagehttps://github.com/python/cpython/pull/103463
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Apr 12, 2023 https://github.com/python/cpython/pull/103463#ref-issue-1663541332
Calling SelectorSocketTransport.writelines with a very large payload doesn't get completely written to the socket #103462 https://github.com/python/cpython/issues/103462
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 12, 2023https://github.com/python/cpython/pull/103463#event-8979928572
https://github.com/ghost
ghosthttps://github.com/ghost
Apr 12, 2023https://github.com/python/cpython/pull/103463#issuecomment-1504438649
Please reload this pagehttps://github.com/python/cpython/pull/103463
https://cpython-clabot.herokuapp.com/signed-contributor-license-agreement?version=96a49432b8b111ec9bf5bfe9ad6c72c4
Please reload this pagehttps://github.com/python/cpython/pull/103463
https://github.com/alisaifee
Merge branch 'main' into fix-incomplete-writelinehttps://github.com/python/cpython/pull/103463/commits/8d2d34ce0f8975b0e9af09e8823fd0d88cdcd64f
8d2d34chttps://github.com/python/cpython/pull/103463/commits/8d2d34ce0f8975b0e9af09e8823fd0d88cdcd64f
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Apr 12, 2023https://github.com/python/cpython/pull/103463#issuecomment-1504445070
require a NEWS entryhttps://devguide.python.org/committing/#updating-news-and-what-s-new-in-python
blurb_ithttps://blurb-it.herokuapp.com
blurbhttps://pypi.org/project/blurb/
Please reload this pagehttps://github.com/python/cpython/pull/103463
https://github.com/alisaifee
alisaifeehttps://github.com/alisaifee
Apr 12, 2023https://github.com/python/cpython/pull/103463#event-8979981604
https://github.com/alisaifee
Ensure tests using sendmsg are marked with skiphttps://github.com/python/cpython/pull/103463/commits/c5a071e3f40cff537d71329ca05b91dcc1dbc6ad
c5a071ehttps://github.com/python/cpython/pull/103463/commits/c5a071e3f40cff537d71329ca05b91dcc1dbc6ad
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Apr 12, 2023https://github.com/python/cpython/pull/103463#issuecomment-1504465027
require a NEWS entryhttps://devguide.python.org/committing/#updating-news-and-what-s-new-in-python
blurb_ithttps://blurb-it.herokuapp.com
blurbhttps://pypi.org/project/blurb/
Please reload this pagehttps://github.com/python/cpython/pull/103463
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Apr 12, 2023 https://github.com/python/cpython/pull/103463#pullrequestreview-1381044409
View reviewed changes https://github.com/python/cpython/pull/103463/files/c5a071e3f40cff537d71329ca05b91dcc1dbc6ad
kumaraditya303https://github.com/kumaraditya303
https://github.com/python/cpython/pull/103463#pullrequestreview-1381044409
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/103463
alisaifeehttps://github.com/alisaifee
April 12, 2023 06:05https://github.com/python/cpython/pull/103463#commits-pushed-7f2b1e7
https://github.com/alisaifee
Add NEWS entryhttps://github.com/python/cpython/pull/103463/commits/7f2b1e7c1feb2ddb3ceedb0b69522101dfa2469e
7f2b1e7https://github.com/python/cpython/pull/103463/commits/7f2b1e7c1feb2ddb3ceedb0b69522101dfa2469e
https://github.com/alisaifee
Merge branch 'main' into fix-incomplete-writelinehttps://github.com/python/cpython/pull/103463/commits/d2bdce257a781321453d6e540c56a75b948386d3
d2bdce2https://github.com/python/cpython/pull/103463/commits/d2bdce257a781321453d6e540c56a75b948386d3
https://github.com/alisaifee
alisaifeehttps://github.com/alisaifee
Apr 12, 2023https://github.com/python/cpython/pull/103463#issuecomment-1505278526
Please reload this pagehttps://github.com/python/cpython/pull/103463
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Apr 13, 2023 https://github.com/python/cpython/pull/103463#pullrequestreview-1382596993
View reviewed changes https://github.com/python/cpython/pull/103463/files/d2bdce257a781321453d6e540c56a75b948386d3
Misc/NEWS.d/next/Library/2023-04-12-06-00-02.gh-issue-103462.w6yBlM.rsthttps://github.com/python/cpython/pull/103463/files/d2bdce257a781321453d6e540c56a75b948386d3#diff-d56961800dcbe3aea9525734197175abcecad10afa3257d7e085c124b4ffb34a
Please reload this pagehttps://github.com/python/cpython/pull/103463
https://github.com/kumaraditya303
Update Misc/NEWS.d/next/Library/2023-04-12-06-00-02.gh-issue-103462.w…https://github.com/python/cpython/pull/103463/commits/239a80f35b74f7fc0bd4e35c21ed1013383af176
239a80fhttps://github.com/python/cpython/pull/103463/commits/239a80f35b74f7fc0bd4e35c21ed1013383af176
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Apr 13, 2023 https://github.com/python/cpython/pull/103463#pullrequestreview-1382597551
View reviewed changes https://github.com/python/cpython/pull/103463/files/239a80f35b74f7fc0bd4e35c21ed1013383af176
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 13, 2023https://github.com/python/cpython/pull/103463#event-8992445438
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Apr 13, 2023https://github.com/python/cpython/pull/103463#event-8992447123
Calling SelectorSocketTransport.writelines with a very large payload doesn't get completely written to the socket #103462 https://github.com/python/cpython/issues/103462
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
Apr 13, 2023https://github.com/python/cpython/pull/103463#event-8992459347
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
19d2639https://github.com/python/cpython/commit/19d2639d1e6478e2e251479d842bdfa2e8272396
Apr 13, 2023https://github.com/python/cpython/pull/103463#event-8992558488
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 13, 2023https://github.com/python/cpython/pull/103463#event-8992558862
carljmhttps://github.com/carljm
Apr 13, 2023 https://github.com/python/cpython/pull/103463#ref-commit-9384106
https://github.com/carljm
Merge branch 'main' into superopthttps://github.com/carljm/cpython/commit/93841061430943cfca586b8752817d3a2faada52
9384106https://github.com/carljm/cpython/commit/93841061430943cfca586b8752817d3a2faada52
pythongh-103479https://github.com/python/cpython/issues/103479
pythonGH-103495https://github.com/python/cpython/pull/103495
pythongh-103365https://github.com/python/cpython/issues/103365
pythonGH-103494https://github.com/python/cpython/pull/103494
pythonGH-103488https://github.com/python/cpython/issues/103488
pythonGH-103502https://github.com/python/cpython/pull/103502
pythongh-103088https://github.com/python/cpython/issues/103088
pythonGH-103500https://github.com/python/cpython/pull/103500
pythonGH-103082https://github.com/python/cpython/issues/103082
python#103507https://github.com/python/cpython/pull/103507
pythongh-102978https://github.com/python/cpython/issues/102978
python#103228https://github.com/python/cpython/pull/103228
pythongh-103462https://github.com/python/cpython/issues/103462
python#103463https://github.com/python/cpython/pull/103463
pythongh-95299https://github.com/python/cpython/issues/95299
python#103316https://github.com/python/cpython/pull/103316
aiskhttps://github.com/aisk
Apr 18, 2023 https://github.com/python/cpython/pull/103463#ref-commit-44b69f6
https://github.com/alisaifee
https://github.com/aisk
pythongh-103462https://github.com/python/cpython/issues/103462
: Ensure SelectorSocketTransport.writelines registers …https://github.com/aisk/cpython/commit/44b69f67de2e03ecaa7bba9285ef99b59a73157f
44b69f6https://github.com/aisk/cpython/commit/44b69f67de2e03ecaa7bba9285ef99b59a73157f
python#103463https://github.com/python/cpython/pull/103463
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103463
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/103463/files/239a80f35b74f7fc0bd4e35c21ed1013383af176
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
topic-asyncio https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-asyncio
Calling SelectorSocketTransport.writelines with a very large payload doesn't get completely written to the socket https://github.com/python/cpython/issues/103462
Please reload this pagehttps://github.com/python/cpython/pull/103463
https://github.com/alisaifee
https://github.com/bedevere-bot
https://github.com/kumaraditya303
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.