| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:13f4e016-fcbc-0615-62e1-3a3d8d297d06 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B74E:2BFBB8:24FA813:3238946:696AD96D |
| html-safe-nonce | 2af8c6a2cb831dca6396a2a037b08ff53c41e27a0858c360bfa3d3eec25f61b6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzRFOjJCRkJCODoyNEZBODEzOjMyMzg5NDY6Njk2QUQ5NkQiLCJ2aXNpdG9yX2lkIjoiODIyMzQ2MzIxNDk5NzQ5NDEyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 65a9035697dc54fe13872c579913db94d9f5add2d8a29b8b1e9ade056c7e07a4 |
| hovercard-subject-tag | pull_request:1306337971 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/103358/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/782d59ede17f0e346eff0d1e87e94f8de2d5f726818186bb61ccaa64c293dd8d/python/cpython/pull/103358 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/782d59ede17f0e346eff0d1e87e94f8de2d5f726818186bb61ccaa64c293dd8d/python/cpython/pull/103358 |
| og:image:alt | #102213 introduced an optimisation to __getattr__ that had some unexpected side effects, one of which was a change in behavior of PropertyMock when the property has a side effect.
This change was r... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | freakboy3742 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 524a93f2c1f36522a3b4be4c110467ee4172245d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/103358#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103358 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103358 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/103358 |
| Reload | https://github.com/python/cpython/pull/103358 |
| Reload | https://github.com/python/cpython/pull/103358 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/103358 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/103358 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/103358#issue-comment-box |
| carljm | https://github.com/carljm |
| python:main | https://github.com/python/cpython/tree/main |
| freakboy3742:propertymock_sideeffect | https://github.com/freakboy3742/cpython/tree/propertymock_sideeffect |
|
gh-103329: Add regression test for PropertyMock with side effect
| https://github.com/python/cpython/pull/103358#top |
| carljm | https://github.com/carljm |
| python:main | https://github.com/python/cpython/tree/main |
| freakboy3742:propertymock_sideeffect | https://github.com/freakboy3742/cpython/tree/propertymock_sideeffect |
|
Conversation
5
| https://github.com/python/cpython/pull/103358 |
|
Commits
3
| https://github.com/python/cpython/pull/103358/commits |
|
Checks
0
| https://github.com/python/cpython/pull/103358/checks |
|
Files changed
2
| https://github.com/python/cpython/pull/103358/files |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/freakboy3742 |
| freakboy3742 | https://github.com/freakboy3742 |
| Apr 8, 2023 | https://github.com/python/cpython/pull/103358#issue-1659315497 |
| Please reload this page | https://github.com/python/cpython/pull/103358 |
| #102213 | https://github.com/python/cpython/issues/102213 |
| #103332 | https://github.com/python/cpython/pull/103332 |
| #103329 | https://github.com/python/cpython/issues/103329 |
| 3.12.0a7 changes behavior of PropertyMock #103329 | https://github.com/python/cpython/issues/103329 |
| Please reload this page | https://github.com/python/cpython/pull/103358 |
|
| https://github.com/freakboy3742 |
| Add regression test for | https://github.com/python/cpython/pull/103358/commits/26f27099cadf3b2e1b69fec02692bc8bab283564 |
| python#103329 | https://github.com/python/cpython/issues/103329 |
| . | https://github.com/python/cpython/pull/103358/commits/26f27099cadf3b2e1b69fec02692bc8bab283564 |
| 26f2709 | https://github.com/python/cpython/pull/103358/commits/26f27099cadf3b2e1b69fec02692bc8bab283564 |
| https://github.com/freakboy3742 |
| freakboy3742 | https://github.com/freakboy3742 |
| cjw296 | https://github.com/cjw296 |
| code owner | https://github.com/python/cpython/blob/91794e587306343619a451473efae22aa9f4b9bd/.github/CODEOWNERS#L106 |
| April 8, 2023 00:43 | https://github.com/python/cpython/pull/103358#event-8956751658 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
Apr 8, 2023
| https://github.com/python/cpython/pull/103358#ref-issue-1658331435 |
|
3.12.0a7 changes behavior of PropertyMock
#103329
| https://github.com/python/cpython/issues/103329 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Apr 8, 2023 | https://github.com/python/cpython/pull/103358#event-8956751850 |
|
| https://github.com/apps/blurb-it |
| 📜🤖 Added by blurb_it. | https://github.com/python/cpython/pull/103358/commits/45a4070957c5f9a7c151e32a0e17959043965d36 |
| 45a4070 | https://github.com/python/cpython/pull/103358/commits/45a4070957c5f9a7c151e32a0e17959043965d36 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
|
Apr 8, 2023
| https://github.com/python/cpython/pull/103358#pullrequestreview-1376684086 |
|
View reviewed changes
| https://github.com/python/cpython/pull/103358/files/45a4070957c5f9a7c151e32a0e17959043965d36 |
| Lib/test/test_unittest/testmock/testhelpers.py | https://github.com/python/cpython/pull/103358/files/45a4070957c5f9a7c151e32a0e17959043965d36#diff-29c9bac78ef671714bc978cfd033586a1f96df08736194b42b66e5a8fcc08bbe |
| Please reload this page | https://github.com/python/cpython/pull/103358 |
|
| https://github.com/carljm |
| Update Lib/test/test_unittest/testmock/testhelpers.py | https://github.com/python/cpython/pull/103358/commits/1a94fad66cb4a9ecf2f6adcef3aae8eda7da8bef |
| 1a94fad | https://github.com/python/cpython/pull/103358/commits/1a94fad66cb4a9ecf2f6adcef3aae8eda7da8bef |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| Apr 8, 2023 | https://github.com/python/cpython/pull/103358#issuecomment-1500754842 |
| @freakboy3742 | https://github.com/freakboy3742 |
| Please reload this page | https://github.com/python/cpython/pull/103358 |
| https://github.com/freakboy3742 |
| freakboy3742 | https://github.com/freakboy3742 |
| Apr 8, 2023 | https://github.com/python/cpython/pull/103358#issuecomment-1500755481 |
| @carljm | https://github.com/carljm |
| Please reload this page | https://github.com/python/cpython/pull/103358 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
|
needs backport to 3.11
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22 |
| Apr 8, 2023 | https://github.com/python/cpython/pull/103358#event-8956856284 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| 26c6598 | https://github.com/python/cpython/commit/26c65980dc6d842879d133165bb7c461d98cc6c7 |
| Apr 8, 2023 | https://github.com/python/cpython/pull/103358#event-8956856570 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Apr 8, 2023 | https://github.com/python/cpython/pull/103358#issuecomment-1500763294 |
| @freakboy3742 | https://github.com/freakboy3742 |
| @carljm | https://github.com/carljm |
| Please reload this page | https://github.com/python/cpython/pull/103358 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Apr 8, 2023 | https://github.com/python/cpython/pull/103358#event-8956856623 |
| miss-islington | https://github.com/miss-islington |
|
Apr 8, 2023
| https://github.com/python/cpython/pull/103358#ref-commit-6c3da92 |
|
| https://github.com/freakboy3742 |
|
| https://github.com/miss-islington |
| pythongh-103329 | https://github.com/python/cpython/issues/103329 |
| : Add regression test for PropertyMock with side effect ( | https://github.com/miss-islington/cpython/commit/6c3da92ee461622201e9690500da97964528daf5 |
| 6c3da92 | https://github.com/miss-islington/cpython/commit/6c3da92ee461622201e9690500da97964528daf5 |
| pythonGH-103358 | https://github.com/python/cpython/pull/103358 |
| 26c6598 | https://github.com/miss-islington/cpython/commit/26c65980dc6d842879d133165bb7c461d98cc6c7 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Apr 8, 2023 | https://github.com/python/cpython/pull/103358#issuecomment-1500763371 |
| GH-103364 | https://github.com/python/cpython/pull/103364 |
| 3.11 branch | https://github.com/python/cpython/tree/3.11 |
| Please reload this page | https://github.com/python/cpython/pull/103358 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.11
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22 |
| Apr 8, 2023 | https://github.com/python/cpython/pull/103358#event-8956857078 |
| https://github.com/freakboy3742 |
| freakboy3742 | https://github.com/freakboy3742 |
| April 8, 2023 02:09 | https://github.com/python/cpython/pull/103358#event-8956857652 |
| https://github.com/freakboy3742 |
| freakboy3742 | https://github.com/freakboy3742 |
|
Apr 8, 2023
| https://github.com/python/cpython/pull/103358#ref-issue-1658174753 |
|
CI Tests Failure with Release of Python 3.12.0-alpha.7
beeware/briefcase#1165
| https://github.com/beeware/briefcase/issues/1165 |
| miss-islington | https://github.com/miss-islington |
|
Apr 8, 2023
| https://github.com/python/cpython/pull/103358#ref-commit-29a1e89 |
|
| https://github.com/miss-islington |
|
| https://github.com/freakboy3742 |
| gh-103329 | https://github.com/python/cpython/issues/103329 |
| : Add regression test for PropertyMock with side effect ( | https://github.com/python/cpython/commit/29a1e89c9fbfaf409cee3d6fada9473a324ac1c8 |
| GH-… | https://github.com/python/cpython/pull/103358 |
| 29a1e89 | https://github.com/python/cpython/commit/29a1e89c9fbfaf409cee3d6fada9473a324ac1c8 |
| …103358 | https://github.com/python/cpython/pull/103358 |
| 26c6598 | https://github.com/python/cpython/commit/26c65980dc6d842879d133165bb7c461d98cc6c7 |
| warsaw | https://github.com/warsaw |
|
Apr 11, 2023
| https://github.com/python/cpython/pull/103358#ref-commit-8c2786a |
|
| https://github.com/freakboy3742 |
|
| https://github.com/warsaw |
| pythongh-103329 | https://github.com/python/cpython/issues/103329 |
| : Add regression test for PropertyMock with side effect ( | https://github.com/warsaw/cpython/commit/8c2786a858e37959b39c7c408b7b7f4982e45eee |
| 8c2786a | https://github.com/warsaw/cpython/commit/8c2786a858e37959b39c7c408b7b7f4982e45eee |
| python#103358 | https://github.com/python/cpython/pull/103358 |
| https://github.com/sunmy2019 |
| sunmy2019 | https://github.com/sunmy2019 |
|
Apr 25, 2023
| https://github.com/python/cpython/pull/103358#ref-pullrequest-1681447672 |
|
gh-102213: Optimize the performance of __getattr__
#103761
| https://github.com/python/cpython/pull/103761 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103358 |
|
| https://github.com/carljm |
|
carljm
| https://github.com/carljm |
|
| https://github.com/python/cpython/pull/103358/files/45a4070957c5f9a7c151e32a0e17959043965d36 |
|
| https://github.com/cjw296 |
|
cjw296
| https://github.com/cjw296 |
|
3.12.0a7 changes behavior of PropertyMock
| https://github.com/python/cpython/issues/103329 |
| Please reload this page | https://github.com/python/cpython/pull/103358 |
|
| https://github.com/freakboy3742 |
|
| https://github.com/carljm |
|
| https://github.com/miss-islington |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |