| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8aabf99c-a02d-110a-2636-502c2efbb511 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 944A:14C034:586D99:7814A4:6969DAB0 |
| html-safe-nonce | 98e48d1a3b87b4a75e6bedb0e71ec9b4c3485bafe620fc0739f261472dd9703c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDRBOjE0QzAzNDo1ODZEOTk6NzgxNEE0OjY5NjlEQUIwIiwidmlzaXRvcl9pZCI6Ijg0MjQwMDkxODgxMDE0NDYzMjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e1f541cd5bc863e1ba980e25cff1fa2f2e0b6009b2c8575207da2531795a58f2 |
| hovercard-subject-tag | pull_request:1305918612 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/103347/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/53f38cbabfb394bcb3d70379ae0d3900f55d52fb784850ad11eb3709c7e36e86/python/cpython/pull/103347 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/53f38cbabfb394bcb3d70379ae0d3900f55d52fb784850ad11eb3709c7e36e86/python/cpython/pull/103347 |
| og:image:alt | This PR adds more tests for runtime-checkable protocols, ensuring various edge cases are covered. Some of the invariants I'm adding tests for would have been broken by some more hare-brained op... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | AlexWaygood |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/103347#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103347 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103347 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/103347 |
| Reload | https://github.com/python/cpython/pull/103347 |
| Reload | https://github.com/python/cpython/pull/103347 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/103347 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/103347 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/103347#issue-comment-box |
| AlexWaygood | https://github.com/AlexWaygood |
| python:main | https://github.com/python/cpython/tree/main |
| AlexWaygood:more-runtime-protocol-tests | https://github.com/AlexWaygood/cpython/tree/more-runtime-protocol-tests |
|
gh-74690: Add more tests for runtime-checkable protocols
| https://github.com/python/cpython/pull/103347#top |
| AlexWaygood | https://github.com/AlexWaygood |
| python:main | https://github.com/python/cpython/tree/main |
| AlexWaygood:more-runtime-protocol-tests | https://github.com/AlexWaygood/cpython/tree/more-runtime-protocol-tests |
|
Conversation
2
| https://github.com/python/cpython/pull/103347 |
|
Commits
1
| https://github.com/python/cpython/pull/103347/commits |
|
Checks
0
| https://github.com/python/cpython/pull/103347/checks |
|
Files changed
| https://github.com/python/cpython/pull/103347/files |
| Please reload this page | https://github.com/python/cpython/pull/103347 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| Apr 7, 2023 | https://github.com/python/cpython/pull/103347#issue-1658819702 |
| Please reload this page | https://github.com/python/cpython/pull/103347 |
| #74690 | https://github.com/python/cpython/issues/74690 |
| #103310 | https://github.com/python/cpython/pull/103310 |
| Performance of typing._ProtocolMeta._get_protocol_attrs and isinstance #74690 | https://github.com/python/cpython/issues/74690 |
| Please reload this page | https://github.com/python/cpython/pull/103347 |
|
| https://github.com/AlexWaygood |
| pythongh-74690 | https://github.com/python/cpython/issues/74690 |
| : Add more tests for runtime-checkable protocols | https://github.com/python/cpython/pull/103347/commits/c3690ad25cceb71c89817c920385007eaa0a4b79 |
| c3690ad | https://github.com/python/cpython/pull/103347/commits/c3690ad25cceb71c89817c920385007eaa0a4b79 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
tests
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
topic-typing
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing |
|
needs backport to 3.11
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22 |
| Apr 7, 2023 | https://github.com/python/cpython/pull/103347#event-8953945701 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| carljm | https://github.com/carljm |
| April 7, 2023 13:42 | https://github.com/python/cpython/pull/103347#event-8953945736 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| Fidget-Spinner | https://github.com/Fidget-Spinner |
| JelleZijlstra | https://github.com/JelleZijlstra |
| gvanrossum | https://github.com/gvanrossum |
| code owners | https://github.com/python/cpython/blob/4dc339b4d69195448207e1faecc3e258700daf33/.github/CODEOWNERS#L141 |
| April 7, 2023 13:42 | https://github.com/python/cpython/pull/103347#event-8953945777 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
Apr 7, 2023
| https://github.com/python/cpython/pull/103347#ref-issue-1198974045 |
|
Performance of typing._ProtocolMeta._get_protocol_attrs and isinstance
#74690
| https://github.com/python/cpython/issues/74690 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Apr 7, 2023 | https://github.com/python/cpython/pull/103347#event-8953946317 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
|
Apr 7, 2023
| https://github.com/python/cpython/pull/103347#pullrequestreview-1376412137 |
|
View reviewed changes
| https://github.com/python/cpython/pull/103347/files/c3690ad25cceb71c89817c920385007eaa0a4b79 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Apr 7, 2023 | https://github.com/python/cpython/pull/103347#event-8955114182 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| 800382a | https://github.com/python/cpython/commit/800382a2b0980c21dfb2a8ac02aaf1e881f987b9 |
| Apr 7, 2023 | https://github.com/python/cpython/pull/103347#event-8955118246 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Apr 7, 2023 | https://github.com/python/cpython/pull/103347#issuecomment-1500483535 |
| @AlexWaygood | https://github.com/AlexWaygood |
| Please reload this page | https://github.com/python/cpython/pull/103347 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Apr 7, 2023 | https://github.com/python/cpython/pull/103347#event-8955118444 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| April 7, 2023 17:21 | https://github.com/python/cpython/pull/103347#event-8955118505 |
| miss-islington | https://github.com/miss-islington |
|
Apr 7, 2023
| https://github.com/python/cpython/pull/103347#ref-commit-ea8f5fe |
|
| https://github.com/AlexWaygood |
|
| https://github.com/miss-islington |
| pythongh-74690 | https://github.com/python/cpython/issues/74690 |
| : Add more tests for runtime-checkable protocols ( | https://github.com/miss-islington/cpython/commit/ea8f5fe26c988aade9f8a9b994a70cd530142049 |
| pytho… | https://github.com/python/cpython/pull/103347 |
| ea8f5fe | https://github.com/miss-islington/cpython/commit/ea8f5fe26c988aade9f8a9b994a70cd530142049 |
| …nGH-103347 | https://github.com/python/cpython/pull/103347 |
| 800382a | https://github.com/miss-islington/cpython/commit/800382a2b0980c21dfb2a8ac02aaf1e881f987b9 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Apr 7, 2023 | https://github.com/python/cpython/pull/103347#issuecomment-1500483655 |
| GH-103350 | https://github.com/python/cpython/pull/103350 |
| 3.11 branch | https://github.com/python/cpython/tree/3.11 |
| Please reload this page | https://github.com/python/cpython/pull/103347 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.11
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.11%22 |
| Apr 7, 2023 | https://github.com/python/cpython/pull/103347#event-8955119248 |
| miss-islington | https://github.com/miss-islington |
|
Apr 7, 2023
| https://github.com/python/cpython/pull/103347#ref-commit-1b1f016 |
|
| https://github.com/miss-islington |
|
| https://github.com/AlexWaygood |
| gh-74690 | https://github.com/python/cpython/issues/74690 |
| : Add more tests for runtime-checkable protocols ( | https://github.com/python/cpython/commit/1b1f0164cb210abc0af5803bee071d67e8272bb8 |
| GH-103347 | https://github.com/python/cpython/pull/103347 |
| ) | https://github.com/python/cpython/commit/1b1f0164cb210abc0af5803bee071d67e8272bb8 |
| 1b1f016 | https://github.com/python/cpython/commit/1b1f0164cb210abc0af5803bee071d67e8272bb8 |
| 800382a | https://github.com/python/cpython/commit/800382a2b0980c21dfb2a8ac02aaf1e881f987b9 |
| warsaw | https://github.com/warsaw |
|
Apr 11, 2023
| https://github.com/python/cpython/pull/103347#ref-commit-3874680 |
|
| https://github.com/AlexWaygood |
|
| https://github.com/warsaw |
| pythongh-74690 | https://github.com/python/cpython/issues/74690 |
| : Add more tests for runtime-checkable protocols ( | https://github.com/warsaw/cpython/commit/38746803f03aa7ad3ef7f6991e50ff8146630087 |
| pytho… | https://github.com/python/cpython/pull/103347 |
| 3874680 | https://github.com/warsaw/cpython/commit/38746803f03aa7ad3ef7f6991e50ff8146630087 |
| …n#103347 | https://github.com/python/cpython/pull/103347 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
Apr 12, 2023
| https://github.com/python/cpython/pull/103347#ref-pullrequest-1664192106 |
|
Backport test coverage improvements for runtime-checkable protocols
python/typing_extensions#136
| https://github.com/python/typing_extensions/pull/136 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103347 |
|
| https://github.com/carljm |
|
carljm
| https://github.com/carljm |
|
| https://github.com/python/cpython/pull/103347/files/c3690ad25cceb71c89817c920385007eaa0a4b79 |
|
| https://github.com/gvanrossum |
|
gvanrossum
| https://github.com/gvanrossum |
|
| https://github.com/Fidget-Spinner |
|
Fidget-Spinner
| https://github.com/Fidget-Spinner |
|
| https://github.com/JelleZijlstra |
|
JelleZijlstra
| https://github.com/JelleZijlstra |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
tests
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests |
|
topic-typing
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing |
| Please reload this page | https://github.com/python/cpython/pull/103347 |
|
| https://github.com/AlexWaygood |
|
| https://github.com/miss-islington |
|
| https://github.com/bedevere-bot |
|
| https://github.com/carljm |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |