René's URL Explorer Experiment


Title: Revert "gh-102213: Optimize the performance of `__getattr__` (GH-102248)" by sobolevn · Pull Request #103332 · python/cpython · GitHub

Open Graph Title: Revert "gh-102213: Optimize the performance of `__getattr__` (GH-102248)" by sobolevn · Pull Request #103332 · python/cpython

X Title: Revert "gh-102213: Optimize the performance of `__getattr__` (GH-102248)" by sobolevn · Pull Request #103332 · python/cpython

Description: This commit caused at least two regressions: Maximum recursion depth exceeded in __getattr__(). #103272 3.12.0a7 changes behavior of PropertyMock #103329 CC @wangxiang-hz @Fidget-Spinner @sunmy20...

Open Graph Description: This commit caused at least two regressions: Maximum recursion depth exceeded in __getattr__(). #103272 3.12.0a7 changes behavior of PropertyMock #103329 CC @wangxiang-hz @Fidget-Spinner @sunmy20...

X Description: This commit caused at least two regressions: Maximum recursion depth exceeded in __getattr__(). #103272 3.12.0a7 changes behavior of PropertyMock #103329 CC @wangxiang-hz @Fidget-Spinner @sunmy20...

Opengraph URL: https://github.com/python/cpython/pull/103332

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:80dd4687-7ce9-0f7c-ae5b-aea6f07229af
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC00:14EE64:2D8515:3DE5A2:6969A9F3
html-safe-nonce4f525c9e22fa49ac4f1a1bafb7aeeb55005a9b0b93105d6875a0caf3df2a2e3f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzAwOjE0RUU2NDoyRDg1MTU6M0RFNUEyOjY5NjlBOUYzIiwidmlzaXRvcl9pZCI6IjcwNzY4NTA4NjcwMjQ1MzgwOTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac50c74ea66130fd254f1c724b4e137cfe2630993ac419acb148d2d2031b18b6da
hovercard-subject-tagpull_request:1305562614
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/103332/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/87111dda4602da09381768d82dc1d752ad7c042024d99acbcab2b512a6807d57/python/cpython/pull/103332
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/87111dda4602da09381768d82dc1d752ad7c042024d99acbcab2b512a6807d57/python/cpython/pull/103332
og:image:altThis commit caused at least two regressions: Maximum recursion depth exceeded in __getattr__(). #103272 3.12.0a7 changes behavior of PropertyMock #103329 CC @wangxiang-hz @Fidget-Spinner @sunmy20...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
None24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release124667f43168afb6c9c03b7c02eb5b1d2e1be3d9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/103332#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103332
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103332
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/103332
Reloadhttps://github.com/python/cpython/pull/103332
Reloadhttps://github.com/python/cpython/pull/103332
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/103332
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/103332
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/103332#issue-comment-box
Fidget-Spinnerhttps://github.com/Fidget-Spinner
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-103272https://github.com/sobolevn/cpython/tree/issue-103272
Revert "gh-102213: Optimize the performance of __getattr__ (GH-102248)" https://github.com/python/cpython/pull/103332#top
Fidget-Spinnerhttps://github.com/Fidget-Spinner
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-103272https://github.com/sobolevn/cpython/tree/issue-103272
Conversation 2 https://github.com/python/cpython/pull/103332
Commits 1 https://github.com/python/cpython/pull/103332/commits
Checks 0 https://github.com/python/cpython/pull/103332/checks
Files changed https://github.com/python/cpython/pull/103332/files
Please reload this pagehttps://github.com/python/cpython/pull/103332
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Apr 7, 2023https://github.com/python/cpython/pull/103332#issue-1658394176
Please reload this pagehttps://github.com/python/cpython/pull/103332
Maximum recursion depth exceeded in __getattr__(). #103272https://github.com/python/cpython/issues/103272
3.12.0a7 changes behavior of PropertyMock #103329https://github.com/python/cpython/issues/103329
@wangxiang-hzhttps://github.com/wangxiang-hz
@Fidget-Spinnerhttps://github.com/Fidget-Spinner
@sunmy2019https://github.com/sunmy2019
@sunmy2019https://github.com/sunmy2019
Improve the Efficiency of Python3.11.1 __getattr__ #102213https://github.com/python/cpython/issues/102213
Please reload this pagehttps://github.com/python/cpython/pull/103332
https://github.com/sobolevn
Revert "https://github.com/python/cpython/pull/103332/commits/96946fd2dd8331c73d6ef5fc6f04c1723b22019e
pythongh-102213https://github.com/python/cpython/issues/102213
: Optimize the performance ofhttps://github.com/python/cpython/pull/103332/commits/96946fd2dd8331c73d6ef5fc6f04c1723b22019e
__getattr__https://github.com/python/cpython/pull/103332/commits/96946fd2dd8331c73d6ef5fc6f04c1723b22019e
(https://github.com/python/cpython/pull/103332/commits/96946fd2dd8331c73d6ef5fc6f04c1723b22019e
p…https://github.com/python/cpython/pull/102248
96946fdhttps://github.com/python/cpython/pull/103332/commits/96946fd2dd8331c73d6ef5fc6f04c1723b22019e
…ythonGH-102248https://github.com/python/cpython/pull/102248
aa0a73dhttps://github.com/sobolevn/cpython/commit/aa0a73d1bc53dcb6348a869df1e775138991e561
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
markshannonhttps://github.com/markshannon
code ownerhttps://github.com/python/cpython/blob/efb0a2cf3adf4629cf4669cb558758fb78107319/.github/CODEOWNERS#L22
April 7, 2023 05:47https://github.com/python/cpython/pull/103332#event-8951622685
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Apr 7, 2023 https://github.com/python/cpython/pull/103332#ref-issue-1598539750
Improve the Efficiency of Python3.11.1 __getattr__ #102213 https://github.com/python/cpython/issues/102213
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 7, 2023https://github.com/python/cpython/pull/103332#event-8951622971
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Apr 7, 2023https://github.com/python/cpython/pull/103332#event-8951623743
https://github.com/sunmy2019
sunmy2019https://github.com/sunmy2019
Apr 7, 2023https://github.com/python/cpython/pull/103332#issuecomment-1499984398
Please reload this pagehttps://github.com/python/cpython/pull/103332
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
Apr 7, 2023https://github.com/python/cpython/pull/103332#issuecomment-1499988438
https://github.com/python/cpython/blob/main/Lib/test/test_descr.pyhttps://github.com/python/cpython/blob/main/Lib/test/test_descr.py
Please reload this pagehttps://github.com/python/cpython/pull/103332
https://github.com/sunmy2019
sunmy2019https://github.com/sunmy2019
Apr 7, 2023 https://github.com/python/cpython/pull/103332#ref-pullrequest-1658493057
gh-103272: add regression test for getattr that raises #103336 https://github.com/python/cpython/pull/103336
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
Apr 7, 2023 https://github.com/python/cpython/pull/103332#pullrequestreview-1375998371
View reviewed changes https://github.com/python/cpython/pull/103332/files/96946fd2dd8331c73d6ef5fc6f04c1723b22019e
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 7, 2023https://github.com/python/cpython/pull/103332#event-8952556329
https://github.com/Fidget-Spinner
Fidget-Spinnerhttps://github.com/Fidget-Spinner
059bb04https://github.com/python/cpython/commit/059bb04245a8b3490f93dfd72522a431a113eef1
Apr 7, 2023https://github.com/python/cpython/pull/103332#event-8952677535
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 7, 2023https://github.com/python/cpython/pull/103332#event-8952677802
https://github.com/sunmy2019
sunmy2019https://github.com/sunmy2019
Apr 7, 2023 https://github.com/python/cpython/pull/103332#ref-issue-1658331435
3.12.0a7 changes behavior of PropertyMock #103329 https://github.com/python/cpython/issues/103329
gh-103329: Add regression test for PropertyMock with side effect #103358 https://github.com/python/cpython/pull/103358
CI Tests Failure with Release of Python 3.12.0-alpha.7 beeware/briefcase#1165 https://github.com/beeware/briefcase/issues/1165
warsawhttps://github.com/warsaw
Apr 11, 2023 https://github.com/python/cpython/pull/103332#ref-commit-ef37048
https://github.com/sobolevn
https://github.com/warsaw
pythongh-102213https://github.com/python/cpython/issues/102213
: Revert "https://github.com/warsaw/cpython/commit/ef370486f6fe904727436a3bd561c56b2498fcbb
pythongh-102213https://github.com/python/cpython/issues/102213
: Optimize the performance of…https://github.com/warsaw/cpython/commit/ef370486f6fe904727436a3bd561c56b2498fcbb
ef37048https://github.com/warsaw/cpython/commit/ef370486f6fe904727436a3bd561c56b2498fcbb
pythonGH-102248https://github.com/python/cpython/pull/102248
pythonGH-103332https://github.com/python/cpython/pull/103332
aa0a73dhttps://github.com/warsaw/cpython/commit/aa0a73d1bc53dcb6348a869df1e775138991e561
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 14, 2023 https://github.com/python/cpython/pull/103332#ref-issue-1669052315
[3.12] Behavior change: __getattr__ gets called after property raises NotImplementedError #103551 https://github.com/python/cpython/issues/103551
https://github.com/sunmy2019
sunmy2019https://github.com/sunmy2019
Apr 20, 2023 https://github.com/python/cpython/pull/103332#ref-issue-1675151210
Unexpected SystemError in Python3.12.0a7: returned a result with an exception set #103632 https://github.com/python/cpython/issues/103632
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103332
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/python/cpython/pull/103332/files/96946fd2dd8331c73d6ef5fc6f04c1723b22019e
https://github.com/markshannon
markshannon https://github.com/markshannon
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/103332
https://github.com/sobolevn
https://github.com/sunmy2019
https://github.com/Fidget-Spinner
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.