René's URL Explorer Experiment


Title: gh-74690: `typing._ProtocolMeta.__instancecheck__`: Exit early for protocols that only have callable members by AlexWaygood · Pull Request #103310 · python/cpython · GitHub

Open Graph Title: gh-74690: `typing._ProtocolMeta.__instancecheck__`: Exit early for protocols that only have callable members by AlexWaygood · Pull Request #103310 · python/cpython

X Title: gh-74690: `typing._ProtocolMeta.__instancecheck__`: Exit early for protocols that only have callable members by AlexWaygood · Pull Request #103310 · python/cpython

Description: This speeds up this isinstance() call 12x, while maintaining all invariants: from typing import SupportsInt isinstance(object(), SupportsInt) The performance of other kinds of isinstance() calls is...

Open Graph Description: This speeds up this isinstance() call 12x, while maintaining all invariants: from typing import SupportsInt isinstance(object(), SupportsInt) The performance of other kinds of isinstance() calls is...

X Description: This speeds up this isinstance() call 12x, while maintaining all invariants: from typing import SupportsInt isinstance(object(), SupportsInt) The performance of other kinds of isinstance() calls is...

Opengraph URL: https://github.com/python/cpython/pull/103310

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d51643ad-8be8-276a-066f-dcff0ac6f73d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA5C4:392B41:3E5CD9:55E30D:696A737E
html-safe-nonce33407411e5113af1987af891a2f37b1dee8687227d6bf5a83bd2c2b7fccabcfb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUM0OjM5MkI0MTozRTVDRDk6NTVFMzBEOjY5NkE3MzdFIiwidmlzaXRvcl9pZCI6IjQwMzA1NjQ5NTM0OTg0ODE1MzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6c42cf3afa31d4250773a7bd4f0f4dff35fe188bc137500682e0702acb5e7fba
hovercard-subject-tagpull_request:1304532749
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/103310/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/440dedb0b8431c2fbb3691ab9055fed2d7728a955c77f38b2e2d60fc189ed005/python/cpython/pull/103310
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/440dedb0b8431c2fbb3691ab9055fed2d7728a955c77f38b2e2d60fc189ed005/python/cpython/pull/103310
og:image:altThis speeds up this isinstance() call 12x, while maintaining all invariants: from typing import SupportsInt isinstance(object(), SupportsInt) The performance of other kinds of isinstance() calls is...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAlexWaygood
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/103310#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103310
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103310
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/103310
Reloadhttps://github.com/python/cpython/pull/103310
Reloadhttps://github.com/python/cpython/pull/103310
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/103310
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/103310
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/103310#issue-comment-box
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:callable-protocols-optimisationhttps://github.com/AlexWaygood/cpython/tree/callable-protocols-optimisation
gh-74690: typing._ProtocolMeta.__instancecheck__: Exit early for protocols that only have callable members https://github.com/python/cpython/pull/103310#top
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:callable-protocols-optimisationhttps://github.com/AlexWaygood/cpython/tree/callable-protocols-optimisation
Conversation 3 https://github.com/python/cpython/pull/103310
Commits 1 https://github.com/python/cpython/pull/103310/commits
Checks 0 https://github.com/python/cpython/pull/103310/checks
Files changed https://github.com/python/cpython/pull/103310/files
Please reload this pagehttps://github.com/python/cpython/pull/103310
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 6, 2023https://github.com/python/cpython/pull/103310#issue-1657161434
Please reload this pagehttps://github.com/python/cpython/pull/103310
Performance of typing._ProtocolMeta._get_protocol_attrs and isinstance #74690https://github.com/python/cpython/issues/74690
Please reload this pagehttps://github.com/python/cpython/pull/103310
https://github.com/AlexWaygood
pythongh-74690https://github.com/python/cpython/issues/74690
: typing._ProtocolMeta.__instancecheck__: Exit early fo…https://github.com/python/cpython/pull/103310/commits/8cc20e60e14e1d5f634e20b692a0064776bd232a
8cc20e6https://github.com/python/cpython/pull/103310/commits/8cc20e60e14e1d5f634e20b692a0064776bd232a
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
type-feature https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-feature
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
stdlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A3.12
Apr 6, 2023https://github.com/python/cpython/pull/103310#event-8944469112
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
carljmhttps://github.com/carljm
April 6, 2023 10:38https://github.com/python/cpython/pull/103310#event-8944469173
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Fidget-Spinnerhttps://github.com/Fidget-Spinner
JelleZijlstrahttps://github.com/JelleZijlstra
gvanrossumhttps://github.com/gvanrossum
code ownershttps://github.com/python/cpython/blob/482b6eeadcde3e6573f0d243e687de7be7680379/.github/CODEOWNERS#L141
April 6, 2023 10:38https://github.com/python/cpython/pull/103310#event-8944469245
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Apr 6, 2023 https://github.com/python/cpython/pull/103310#ref-issue-1198974045
Performance of typing._ProtocolMeta._get_protocol_attrs and isinstance #74690 https://github.com/python/cpython/issues/74690
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 6, 2023https://github.com/python/cpython/pull/103310#event-8944470209
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Apr 6, 2023https://github.com/python/cpython/pull/103310#event-8944471386
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 6, 2023https://github.com/python/cpython/pull/103310#issuecomment-1498875227
Please reload this pagehttps://github.com/python/cpython/pull/103310
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
Apr 6, 2023https://github.com/python/cpython/pull/103310#event-8944620937
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 6, 2023https://github.com/python/cpython/pull/103310#issuecomment-1498876348
Please reload this pagehttps://github.com/python/cpython/pull/103310
Please reload this pagehttps://github.com/python/cpython/pull/103310
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 6, 2023https://github.com/python/cpython/pull/103310#issuecomment-1499123360
Please reload this pagehttps://github.com/python/cpython/pull/103310
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 6, 2023https://github.com/python/cpython/pull/103310#event-8946419684
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
April 6, 2023 14:08https://github.com/python/cpython/pull/103310#event-8946420652
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 7, 2023 https://github.com/python/cpython/pull/103310#ref-pullrequest-1658819702
gh-74690: Add more tests for runtime-checkable protocols #103347 https://github.com/python/cpython/pull/103347
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103310
https://github.com/carljm
carljm https://github.com/carljm
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A3.12
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
stdlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
type-feature https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-feature
Please reload this pagehttps://github.com/python/cpython/pull/103310
https://github.com/AlexWaygood
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.