René's URL Explorer Experiment


Title: gh-74690: Further optimise `typing._ProtocolMeta.__instancecheck__` by AlexWaygood · Pull Request #103280 · python/cpython · GitHub

Open Graph Title: gh-74690: Further optimise `typing._ProtocolMeta.__instancecheck__` by AlexWaygood · Pull Request #103280 · python/cpython

X Title: gh-74690: Further optimise `typing._ProtocolMeta.__instancecheck__` by AlexWaygood · Pull Request #103280 · python/cpython

Description: I probably should have spotted this when doing #103034! This provides some more speedup for isinstance() checks against runtime-checkable protocols. The improvement is small, but noticeable. Benchm...

Open Graph Description: I probably should have spotted this when doing #103034! This provides some more speedup for isinstance() checks against runtime-checkable protocols. The improvement is small, but noticeable. Benchm...

X Description: I probably should have spotted this when doing #103034! This provides some more speedup for isinstance() checks against runtime-checkable protocols. The improvement is small, but noticeable. Benchm...

Opengraph URL: https://github.com/python/cpython/pull/103280

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2ab089f7-e8eb-3441-b04b-79bd4436827e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCFD4:1FC3E6:926A4:CE0FF:696A020D
html-safe-nonceaeae1fb4d0e93b043796dfb628294a46941ebb30a46216b0d3702d1f2ad6c3dd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRkQ0OjFGQzNFNjo5MjZBNDpDRTBGRjo2OTZBMDIwRCIsInZpc2l0b3JfaWQiOiI3NTk3OTAwMzI2MzkxOTA2ODI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaceb01852c57fd3a064da061ec05d144bf39e60f2f384e3c8a84311a920aa3f985
hovercard-subject-tagpull_request:1303358185
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/103280/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0a13844745acc064d3634b92c3f2f418d7b5303b6e2ff68125d33829c68d93bf/python/cpython/pull/103280
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0a13844745acc064d3634b92c3f2f418d7b5303b6e2ff68125d33829c68d93bf/python/cpython/pull/103280
og:image:altI probably should have spotted this when doing #103034! This provides some more speedup for isinstance() checks against runtime-checkable protocols. The improvement is small, but noticeable. Benchm...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAlexWaygood
hostnamegithub.com
expected-hostnamegithub.com
None578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release671c2f67171dbced24284331f3133a613d08c366
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/103280#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103280
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103280
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/103280
Reloadhttps://github.com/python/cpython/pull/103280
Reloadhttps://github.com/python/cpython/pull/103280
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/103280
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/103280
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/103280#issue-comment-box
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:more-optimisationhttps://github.com/AlexWaygood/cpython/tree/more-optimisation
gh-74690: Further optimise typing._ProtocolMeta.__instancecheck__ https://github.com/python/cpython/pull/103280#top
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:more-optimisationhttps://github.com/AlexWaygood/cpython/tree/more-optimisation
Conversation 2 https://github.com/python/cpython/pull/103280
Commits 1 https://github.com/python/cpython/pull/103280/commits
Checks 0 https://github.com/python/cpython/pull/103280/checks
Files changed https://github.com/python/cpython/pull/103280/files
Please reload this pagehttps://github.com/python/cpython/pull/103280
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 5, 2023https://github.com/python/cpython/pull/103280#issue-1655797096
Please reload this pagehttps://github.com/python/cpython/pull/103280
#103034https://github.com/python/cpython/pull/103034
Performance of typing._ProtocolMeta._get_protocol_attrs and isinstance #74690https://github.com/python/cpython/issues/74690
Please reload this pagehttps://github.com/python/cpython/pull/103280
https://github.com/AlexWaygood
pythongh-74690https://github.com/python/cpython/issues/74690
: Further optimise `typing._ProtocolMeta.__instancechec…https://github.com/python/cpython/pull/103280/commits/eee4b2c91c1da374f9d5b2cb735d96f7bef4c3dc
eee4b2chttps://github.com/python/cpython/pull/103280/commits/eee4b2c91c1da374f9d5b2cb735d96f7bef4c3dc
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
type-feature https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-feature
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
stdlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A3.12
Apr 5, 2023https://github.com/python/cpython/pull/103280#event-8936274410
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
carljmhttps://github.com/carljm
April 5, 2023 15:00https://github.com/python/cpython/pull/103280#event-8936274484
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Fidget-Spinnerhttps://github.com/Fidget-Spinner
JelleZijlstrahttps://github.com/JelleZijlstra
gvanrossumhttps://github.com/gvanrossum
code ownershttps://github.com/python/cpython/blob/fdd0fff277a55c010a4da0a7af0e986e38560545/.github/CODEOWNERS#L141
April 5, 2023 15:00https://github.com/python/cpython/pull/103280#event-8936274650
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 5, 2023https://github.com/python/cpython/pull/103280#event-8936275183
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Apr 5, 2023 https://github.com/python/cpython/pull/103280#ref-issue-1198974045
Performance of typing._ProtocolMeta._get_protocol_attrs and isinstance #74690 https://github.com/python/cpython/issues/74690
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Apr 5, 2023https://github.com/python/cpython/pull/103280#event-8936282169
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 5, 2023https://github.com/python/cpython/pull/103280#issuecomment-1497642821
Please reload this pagehttps://github.com/python/cpython/pull/103280
#74690 (comment)https://github.com/python/cpython/issues/74690#issuecomment-1497351414
Please reload this pagehttps://github.com/python/cpython/pull/103280
https://github.com/carljm
carljmhttps://github.com/carljm
Apr 5, 2023 https://github.com/python/cpython/pull/103280#pullrequestreview-1373298339
View reviewed changes https://github.com/python/cpython/pull/103280/files/eee4b2c91c1da374f9d5b2cb735d96f7bef4c3dc
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 5, 2023https://github.com/python/cpython/pull/103280#event-8937251900
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
de18267https://github.com/python/cpython/commit/de182676853e8de22363e8a0641c42392c0fdaa9
Apr 5, 2023https://github.com/python/cpython/pull/103280#event-8937273148
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 5, 2023https://github.com/python/cpython/pull/103280#event-8937273606
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
April 5, 2023 16:37https://github.com/python/cpython/pull/103280#event-8937273790
https://github.com/bedevere-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103280
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 7, 2023 https://github.com/python/cpython/pull/103280#ref-pullrequest-1658857896
gh-74690: Document changes made to runtime-checkable protocols in 3.12 #103348 https://github.com/python/cpython/pull/103348
gaogaotiantianhttps://github.com/gaogaotiantian
Apr 8, 2023 https://github.com/python/cpython/pull/103280#ref-commit-d515fb0
https://github.com/AlexWaygood
https://github.com/gaogaotiantian
pythongh-74690https://github.com/python/cpython/issues/74690
: Further optimise `typing._ProtocolMeta.__instancechec…https://github.com/gaogaotiantian/cpython/commit/d515fb0d7088e3f2fee086732b98955a8fdb804f
d515fb0https://github.com/gaogaotiantian/cpython/commit/d515fb0d7088e3f2fee086732b98955a8fdb804f
python#103280https://github.com/python/cpython/pull/103280
warsawhttps://github.com/warsaw
Apr 11, 2023 https://github.com/python/cpython/pull/103280#ref-commit-d9edf14
https://github.com/AlexWaygood
https://github.com/warsaw
pythongh-74690https://github.com/python/cpython/issues/74690
: Further optimise `typing._ProtocolMeta.__instancechec…https://github.com/warsaw/cpython/commit/d9edf14b6b513015b654f893f67dea1223fa3c90
d9edf14https://github.com/warsaw/cpython/commit/d9edf14b6b513015b654f893f67dea1223fa3c90
python#103280https://github.com/python/cpython/pull/103280
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 12, 2023 https://github.com/python/cpython/pull/103280#ref-pullrequest-1664378642
Backport performance improvements to runtime-checkable protocols python/typing_extensions#137 https://github.com/python/typing_extensions/pull/137
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 24, 2023 https://github.com/python/cpython/pull/103280#ref-issue-1723200108
[Bug] typing_extensions.Protocol unsupported under typing_extensions ≥ 4.6.0 beartype/beartype#241 https://github.com/beartype/beartype/issues/241
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Aug 9, 2024 https://github.com/python/cpython/pull/103280#ref-issue-2410113881
Is the protocol caching still needed? beartype/numerary#20 https://github.com/beartype/numerary/issues/20
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103280
https://github.com/carljm
carljm https://github.com/carljm
https://github.com/python/cpython/pull/103280/files/eee4b2c91c1da374f9d5b2cb735d96f7bef4c3dc
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A3.12
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
stdlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
type-feature https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-feature
Please reload this pagehttps://github.com/python/cpython/pull/103280
https://github.com/AlexWaygood
https://github.com/bedevere-bot
https://github.com/carljm
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.