René's URL Explorer Experiment


Title: gh-102660: Fix is_core_module() by ericsnowcurrently · Pull Request #103257 · python/cpython · GitHub

Open Graph Title: gh-102660: Fix is_core_module() by ericsnowcurrently · Pull Request #103257 · python/cpython

X Title: gh-102660: Fix is_core_module() by ericsnowcurrently · Pull Request #103257 · python/cpython

Description: In gh-102744 we added is_core_module() (in Python/import.c), which relies on 'get_core_module_dict()(also added in that PR). The problem is that_PyImport_FixupBuiltin(), which ultimately calls is_...

Open Graph Description: In gh-102744 we added is_core_module() (in Python/import.c), which relies on 'get_core_module_dict()(also added in that PR). The problem is that_PyImport_FixupBuiltin(), which ultimately calls...

X Description: In gh-102744 we added is_core_module() (in Python/import.c), which relies on 'get_core_module_dict()(also added in that PR). The problem is that_PyImport_FixupBuiltin(), which ultimately c...

Opengraph URL: https://github.com/python/cpython/pull/103257

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:91b3dd3e-cc8e-696b-719a-ef9d69fd0686
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C44:2B81A2:4ECD75:6B388C:6969D953
html-safe-noncea762ff0471aef1d36a8ee49da76c65d4311f0a21409e1a686b66d0557e796b8b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzQ0OjJCODFBMjo0RUNENzU6NkIzODhDOjY5NjlEOTUzIiwidmlzaXRvcl9pZCI6Ijc4MTcxMTg4NTQ0OTg4Njc1MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7deebfca40231ddf93b2aa0d670a1b9f6a02d638f67c5b0a3d37ba937f344d76
hovercard-subject-tagpull_request:1302357677
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/103257/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2c53e50bdb76f2e05751cd8810c8e64a59ce3656f55ca8d2da364f9d28c7841f/python/cpython/pull/103257
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2c53e50bdb76f2e05751cd8810c8e64a59ce3656f55ca8d2da364f9d28c7841f/python/cpython/pull/103257
og:image:altIn gh-102744 we added is_core_module() (in Python/import.c), which relies on 'get_core_module_dict()(also added in that PR). The problem is that_PyImport_FixupBuiltin(), which ultimately calls...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericsnowcurrently
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/103257#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103257
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103257
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/103257
Reloadhttps://github.com/python/cpython/pull/103257
Reloadhttps://github.com/python/cpython/pull/103257
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/103257
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/103257
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/103257#issue-comment-box
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:fix-builtins-mcopyhttps://github.com/ericsnowcurrently/cpython/tree/fix-builtins-mcopy
gh-102660: Fix is_core_module() https://github.com/python/cpython/pull/103257#top
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:mainhttps://github.com/python/cpython/tree/main
ericsnowcurrently:fix-builtins-mcopyhttps://github.com/ericsnowcurrently/cpython/tree/fix-builtins-mcopy
Conversation 0 https://github.com/python/cpython/pull/103257
Commits 1 https://github.com/python/cpython/pull/103257/commits
Checks 0 https://github.com/python/cpython/pull/103257/checks
Files changed https://github.com/python/cpython/pull/103257/files
Please reload this pagehttps://github.com/python/cpython/pull/103257
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Apr 4, 2023https://github.com/python/cpython/pull/103257#issue-1654660262
Please reload this pagehttps://github.com/python/cpython/pull/103257
gh-102744https://github.com/python/cpython/pull/102744
gh-101660https://github.com/python/cpython/pull/101660
Re-Loading the sys or builtins Modules is Problematic #102660https://github.com/python/cpython/issues/102660
Please reload this pagehttps://github.com/python/cpython/pull/103257
https://github.com/ericsnowcurrently
Fix is_core_module().https://github.com/python/cpython/pull/103257/commits/f1ccc2d79ccbba86f06ed5fe32c2cd5f99aacb04
f1ccc2dhttps://github.com/python/cpython/pull/103257/commits/f1ccc2d79ccbba86f06ed5fe32c2cd5f99aacb04
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Apr 4, 2023https://github.com/python/cpython/pull/103257#event-8929333710
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
brettcannonhttps://github.com/brettcannon
encukouhttps://github.com/encukou
ncoghlanhttps://github.com/ncoghlan
warsawhttps://github.com/warsaw
code ownershttps://github.com/python/cpython/blob/935aa452359ac3f79febefcdb4387b962cf528af/.github/CODEOWNERS#L67
April 4, 2023 22:27https://github.com/python/cpython/pull/103257#event-8929333754
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 4, 2023https://github.com/python/cpython/pull/103257#event-8929333901
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Apr 4, 2023 https://github.com/python/cpython/pull/103257#ref-issue-1622302411
Re-Loading the sys or builtins Modules is Problematic #102660 https://github.com/python/cpython/issues/102660
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
brettcannonhttps://github.com/brettcannon
encukouhttps://github.com/encukou
ncoghlanhttps://github.com/ncoghlan
warsawhttps://github.com/warsaw
April 4, 2023 22:27https://github.com/python/cpython/pull/103257#event-8929334523
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
f513d5chttps://github.com/python/cpython/commit/f513d5c80672c76acbdaf7d5b601f4bbe9fae56a
Apr 4, 2023https://github.com/python/cpython/pull/103257#event-8929500369
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 4, 2023https://github.com/python/cpython/pull/103257#event-8929500540
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
April 4, 2023 23:03https://github.com/python/cpython/pull/103257#event-8929500553
gaogaotiantianhttps://github.com/gaogaotiantian
Apr 8, 2023 https://github.com/python/cpython/pull/103257#ref-commit-f7e15af
https://github.com/ericsnowcurrently
https://github.com/gaogaotiantian
pythongh-102660https://github.com/python/cpython/issues/102660
: Fix is_core_module() (https://github.com/gaogaotiantian/cpython/commit/f7e15afccd0663ec67a0efd5879017fb5c011464
pythongh-103257https://github.com/python/cpython/pull/103257
)https://github.com/gaogaotiantian/cpython/commit/f7e15afccd0663ec67a0efd5879017fb5c011464
f7e15afhttps://github.com/gaogaotiantian/cpython/commit/f7e15afccd0663ec67a0efd5879017fb5c011464
pythongh-102744https://github.com/python/cpython/pull/102744
pythongh-101660https://github.com/python/cpython/pull/101660
warsawhttps://github.com/warsaw
Apr 11, 2023 https://github.com/python/cpython/pull/103257#ref-commit-2380473
https://github.com/ericsnowcurrently
https://github.com/warsaw
pythongh-102660https://github.com/python/cpython/issues/102660
: Fix is_core_module() (https://github.com/warsaw/cpython/commit/2380473f3d7f31d9c3d62e9245547707334a2eb9
pythongh-103257https://github.com/python/cpython/pull/103257
)https://github.com/warsaw/cpython/commit/2380473f3d7f31d9c3d62e9245547707334a2eb9
2380473https://github.com/warsaw/cpython/commit/2380473f3d7f31d9c3d62e9245547707334a2eb9
pythongh-102744https://github.com/python/cpython/pull/102744
pythongh-101660https://github.com/python/cpython/pull/101660
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103257
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/103257
https://github.com/ericsnowcurrently
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.