René's URL Explorer Experiment


Title: gh-74690: typing: Call `_get_protocol_attrs` and `_callable_members_only` at protocol class creation time, not during `isinstance()` checks by AlexWaygood · Pull Request #103160 · python/cpython · GitHub

Open Graph Title: gh-74690: typing: Call `_get_protocol_attrs` and `_callable_members_only` at protocol class creation time, not during `isinstance()` checks by AlexWaygood · Pull Request #103160 · python/cpython

X Title: gh-74690: typing: Call `_get_protocol_attrs` and `_callable_members_only` at protocol class creation time, not during `isinstance()` checks by AlexWaygood · Pull Request #103160 · python/cpython

Description: This PR proposes caching the results of _get_protocol_attrs() and _callable_members_only(), so that they only need to be computed once for each protocol class. This hugely speeds up calling isinsta...

Open Graph Description: This PR proposes caching the results of _get_protocol_attrs() and _callable_members_only(), so that they only need to be computed once for each protocol class. This hugely speeds up calling isinsta...

X Description: This PR proposes caching the results of _get_protocol_attrs() and _callable_members_only(), so that they only need to be computed once for each protocol class. This hugely speeds up calling isinsta...

Opengraph URL: https://github.com/python/cpython/pull/103160

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:52f11da4-bf14-86ea-7add-6516159664dc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCBAA:341673:89C5D8:B90095:6969BF05
html-safe-nonce7facd82283464636941717554f390ea91d5a03d3c9763853ef4b0f2aded3a1d5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkFBOjM0MTY3Mzo4OUM1RDg6QjkwMDk1OjY5NjlCRjA1IiwidmlzaXRvcl9pZCI6IjE5MDI0MzY1MDY4OTgzODI1OTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4c6fddb3c813a6ebc6d7df53786c67e1605ea48a7c0423f7adaf3bd00f43b233
hovercard-subject-tagpull_request:1298479719
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/103160/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c712e6b6951b3e4b3b41f1147f91f11bfc8e6d8b980b497c90aed1774a65f3d2/python/cpython/pull/103160
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c712e6b6951b3e4b3b41f1147f91f11bfc8e6d8b980b497c90aed1774a65f3d2/python/cpython/pull/103160
og:image:altThis PR proposes caching the results of _get_protocol_attrs() and _callable_members_only(), so that they only need to be computed once for each protocol class. This hugely speeds up calling isinsta...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAlexWaygood
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/103160#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103160
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103160
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/103160
Reloadhttps://github.com/python/cpython/pull/103160
Reloadhttps://github.com/python/cpython/pull/103160
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/103160
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/103160
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/103160#issue-comment-box
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:protocol-attrs-cache-1https://github.com/AlexWaygood/cpython/tree/protocol-attrs-cache-1
gh-74690: typing: Call _get_protocol_attrs and _callable_members_only at protocol class creation time, not during isinstance() checks https://github.com/python/cpython/pull/103160#top
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:protocol-attrs-cache-1https://github.com/AlexWaygood/cpython/tree/protocol-attrs-cache-1
Conversation 17 https://github.com/python/cpython/pull/103160
Commits 9 https://github.com/python/cpython/pull/103160/commits
Checks 0 https://github.com/python/cpython/pull/103160/checks
Files changed 1 https://github.com/python/cpython/pull/103160/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 1, 2023https://github.com/python/cpython/pull/103160#issue-1650191407
Please reload this pagehttps://github.com/python/cpython/pull/103160
Performance of typing._ProtocolMeta._get_protocol_attrs and isinstance #74690https://github.com/python/cpython/issues/74690
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/AlexWaygood
pythongh-74690https://github.com/python/cpython/issues/74690
: typing: Cache results ofhttps://github.com/python/cpython/pull/103160/commits/f15c64abf5fb66d16cf4723abac07f474f752f05
_get_protocol_attrshttps://github.com/python/cpython/pull/103160/commits/f15c64abf5fb66d16cf4723abac07f474f752f05
and `_…https://github.com/python/cpython/pull/103160/commits/f15c64abf5fb66d16cf4723abac07f474f752f05
f15c64ahttps://github.com/python/cpython/pull/103160/commits/f15c64abf5fb66d16cf4723abac07f474f752f05
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
type-feature https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-feature
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
stdlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A3.12
Apr 1, 2023https://github.com/python/cpython/pull/103160#event-8902763871
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
carljmhttps://github.com/carljm
hauntsaninjahttps://github.com/hauntsaninja
April 1, 2023 00:04https://github.com/python/cpython/pull/103160#event-8902763939
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Fidget-Spinnerhttps://github.com/Fidget-Spinner
JelleZijlstrahttps://github.com/JelleZijlstra
gvanrossumhttps://github.com/gvanrossum
code ownershttps://github.com/python/cpython/blob/d97aef8ebfbbb275384b17f06945e583fb3189ea/.github/CODEOWNERS#L141
April 1, 2023 00:04https://github.com/python/cpython/pull/103160#event-8902764009
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Apr 1, 2023 https://github.com/python/cpython/pull/103160#ref-issue-1198974045
Performance of typing._ProtocolMeta._get_protocol_attrs and isinstance #74690 https://github.com/python/cpython/issues/74690
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 1, 2023https://github.com/python/cpython/pull/103160#event-8902764923
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
gvanrossumhttps://github.com/gvanrossum
April 1, 2023 00:04https://github.com/python/cpython/pull/103160#event-8902767102
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 1, 2023https://github.com/python/cpython/pull/103160#issuecomment-1492745307
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 1, 2023https://github.com/python/cpython/pull/103160#issuecomment-1492756025
@positahttps://github.com/posita
Please reload this pagehttps://github.com/python/cpython/pull/103160
AlexWaygoodhttps://github.com/AlexWaygood
April 1, 2023 11:17https://github.com/python/cpython/pull/103160#commits-pushed-f3ec3db
https://github.com/AlexWaygood
Simplify and inlinehttps://github.com/python/cpython/pull/103160/commits/f3ec3db9a43244602c6da89553fcba7051a48717
f3ec3dbhttps://github.com/python/cpython/pull/103160/commits/f3ec3db9a43244602c6da89553fcba7051a48717
https://github.com/AlexWaygood
Use a metaclass instance method, not a classmethod on the classhttps://github.com/python/cpython/pull/103160/commits/8e3c6f71c986e0daf588faa437b39e7bf768e5ac
8e3c6f7https://github.com/python/cpython/pull/103160/commits/8e3c6f71c986e0daf588faa437b39e7bf768e5ac
https://github.com/carljm
carljmhttps://github.com/carljm
Apr 1, 2023https://github.com/python/cpython/pull/103160#issuecomment-1492991323
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 1, 2023https://github.com/python/cpython/pull/103160#issuecomment-1492995191
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 1, 2023https://github.com/python/cpython/pull/103160#issuecomment-1493001781
Please reload this pagehttps://github.com/python/cpython/pull/103160
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/carljm
carljmhttps://github.com/carljm
Apr 1, 2023https://github.com/python/cpython/pull/103160#issuecomment-1493003109
@JelleZijlstrahttps://github.com/JelleZijlstra
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 1, 2023https://github.com/python/cpython/pull/103160#issuecomment-1493003901
Please reload this pagehttps://github.com/python/cpython/pull/103160
@JelleZijlstrahttps://github.com/JelleZijlstra
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 1, 2023https://github.com/python/cpython/pull/103160#issuecomment-1493014220
Please reload this pagehttps://github.com/python/cpython/pull/103160
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 1, 2023https://github.com/python/cpython/pull/103160#issuecomment-1493015528
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/AlexWaygood
Move to class-creation timehttps://github.com/python/cpython/pull/103160/commits/a34f7005abc35f7da745e45aed3043d9c273837a
a34f700https://github.com/python/cpython/pull/103160/commits/a34f7005abc35f7da745e45aed3043d9c273837a
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 1, 2023https://github.com/python/cpython/pull/103160#event-8904440947
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 1, 2023https://github.com/python/cpython/pull/103160#event-8904450079
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 1, 2023https://github.com/python/cpython/pull/103160#issuecomment-1493039039
Please reload this pagehttps://github.com/python/cpython/pull/103160
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/AlexWaygood
Use __init__, not __new__https://github.com/python/cpython/pull/103160/commits/4d050749087ea86a7cacc9ce96b867057e655788
4d05074https://github.com/python/cpython/pull/103160/commits/4d050749087ea86a7cacc9ce96b867057e655788
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 1, 2023 https://github.com/python/cpython/pull/103160#pullrequestreview-1367897844
View reviewed changes https://github.com/python/cpython/pull/103160/files/4d050749087ea86a7cacc9ce96b867057e655788
Lib/typing.pyhttps://github.com/python/cpython/pull/103160/files/4d050749087ea86a7cacc9ce96b867057e655788#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
AlexWaygoodhttps://github.com/AlexWaygood
Apr 1, 2023https://github.com/python/cpython/pull/103160#discussion_r1155142512
Please reload this pagehttps://github.com/python/cpython/pull/103160
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/103160
AlexWaygoodhttps://github.com/AlexWaygood
Apr 1, 2023https://github.com/python/cpython/pull/103160#discussion_r1155145364
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/antonagestam/phantom-types/blob/68ee857af4452a90a48669a8dbc7d1d7110b31d0/src/phantom/sized.py#L71-L82https://github.com/antonagestam/phantom-types/blob/68ee857af4452a90a48669a8dbc7d1d7110b31d0/src/phantom/sized.py#L71-L82
https://github.com/protolambda/remerkleable/blob/91ed092d08ef0ba5ab076f0a34b0b371623db728/remerkleable/core.py#L18-L22https://github.com/protolambda/remerkleable/blob/91ed092d08ef0ba5ab076f0a34b0b371623db728/remerkleable/core.py#L18-L22
https://github.com/InterStella0/stella_bot/blob/bf5f5632bcd88670df90be67b888c282c6e83d99/utils/useful.py#L337-L343https://github.com/InterStella0/stella_bot/blob/bf5f5632bcd88670df90be67b888c282c6e83d99/utils/useful.py#L337-L343
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/AlexWaygood
Add missing super().__init__() call, to be safehttps://github.com/python/cpython/pull/103160/commits/d3f9ebee0fb88db3d87bac71180fa00ab853f2c4
d3f9ebehttps://github.com/python/cpython/pull/103160/commits/d3f9ebee0fb88db3d87bac71180fa00ab853f2c4
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 2, 2023 https://github.com/python/cpython/pull/103160#ref-pullrequest-1640588419
gh-102433: Use inspect.getattr_static in typing._ProtocolMeta.__instancecheck__ #103034 https://github.com/python/cpython/pull/103034
https://github.com/AlexWaygood
Merge branch 'main' into protocol-attrs-cache-1https://github.com/python/cpython/pull/103160/commits/e8a63045eb5d108483e71ba8714797e8f7e835cd
e8a6304https://github.com/python/cpython/pull/103160/commits/e8a63045eb5d108483e71ba8714797e8f7e835cd
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Apr 2, 2023https://github.com/python/cpython/pull/103160#event-8906429508
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 2, 2023https://github.com/python/cpython/pull/103160#issuecomment-1493334084
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 2, 2023https://github.com/python/cpython/pull/103160#issuecomment-1493337995
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 2, 2023 https://github.com/python/cpython/pull/103160#ref-issue-1650438432
Typing: undocumented behaviour change for protocols decorated with @final and @runtime_checkable in 3.11 #103171 https://github.com/python/cpython/issues/103171
https://github.com/carljm
carljmhttps://github.com/carljm
Apr 4, 2023 https://github.com/python/cpython/pull/103160#pullrequestreview-1371935661
View reviewed changes https://github.com/python/cpython/pull/103160/files/e8a63045eb5d108483e71ba8714797e8f7e835cd
carljmhttps://github.com/carljm
https://github.com/python/cpython/pull/103160#pullrequestreview-1371935661
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 4, 2023https://github.com/python/cpython/pull/103160#event-8929689244
https://github.com/AlexWaygood
Merge branch 'main' into protocol-attrs-cache-1https://github.com/python/cpython/pull/103160/commits/4816afa2865fe43eb9658882e0b4f2ae3b3f4c20
4816afahttps://github.com/python/cpython/pull/103160/commits/4816afa2865fe43eb9658882e0b4f2ae3b3f4c20
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 5, 2023 https://github.com/python/cpython/pull/103160#pullrequestreview-1372533482
View reviewed changes https://github.com/python/cpython/pull/103160/files/4816afa2865fe43eb9658882e0b4f2ae3b3f4c20
Lib/typing.pyhttps://github.com/python/cpython/pull/103160/files/4816afa2865fe43eb9658882e0b4f2ae3b3f4c20#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/AlexWaygood
Update Lib/typing.pyhttps://github.com/python/cpython/pull/103160/commits/08af61593d85db78efa1abef197f8d8e510a7913
08af615https://github.com/python/cpython/pull/103160/commits/08af61593d85db78efa1abef197f8d8e510a7913
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
DO-NOT-MERGE https://github.com/python/cpython/issues?q=state%3Aopen%20label%3ADO-NOT-MERGE
Apr 5, 2023https://github.com/python/cpython/pull/103160#event-8933980608
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 5, 2023https://github.com/python/cpython/pull/103160#issuecomment-1497320404
#103160https://github.com/python/cpython/pull/103160
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
3246688https://github.com/python/cpython/commit/3246688918a428738b61c4adb5fbc6525eae96f9
Apr 5, 2023https://github.com/python/cpython/pull/103160#event-8933992422
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 5, 2023https://github.com/python/cpython/pull/103160#event-8933992892
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
April 5, 2023 11:19https://github.com/python/cpython/pull/103160#event-8933993079
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 7, 2023 https://github.com/python/cpython/pull/103160#ref-pullrequest-1658857896
gh-74690: Document changes made to runtime-checkable protocols in 3.12 #103348 https://github.com/python/cpython/pull/103348
gaogaotiantianhttps://github.com/gaogaotiantian
Apr 8, 2023 https://github.com/python/cpython/pull/103160#ref-commit-9b978ee
https://github.com/AlexWaygood
https://github.com/gaogaotiantian
pythongh-74690https://github.com/python/cpython/issues/74690
: typing: Callhttps://github.com/gaogaotiantian/cpython/commit/9b978ee0dfe9c367d0a5960bd95d01427086f0dd
_get_protocol_attrshttps://github.com/gaogaotiantian/cpython/commit/9b978ee0dfe9c367d0a5960bd95d01427086f0dd
and `_callable_mem…https://github.com/gaogaotiantian/cpython/commit/9b978ee0dfe9c367d0a5960bd95d01427086f0dd
9b978eehttps://github.com/gaogaotiantian/cpython/commit/9b978ee0dfe9c367d0a5960bd95d01427086f0dd
python#103160https://github.com/python/cpython/pull/103160
warsawhttps://github.com/warsaw
Apr 11, 2023 https://github.com/python/cpython/pull/103160#ref-commit-f2f5e5d
https://github.com/AlexWaygood
https://github.com/warsaw
pythongh-74690https://github.com/python/cpython/issues/74690
: typing: Callhttps://github.com/warsaw/cpython/commit/f2f5e5d9c7c57d7382bd287122bfac05e12c9c03
_get_protocol_attrshttps://github.com/warsaw/cpython/commit/f2f5e5d9c7c57d7382bd287122bfac05e12c9c03
and `_callable_mem…https://github.com/warsaw/cpython/commit/f2f5e5d9c7c57d7382bd287122bfac05e12c9c03
f2f5e5dhttps://github.com/warsaw/cpython/commit/f2f5e5d9c7c57d7382bd287122bfac05e12c9c03
python#103160https://github.com/python/cpython/pull/103160
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 12, 2023 https://github.com/python/cpython/pull/103160#ref-pullrequest-1664378642
Backport performance improvements to runtime-checkable protocols python/typing_extensions#137 https://github.com/python/typing_extensions/pull/137
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 18, 2023 https://github.com/python/cpython/pull/103160#ref-pullrequest-1716201399
gh-74690: Don't set special protocol attributes on non-protocol subclasses of protocols #104622 https://github.com/python/cpython/pull/104622
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
May 24, 2023 https://github.com/python/cpython/pull/103160#ref-issue-1724357892
Add typing.get_protocol_members and typing.is_protocol #104873 https://github.com/python/cpython/issues/104873
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 24, 2023 https://github.com/python/cpython/pull/103160#ref-issue-1723200108
[Bug] typing_extensions.Protocol unsupported under typing_extensions ≥ 4.6.0 beartype/beartype#241 https://github.com/beartype/beartype/issues/241
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Nov 16, 2023 https://github.com/python/cpython/pull/103160#ref-issue-1959629323
datetime.__sub__ overload order python/typeshed#10924 https://github.com/python/typeshed/issues/10924
https://github.com/posita
positahttps://github.com/posita
Aug 9, 2024 https://github.com/python/cpython/pull/103160#ref-issue-2410113881
Is the protocol caching still needed? beartype/numerary#20 https://github.com/beartype/numerary/issues/20
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103160
https://github.com/carljm
carljm https://github.com/carljm
https://github.com/python/cpython/pull/103160/files/e8a63045eb5d108483e71ba8714797e8f7e835cd
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A3.12
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
stdlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
type-feature https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-feature
Please reload this pagehttps://github.com/python/cpython/pull/103160
https://github.com/AlexWaygood
https://github.com/carljm
https://github.com/JelleZijlstra
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.