René's URL Explorer Experiment


Title: gh-74690: Micro-optimise `typing._get_protocol_attrs` by AlexWaygood · Pull Request #103152 · python/cpython · GitHub

Open Graph Title: gh-74690: Micro-optimise `typing._get_protocol_attrs` by AlexWaygood · Pull Request #103152 · python/cpython

X Title: gh-74690: Micro-optimise `typing._get_protocol_attrs` by AlexWaygood · Pull Request #103152 · python/cpython

Description: This PR is a bunch of micro-optimisations for typing._get_protocol_attrs that together have a significant impact on the speed of isinstance checks against runtime-checkable protocols. Benchmark: i...

Open Graph Description: This PR is a bunch of micro-optimisations for typing._get_protocol_attrs that together have a significant impact on the speed of isinstance checks against runtime-checkable protocols. Benchmark: i...

X Description: This PR is a bunch of micro-optimisations for typing._get_protocol_attrs that together have a significant impact on the speed of isinstance checks against runtime-checkable protocols. Benchmark: i...

Opengraph URL: https://github.com/python/cpython/pull/103152

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:97773169-6246-26b7-ce6a-97b225302c02
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9996:2B0240:6AE36F:927118:6969DCC1
html-safe-noncec03bcc59c202c8006cb77f1b8e81cdefb2b0002bd4b3c443e258adc90d0bcd52
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTk2OjJCMDI0MDo2QUUzNkY6OTI3MTE4OjY5NjlEQ0MxIiwidmlzaXRvcl9pZCI6IjU5MjMwNzgzMDYwNTgwNjcxMzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaceb5d24e2603241ccbec82eb38a332b833040a75cd654f16a581faf91d0c451ad
hovercard-subject-tagpull_request:1298176202
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/103152/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8001522a0ef02fff21363fd33fc1e5bf97a0cecf22b6a973d8e4f0d90f402860/python/cpython/pull/103152
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8001522a0ef02fff21363fd33fc1e5bf97a0cecf22b6a973d8e4f0d90f402860/python/cpython/pull/103152
og:image:altThis PR is a bunch of micro-optimisations for typing._get_protocol_attrs that together have a significant impact on the speed of isinstance checks against runtime-checkable protocols. Benchmark: i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAlexWaygood
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/103152#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103152
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103152
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/103152
Reloadhttps://github.com/python/cpython/pull/103152
Reloadhttps://github.com/python/cpython/pull/103152
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/103152
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/103152
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/103152#issue-comment-box
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:micro-optimise-protocolshttps://github.com/AlexWaygood/cpython/tree/micro-optimise-protocols
gh-74690: Micro-optimise typing._get_protocol_attrs https://github.com/python/cpython/pull/103152#top
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/cpython/tree/main
AlexWaygood:micro-optimise-protocolshttps://github.com/AlexWaygood/cpython/tree/micro-optimise-protocols
Conversation 11 https://github.com/python/cpython/pull/103152
Commits 2 https://github.com/python/cpython/pull/103152/commits
Checks 0 https://github.com/python/cpython/pull/103152/checks
Files changed https://github.com/python/cpython/pull/103152/files
Please reload this pagehttps://github.com/python/cpython/pull/103152
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Mar 31, 2023https://github.com/python/cpython/pull/103152#issue-1649839180
Please reload this pagehttps://github.com/python/cpython/pull/103152
dfc4c95https://github.com/python/cpython/commit/dfc4c95762f417e84dcb21dbbe6399ab7b7cef19
#103034https://github.com/python/cpython/pull/103034
Performance of typing._ProtocolMeta._get_protocol_attrs and isinstance #74690https://github.com/python/cpython/issues/74690
Please reload this pagehttps://github.com/python/cpython/pull/103152
https://github.com/AlexWaygood
pythongh-74690https://github.com/python/cpython/issues/74690
: Micro-optimisehttps://github.com/python/cpython/pull/103152/commits/b4ddcc9671496bec6a1a7f3b322e0ac554816c87
typing._get_protocol_attrshttps://github.com/python/cpython/pull/103152/commits/b4ddcc9671496bec6a1a7f3b322e0ac554816c87
b4ddcc9https://github.com/python/cpython/pull/103152/commits/b4ddcc9671496bec6a1a7f3b322e0ac554816c87
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
type-feature https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-feature
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
stdlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A3.12
Mar 31, 2023https://github.com/python/cpython/pull/103152#event-8900821566
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
carljmhttps://github.com/carljm
March 31, 2023 18:36https://github.com/python/cpython/pull/103152#event-8900821627
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Fidget-Spinnerhttps://github.com/Fidget-Spinner
JelleZijlstrahttps://github.com/JelleZijlstra
gvanrossumhttps://github.com/gvanrossum
code ownershttps://github.com/python/cpython/blob/dfc4c95762f417e84dcb21dbbe6399ab7b7cef19/.github/CODEOWNERS#L141
March 31, 2023 18:36https://github.com/python/cpython/pull/103152#event-8900821695
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 31, 2023 https://github.com/python/cpython/pull/103152#ref-issue-1198974045
Performance of typing._ProtocolMeta._get_protocol_attrs and isinstance #74690 https://github.com/python/cpython/issues/74690
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 31, 2023https://github.com/python/cpython/pull/103152#event-8900822459
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Mar 31, 2023https://github.com/python/cpython/pull/103152#issuecomment-1492430640
@leycechttps://github.com/leycec
@positahttps://github.com/posita
Please reload this pagehttps://github.com/python/cpython/pull/103152
https://github.com/carljm
carljmhttps://github.com/carljm
Mar 31, 2023 https://github.com/python/cpython/pull/103152#pullrequestreview-1367477670
View reviewed changes https://github.com/python/cpython/pull/103152/files/b4ddcc9671496bec6a1a7f3b322e0ac554816c87
carljmhttps://github.com/carljm
https://github.com/python/cpython/pull/103152#pullrequestreview-1367477670
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@hauntsaninjahttps://github.com/hauntsaninja
#103141https://github.com/python/cpython/pull/103141
#103034https://github.com/python/cpython/pull/103034
Please reload this pagehttps://github.com/python/cpython/pull/103152
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 31, 2023https://github.com/python/cpython/pull/103152#event-8901165194
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Mar 31, 2023 https://github.com/python/cpython/pull/103152#pullrequestreview-1367503698
View reviewed changes https://github.com/python/cpython/pull/103152/files/b4ddcc9671496bec6a1a7f3b322e0ac554816c87
Lib/typing.pyhttps://github.com/python/cpython/pull/103152/files/b4ddcc9671496bec6a1a7f3b322e0ac554816c87#diff-ddb987fca5f5df0c9a2f5521ed687919d70bb3d64eaeb8021f98833a2a716887
Please reload this pagehttps://github.com/python/cpython/pull/103152
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Mar 31, 2023 https://github.com/python/cpython/pull/103152#pullrequestreview-1367504011
View reviewed changes https://github.com/python/cpython/pull/103152/files/b4ddcc9671496bec6a1a7f3b322e0ac554816c87
hauntsaninjahttps://github.com/hauntsaninja
https://github.com/python/cpython/pull/103152#pullrequestreview-1367504011
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/103152
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Mar 31, 2023https://github.com/python/cpython/pull/103152#issuecomment-1492539913
@hauntsaninjahttps://github.com/hauntsaninja
#103141https://github.com/python/cpython/pull/103141
#103034https://github.com/python/cpython/pull/103034
#103034https://github.com/python/cpython/pull/103034
Please reload this pagehttps://github.com/python/cpython/pull/103152
https://github.com/AlexWaygood
Revert direct __annotations__ accesshttps://github.com/python/cpython/pull/103152/commits/d6c3b657b0009d51fd94d29347a019a68c5316e0
d6c3b65https://github.com/python/cpython/pull/103152/commits/d6c3b657b0009d51fd94d29347a019a68c5316e0
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
hauntsaninjahttps://github.com/hauntsaninja
March 31, 2023 20:27https://github.com/python/cpython/pull/103152#event-8901618837
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
Mar 31, 2023 https://github.com/python/cpython/pull/103152#pullrequestreview-1367561647
View reviewed changes https://github.com/python/cpython/pull/103152/files/d6c3b657b0009d51fd94d29347a019a68c5316e0
hauntsaninjahttps://github.com/hauntsaninja
https://github.com/python/cpython/pull/103152#pullrequestreview-1367561647
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/103152
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
361a3eahttps://github.com/python/cpython/commit/361a3eaf1b6bf3360e34388cc909307ddd20737b
Mar 31, 2023https://github.com/python/cpython/pull/103152#event-8901787014
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Mar 31, 2023https://github.com/python/cpython/pull/103152#event-8901787317
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
March 31, 2023 20:54https://github.com/python/cpython/pull/103152#event-8901787406
gh-102433: Use inspect.getattr_static in typing._ProtocolMeta.__instancecheck__ #103034 https://github.com/python/cpython/pull/103034
gh-74690: Document changes made to runtime-checkable protocols in 3.12 #103348 https://github.com/python/cpython/pull/103348
warsawhttps://github.com/warsaw
Apr 11, 2023 https://github.com/python/cpython/pull/103152#ref-commit-deb1c45
https://github.com/AlexWaygood
https://github.com/warsaw
pythongh-74690https://github.com/python/cpython/issues/74690
: Micro-optimisehttps://github.com/warsaw/cpython/commit/deb1c45513774a64e3a1ce48dc077606aaf2fb67
typing._get_protocol_attrshttps://github.com/warsaw/cpython/commit/deb1c45513774a64e3a1ce48dc077606aaf2fb67
(https://github.com/warsaw/cpython/commit/deb1c45513774a64e3a1ce48dc077606aaf2fb67
python#1…https://github.com/python/cpython/pull/103152
deb1c45https://github.com/warsaw/cpython/commit/deb1c45513774a64e3a1ce48dc077606aaf2fb67
…03152https://github.com/python/cpython/pull/103152
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Apr 12, 2023 https://github.com/python/cpython/pull/103152#ref-pullrequest-1664378642
Backport performance improvements to runtime-checkable protocols python/typing_extensions#137 https://github.com/python/typing_extensions/pull/137
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
May 24, 2023 https://github.com/python/cpython/pull/103152#ref-issue-1723200108
[Bug] typing_extensions.Protocol unsupported under typing_extensions ≥ 4.6.0 beartype/beartype#241 https://github.com/beartype/beartype/issues/241
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103152
https://github.com/carljm
carljm https://github.com/carljm
https://github.com/python/cpython/pull/103152/files/b4ddcc9671496bec6a1a7f3b322e0ac554816c87
https://github.com/hauntsaninja
hauntsaninja https://github.com/hauntsaninja
https://github.com/python/cpython/pull/103152/files/d6c3b657b0009d51fd94d29347a019a68c5316e0
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/Fidget-Spinner
Fidget-Spinner https://github.com/Fidget-Spinner
https://github.com/JelleZijlstra
JelleZijlstra https://github.com/JelleZijlstra
3.12 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A3.12
performance https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Aperformance
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
stdlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib
topic-typing https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-typing
type-feature https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-feature
Please reload this pagehttps://github.com/python/cpython/pull/103152
https://github.com/AlexWaygood
https://github.com/carljm
https://github.com/hauntsaninja
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.