| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0a1bb487-5417-7a39-a68b-c308628de5f8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A340:249571:106C96F:1607862:6969931B |
| html-safe-nonce | a457850f7e74f2c196e6e10de1672d4544c89083043d1fbbcfab7d040eeb8046 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzQwOjI0OTU3MToxMDZDOTZGOjE2MDc4NjI6Njk2OTkzMUIiLCJ2aXNpdG9yX2lkIjoiOTY5NTEzNzc5OTI3MjkwNjUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a51c3da4bb082ab8b79eb018e0b29675b1025bc2e4a50dcd267366e595fcf275 |
| hovercard-subject-tag | pull_request:1294423313 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/103108/files |
| twitter:image | https://avatars.githubusercontent.com/u/13780613?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/13780613?s=400&v=4 |
| og:image:alt | TODO
There's no way to pass state to PyOS_InputHooks. Introduce a new hook with context pointer? Just opt out of multi-phase init / module state for _tkinter? Or just protect these with per-i... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3542e147982176a7ebaa23dfb559c8af16f721c03ec560c68c56b64a0f35e751 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | af80af7cc9e3de9c336f18b208a600950a3c187c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/103108/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103108%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F103108%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/103108/files |
| Reload | https://github.com/python/cpython/pull/103108/files |
| Reload | https://github.com/python/cpython/pull/103108/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/103108/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/103108/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| erlend-aasland | https://github.com/erlend-aasland |
| python:main | https://github.com/python/cpython/tree/main |
| erlend-aasland:isolate-tkinter | https://github.com/erlend-aasland/cpython/tree/isolate-tkinter |
|
Conversation
1
| https://github.com/python/cpython/pull/103108 |
|
Commits
18
| https://github.com/python/cpython/pull/103108/commits |
|
Checks
0
| https://github.com/python/cpython/pull/103108/checks |
|
Files changed
| https://github.com/python/cpython/pull/103108/files |
| Please reload this page | https://github.com/python/cpython/pull/103108/files |
|
gh-103092: Isolate _tkinter (WIP)
| https://github.com/python/cpython/pull/103108/files#top |
|
Show all changes
18 commits
| https://github.com/python/cpython/pull/103108/files |
|
45f3b7d
Establish global state
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/45f3b7d6e98821e90e31a79f441c5ac366a53a92 |
|
d09999d
DEBUG: disable test restriction
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/d09999dd2dd3fcaebed360a0cf78993981beec92 |
|
ad27a32
Adapt PyTclObject_Type and move it to module state
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/ad27a3263248375b4eace723f7e7ea48a0940583 |
|
ae833f8
Adapt Tkapp_Type and add it to module state
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/ae833f8a89693e99cf00f4dc0c132c0494342757 |
|
18b1a42
Adapt Tktt_Type and add it to state
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/18b1a429cf0b725b2d4dca29c7f0bd3a5d5dd73f |
|
6bfafcc
Add Tkinter_TclError to state
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/6bfafccfe86461eb3fc1285e8015ad70508a7962 |
|
3d8d5df
Add tcl_lock to state
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/3d8d5dff7a43698ef6947aeb44ab3196ca522661 |
|
02d4b26
Put error handling vars in module state
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/02d4b26f79ca95d6baa5a331120df6bd223ff934 |
|
6610e11
Put Tkinter_busywaitinterval into module state
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/6610e11236a15bb6a7118ccc2050e89a4ff46ac3 |
|
b6ac21d
Put HeadFHCD into module state
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/b6ac21ddd555c8c3230e20d8b45af0197ebbac2a |
|
3d3e881
Put stdin_ready into module state
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/3d3e8818dba06e128fb6baa7dbdcd98e51105192 |
|
686b69a
Put event_tstate into module state
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/686b69a1dce6d100a12a95d6db59b384d92bc5b1 |
|
525897d
Purge non-existent valInCmd and trbInCmd
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/525897d96c82277029db0e0a994bba9ef25f3bb5 |
|
ef328cf
Make space for module state
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/ef328cf727740adc092118f5cda48c00d4888b38 |
|
3349ad3
Add get-state helpers
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/3349ad3e6d7e02af53dec2365b61a0da7e2457d0 |
|
e04df03
Get rid of most GLOBAL_STATE() use
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/e04df03f4bc3a6c6c3f0ef167947260e48a5edf7 |
|
6818bb2
Get rid of more GLOBAL_STATE() calls
erlend-aasland Mar 29, 2023
| https://github.com/python/cpython/pull/103108/commits/6818bb2c509b29903d2412777a6d8864a91ec7ef |
|
d3b8f5e
Pull in main
erlend-aasland Apr 19, 2023
| https://github.com/python/cpython/pull/103108/commits/d3b8f5e8652c0e5b9187a5fe6ddd4880fab9bd62 |
|
Clear filters
| https://github.com/python/cpython/pull/103108/files |
| Please reload this page | https://github.com/python/cpython/pull/103108/files |
| Please reload this page | https://github.com/python/cpython/pull/103108/files |
|
__init__.py
| https://github.com/python/cpython/pull/103108/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d |
|
test_simpledialog.py
| https://github.com/python/cpython/pull/103108/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
_tkinter.c
| https://github.com/python/cpython/pull/103108/files#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd |
|
globals-to-fix.tsv
| https://github.com/python/cpython/pull/103108/files#diff-8d1e9a0d5771dfc3a628047509e2d4a1027327bd89392e5a3ec5fbd3d08cfa19 |
| Lib/test/support/__init__.py | https://github.com/python/cpython/pull/103108/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d |
|
View file
| https://github.com/erlend-aasland/cpython/blob/d3b8f5e8652c0e5b9187a5fe6ddd4880fab9bd62/Lib/test/support/__init__.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/103108/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/103108/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d |
|
| https://github.com/python/cpython/pull/103108/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d |
| Lib/test/test_tkinter/test_simpledialog.py | https://github.com/python/cpython/pull/103108/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
View file
| https://github.com/erlend-aasland/cpython/blob/d3b8f5e8652c0e5b9187a5fe6ddd4880fab9bd62/Lib/test/test_tkinter/test_simpledialog.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/103108/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/103108/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
|
| https://github.com/python/cpython/pull/103108/files#diff-c24e251f02fe42b46b17230a00a6a616d48a383fc02b03427e81682b51eaa651 |
| Please reload this page | https://github.com/python/cpython/pull/103108/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |