René's URL Explorer Experiment

Title: bpo-35113: Fix inspect.getsource to return correct source for inner classes by tirkarthi · Pull Request #10307 · python/cpython · GitHub

Open Graph Title: bpo-35113: Fix inspect.getsource to return correct source for inner classes by tirkarthi · Pull Request #10307 · python/cpython

X Title: bpo-35113: Fix inspect.getsource to return correct source for inner classes by tirkarthi · Pull Request #10307 · python/cpython

Description: Previous approach used regex along with indentation of the match to return the source code. This caused below issues. This PR proposes usage of ast module to do correct parsing. Issues When a class with same name is defined under different classes. When a class definition is part of a string declaration. When a class definition is part of multiline comment. Examples of incorrect output can be found with https://bugs.python.org/issue35113. This PR also adds returning class decorators as part of the source code instead of just returning the class definition. Inner class example : import inspect class Foo: class Bar: def foo(self): pass class Spam: class Bar: def bar(self): pass print(inspect.getsource(Spam.Bar)) On master $ ./python.exe foo.py class Bar: def foo(self): pass IPython inspect.getsource is also used in lot of tools like IPython and pdb which also return incorrect output due to this ipython Python 3.6.4 (default, Mar 12 2018, 13:42:53) Type 'copyright', 'credits' or 'license' for more information IPython 6.3.1 -- An enhanced Interactive Python. Type '?' for help. In [1]: import foo In [2]: foo.Spam.Bar?? Init signature: foo.Spam.Bar() Docstring: Source: class Bar: def foo(self): pass File: ~/stuff/python/backups/foo.py Type: type $ python3 foo.py > /Users/karthikeyansingaravelan/stuff/python/backups/foo.py(13)() -> if __name__ == "__main__": (Pdb) pdb.getsourcelines(Spam.Bar) ([' class Bar:\n', ' def foo(self):\n', ' pass\n'], 2) With PR $ ./python.exe foo.py class Bar: def bar(self): pass Class decorator example import inspect def foo(cls): return cls @foo @foo class Foo: pass print(inspect.getsource(Foo)) On master $ ./python.exe foo.py class Foo: pass With PR $ ./python.exe foo.py @foo @foo class Foo: pass https://bugs.python.org/issue35113

Open Graph Description: Previous approach used regex along with indentation of the match to return the source code. This caused below issues. This PR proposes usage of ast module to do correct parsing. Issues When a clas...

X Description: Previous approach used regex along with indentation of the match to return the source code. This caused below issues. This PR proposes usage of ast module to do correct parsing. Issues When a clas...

Opengraph URL: https://github.com/python/cpython/pull/10307

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width